From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 05CFD491B6 for ; Mon, 5 Feb 2024 12:19:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CE2D068CF3E; Mon, 5 Feb 2024 14:19:27 +0200 (EET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2093.outbound.protection.outlook.com [40.92.90.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4CB9568C15D for ; Mon, 5 Feb 2024 14:19:21 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KHPy+HAW02cGYNuup6G0VtLyPdGspb24/RjvbDpLZw83nIPCw8Iz7k1VWKfZUhzrxny7rWKEFwI0VThMJTdnou2p22Yv1hMYcsNKIGBsuLGqOgVd/Fyjeqrsv34igqPz1FvPDBTow1Hnw+hf07x7HgxqKCPqt+CWGT4CJ14CXRDLrsCV95EJrb0FczZkZF8QArQCx6eBIeCNkaAazOJF5i7p6O9HCV9wxPubEMXA14URkCMg/watL/zSHFcaUDz8winmIINEaIDELJgrvId4f6gR3igE0jTOtJ4sw1hY5SVe0F4uY2bPTtNzYVufSTJCuCzwymO7sECk3D+ORk/lOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J+H7duaC5EaRvtyNwwwm8l8fL185FPPqgMwu66t2Z4k=; b=TyL0jTiKy3Oj3JzIth8P8KF+4XFFKxVhF3fz+qE0oGK7SdOLYR55RgjM5zW1hzsTUERgLP4G2wMRgFGl+wJHxiZZ9WyCnCgYCd9NQDJ5HNaomOpUB1e6lnSBkwZChbAIAnj8oq7TfDBljJXPtvs8Zdu1MW+kDL4rX8UhGs0sMdtvKrzZBupY95nZ05gH0AatcXO7wbkrJ5/4vCY6xZ3rfNXdjSttiWTEa/59gONQnSym5IA93y5Mmbf8TyXt8UvOLWuo4ChnktiaO5INgD+iDlyTLCR4ZxG4bwDrkDDxlVZ5qjxX/OIBHYoMQP0hZMq0kBtpGl1M91ql1d8vLBIsMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J+H7duaC5EaRvtyNwwwm8l8fL185FPPqgMwu66t2Z4k=; b=XjYJwrtWY7lXx3+n3vA7/f8WR+vfhj+HgUG9ICQ9DYx7AhZiTdThZCDww9J1hv7cFekkG1ZQkrTVwcqAr2Jg2010AdGnSWOM6EkgxDj3Lnj/InIzFgcztP7fv+m7viJNHZ7JLoY8yJOYKmE5lDo2gctYpxNrLEaexVwpfk93KZYf7/fLlccuupbrt7cd5wlxpPNQLZRr302JDwe5OtMLYQ/3bNXMM5G81zJiBnEFVWeAogBFkQDMOcpCYBLSWSwp68SumzU37X1Nzim/sI4Gkp97AOe3ayl6J73loBUmQCBQsqzRzuywon1TTcsItPiBFOpSYv2fwh3LJQyJkdbVfw== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DB9P250MB0404.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:326::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.33; Mon, 5 Feb 2024 12:19:16 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7249.032; Mon, 5 Feb 2024 12:19:16 +0000 Message-ID: Date: Mon, 5 Feb 2024 13:21:09 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240204183000.726766-1-marth64@proxyid.net> From: Andreas Rheinhardt In-Reply-To: <20240204183000.726766-1-marth64@proxyid.net> X-TMN: [SalgMMwVkwSCjp2JsGXaJ/+BLtLQZYVNxb6sgKUsUQw=] X-ClientProxiedBy: ZRAP278CA0008.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:10::18) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <1928284a-cbcc-498f-b8b9-448abcec836c@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DB9P250MB0404:EE_ X-MS-Office365-Filtering-Correlation-Id: 15fea1f4-acc1-45e2-c841-08dc2644abfc X-MS-Exchange-SLBlob-MailProps: 9IecXKUgicByOPSJwOf10mei4LWviw7wJUuHR6IHKrsGSDoQjk4LxtYcAKOqSL9RlnirOMpfZFg1gT5PBjkWm1vbvp6BKmmpsJZeN67089LBUPI8EZTef14FjJREi9O6Fp7I/qzMl3NP7Clfmu0s+1W7osCmz2BQSx3VxM4I5vtjUg2WuomNt8ugNZQc+GF4fJmWcJAUCkMhBzrQ/Pv1ZO0I4v/sc37Bcx3yfLi7VNBHECdZ3Ve0zRIEMUqWaK3qEfq2FVgOG+9Xss14E7oXQvyoR8o0NJmqF8jItaxJjzp+DMsHdObAdPfiHLSzKmQ4RMeagbFjQ3TqiUstYvXpDw30goTqsx4SthURlGWfHG5BtQIZYsNerGw9mwhhIOI2hfkEAujgJjhuOBK+H+jhma4pILcl+A8eSV4M1QKMutCf3UkuZGJYHsHKVW831gtFQNY2UFNfPzsl/6S74b+oVdcf1ugR26Oq9e/kCoUwLV5P+UKR7cmGzlDA3LVZrcrUBM2/Voxc28gHr6FIO0BNO2C0okynB3UJrOGrrYzIlSPvth7JLsULrf7LV8dJOYIeo6TMAPdmALhDAIcdZJ3KXr1I4uLAe8Z+ABTzFhypTwq0RKMhbTfNzFm6LrSfU/pJ01KLV+VuuR0ZdarmkGwSl85r+5kF/tHsmkVWt8agjjDh5U310AZyWFWtt7Ie1saEdFmp2ORMGHvpZdtPZu6I/pubRmzgpfyeNMXYaFR9vQ+74rzw7MTaBw== X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6V2XqQ/5dqkphyZ1wYv54o7poLooMPoiRQ1wiWIJk55jdFeh4Otgt9iVSO1kTjcvrze3i4cFI7onIpYlyhaGHd1cWG028lmFbRD69ybAAXmhJpIHLm8x7LTU7AdmvrhTpUllS5gBMH6Ei4fC4qTiz+C8kVXsbGbgnp1tRZIhBzP40ur/NlWO1GyCsOfT2DySj5GGD6C82CsoXkmOuXZ4sfzIkZP2LnKws62NHTKAHXJz1vSqsB7oXQds6J9mggH02Cw4COuE7GuIiyUbFt9yQR2Wig/gd1j5qnQ6TMvzm6FRVoQKhmbGlD+Em7Su7BCVx/uhz+bBoWKYfZughJawDDr8XucLD42yVuIoPij8yYa5HE8aFQgWgpfwiMllkU7xDy2jtUTE+UooaU1iQ9UQJCCZqZlp3Lxzxg8V1NJF6KBRpvSVS4JaSeI/fKpIA+6cqQoiMVh6OKwu5nd1pc24VO+qtgMIc8PM07nlv8TMIuztNlCOXrqiUAw24G2pGFTBLEVqPzjGBppfq/scMtgn5UuKWxgmfntgMxUu3dVepp+QeZ4hK8fUutu4IfCxJw/y X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckFUaUZRTmlEZk1WdTFXV09WQm1aeHNPK0tPS09SRGk1TEpFbzNXcDBhVW1k?= =?utf-8?B?Q2I1WUJoK2JZU01pdDBnVjZicElYWlBWQUEyY1hmWkhTcUNKalU2Ynd6OXEr?= =?utf-8?B?WXBhNTJKazdWZ2s0U3R2ZHBEQTIwWHpYbzkwRnp4MUhNVFBHUm5iRzFjSFhq?= =?utf-8?B?cnJuV0drZTFFY2FxbHEvT2ZMeDdicy9ZQVptQUQyMEpOb0VaVWFJSWllMnlw?= =?utf-8?B?YnpIZ2lBQjQ0RDVXNjNQZVNvZ0RralkwTzhFbVBjK1IxQ0hwMHRqSTBvTElv?= =?utf-8?B?aFkzWGsxK1U3VUtUUlp4WlFwVU45M1I3ZEJ4T3JpT2ZmNDlGcGF2YVA2Y2I0?= =?utf-8?B?UUp1WlBORHlGNmhmWG1YZDludjY5V2xiam5hT3RCOUN5eFFhNHNPWVhCa0tU?= =?utf-8?B?V0tReEsybS9Ub3gxYmEweWdnNTdzZkZNdEdZS0hvMm9XS0hrQ1o3WlhPc0Uy?= =?utf-8?B?NExUOU1PdExibHE1dDJvNDR6cDNzTE5meUt5SFNpRmJTVmFLcFQzMVR1aWpT?= =?utf-8?B?amx0MUtuSnFnUHZZT3hkcGhjK0NWQXhoTU1yeW9OaFZMV3FHT01NcklMN2Uv?= =?utf-8?B?Y2NySjhpLzgzRU9WSzFQV012UFo2TVBmK3Q0ZlZ5a1p2dmEyUU52L0ZvWG5J?= =?utf-8?B?aXRQMkdlSnZBeGF2MXdhTi9xdGtSMlFCVmZIUnBrQjF5Y2EzTXBGcGc0a0dG?= =?utf-8?B?MFhaaUE0YlZhRDA0SkxiT2prYjRjaExWSXpvUE9kTys4WGpjOGdCbUQ3LzhG?= =?utf-8?B?amlmUWNTUU42Y3lnVzNaQXFhTy9EVnZGcjd4SWNaODEvTC9GRVQyNzJYakVM?= =?utf-8?B?RmVKT1F2ZWgzRE9Ic3lTcXNpZnRFMnh5RC9qSy9uR3RVb2dhRUJnblVURFhS?= =?utf-8?B?OThmeHB0cERMazFxOUtMNHluWHFhQ0hUZTRDS0FUL2FGMExQaU41VGhnY2dI?= =?utf-8?B?U3Q4Nzc4dnJ2Ujd2c05TdTMyM2pSdEZTR0lGSnNWaE9tdnJjeTJBMnRlKzFt?= =?utf-8?B?UWNlY0oycWVWVmJvMFl3N21kSVV0L2p2V1h3K3l0Sk5ZV3lWUGs2TFRwUjNn?= =?utf-8?B?VUIvTzJHVGRxRXAwMWV0bFllTVlpdktYeVdGY2ZEQThYbVEzR3NJeitrc0RX?= =?utf-8?B?a3I0VUQ1K2xwOVdRSzZKN2hDTTJHQ204N3oyUFlZNG9sU05hcklhc1VTdksz?= =?utf-8?B?OFFCZGVwZGJDeXVEdmppcFNSVytaVkJHOGU0OTJraW1ETGJFTmNWWHVmOVBs?= =?utf-8?B?Tkd4QzNRTkpFd3VFRHI1dVZiRkN2eVdrT3VvL1I2SXF0R09kc3BSdzVCWmJj?= =?utf-8?B?ZnJ3YitUQUo4c05xeHVPTVhqazlqTERFTVBlUnYrdkY1Z0tyb0tHM1pvOERl?= =?utf-8?B?aHhDdkdwK3A4RzlSSHAyMkxCQ1BXYURheDFCbkxDaVpSZHJkR0VoTGhSdTVy?= =?utf-8?B?WFhsd29oaDBmSjdqODdrM3JIdmQ3NUwrNENaZ1VpN0U0U05VMUdjeHRwWTRG?= =?utf-8?B?NU5yMUNoRHJnck8ydkpicE1DTUNienRsTytkL2ZDdHRUcWF3WGVOMzVTcWtX?= =?utf-8?B?cytBMXlRODVDYXpYc292OGRabTc5aG1ZaFVoQVlIL3VVMHhRSmhoQlBTYjhk?= =?utf-8?B?RVpRRHFMSmQyZE11V2ZISXhHRjZHb1FnWmxTVW44anZKRFh2ODZQOXE5SlZj?= =?utf-8?Q?ig3u/0SFUzhIepepsXjk?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15fea1f4-acc1-45e2-c841-08dc2644abfc X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2024 12:19:16.6876 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9P250MB0404 Subject: Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc: reformat options table indentation and descriptions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Marth64: > matroskaenc options table has grown packed over time, and is now challenging > to read. The purpose of this patch is to reformat the table, indentation-wise, > and to make the capitalization/endings of each description at least consistent. > > I intend to sort the options in a follow-up patch, but wanted to phase > this out to be easier to validate. > > Signed-off-by: Marth64 > --- > libavformat/matroskaenc.c | 42 ++++++++++++++++++++++++++------------- > 1 file changed, 28 insertions(+), 14 deletions(-) > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c > index 1457a6890c..2668d1e009 100644 > --- a/libavformat/matroskaenc.c > +++ b/libavformat/matroskaenc.c > @@ -3497,20 +3497,34 @@ static const AVCodecTag additional_subtitle_tags[] = { > #define OFFSET(x) offsetof(MatroskaMuxContext, x) > #define FLAGS AV_OPT_FLAG_ENCODING_PARAM > static const AVOption options[] = { > - { "reserve_index_space", "Reserve a given amount of space (in bytes) at the beginning of the file for the index (cues).", OFFSET(reserve_cues_space), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, FLAGS }, > - { "cues_to_front", "Move Cues (the index) to the front by shifting data if necessary", OFFSET(move_cues_to_front), AV_OPT_TYPE_BOOL, { .i64 = 0}, 0, 1, FLAGS }, > - { "cluster_size_limit", "Store at most the provided amount of bytes in a cluster. ", OFFSET(cluster_size_limit), AV_OPT_TYPE_INT , { .i64 = -1 }, -1, INT_MAX, FLAGS }, > - { "cluster_time_limit", "Store at most the provided number of milliseconds in a cluster.", OFFSET(cluster_time_limit), AV_OPT_TYPE_INT64, { .i64 = -1 }, -1, INT64_MAX, FLAGS }, > - { "dash", "Create a WebM file conforming to WebM DASH specification", OFFSET(is_dash), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, FLAGS }, > - { "dash_track_number", "Track number for the DASH stream", OFFSET(dash_track_number), AV_OPT_TYPE_INT, { .i64 = 1 }, 1, INT_MAX, FLAGS }, > - { "live", "Write files assuming it is a live stream.", OFFSET(is_live), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, FLAGS }, > - { "allow_raw_vfw", "allow RAW VFW mode", OFFSET(allow_raw_vfw), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, FLAGS }, > - { "flipped_raw_rgb", "Raw RGB bitmaps in VFW mode are stored bottom-up", OFFSET(flipped_raw_rgb), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, FLAGS }, > - { "write_crc32", "write a CRC32 element inside every Level 1 element", OFFSET(write_crc), AV_OPT_TYPE_BOOL, { .i64 = 1 }, 0, 1, FLAGS }, > - { "default_mode", "Controls how a track's FlagDefault is inferred", OFFSET(default_mode), AV_OPT_TYPE_INT, { .i64 = DEFAULT_MODE_PASSTHROUGH }, DEFAULT_MODE_INFER, DEFAULT_MODE_PASSTHROUGH, FLAGS, "default_mode" }, > - { "infer", "For each track type, mark each track of disposition default as default; if none exists, mark the first track as default.", 0, AV_OPT_TYPE_CONST, { .i64 = DEFAULT_MODE_INFER }, 0, 0, FLAGS, "default_mode" }, > - { "infer_no_subs", "For each track type, mark each track of disposition default as default; for audio and video: if none exists, mark the first track as default.", 0, AV_OPT_TYPE_CONST, { .i64 = DEFAULT_MODE_INFER_NO_SUBS }, 0, 0, FLAGS, "default_mode" }, > - { "passthrough", "Use the disposition flag as-is", 0, AV_OPT_TYPE_CONST, { .i64 = DEFAULT_MODE_PASSTHROUGH }, 0, 0, FLAGS, "default_mode" }, > + { "reserve_index_space", "Reserve a given amount of space (in bytes) at the beginning of the file for the index (cues)", > + OFFSET(reserve_cues_space), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, FLAGS }, > + { "cues_to_front", "Move Cues (the index) to the front by shifting data if necessary", > + OFFSET(move_cues_to_front), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, FLAGS }, > + { "cluster_size_limit", "Store at most the provided amount of bytes in a cluster", > + OFFSET(cluster_size_limit), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, INT_MAX, FLAGS }, > + { "cluster_time_limit", "Store at most the provided number of milliseconds in a cluster", > + OFFSET(cluster_time_limit), AV_OPT_TYPE_INT64, { .i64 = -1 }, -1, INT64_MAX, FLAGS }, > + { "dash", "Create a WebM file conforming to WebM DASH specification", > + OFFSET(is_dash), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, FLAGS }, > + { "dash_track_number", "Track number for the DASH stream", > + OFFSET(dash_track_number), AV_OPT_TYPE_INT, { .i64 = 1 }, 1, INT_MAX, FLAGS }, > + { "live", "Write files assuming it is a live stream", > + OFFSET(is_live), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, FLAGS }, > + { "allow_raw_vfw", "Allow RAW VFW mode", > + OFFSET(allow_raw_vfw), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, FLAGS }, > + { "flipped_raw_rgb", "Raw RGB bitmaps in VFW mode are stored bottom-up", > + OFFSET(flipped_raw_rgb), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, FLAGS }, > + { "write_crc32", "Write a CRC32 element inside every Level 1 element", > + OFFSET(write_crc), AV_OPT_TYPE_BOOL, { .i64 = 1 }, 0, 1, FLAGS }, > + { "default_mode", "Controls how a track's FlagDefault is inferred", > + OFFSET(default_mode), AV_OPT_TYPE_INT, { .i64 = DEFAULT_MODE_PASSTHROUGH }, DEFAULT_MODE_INFER, DEFAULT_MODE_PASSTHROUGH, FLAGS, "default_mode" }, > + { "infer", "For each track type, mark each track of disposition default as default; if none exists, mark the first track as default", > + 0, AV_OPT_TYPE_CONST, { .i64 = DEFAULT_MODE_INFER }, 0, 0, FLAGS, "default_mode" }, > + { "infer_no_subs", "For each track type, mark each track of disposition default as default; for audio and video: if none exists, mark the first track as default", > + 0, AV_OPT_TYPE_CONST, { .i64 = DEFAULT_MODE_INFER_NO_SUBS }, 0, 0, FLAGS, "default_mode" }, > + { "passthrough", "Use the disposition flag as-is", > + 0, AV_OPT_TYPE_CONST, { .i64 = DEFAULT_MODE_PASSTHROUGH }, 0, 0, FLAGS, "default_mode" }, > { NULL }, > }; > I do not really see the point of this. It will just interfere with git blame when searching for the commit that introduced an option. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".