From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH] avformat/webpenc: Check seeks
Date: Fri, 6 Oct 2023 03:55:31 +0200
Message-ID: <AS8P250MB0744038666E367587890E4D18FC9A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
Addresses the issue reported in ticket #4609.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
libavformat/webpenc.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/libavformat/webpenc.c b/libavformat/webpenc.c
index b3f5bdc9b5..fb0cca3922 100644
--- a/libavformat/webpenc.c
+++ b/libavformat/webpenc.c
@@ -177,8 +177,8 @@ static int webp_write_trailer(AVFormatContext *s)
if (w->using_webp_anim_encoder) {
if (w->loop) { // Write loop count.
- avio_seek(s->pb, 42, SEEK_SET);
- avio_wl16(s->pb, w->loop);
+ if (avio_seek(s->pb, 42, SEEK_SET) == 42)
+ avio_wl16(s->pb, w->loop);
}
} else {
int ret;
@@ -186,10 +186,11 @@ static int webp_write_trailer(AVFormatContext *s)
return ret;
filesize = avio_tell(s->pb);
- avio_seek(s->pb, 4, SEEK_SET);
- avio_wl32(s->pb, filesize - 8);
- // Note: without the following, avio only writes 8 bytes to the file.
- avio_seek(s->pb, filesize, SEEK_SET);
+ if (avio_seek(s->pb, 4, SEEK_SET) == 4) {
+ avio_wl32(s->pb, filesize - 8);
+ // Note: without the following, avio only writes 8 bytes to the file.
+ avio_seek(s->pb, filesize, SEEK_SET);
+ }
}
return 0;
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2023-10-06 1:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8P250MB0744038666E367587890E4D18FC9A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git