From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avformat/codec2: remove surplus include 'memory.h' statement
Date: Wed, 23 Mar 2022 11:54:42 +0100
Message-ID: <AS1PR01MB9564EB5650E9FFDEC31669298F189@AS1PR01MB9564.eurprd01.prod.exchangelabs.com> (raw)
In-Reply-To: <67939932c67d883bd62b5c0fa9c38dc172e3da44.1648013166.git.pross@xvid.org>
Peter Ross:
> on glibc memory.h drags in string.h, but codec2 does not use any
> str* or mem* functions. additionally, memory.h is not part of the
> C99 or POSIX standards.
> ---
> libavformat/codec2.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/libavformat/codec2.c b/libavformat/codec2.c
> index cd0521299c..400c5acbdb 100644
> --- a/libavformat/codec2.c
> +++ b/libavformat/codec2.c
> @@ -21,7 +21,6 @@
>
> #include "config_components.h"
>
> -#include <memory.h>
> #include "libavcodec/codec2utils.h"
> #include "libavutil/channel_layout.h"
> #include "libavutil/intreadwrite.h"
>
LGTM.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-03-23 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 5:26 Peter Ross
2022-03-23 10:54 ` Andreas Rheinhardt [this message]
2022-03-24 17:33 ` Tomas Härdin
2022-04-09 19:07 ` Marton Balint
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS1PR01MB9564EB5650E9FFDEC31669298F189@AS1PR01MB9564.eurprd01.prod.exchangelabs.com \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git