From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 016E542547 for ; Fri, 18 Mar 2022 13:37:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BF67468B124; Fri, 18 Mar 2022 15:37:22 +0200 (EET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073090.outbound.protection.outlook.com [40.92.73.90]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 30A2268AE56 for ; Fri, 18 Mar 2022 15:37:16 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G+H7zxBKDkeJyfKFUrKFtP1BhqwEAKsV5aUt/qWUdnMNlz/mndOZFHeD9N5IC6PQBIo0UW1rFidnq3kpFYzKmlzOBhnNW7wGiio6+0u5qtBvnn/X5gZfCqbMgBp6mbDhL0LV5TI4A6c2Lt1+KajGhuxV47CiFc/2WeZ6Sbcz8cGD4FUP945A5a89AFRhNB+Y70T3mXBO7If4pJkmb3Zx8VVGrcwlbHsMrQwmgk5TQa0KbhaAchP3G8i7BkGixcucEtt7PFViYMsmvRRWeepk6o5xQ/u8ME6pOhYkIYGRSLu+lrRhyS8ZbtJrMusYBiMN6DrW1rqkC+xlYqA3OIeYrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nw6jEUrNELzXsw7E5Z+P0T7NkwMP9LGMAG8plJQRRGM=; b=WQkGInW8ap4vKCA+kmQB3rf0ztIuDcqARFJT4y6AHogVnM2Z6KFiNpSOHivHPAGBpOD/cqzoeJ9c3Byu6shJX2Fwxz+FnAIlDhCUkfsxhfuFsoM72Iu8mmzBP5P4BAon/NNvBg3bBBSMRST0P08EoKPiN5Bvh4yBiqs76MQGJvmXY201jOoLxeB6D9jX0oV4KrjPdLjaeXOKAFitH32YR5iEpN9n8J099h0TTB1vCOB5nIghl34xUiK5SrPau1HH4Lo5TBBmGxZ2CBTKkpyFM3N7k3ysNxe+F/+JGPkBuPeggH8G4Kfcjgh7QJS6FVtoh7bphRZqeLldMR8Jpz4Xew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nw6jEUrNELzXsw7E5Z+P0T7NkwMP9LGMAG8plJQRRGM=; b=i/BXxiB2jw/s1BvTnUcXDOMdQzQl2PeBYk1axUImqccLMoPy+ghGuq9V8QsSHVELJSv0XHzu4oLNclrC4+vGklXGlkzIAyKy9YbRmzXo21mOGS5VYt6bgjM/JG0bMCflcszDwfzLQ50sBzI6eJzGSYuU8r0fXfC1YvN8FQBdQXm70WOJ8hA5Sz0e3qApTd1BSnlujNBEE7PknvrFEiyrNShtpQsWPpHpoz58erWnCGPtFUOpV4RyyYX1MK8tJuljmy/1TE+op6HilAdr6cO9SQmfTFDuwv/A8j6wjkJn7akR6v0ohF+hM+TZWGb1or2Vzcugv7AbEmoVrPe6yzb80w== Received: from AS1PR01MB9564.eurprd01.prod.exchangelabs.com (2603:10a6:20b:4d1::16) by DU2PR01MB8035.eurprd01.prod.exchangelabs.com (2603:10a6:10:274::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.17; Fri, 18 Mar 2022 13:37:13 +0000 Received: from AS1PR01MB9564.eurprd01.prod.exchangelabs.com ([fe80::9070:a5fd:e532:bdf8]) by AS1PR01MB9564.eurprd01.prod.exchangelabs.com ([fe80::9070:a5fd:e532:bdf8%3]) with mapi id 15.20.5081.016; Fri, 18 Mar 2022 13:37:13 +0000 Message-ID: Date: Fri, 18 Mar 2022 14:37:12 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220318131316.GU2829255@pb2> From: Andreas Rheinhardt In-Reply-To: <20220318131316.GU2829255@pb2> X-TMN: [N2SBH9q83Zou1YD+4t8piP0IpF37UMZK] X-ClientProxiedBy: AM5PR0601CA0033.eurprd06.prod.outlook.com (2603:10a6:203:68::19) To AS1PR01MB9564.eurprd01.prod.exchangelabs.com (2603:10a6:20b:4d1::16) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: df33fde2-ad70-47cf-a7c9-08da08e46906 X-MS-TrafficTypeDiagnostic: DU2PR01MB8035:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IkboMZJ4egp4LDw34NVmZ7j+/oP2fJqGhVAY9/05C2GUjarbiWJSztKQGbo2wdWEjqGQYVkeQFXUXtj1B8H7tCxxoXaL7JNGnqXshrRVqWaZ/zJZDZM2CTZvGEA6XXhcR02MjTvXBnbqYgyWcaS9N9KGmG5zlc0wtzUt0BJoTre6IZD8R1bAX4hnyIJQjlPHqvsd/tTSK+LtMLBYEYI+s03fIxJblwOZhRR044BAJNh2t9x/JC0VxXkPF7xXRxmYBoWW6SRZt1EPVeY1kt7odgVCghC5EEYOJlILeGP+HrSnMtpPAY9URF57xKDRyPlYj+HpbTqk3Uc47+YNSoA+uPocW3/32qHFUq87ZFlFcUJg22yF+cwu2PDlKBU9hK8Yx/WfveInCMTp7Vp6TFzgwYjBCi4RqHat6ODrN5+jRpSSPqh1PLdY8hQi16rxHgO4edJtvYYBgR/DHT7bBHj9pEIwg03ECr2lg6/LcUbxaLOeYoYxXqvBZqGyTOzvPyInFiN50yWKn8l8GLEBDfj4wWYKk/tOHn/hjKsIHQUKK+FdI3dSHacMlz9T+fiDUvS1xAZuftEWHdY09fBiGc0dAA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHdmNEpvYTdmRDJDWFl3SnRMNVVsTzdqUUN0d1NGbTJjVTE0UHlUS2lScFJZ?= =?utf-8?B?bDdJRmRDU0p5M1NJTExuVTc1b0VYYjFMSHVNZzVHbEdXZXZhdUxQdTNQOGJt?= =?utf-8?B?NENuVnZYMEpCeTF1QWsrZ0ZkMjQ1RlpNOFFJQ05KTml2Rml1SFcyakVpdXY3?= =?utf-8?B?R2N1T0cxQUNnM0x2enFDQXRDMmF1cmJjUVgwc2R4SU1hMlVMdS9mUXZhTW91?= =?utf-8?B?cVVPZTlGM3FYMTMvV1UyS1AxZ2RhWWlSZm9MUXhjVExVOFEwWEhPK0E5UHZn?= =?utf-8?B?WVNWR3RzR1ZuOVFoNG5PZ1FUQmVOMUpCaUovcGtkU0YzcHVsVlhwTWhFUDlM?= =?utf-8?B?eWZYNnBkYTJYVGxoOUxkRUk5MzBWbHFlUitpSFd3Nk9RQ3lRQ21jMkpOZjZL?= =?utf-8?B?M0pUYW4zcmVqNkI0dkZFdUY2NVhjaXI1cXdkZnBtNjBNQnNZeFN5MXBzZ25j?= =?utf-8?B?bTMybGZVNndnR1ZoN2F1OVpIYXlBdE1TQjlsa2h1VTdnOXJnbTh6NkJhSW95?= =?utf-8?B?RXIybzVJRURmYWg0TXZLTGRHbkdTL010LzZ1Y2dKM3hmZmVXaTgvRG52NG1G?= =?utf-8?B?MWFBamJJV2ZDdG94U1pDZXM5RzR2dHd3aUZnU1JXeXgwVE1kMzIyRHVWdytX?= =?utf-8?B?cWpUSHFyTWhWOGJjeWE4alVHemtnRlRhaU5QODI0UXd4b01oSWdxb1luVnhu?= =?utf-8?B?NzhTeTdLZlVkYVlCb2JwcEwxOGpsc0t6QjJUbENKWkV2bjlRKys4N3IwZS9R?= =?utf-8?B?aTZpZFVCdTN1SEVFNlR0TzVuWFBBQUt0dEVudFowanowMzVvbmlhRDQvdTJE?= =?utf-8?B?MjFHR1A3d05ZenJlbTJ1U2hmeURHUXgzUmRVTU9ocW9rdWZMRlFUbEYxSW1U?= =?utf-8?B?ZkFFSGFkK0FWSTIwRUJzZ3N4R2VHK3h1Smp6NlZDWjhXWXNFQXBmbjJpQW1u?= =?utf-8?B?eFdxWXlRdWRZdXFtZXo5ZE95dFJBVERMSUlNMytISHNNVTBidTQraVpxR2p4?= =?utf-8?B?Um5RNyswZ3BKQThlNW1jbUZWbkI0Y2E5djFlZTF6NGJ5Vi9SdGtEVWwvNWk5?= =?utf-8?B?MDl0ZUNKcjlLOHZRN3RKaEUwRlozMEI1ODdYSnVrSEJjQ2RJWTVHWGx2K2tu?= =?utf-8?B?Q0FqaTFtV0VNRzFrdUF0Z1BKc0NDK2lDbmo4cUpuWnliUlVHb1FjaW96U1ll?= =?utf-8?B?M3JLSVV6TDlGRzEzemV5eVRUNDlsSnZPbDQwanhrZ21TZzUwalEyRjdUTThu?= =?utf-8?B?U2wxcW1kSlc1QkZsdm1Qb3NEYjhza0Q4dHk1M2l6NW5QT3p1d3Y5dWdkaitl?= =?utf-8?B?WDB6QVV5UVN2YjdzOUIrRUpScitBbmZEZ2NkeStOZCtBMEh5dWovU0lrbU8x?= =?utf-8?B?M2tRbWRtRVVSb0EwdThOTDRLdnU0QlZMSEJleUdNKy9sajJKaGhDTTZMNjJF?= =?utf-8?B?Ym4wT2drOWdLYzVqS1B0M0owakwwTVMvNTZUOTFlRURwZEdoTlgxNHZ6aHkw?= =?utf-8?B?NllKK3Bvd2FKNkQvQXFSM3B4bVpuSEpFZHRGbWxWYzdkb1crdkFFUTNZYW45?= =?utf-8?Q?1qR8J2tFfkUJp9mfIyikxfYUN1VhdypSbCCK66sV8UeI4E?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: df33fde2-ad70-47cf-a7c9-08da08e46906 X-MS-Exchange-CrossTenant-AuthSource: AS1PR01MB9564.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2022 13:37:13.7080 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR01MB8035 Subject: Re: [FFmpeg-devel] [PATCH 8/8] avcodec/codec_internal: Include codec_tags only when they are needed X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Fri, Mar 18, 2022 at 11:52:54AM +0100, Andreas Rheinhardt wrote: >> They are only needed for the fuzzer, so check for CONFIG_OSSFUZZ. >> This decreases sizeof(FFCodec), which is important given that >> FFCodecs reside in .data.rel.ro in case of ELF with >> position-independent code which is always loaded and can't be shared >> between processes. >> > > They are currently only used by the fuzzer, if there is no other > use, iam not sure. But i agree shareable memory would be better for them > GCC by default aligns big enough objects to 32* (so while sizeof(codec) need not be a multiple of said alignment, the actual object is still padded to said alignment) and it was aligned to 32 before the addition of ch_layouts (for x64), so adding it increased the size by 32 (and resulted in over 21KiB size increase here on a really not-all-encompassing build). Optimizing codec_tags away would reverse this. > > [...] >> diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c >> index 288aa63313..77f4bb8dd8 100644 >> --- a/tools/target_dec_fuzzer.c >> +++ b/tools/target_dec_fuzzer.c >> @@ -279,12 +279,14 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { >> ctx->sample_rate = bytestream2_get_le32(&gbc) & 0x7FFFFFFF; >> ctx->ch_layout.nb_channels = (unsigned)bytestream2_get_le32(&gbc) % FF_SANE_NB_CHANNELS; >> ctx->block_align = bytestream2_get_le32(&gbc) & 0x7FFFFFFF; >> +#if CONFIG_OSSFUZZ >> ctx->codec_tag = bytestream2_get_le32(&gbc); >> if (c->codec_tags) { >> int n; >> for (n = 0; c->codec_tags[n] != FF_CODEC_TAGS_END; n++); >> ctx->codec_tag = c->codec_tags[ctx->codec_tag % n]; >> } >> +#endif >> keyframes = bytestream2_get_le64(&gbc); >> request_channel_layout = bytestream2_get_le64(&gbc); >> > > how does the fuzzer work without the fuzzer ? > You could just not use --enable-ossfuzz, but nevertheless want to "make tools/target_dec_foo_fuzzer" (with custom fuzzer CFLAGS/LDFLAGS). But it is not really the intended usecase, so I made sure it compiles, but nothing more. - Andreas *: The ELF-x64-ABI only requires 16, but it uses 32 for compatibility with ancient versions of GCC which required 32. One can use -malign-data=abi to make it only use 16. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".