From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avformat/imfdec: Convert to the new channel layout API
Date: Thu, 17 Mar 2022 15:04:55 +0100
Message-ID: <AS1PR01MB95649A40D6976CC6500E312E8F129@AS1PR01MB9564.eurprd01.prod.exchangelabs.com> (raw)
In-Reply-To: <77c73b01-88c3-ec05-a961-5148b68ef091@gmail.com>
James Almer:
>
>
> On 3/17/2022 10:09 AM, Andreas Rheinhardt wrote:
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
>> ---
>> libavformat/imfdec.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
>> index 3ce850b75a..9ec52efbc8 100644
>> --- a/libavformat/imfdec.c
>> +++ b/libavformat/imfdec.c
>> @@ -874,7 +874,7 @@ static int imf_read_packet(AVFormatContext *s,
>> AVPacket *pkt)
>> int64_t nbsamples = av_rescale_q(pkt->duration,
>> st->time_base,
>> av_make_q(1,
>> st->codecpar->sample_rate));
>> - av_shrink_packet(pkt, nbsamples *
>> st->codecpar->channels * bytes_per_sample);
>> + av_shrink_packet(pkt, nbsamples *
>> st->codecpar->ch_layout.nb_channels * bytes_per_sample);
>
> Guess i missed it because i didn't have libxml2 enabled.
>
> LGTM, thanks.
>
This and the fact that this code is quite recent: It has been merged in
b0193e26ca32914bdd3d05be5d1f474ca8c52124 on Feb 20.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-03-17 14:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 13:09 Andreas Rheinhardt
2022-03-17 13:57 ` James Almer
2022-03-17 14:04 ` Andreas Rheinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS1PR01MB95649A40D6976CC6500E312E8F129@AS1PR01MB9564.eurprd01.prod.exchangelabs.com \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git