From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A09B94254C for ; Fri, 18 Mar 2022 13:40:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 294DF68B15F; Fri, 18 Mar 2022 15:40:06 +0200 (EET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073102.outbound.protection.outlook.com [40.92.73.102]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7A89F68AE56 for ; Fri, 18 Mar 2022 15:39:59 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i5gBTakZQJc9vC8I/ewTlDleI40AhbRiiViksMFT0XA0ARHYrtGFf+cN8vGulaBdnpjzHtJjm/jnhmDkRunceSkhNPU7GwmYzNtC8iF3K9StrXIrRToR7K1ny2tkAbt9IFtP4PnFIe59ETRJjzZnWKq3K3ZSlnvMgY3enfgcXcbLbNBoB4Ru614aJADSx/6Gk0TsM52VyfyXKApjIIf+68b9vm9aF6CXIEvE/kNb67p1iABPmS8su3XTYzIMamCx0oMn6qkcYeeVKPbCjlVSjRSSd3RdZQyaUqDesP1b1CopsVMHqLEx0q8WqHSe6UsXpQr/SmDDjfi1IwrSLa7BTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0EpPWsPSgopcKR03PDM35J+33Kyvd5psLYyx+vojNaU=; b=JJvd8MWve20ZA1YBrpJZzeE68C8x6TSSWunxGpP/nPfdQqnoawTydGZKjG4dei3M+7XbcIJhnVvIO2/Q6S+BY0z3ElPADVsafJFeAXaf4aO8mb6Wivr553KN4lBNLBkZwJGi0LbOY5BJw1XqTREaG9tFSvF0HrLuI9IzUsNiX+PLSjKNJ2xuHxGx8IJAyHG1danolWQXPVYcaY4VyL5hkxBtd7B8RBwAqBjjANoymDjxj2W5vHeQnCs66LBzNe9jojwNJmSc6F0sjcWxnlOsbDJBkxeNigT4IzCxV+1rZ8CRpBj8L5hPwgX8tmaDTC0nt0iUwR8Yr67kDKJx8GGFoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0EpPWsPSgopcKR03PDM35J+33Kyvd5psLYyx+vojNaU=; b=X1lDw9Hh4uTtQNOamdQzYBhvvEEj3EjsCUBsqJkm34ZC5d1ms+gmSMc35HiIgc9ekXtyOrqOs+0OiuqWXZobKNpZyCUC0+3kKAAdq0xg4zZf0N+oAxomQ9EbOle0itFskrxkWQDuiodTyEZak+RunZeC0JCef7eVLwPOev5HbiJNNBxFuX2IQO4Nhv8rnUj3VXOEJ9cNksWgyXSxU3EboG9zp15s7Tp05qDsc8BUFWGVspdVdBdtQZ+slswwR6cVt5ZheW0HVnAqXV3+/+T0KfC2z/dY6n/r/OVAUVbgTSk3ZCm2FZHJF2+XhDFThc4torW9fwcwUa/GoAMCtaG0cA== Received: from AS1PR01MB9564.eurprd01.prod.exchangelabs.com (2603:10a6:20b:4d1::16) by AM6PR01MB4022.eurprd01.prod.exchangelabs.com (2603:10a6:20b:22::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.17; Fri, 18 Mar 2022 13:39:58 +0000 Received: from AS1PR01MB9564.eurprd01.prod.exchangelabs.com ([fe80::9070:a5fd:e532:bdf8]) by AS1PR01MB9564.eurprd01.prod.exchangelabs.com ([fe80::9070:a5fd:e532:bdf8%3]) with mapi id 15.20.5081.016; Fri, 18 Mar 2022 13:39:58 +0000 Message-ID: Date: Fri, 18 Mar 2022 14:39:56 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220318131316.GU2829255@pb2> <20220318133157.GV2829255@pb2> From: Andreas Rheinhardt In-Reply-To: <20220318133157.GV2829255@pb2> X-TMN: [QUSSm+Gmjo0QjatuoGj+kq2cRP4l4ECE] X-ClientProxiedBy: AS9PR06CA0295.eurprd06.prod.outlook.com (2603:10a6:20b:45a::12) To AS1PR01MB9564.eurprd01.prod.exchangelabs.com (2603:10a6:20b:4d1::16) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2570977d-d8d8-4b98-e277-08da08e4cb2a X-MS-TrafficTypeDiagnostic: AM6PR01MB4022:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 51Gp5c8jq5u3+fRonsExLVOzvXgcA1xsRqmaVMP1udPd6syA3JeRG0127I03i1JNNAx553iwE4TT6GgfDalwCcFn7WU3f7NGK1sak1Jpd4+P3qBD7EgYk9ggQUPsu/UALscjgBBHsEHcoAch/lh95R43pkgPvgZRoNvCZrVZeUuw5riNBHTsPA7CbefN4HuWcZMR4agt86Cdrx+TogHzrZVjJzY/RsI8qWT5EBH3hMSnNtykSr0i1qG+dnq3sStvvPJGWE4m1sPCOHzgPiCZ8GJ0QD+QuIUD2zTRLQq+s+ZUJ9AJRP9rHNoUck5GRS1EJR0aiLXpLt1+BtQrqMOGQwQr4BPNck9Yu8k3mdxjHzX2X3tUnCo1jLqcFpC4NIn6lksWuhX7d7h/sbGEMUu2W4XOAGciCIoPNo/8pAVUfRoWa3To+Fd36RE+WsYCyjMJ58LLouRLz8yHbcliSJVdxpzp3ICtlcepyk+eTQ5dHzadIwNoUCDZY5TjAKvjJbhkulTRaOiB+kCPPMqVZ8iEg1o5ijHKi3/sWLN5XzYd5PVxS6HMRiVZnMfrZan+qYTutawTeMWbwyhDwApEZyfcoA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmxTU1BsMWFUMnZ3TkJaQy80SzFOZ3NtUHdpcllvVVlMVGRmKzI1cjZMYXVJ?= =?utf-8?B?ZUZiZGlMVmFyWWxOdk5sd0tYOFRMMDdUeHFqTWczNmNDcllTeXNNUmFhY0VQ?= =?utf-8?B?SnU5NEV1R1AyVXFTUGMrOHVscmlqWGhjWVYvMW1zOHdIY0hHeUs4QVBlVWdq?= =?utf-8?B?UjZncm1qUzhjNjhSUFpORlhPZHF2MGsxZGovVU1UdW1laDExa1BFd09aZmFh?= =?utf-8?B?V2N3VThXOHdRd3hKUzRFNmFoQmtUcnF4UVlKZnlNTHh3by91cnYvb0tPbU5O?= =?utf-8?B?S21oM1VXVXVWZGsyMDVMeFZQNjNBKzBTYmlaNHZscnNwYUovNnBxU1pzZFRJ?= =?utf-8?B?cEhsS2xoaUpXaEY1VXlvcVloS3FObHZ0ZWYzd201SXVtbGx5T1hxY3NoZFFr?= =?utf-8?B?UFkxdFU5bkxndHZmTy9oV3R6WHA5a0VIdlJlN2h1aXdzcFVWNzM0QzUxbXA0?= =?utf-8?B?cWFkdGpWa1VXUVFtbEpKeUhSVnMycDdxdnBIOWxaeld4Ymc0Q1Z4QUhob204?= =?utf-8?B?aEJQaFBzdXI0Y1J0dUMvNzFidWZHOGsvMndwbXp4U3Jhci9OTXk4UU9zUkdM?= =?utf-8?B?WEYyZXBZMGZpK2hwSDhDYzdzYlp1QzRrU2VUM01hRTZPNzRSSjhCSDA1YlUy?= =?utf-8?B?eFlOWXpYR1lLTENWUk00ZjRZOGhROC9wNDNHS0FhcWkvcFVaSUljRGRhdjJn?= =?utf-8?B?VHlOTEo3cTBlTy9XK3gwLzBia0lGOStwazB0WU5raWtKd2JmcENuZ0x5Z3B3?= =?utf-8?B?Mm9VUittanpiaEJ0K1NjWWQ5blpnaUowOFdDRHNEYmRpSzhkWGpHMGhBUmpq?= =?utf-8?B?WktIVlUwNXNuSWFRNm1yTWl2NXpMeDBYTjJndEhLekxqelo0YjRiT1IxUjEr?= =?utf-8?B?dnV6SW1VTmc5UHQrTWhJQ3lrejMxVVAvcm43SSswMDJuWkp4TmM3a0w4NUdo?= =?utf-8?B?alNHclpRM2ZRMkR5NTRGV0RhMEJoWmpkSkd0c0Y5US9Na2Z0YU0xd3JIWEtN?= =?utf-8?B?THFyKzZrM0JFVUVnWU16VVVrY3Q4SHJOVFZVOUExT003ZjRyZ3c0bSs4OXBk?= =?utf-8?B?TnB5b25KUzZZL05pc1Y3VzBUODNZaDBRWlpuYzNWNW45Y1E5VU1IRjlocDVT?= =?utf-8?B?Qzk1eFhWYXNURXJiNzFxdTVPZFY0MmdXV2svVlJWb1ZTMjJEdVJZRHV5cHlY?= =?utf-8?B?Zlp0eFY3a0twUkc1NWZMb3pNajRoY21jMDFxZzdRZklOS1FrbFFpTjVaUzlM?= =?utf-8?B?UHVySmhyaE9ENTlHeHJzWEsrL015Zkw0SmJuKzFGMENYYjhhREI3YmJNVFVn?= =?utf-8?B?RVVybG9YUFhrczZRM05UbHU1S0EzRTNZU0pnWG1VSGl3Q3ZreUNCTkdBYjhy?= =?utf-8?B?bFdsWFpSemdlbkZvS3hFQWtEa2xGemRCUG9UNk1NdGcrM0FGZVYrWTJnNTJp?= =?utf-8?B?K2N2ZVNLZ0k0cFhDYlJFYnBwVEZMaXdjODlHK042NXZaa3dhaExlekV4c0VW?= =?utf-8?B?ekdpZzZLNzgxTUpLWUpGZjV4clNOZDNoUExINXp4N0dqUGJ0ZjkzbDlRZkl1?= =?utf-8?Q?uOIrOdurQ5JTsp2eOz9obsX7xmWD4qXsc4NdyDJLPQx6FN?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2570977d-d8d8-4b98-e277-08da08e4cb2a X-MS-Exchange-CrossTenant-AuthSource: AS1PR01MB9564.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2022 13:39:58.2059 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR01MB4022 Subject: Re: [FFmpeg-devel] [PATCH 8/8] avcodec/codec_internal: Include codec_tags only when they are needed X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Fri, Mar 18, 2022 at 02:13:16PM +0100, Michael Niedermayer wrote: >> On Fri, Mar 18, 2022 at 11:52:54AM +0100, Andreas Rheinhardt wrote: >>> They are only needed for the fuzzer, so check for CONFIG_OSSFUZZ. >>> This decreases sizeof(FFCodec), which is important given that >>> FFCodecs reside in .data.rel.ro in case of ELF with >>> position-independent code which is always loaded and can't be shared >>> between processes. >>> >> >> They are currently only used by the fuzzer, if there is no other >> use, iam not sure. But i agree shareable memory would be better for them >> >> >> [...] >>> diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c >>> index 288aa63313..77f4bb8dd8 100644 >>> --- a/tools/target_dec_fuzzer.c >>> +++ b/tools/target_dec_fuzzer.c >>> @@ -279,12 +279,14 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { >>> ctx->sample_rate = bytestream2_get_le32(&gbc) & 0x7FFFFFFF; >>> ctx->ch_layout.nb_channels = (unsigned)bytestream2_get_le32(&gbc) % FF_SANE_NB_CHANNELS; >>> ctx->block_align = bytestream2_get_le32(&gbc) & 0x7FFFFFFF; >>> +#if CONFIG_OSSFUZZ >>> ctx->codec_tag = bytestream2_get_le32(&gbc); >>> if (c->codec_tags) { >>> int n; >>> for (n = 0; c->codec_tags[n] != FF_CODEC_TAGS_END; n++); >>> ctx->codec_tag = c->codec_tags[ctx->codec_tag % n]; >>> } >>> +#endif >>> keyframes = bytestream2_get_le64(&gbc); >>> request_channel_layout = bytestream2_get_le64(&gbc); >>> >> >> how does the fuzzer work without the fuzzer ? > > or is the idea to build test this even without oss-fuzz somehow? > Yes, this #if CONFIG_OSSFUZZ is just intended to make it still compile in this case. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".