From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C3BEA426A4 for ; Tue, 22 Mar 2022 13:28:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8F3B868B084; Tue, 22 Mar 2022 15:28:20 +0200 (EET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2041.outbound.protection.outlook.com [40.92.90.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A720968A774 for ; Tue, 22 Mar 2022 15:28:13 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bWJ1yKLmVIFMYxVvmh1obHAvrgTyuJ/NA/dfUisJr4rLsWsoGS4NWJyxY4/qtVFmbnu7m77Bb331IjuYcaSo78KfMtSRT92JE+Mn4wW2agYn7wX07dr2Q00yVhVoelhVl8g/2F/Cwo4ej+IgCZKai3Tv6xiGiZSeTT9fI3+362RmlMAu5bjR4op5ryngUIl7VrDjK02GZv4gZTiK4q3nZNnseRWj+MYojKeqvlW2nki1ca/WWojxKawrrxGVMNmT/aOQHlJpy4pLCjdf0Zr8EWk/6BX+KzjooJoL/BpA5nZYFNKYS77ChdZmF9c+UyioRv6srea3g7976K5hoVtxfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U8IK+q0wy4B09xlxiQGX+K8uLuIq5MMUesgWbFF5BXk=; b=elC4PMC1MVlfXZtK5tSCkvlUNlaGLHZC7HCIAISTvoy9BAO1kUc7Vt2RWOays9NaqEdhMww5c5KMnlVvr96JxYzroMFRfWulPlIDTxvA70aphhCiDlBhZMZGroDeL4bAfwfD7iXw0/74QVSuEkJxn2t777fvS1iP3MYOSxtuai/hTLF567xGWAs3Fpo+Rq9GBkU5eqR3/V8DpNMOeKylY8f0MitGiPZGSINLvFMISP0PPWjWLWf8WoX91d1XsLwqq3QsHJ0QZm08ocDRHyRa5JDyUqWQ4wlaoYn6tBonXoZYs3KUkmXZDT/R8UR1X3Rcmn9Fqgm46i45za75MYMnYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U8IK+q0wy4B09xlxiQGX+K8uLuIq5MMUesgWbFF5BXk=; b=twOAnKrTDC5USrsnnR45JmRLX5IFDOlQJogYOdlh3/Y9A1hY63qR9NVvU4f5puU20+Demi12f7R5wE0rnal6hre6PhnGzkiU1amUedWD85We/Ig/QEiFcxJK6GyCvjWLzOEreS/uyDOdmWHSpoI8f6kYoHHjrOZqK2+TQVjnefj9bPzHKS2NcdIExqcgVRFiZVjo3CFACnyiwvNpVL2JZT8HYe/JDXrYfp+YGkbbQGHPpmNHeriB3h/HGvScwCdsXrmm5y9e/WnxCp/R0OvvzmS45AuZIaMjtBrNQxfXl6M8H5WwRzdyDs6CRPT4FUDZCLj1UtSqy6JupP6Hyn19rw== Received: from AS1PR01MB9564.eurprd01.prod.exchangelabs.com (2603:10a6:20b:4d1::16) by VI1PR01MB4941.eurprd01.prod.exchangelabs.com (2603:10a6:803:91::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.17; Tue, 22 Mar 2022 13:28:11 +0000 Received: from AS1PR01MB9564.eurprd01.prod.exchangelabs.com ([fe80::9070:a5fd:e532:bdf8]) by AS1PR01MB9564.eurprd01.prod.exchangelabs.com ([fe80::9070:a5fd:e532:bdf8%3]) with mapi id 15.20.5081.022; Tue, 22 Mar 2022 13:28:11 +0000 Message-ID: Date: Tue, 22 Mar 2022 14:28:10 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <1646229512-12103-1-git-send-email-lance.lmwang@gmail.com> <20220311135854.GA24038@gmail.com> <20220311155851.GA9443@gmail.com> <20220322123756.GA12953@gmail.com> From: Andreas Rheinhardt In-Reply-To: <20220322123756.GA12953@gmail.com> X-TMN: [xyjbomJp0q2XZWE/3HF+0fsYq0UiS3lL] X-ClientProxiedBy: FR3P281CA0018.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::11) To AS1PR01MB9564.eurprd01.prod.exchangelabs.com (2603:10a6:20b:4d1::16) X-Microsoft-Original-Message-ID: <85672256-18c9-4374-d756-7cab1ae54780@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c004a90d-dd84-492a-0113-08da0c07cf8d X-MS-TrafficTypeDiagnostic: VI1PR01MB4941:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GoifPlw8IJm3nNmvGE0f6kE3XxPx2LDJjTGb5Lb2uF0oHCGxkrRhuWNHYmo0PNLVP+EBS3TNTOjYV6ZPHc0+WyfEeJRqQMihCKo1zpKF9z+Ja5FPT14IAXrDO56TpKzW1OEGTsg2vtoVFvN7WquL3y0CweMKK9U5apc+7TdjejATaj5+GKBJaXXN61KyWNYspU8E+GKmHHdUFSeUiYPTwgkgdzj4RZz6CLjw9yU+8dv8gzElO2bjn5zrSeJUTZjCRQ6Q9zK0xtmIvNpK5bBktyfaLeOtcjHqSMBhyVp7UFBgbJjTZIJYGlncq/dVPcu1bm7Dj2Rwo0JMcknOw/seZU2lUMnejR0bM68huBldNrhS42iHVX5jtVc9Jf0t3C6Hez5iGvjhFvMOhtdhLrBkDwSmdnPr5lnQYcgH6IO9+7xXzyYjSPwSoPV76A3rphomnE4FD2ByvU/JOM2+U/eYA3DjyaI6C1WMgEK0sV+IMD/BWUzO04W80OKLvdPxRt7gGwdqb9mOHIeFRHWSxupC4Alr7RHzQscrVYC93N5TduJbE9x9b6eJzaXgt2IuEN6/lupYIphcTgMKF/g9C9lrpA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTk3eURieFo2eHZRenBlY0JmYkVIRmZKRGYzMlB4ZnlHd003VEtQNDloK3Ex?= =?utf-8?B?a0xHRFRnZ3RHSHBzVWVoQzdXV0YzUFBzazIxTkNtU1ZWUkRxK281d283SkZH?= =?utf-8?B?eWQxSi8zRmxFUW5GZnNONTJtUGNGRGduUlZNQ1BGY1lmTzk5M2k2L2hsZ0Zx?= =?utf-8?B?YWJVVjJPanpNcFEvZ3NpaUZubVQ3SWVJMHJhSjBvMDJpcis1dXNYWEdmZGYv?= =?utf-8?B?VXFKb2o3T3dmelZ6UWxqODM0OVpJZEhyZkRpVXFNdU5EejhJMUt0S0RJSnhl?= =?utf-8?B?ZWFRcTF2Snd3NWxEaXN5cTF3elVLblNVOTdJTUN2K3lTR0JkRnJqbmFzdkp0?= =?utf-8?B?L0tlZ0lab1pBVStFejJnQm5mWXV0bVhlVEdkZkxqdEZUWURycGZESzJlTE41?= =?utf-8?B?NWZsK3pySWxZWndmZktkNGFVYnJpWnVjaEtpbDRhaEFXcDdEQ1BYNkR6WlYy?= =?utf-8?B?SWRhejJoWENZWXM1SG9BaEpRU0l6ckNqMnlPVGVlbTY0U1N2bmJVMzd2dXNp?= =?utf-8?B?bHBnaGsyUjNweE1PY1U0dVZxbU9xYXJlYmdLN1l1Sm9VTXoxc3ZkeE9Ka010?= =?utf-8?B?VWpLL1h6MGN2dUdhWk9GOE53V04zL09sTTh2YW9WRzZVUUNsaFJ4dzJwWUZl?= =?utf-8?B?SnYxUkt1WFlZM2RMeVNjYlNXQTE0WU9WZ3JaRzVxS0dWZE1zSWUrd2tuN1hn?= =?utf-8?B?Nnc2c2lJTHNZSFFYZzJha3V6MG5zUzVFeEZBakg3YVdZWWZJYU44Q05yTWxQ?= =?utf-8?B?RVFFQ1ZzM2dudEpaRDhYTkVlc0NoOGVYSkNlSmpnZWI1bmhkTmhZU00zTnJF?= =?utf-8?B?YitMM1dOVmFISS9GQ08wSmFxR21ZSytUM0psckZOZEcyUHJGa3JpU1JlZCtQ?= =?utf-8?B?c2lraWhrRFBzSlFERWRkNkwzMlU0VXA2OW5oTzdnbkJiZ0JoMmlidVhkUHln?= =?utf-8?B?dGFyeE1nSWI0ZWQ0TXJFeTVMb0tFa0ZrQVRPc3NsbU1JZUVJNFE3Tnl3Q3Fx?= =?utf-8?B?M2h4Tk9IVFZqYkxzczM3bFNock1RSmRMMW95bU1xU01iNU9KbGNTQWNJQ0l6?= =?utf-8?B?MHVyRk03NGxnWnpZTmtjZFBRbVF3NnBTUTFMVnZVWURhSFBDT2JFVGgrRWlh?= =?utf-8?B?d1ZhbVFxUitETHdRclVDemVzSFJTWkxIUWFaRjdLY2tyNFBXZ3RzMWlNMVhM?= =?utf-8?B?OUxmTkVwcDRkN243K3NQSk1YaTBwazNWYjAwT2ZwTnBTMWUrNmdTZnhlZWZY?= =?utf-8?B?WVBwaDVPUS9neUtUc3lJMGpsaGRMU051dURuc0h2bTR2NGdtZnB4OXJOK3Fj?= =?utf-8?B?Z01lM0NmS0RKTVVGMWVkZVJ2QjJ2d0hBMDVvNmxZRG5xeUxqRE4wVUh3VmY5?= =?utf-8?B?ZjJRcHB6OHVLbGMxUDZWODZtNUJGbWNjSkdiTGhYL3F3OVpwYlRwOUhiYUtY?= =?utf-8?B?cXlZSGc1aGZoY2I0MzBNQmZ4ZHczT1lQQXQwWTdURmd0b2hGRG5xRlRQdTkz?= =?utf-8?B?RVRDOHVqc2RmZS80WnNhbVNNZUlSKzBidGFNNFNmdVJ5TVJQQjRPcWZuQnJw?= =?utf-8?Q?nvevniIgblNOOVY6pTVw4hTGI=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c004a90d-dd84-492a-0113-08da0c07cf8d X-MS-Exchange-CrossTenant-AuthSource: AS1PR01MB9564.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2022 13:28:11.5431 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR01MB4941 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/movenc: initialize pts/dts/duration of timecode packet X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: lance.lmwang@gmail.com: > On Fri, Mar 11, 2022 at 05:16:09PM +0100, Andreas Rheinhardt wrote: >> lance.lmwang@gmail.com: >>> On Fri, Mar 11, 2022 at 03:04:32PM +0100, Andreas Rheinhardt wrote: >>>> lance.lmwang@gmail.com: >>>>> On Wed, Mar 02, 2022 at 09:58:31PM +0800, lance.lmwang@gmail.com wrote: >>>>>> From: Limin Wang >>>>>> >>>>>> Fix below error message when timecode packet is written. >>>>>> "Application provided duration: -9223372036854775808 / timestamp: -9223372036854775808 is out of range for mov/mp4 format" >>>>>> >>>>>> try to reproduce by: >>>>>> ffmpeg -y -f lavfi -i color -metadata "timecode=00:00:00:00" -t 1 test.mov >>>>>> >>>>>> Note although error message is printed, the timecode packet will be written anyway. So >>>>>> the patch 2/2 will try to change the log level to warning. >>>>>> >>>>>> The first two test case of fate-lavf-ismv have timecode setting, so the crc of ref data is different. >>>>>> Fixes ticket #9488 >>>>>> >>>>>> Signed-off-by: Limin Wang >>>>>> --- >>>>>> libavformat/movenc.c | 2 ++ >>>>>> tests/ref/lavf/ismv | 4 ++-- >>>>>> 2 files changed, 4 insertions(+), 2 deletions(-) >>>>>> >>>>>> diff --git a/libavformat/movenc.c b/libavformat/movenc.c >>>>>> index 4c86891..74b94cd 100644 >>>>>> --- a/libavformat/movenc.c >>>>>> +++ b/libavformat/movenc.c >>>>>> @@ -6383,6 +6383,8 @@ static int mov_create_timecode_track(AVFormatContext *s, int index, int src_inde >>>>>> pkt->data = data; >>>>>> pkt->stream_index = index; >>>>>> pkt->flags = AV_PKT_FLAG_KEY; >>>>>> + pkt->pts = pkt->dts = av_rescale_q(tc.start, av_inv_q(rate), (AVRational){1,mov->movie_timescale}); >>>>>> + pkt->duration = av_rescale_q(1, av_inv_q(rate), (AVRational){1,mov->movie_timescale}); >>>>>> pkt->size = 4; >>>>>> AV_WB32(pkt->data, tc.start); >>>>>> ret = ff_mov_write_packet(s, pkt); >>>>>> diff --git a/tests/ref/lavf/ismv b/tests/ref/lavf/ismv >>>>>> index ac7f72b..723b432 100644 >>>>>> --- a/tests/ref/lavf/ismv >>>>>> +++ b/tests/ref/lavf/ismv >>>>>> @@ -1,7 +1,7 @@ >>>>>> -48fb8d7a5d19bd60f3a49ccf4b7d6593 *tests/data/lavf/lavf.ismv >>>>>> +7a24b73c096ec0f13f0f7a2d9101c4c1 *tests/data/lavf/lavf.ismv >>>>>> 313169 tests/data/lavf/lavf.ismv >>>>>> tests/data/lavf/lavf.ismv CRC=0x9d9a638a >>>>>> -d19cd8e310a2e94fe0a0d11c5dc29217 *tests/data/lavf/lavf.ismv >>>>>> +79646383fd099d45ad0d0c2791c601dd *tests/data/lavf/lavf.ismv >>>>>> 322075 tests/data/lavf/lavf.ismv >>>>>> tests/data/lavf/lavf.ismv CRC=0xe8130120 >>>>>> 3b6023766845b51b075aed474c00f73c *tests/data/lavf/lavf.ismv >>>>>> -- >>>>>> 1.8.3.1 >>>>>> >>>>> >>>>> will apply the patch set tomorrow unless there are any objections. >>>>> >>>> >>>> You have not really answered whether the current files or the new files >>>> are spec-incompliant; you have just reported that one byte is different. >>> >>> Sorry, I think I have said both current and new file is spec-compliant in the last >>> email. >>> >> >> You stated that you think that both files are valid, but you also said >> that you don't even know what this byte that is different actually means. >> >>> By Quicktime file format specs: >>> Section Timecode Sample Description, all tmcd field isn't used pts/dts. >>> >>> As for where is the different for one byte, it's caused by pkt->duration. The >>> old is 0(uninitialized), after the patch it's 33(1 frame duration). >>> >> >> The text about Timecode Sample Description reads as follows: "Frame >> duration: A 32-bit integer that indicates how long each frame lasts in >> real time." This implies that only one of the two files can be >> spec-compliant. I am not a mov/ISOBMFF expert, but it seems to me that >> the current way of doing things is wrong. But I wonder about whether >> your patch is correct for vfr content. Doesn't the property of being vfr >> need to be reflected in the timecodes somehow (with different durations >> for different packets)? > > Andreas, I have updated the patch and remove the fate difference which is > caused by duration, do you have any other comments for v2 patch? > No. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".