From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 96F9B42583 for ; Fri, 18 Mar 2022 22:41:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7A87868AF91; Sat, 19 Mar 2022 00:41:40 +0200 (EET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-oln040092072022.outbound.protection.outlook.com [40.92.72.22]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C5C8668AE99 for ; Sat, 19 Mar 2022 00:41:34 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lr5IqZQxtIgkmumh3Gdto/6We2+lkdU2zo4Ms3iCnALYGbXEbm2xcWVoqjmJCyljJKH/AfeYxYSNoHiWo6Rz4aPcFTRl1nxopq9C1vkZ8RVsF+6I0fqG7UDtlOeBvgPA//U+78QkgY1Icf5U+NHlwc+hSjFU9M753EAagoYLlexHbFf+g7O1tES/a6Kkby/88uE1ZkwRZ1OMxrBcMbCT7h+78Qg6fgM+IflZ5TVrO2DWFErgDjh3JdiZiVEeJmkQlbkWUp+3CB5PpHV0a2yFKyP06rvm/pYNsXa/MBxFVTzWuAfhEbMvHmWFlpaoViilG0y1VH+Bg68g5siNdZrxhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FUwPNTzMdW+jq4ul533JqDj9DBDHi3Wju0MrUZMsQCA=; b=UDDNJS3x49io8NvG17+Hx0GVG9E7Iqf93xWDABPBxdzhjWHR563n+DxlHbj4MucX2uKTdexwEPtDcliNC8s4RL2x9CE0coCNY9fayL4j46JdSS30kqMg2xeNNF+b1TR/bwVpEVf43zIHUAkPxvTTwzNO3kdwDGsMKH0nSqXDDdewENVHUxRl49k7B632qWY9qnONoVtmDoIWeG+uikFBYjItEcHv43VpX6d+JHNMie/RwR826sgCVYDxr7BkUZcCEz+UuCWyeLvRyYicUZ4zLLbEHmjdtFBN5g00cKigyoKk6+p5DUm/E6pMTLIvEoJu93Sg0saP2aJnwyBrOg/ODg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FUwPNTzMdW+jq4ul533JqDj9DBDHi3Wju0MrUZMsQCA=; b=JnlRyJ+KovGYp0v9VtDpApkg75adjMG5jzqnxb2+vgTE8aCgnNoIQ/Jz8cJcoxH14CyZ++LJuZcmTskQRpvjy+lWAFn43Us1AGcJAV6PwjXgL7V3dSSLJ9pr7xby4ydzK1lwareuPZKSe9kZ7g6QkTNSSHx3FLILoEOqZy17gZZEa3jS7mb8iHxCoR1FEz41nUcFrwYec+7fen2DJF+2tGDpfPZO3jpgHuN71nt5rdbIu1D4GLlutdLi/er5RcKoDnoGiIpWSNkZfhpYEC3V0Unv2z8YzTUAnJKF4RsO6DHh7g025sFqU4wvgTgjikd0GrHY/aPCvUfKwOBS12cxsw== Received: from AS1PR01MB9564.eurprd01.prod.exchangelabs.com (2603:10a6:20b:4d1::16) by PAXPR01MB8487.eurprd01.prod.exchangelabs.com (2603:10a6:102:229::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.17; Fri, 18 Mar 2022 22:41:33 +0000 Received: from AS1PR01MB9564.eurprd01.prod.exchangelabs.com ([fe80::9070:a5fd:e532:bdf8]) by AS1PR01MB9564.eurprd01.prod.exchangelabs.com ([fe80::9070:a5fd:e532:bdf8%3]) with mapi id 15.20.5081.016; Fri, 18 Mar 2022 22:41:33 +0000 Message-ID: Date: Fri, 18 Mar 2022 23:41:31 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220318221907.44594-1-jamrial@gmail.com> From: Andreas Rheinhardt In-Reply-To: <20220318221907.44594-1-jamrial@gmail.com> X-TMN: [t5vxT6jx+A97W1NEVNjUDawWufN4Roel] X-ClientProxiedBy: AM7PR03CA0004.eurprd03.prod.outlook.com (2603:10a6:20b:130::14) To AS1PR01MB9564.eurprd01.prod.exchangelabs.com (2603:10a6:20b:4d1::16) X-Microsoft-Original-Message-ID: <62071fc1-ff60-38fb-c0f8-5d9a3c057c6d@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 47f85c9d-096c-4953-4a3a-08da0930737a X-MS-TrafficTypeDiagnostic: PAXPR01MB8487:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ThQv7r13G3FNuWyfYVu8BXwL4TD4lRs/Dy0A44ERCmHDecawcsohN6lfyp6HIxl3AQzCKeHHfljb4etk6++PjLXpUSPZ/NhdtjJT/+dGeOQBTQScYLhJKlgO7Kz1LVpQCzRaj89NPyu9+AHHXvWv4WyTSFkyJoKgZs+orrraHbSRcRLbEGGtJlSKk0eCkgUUo8Qw8P+LXC3CxTx3ZWao0wgDbaNMfdIogLLtawfId3lR2RFJZ+DX4B7mfe1WpJNHaF5CTK1K5kYbG2abolxww+BT9S510JKAa5zQ9/OCkO5Thc/Z9JaXBAlngmhrE5c8WX7KHo43vKOF6oaDc0LYd8GRuHAoSWlCPuCdqL8pKrpTOrPHqyACmDibIxViu37oDe8/kL81lh62oKYeCPbMwaYWdnZt6FFnx9gdAKGCL1crpJ/w2RrpKmDd4SYoOyeWAS8nSQmxsvp2ZygT5SJahDR+agGuxZsYVRfpTswaafFM25ZNSu3ie86n3r/1dgaa/8T+NsMk6ppNq+ZywhiI8fPKwyHbLDMKeQe3PrDTFZpmv9zxHhQSCsXCUpBlj0FDwI9qGiDp/scnLA4/axSeHQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djhrVXJnb2tLRy8xM0xZY1h6SVFpSk9NUUJYcWIwM1VPVW1IZjlWOXprNkVz?= =?utf-8?B?b1FnaXpxYzZwOStsM25hQUF4bFY2K1d1eDg0TEpyK2ZmOXZJSmF2TlA5TW95?= =?utf-8?B?aEJzNk9NV01FSldqZFNLU2o2QW12YUV6dWF6aVhtMjV0OTc0OXBlTktSWjlR?= =?utf-8?B?S052VGhIUDcvVmFmdUxOUEc3bm5WUnVNSkdtb21rUlo2djdodVdLNVdZSFRG?= =?utf-8?B?cU5aZGxMdE41MHVZQmZjR2YwOWpRd2tyZTduUEJLQTlZTUlINFhzRDN4WTV2?= =?utf-8?B?dkVsMVBjTWNRcE1sU0RLUkdIVy9TNy9GdW5QNWpwclhWM3lCeVRPYnFyejlY?= =?utf-8?B?K0Fvc1FRaTM4Y2NPNEE3MGgreUQrWVFYMUxyYXlOWU1FMVVDdDd4dXJQeXAy?= =?utf-8?B?ZDdXL082Qm9IQnNwcTVtSUdQeldIZUltRFFPVzdrcmdoS3dWaUludjEzS1Uy?= =?utf-8?B?b0kycnF3cHJTQTBHbGJIZUduRzFJRVlubDRyUThqU1IrVXI2OW9hV2ltZEkv?= =?utf-8?B?QnBvbSt6RDdlS3RvYVhQbFFmNXk5cU1hNmxTY3lsR0owZHNadEYyVWYya1d1?= =?utf-8?B?bU1tWmo2cGtsdTMrK2dvV0JOMDRwL2xyRWhvZEFvOVkrOVV1cmhlejZJTHZx?= =?utf-8?B?ckVzK1NLWU1odjJUcmNKdHhpMWVRdU5nam1ZbXVoY0hTYTBlOG1hRUc3ckNs?= =?utf-8?B?bnl4MUxBQnllclFwMUpnYVNQeHBXRHVTYi9WTVFrVm53U1BROXJCb2xxdmdv?= =?utf-8?B?Q0RLZE9VWE5LWSs2UkllV2ZiYWdMN0V4aUZvSGx3QUdGZWxFMHkyclFXUnlw?= =?utf-8?B?KzNLbHRadVFKTzNpL0lrcUFyOUVGak0zUHJ1OGF0Tm5DalllZXpNdUUwbjdo?= =?utf-8?B?MWxmRkR2UG8rNGFNN0lBeDdDZm1qWUFlWUtzZWlzMncvVFNhck1VODdsQ1pR?= =?utf-8?B?a0w5WE5GSmo5cHJnQVFSV0lDUSs2b0M2bGFtRTkvWWUzNnZUYk0rendPWVV3?= =?utf-8?B?cy9BakRCbG1vdGNzZW9qKzdrT2FUS1dCdlpiY0lnVGtzV1psTVAyNG80OUI4?= =?utf-8?B?VkEycjBjeVBuUFJnK3VjcitwYVhaQ2ZpelFGZ21xMmlRbzV1azdVS3QyZnJ6?= =?utf-8?B?eDh2empUZ0xjbnkzVFdPZW5nTU5QT0ZhSnk0SkhUbytQRjEwNnhJZEhWajBI?= =?utf-8?B?UldXbXk0TkVGek9EWkxpOFRuVHFQZ3V6Wis4dTFIbW1wdUVOWVUybjdnUmpv?= =?utf-8?B?SExoMVVSdjZxcytPOG9oR0hOKzlhYk5tZTRPL0VoV0RiVngwc1dlQ3ZZUXlj?= =?utf-8?B?amg0MURqOGFUK1UyOTYvbStYc3lxOFlib1F3NGpodWIzOVNZZUVMclpNWXk4?= =?utf-8?B?Zm1LSWVuaWpNamJyVFhkaEZPbjRZby94RjFneEE1WkZMdlc4RTBtbHE0clRH?= =?utf-8?B?V3ZjTjR2eEFaMDczUEVYbE1rOGxjMy9DSDNrQmsrWXM2TzZvUVlzVG9iMFhF?= =?utf-8?B?Z1FTRTNnaU4zbmZtRnNsTFQvUXhEQTN6TnR5cjk0ZWdpZFU0bmw3MUJYNHha?= =?utf-8?Q?EqFJ8oG1eV025hZfP8wYG9GlA=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47f85c9d-096c-4953-4a3a-08da0930737a X-MS-Exchange-CrossTenant-AuthSource: AS1PR01MB9564.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2022 22:41:32.9945 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR01MB8487 Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/slndec: add support to set channel layout X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer: > Signed-off-by: James Almer > --- > libavformat/pcmdec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/pcmdec.c b/libavformat/pcmdec.c > index dcd13787d5..a2bcfc2814 100644 > --- a/libavformat/pcmdec.c > +++ b/libavformat/pcmdec.c > @@ -170,7 +170,8 @@ PCMDEF(vidc, "PCM Archimedes VIDC", NULL, VIDC) > #if CONFIG_SLN_DEMUXER > static const AVOption sln_options[] = { > { "sample_rate", "", offsetof(PCMAudioDemuxerContext, sample_rate), AV_OPT_TYPE_INT, {.i64 = 8000}, 0, INT_MAX, AV_OPT_FLAG_DECODING_PARAM }, > - { "channels", "", offsetof(PCMAudioDemuxerContext, channels), AV_OPT_TYPE_INT, {.i64 = 1}, 0, INT_MAX, AV_OPT_FLAG_DECODING_PARAM }, > + { "channels", "", offsetof(PCMAudioDemuxerContext, channels), AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, AV_OPT_FLAG_DECODING_PARAM }, > + { "ch_layout", "", offsetof(PCMAudioDemuxerContext, ch_layout), AV_OPT_TYPE_CHLAYOUT, {.str = "mono"}, 0, 0, AV_OPT_FLAG_DECODING_PARAM }, > { NULL }, > }; > There is no avformat/slndec. And I presume it is possible to set an unspecified channel layout via AV_OPT_TYPE_CHLAYOUT, so why don't you deprecate the now redundant channels option? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".