From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E7B7D4AAD0 for ; Tue, 11 Jun 2024 17:19:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 81F1668D89B; Tue, 11 Jun 2024 20:19:20 +0300 (EEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01olkn2104.outbound.protection.outlook.com [40.92.65.104]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 24A8568D432 for ; Tue, 11 Jun 2024 20:19:13 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OwsGv3Ga1e2D8haM9A4MY7gwuZj4H5gtWmQ3nj+nOM778lgHsuoijPydabHuBQcO3eo3Y/8VJVWgrAu4srbyC/JuTGIjywsqvWKxIU0YPRCc3FrCgt9ecIYh0DI8fOv0MvJycqfaaqa7oov5mm+seaXRtUcI+RJt7jnoK0YX+ih5sYN2B/+Ai3ujKtgVm3LStnx/OnC1NaapUr2BmF9xQdpF3pAloouwSGJUaVM7BJmA6tflRFRjV9QjmybU59fMqZNwfRbWlbr68hmb+RWfhCoN/DnaJIj3u9KxfqCS3oitqsio8SA6JWNu1KVlIL/ljaeTmV2G8ZKPiMX18nSljw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UtTSH7+9RZveUhlowhFrM6qH0liGTj7Pom3Jh8Oexc0=; b=hBgTQdaHL++rB0S1OvATwu/Kfy1Q417EKIAUG3J6xCgf9FOkMlUo7V6e7kHynPECfOR1J+wXIu9b+6bLJHxf5xrCEZIghegIP3oJIAx26/03tLxgSjTXL3qc0WVgBF5JcsDH6OkVpc2uzkmVmJaaW/lYDyYofaVmDaGLFewawUzlreH7SsRFL9NIBkYedX4McZfW4EwxIaFEr7/Un0+Q4X64eHun7bysJ15y/rTgCldQ2bexHZDxc4huQwL9+To0Gi9Pl8yYrxhwMa1L0BNlag8KMaIzpx+XR6kLGspl1TOovHx6KmsLNCf1ukO1QtWcpkRH8PaJooapue65O2YVBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UtTSH7+9RZveUhlowhFrM6qH0liGTj7Pom3Jh8Oexc0=; b=GLb3MFws7rGHO8tBmYx6X0veY8ITTYH1V/Qo/rOa9BbRQ0dJ6+DNGwKAsVCs6/3Be/de+IN6fCMsJX6LFQHoWHAmWdNOasIpTTQr2ns/X6GbJnMpx87WExDUdwQlmXqfI+gCkHytKVsZR38wgnuzgizKKxXVQ4JBFfJjQSgzjKhRtvNHjBLS+HgtFUgSukZEZuMCfLcpfsTOAmo1DXzXrRRb0t80AzTha2+50tm+KJanIzSYhMGmU8fxGJAxygQcaf17aC2GsBv0c499FhMEqDqTwOKHTqZYuDbCi3Xzj6BxLAy0zL6DAaktqazWiw/XkT4cLDHztl8oc9vQQFjVqQ== Received: from AM9P193MB1940.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:3b7::8) by PAXP193MB1358.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:137::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.36; Tue, 11 Jun 2024 17:19:11 +0000 Received: from AM9P193MB1940.EURP193.PROD.OUTLOOK.COM ([fe80::203e:7cd6:289f:2ce4]) by AM9P193MB1940.EURP193.PROD.OUTLOOK.COM ([fe80::203e:7cd6:289f:2ce4%4]) with mapi id 15.20.7633.036; Tue, 11 Jun 2024 17:19:06 +0000 From: Mario Hros To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [PATCH] libswscale/x86/yuv2rgb: Add missing EMMS Thread-Index: AQHat2690ck1xfZGaEeBNLynW+o627HCy18s Date: Tue, 11 Jun 2024 17:19:06 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-tmn: [0Iy0+qEyDjtdIvlNSqTOTVMYjCVQiBoZ] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM9P193MB1940:EE_|PAXP193MB1358:EE_ x-ms-office365-filtering-correlation-id: 83a87891-30ce-4b70-c051-08dc8a3a9982 x-microsoft-antispam: BCL:0; ARA:14566002|461199020|440099020|3412199017|102099026|3430499026|3420499026; x-microsoft-antispam-message-info: 3j6SKlDAoTcNBPT8gZpwA7G9GV2qTeKZCOodNzEW/USEChqs4tfi0mxMeXzCgArojfngouLxo+plfuNi59jSvPGsyB2dl0Rkv5wP3BbjzqvlWWqKwgi+ZJubeWRmZbcNOrDOp4tuYU6hwullhwVPeiw9ZGGznMluCy4L2TeHPek3dJcmA0KhwRrFkVg+yaQyjX7BHATsjCTQVrs9cM71cSnn67vaDI21r2jyyneDC33AUYQVVOy2DdikjkcBHHIzJFXMviYxZxi46Rv85P6QiDgnwk/lYrGIfVlEabdpewBZPqGuP+Lf3Q1IzpjpQaq7fyQZ3SS7pFWuSLKV1skrwiLMhLBqqk65kftbiphnJk2G2tqtOgdqiemQeLGszLLsPSX+EC78kBP3lRnrQ+y2tWC0QRSIDVcOJM8eviXL3vqTc9hzxGROT8wzk0SrmNOu2EQ/ZosEvdxfW8yS6pfTNodwIwj5qI3sjXwMZSvb6ZJPfYZI53Wyl/sy11YG1pMb7VCVthRloCVLaYa63TREl/tXhZ6ClksRvqcBTDLw276+9y7MIwl71zANnmETveJm x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IiurIJpiLkPuSs8VmFy/TP7xprP8/1P1WbJNTfd/9XlIO7FB1ZMLLL+0T4gX?= =?us-ascii?Q?MHLKGofVr9bDrxnp37qePx0ePXwYFgTlfqBVKJxQcxVrn4JaorNEfaa5R9pf?= =?us-ascii?Q?lCBtmD7SELUo1OFP/4vgfxvTDMSov0W4zH3188+72T3HxYC0+QRe83MBkvA+?= =?us-ascii?Q?lNnfSVFg0+vSM7catnAPO3eRVhVOLJVG7veBfptkgVEZmhRmxoO4vn8VTmqM?= =?us-ascii?Q?4ukVqCbd3g5AkzJgJW4Z8Rb77wGc4+ey4BiWB54B9+Br9Ga94tHRMILFXCtR?= =?us-ascii?Q?le/7GWRJHcnp+u940aznx5bH/Q6LW6xv5pR9h9EtHOOmR9hA1s1blDAe530R?= =?us-ascii?Q?ijO9lCO2dngKrqL9n4N1qdYflOS4hDNLQLrb2GUycq+3Bpbl5yycm0GMuZ6p?= =?us-ascii?Q?NIFba/tzQaGn6BZ+/eiz24liEP/+nAfOjxZ2qCKNEQDBuXURiLS0VH97+0SS?= =?us-ascii?Q?oBQSbJMqrnqKb3oORjacPahRDtznqwxARbMHwQ1N0w9T+mEIU2E05rNLqSMM?= =?us-ascii?Q?4MNdWrc9qGwNrM/adBJTGHUss2DXbqNfScrKbbNcGTJwvqPcUcMEE3LeNw5Z?= =?us-ascii?Q?8wGNTVfV9naziCjN7QIfWe/YwEqdc+4qDktjDECv8CKRe7GRokBhPJgaC8zi?= =?us-ascii?Q?dPDaRej59IHrWvu9XK7ax2Rs6qKOWhAym7nonXjpaWyOXjM2bFm18KfM7AtZ?= =?us-ascii?Q?7rTNOi82VjxJfVF4vApZkubeab5bM4i1JWbRAB9x1F/SYMn1G/cdA9k7UAuL?= =?us-ascii?Q?QqUqj5JaByEBQv1Iv/6SFQ2Ju2Nv3wT36jp4V5wccc/YH1V2AtFd6IkXwWaU?= =?us-ascii?Q?d2LYfTMYTRdrYOofd4+SX+lET0Qy1ipCyKSrqxt8D5GGiAdOECVXJUKYHUUs?= =?us-ascii?Q?zkIXBHlWWA+dnXvYZSBmzpuonQ+NEncFIAspHD+G9Ef6NfpDFHpmzBjH9KSU?= =?us-ascii?Q?gt/41QiH3P/zY9yGoEEh00GWbwgjtZBgCjDJ+axSEQOBGJfWc0c1wgyMYEIW?= =?us-ascii?Q?/Tco9D3Erj5ChijrVV2h82gt+VzXNhmZrzQTRnHPvEAbZEDpqlpHEZGK2CWQ?= =?us-ascii?Q?Kvo0tdiQFvXIdzSdetrOsFHHUx+/lFxLvHUgZ1wxViUQWP9ww97QrlT7tyr4?= =?us-ascii?Q?byQJ+j9moM3dR0M9HZNi73UNnl9W91Ju8rKRolEerGX90MBiDL2AJKw8OnSS?= =?us-ascii?Q?Lj9gBQEqNLq6nUfYG/1auorMP3Qs2NFZ3hoq5g=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM9P193MB1940.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 83a87891-30ce-4b70-c051-08dc8a3a9982 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2024 17:19:06.7880 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP193MB1358 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] libswscale/x86/yuv2rgb: Add missing EMMS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "ting.fu@intel.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Ping? Not including EMMS causes the FPU to become unusable (as the IE and SF bits are set in the status word). This breaks code which, for instance, calls fmod() and is compiled by GCC with the -O3 flag enabled. In that scenario, GCC implements fmod using the FPREM FPU instruction, but because FPU is in the invalid state at that point, the result is NaN. This must to breaking other code using FPU also. The original code with inline assembly used EMMS at the end. ________________________________ From: Mario Hros Sent: Wednesday, June 5, 2024 7:35 PM To: ffmpeg-devel@ffmpeg.org Cc: Mario Hros Subject: [PATCH] libswscale/x86/yuv2rgb: Add missing EMMS Previous rewrite from inline assembly into nasm (commit e934194) missed the required EMMS instruction to bring the x87 FPU back into usable state. Signed-off-by: Mario Hros --- libswscale/x86/yuv_2_rgb.asm | 1 + 1 file changed, 1 insertion(+) diff --git a/libswscale/x86/yuv_2_rgb.asm b/libswscale/x86/yuv_2_rgb.asm index e3470fd9ad..7a247797e4 100644 --- a/libswscale/x86/yuv_2_rgb.asm +++ b/libswscale/x86/yuv_2_rgb.asm @@ -353,6 +353,7 @@ cglobal %1_420_%2%3, GPR_num, GPR_num, reg_num, parameters add imageq, 8 * depth * time_num add indexq, 4 * time_num js .loop0 +emms RET -- 2.39.3 (Apple Git-146) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".