From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 19/24] ffmpeg: fix initial muxing queue size
Date: Fri, 17 Dec 2021 00:08:34 +0100
Message-ID: <AM7PR03MB6660F8C09B7ED7CFE73B4AB68F779@AM7PR03MB6660.eurprd03.prod.outlook.com> (raw)
In-Reply-To: <20211213152042.5900-19-anton@khirnov.net>
Anton Khirnov:
> It stores pointers to AVPacket, not AVPackets themselves.
> ---
> fftools/ffmpeg_mux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c
> index 5a12a1c899..9281e6c94c 100644
> --- a/fftools/ffmpeg_mux.c
> +++ b/fftools/ffmpeg_mux.c
> @@ -411,7 +411,7 @@ int of_muxer_init(OutputFile *of, uint64_t limit_filesize)
>
> for (int i = 0; i < of->ctx->nb_streams; i++) {
> MuxStream *ms = &mux->streams[i];
> - ms->muxing_queue = av_fifo_alloc(8 * sizeof(AVPacket));
> + ms->muxing_queue = av_fifo_alloc(8 * sizeof(AVPacket*));
> if (!ms->muxing_queue) {
> ret = AVERROR(ENOMEM);
> goto fail;
>
LGTM.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2021-12-16 23:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211213152042.5900-1-anton@khirnov.net>
[not found] ` <20211213152042.5900-23-anton@khirnov.net>
[not found] ` <20211214211343.GP2829255@pb2>
2021-12-15 19:36 ` [FFmpeg-devel] [PATCH 23/24] ffmpeg: simplify the use of OutputStream.frame_number Anton Khirnov
2021-12-16 19:43 ` Michael Niedermayer
[not found] ` <20211213152042.5900-2-anton@khirnov.net>
2021-12-16 11:54 ` [FFmpeg-devel] [PATCH 02/24] ffmpeg: simplify getting output file size Andreas Rheinhardt
[not found] ` <20211213152042.5900-3-anton@khirnov.net>
2021-12-16 12:38 ` [FFmpeg-devel] [PATCH 03/24] ffmpeg: remove a redundant assignment of interrupt_callback Andreas Rheinhardt
[not found] ` <20211213152042.5900-17-anton@khirnov.net>
2021-12-16 19:48 ` [FFmpeg-devel] [PATCH 17/24] ffmpeg: do not log to the muxer context Michael Niedermayer
[not found] ` <20211213152042.5900-6-anton@khirnov.net>
2021-12-16 21:11 ` [FFmpeg-devel] [PATCH 06/24] ffmpeg: move writing the trailer to ffmpeg_mux.c Andreas Rheinhardt
[not found] ` <20211213152042.5900-9-anton@khirnov.net>
2021-12-16 21:24 ` [FFmpeg-devel] [PATCH 09/24] ffmpeg_mux: add private muxer context Andreas Rheinhardt
[not found] ` <20211213152042.5900-16-anton@khirnov.net>
2021-12-16 23:08 ` [FFmpeg-devel] [PATCH 16/24] ffmpeg: access output file chapters through a wrapper Andreas Rheinhardt
2021-12-17 10:29 ` Anton Khirnov
[not found] ` <20211213152042.5900-19-anton@khirnov.net>
2021-12-16 23:08 ` Andreas Rheinhardt [this message]
[not found] ` <20211213152042.5900-21-anton@khirnov.net>
2021-12-16 23:42 ` [FFmpeg-devel] [PATCH 21/24] ffmpeg_mux: split of_write_packet() Andreas Rheinhardt
2021-12-17 10:54 ` Anton Khirnov
2021-12-17 11:50 ` Andreas Rheinhardt
[not found] ` <20211213152042.5900-5-anton@khirnov.net>
2021-12-16 21:20 ` [FFmpeg-devel] [PATCH 05/24] ffmpeg: move some muxing-related code into a separate file Andreas Rheinhardt
2021-12-17 1:55 ` Andreas Rheinhardt
2021-12-17 9:33 ` Anton Khirnov
2021-12-17 11:43 ` Andreas Rheinhardt
[not found] ` <20211213152042.5900-11-anton@khirnov.net>
2021-12-16 21:40 ` [FFmpeg-devel] [PATCH 11/24] ffmpeg: set want_sdp when initializing the muxer Andreas Rheinhardt
2021-12-17 9:44 ` Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM7PR03MB6660F8C09B7ED7CFE73B4AB68F779@AM7PR03MB6660.eurprd03.prod.outlook.com \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git