From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EDB2F41112 for ; Mon, 3 Jan 2022 14:01:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 43D1468B1A5; Mon, 3 Jan 2022 16:01:00 +0200 (EET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2095.outbound.protection.outlook.com [40.92.91.95]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B130E68AEF7 for ; Mon, 3 Jan 2022 16:00:53 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aoxFolScHv/vHNrCfQDqVSZJNzefiyVYBrTTmJKvKvGbZiHY0Awx/OpQASwqtqj80aRAhEESzQrlH1bI1Qm5TNAJ4Nug1kfNcX/Ch//VB+RZNMUkOqir6mvH8P6XYyQRbxMBtz1t65DaLck+lXVjkk5F9h98i5xHP63Jkn8y0GZefMfyveWlcoTwU31olI+GvShekqNPvKLtLWrLxJ5ITfAyYayOr8E8X5gNgxMw1amYnm+MhRIN0oG+WX4kKDbg6nR3tObVE/MsTnX2J44uJRL4f/pUzM6J4bQdj3lGXeJDLOKr7O7pYAKmwubOYHcp0F93O1tUidBC93ogmAzHxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8dEs/h5N/Ltu1mPXSDChSwxG3d/P5mO6aB8+DuODNB4=; b=htINWFfwx9MnP3UeeXB6exLKs1CVxzBHFLZ2dVj7COs2gHdFIqlfXpJIvvRrNonerTl4VIxaxVH70qWJZo3F1r1/yd3YLj6O9Ns0w2En7USvwZJy5qRWWFi0uXQkaT+U2nuzshiqbcZtezXILC39gLpddG03LbBpBGAKUv45atDDrf8P8BidSB3hFy/7sy6YzsJi3QkOtuIYkPZT3rB1HEdzn7QWMGRjk9rqKzx/TiV96bsLQp28ixB7js10aIyzEz05tjvNd8qS2ThRyE2Kzp4T/F2HgLSLuVP0mBw0ExpMqNlO3cz7iA6NtoxarxiuDR80BP8tsH1fQp1a5utgmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8dEs/h5N/Ltu1mPXSDChSwxG3d/P5mO6aB8+DuODNB4=; b=WVuLtGTPx56JT0hcVPb6mBXZZ01ux9MsDuWWzA3YqtzSEgoyV83L3GKZGxX8vIx7HGSWjaEOD12UuugO7EEn+yArQ9G4fmTVzFyHwE2KAqfU4k2+HebUwf/jUEIzUjClAerRiDnc7e8AVbTxF37pP1AF/HentKPDRr7oZP/l+S1FZ5s15Tm02OvcZNfkm+1wKOdYGyzEAZjUXTw0tclxQNhbS9GvbQO7p1iJx3zqFR6tf9Za+4QwLqSRxpLS89XBRtT6FKwCc+wGMLkdgc4dJa87hRZBrXJrXTpg6vgAs7DRya/IOmdSa/9NyY56uaGzpbqE97ogbnaNUKadP04vAQ== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM6PR03MB3607.eurprd03.prod.outlook.com (2603:10a6:209:34::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.15; Mon, 3 Jan 2022 14:00:52 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5%6]) with mapi id 15.20.4844.016; Mon, 3 Jan 2022 14:00:52 +0000 Message-ID: Date: Mon, 3 Jan 2022 15:00:46 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220103123719.1166-1-jamrial@gmail.com> From: Andreas Rheinhardt In-Reply-To: <20220103123719.1166-1-jamrial@gmail.com> X-TMN: [sC2h/t645jPU6ParDjpHzU0Ij8euSdf9] X-ClientProxiedBy: AS9PR06CA0326.eurprd06.prod.outlook.com (2603:10a6:20b:45b::34) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 26796b7c-1813-4a12-1cc3-08d9cec1740e X-MS-TrafficTypeDiagnostic: AM6PR03MB3607:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZvD+h93mG1IhGhv90UB5jZ1PIQRhqp21RE5gHnGSNLkz4xqF44itlbVXeu3VFrqlHbBTEv3NJ9B2rTfK+tR989XKUqZa/1Cwf6JA1E+E9CWzx4uEqhQok48hBoGVJwKqOylbCPZvMYw8HSc78+en5FMdNdSvWZSEqtvsUWJRbSrtPVvrj/zSV6cmzTmMqv2Ef/CWs4iEZw3b1g4lK27A3ay5vVhYXebTJNWr6rCjYucN9kJYJXHQ2D3vfnGe7SyRfoMEdPqucvwfUyqrGeOa5QV8zhxhSwgOWvvGmKM/9zHQ8QHa/vIhQlx7tj+fGKGLC5d2uEvKSaJRCqJZ+3jFcG4v7gI4+t52spjob0F8rL4vg6XzdgtA8o0KDHFKka2zCvu/fydAc8UTT4SscnTK3NUln07O023TEiJnGN4GT2MK7IWFEZAODX6AP9/nF6dpeAAzrE+BtSCONjEP0lSG/ykwcPoxq0Qf0Emm5mDcDmhZcCM4w25sywQzpOzJG+Uz7ZiJtsOI791C5w9KSMepxIn2A4fG7vGCEZOgMM1vJ2ptp8gPO0lvsDsmxL69BRwvBJGGI8eQYF+fgilEVousgQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzNZZUVQMWRkNjV4djh0UHQ3d2NzZTZmRkhaM0FKK2tPWENnWkU5YVQ5MEQz?= =?utf-8?B?ZUd1M3NHbWdmMDB1bjBrL2VhRGFmSXFyZlFRUS9TaTNnVi8zYmdVcEtxR2Z0?= =?utf-8?B?aGN0SFJ2UTl4SmhvcGpFZ3hhZ2ltM05zYWNUZGRDeEJOSklZNVRNRUo2Z0dB?= =?utf-8?B?YlJrbjF3azVGL0lMdnJFdVZkT2l2T0JsYlZ2K3c1YUo5ZHIzY3N2c0djUHgw?= =?utf-8?B?SkJiTjhlME5OQ1BiQ2w3MlpNd3pLZ3ZlN2s1QlgrU0ZrQVlRRXVBUkQ0YmU0?= =?utf-8?B?ZTltTjQxNWdjdzdHRmE2SWlJaVNhbDA1K3ZYRnRsTFFvQjJDd2xLT0NIWFM2?= =?utf-8?B?dmhaTzRiZVJtaXVpQjlETFVlWE9ERFVFMk9HTHlrY2VQdWFRSlFuRnMzeVM1?= =?utf-8?B?VFVjMGo4US9CSWU3eVoyeGpyTXpOOWdyRWNaQVpRWHNWL3ZnRzR5MGtVaWFl?= =?utf-8?B?S09tWjkvTDlvYno4MmJMbDZRZGRHSDIyWXJnT3VQdVkydVNxK2RoWkpFU3NR?= =?utf-8?B?RVJTL3o5dmRIZlpVK1dvY1NFUGxML3NzaEJEMWFtTHBJcDFKbENGNE9KRWo2?= =?utf-8?B?QU1OMXlxeTVDKzBZSFdRL0pyRlI0TFBoVkpVWjZrTnp4NlV6bm5TcUhjTzN2?= =?utf-8?B?ZFFHSi9BY2s5cUtXcWNTOHhIYXB2TDlGYXVGcDJyUmh4TlF3UjdzZ1p6b1Ju?= =?utf-8?B?ODZieDJOenlYK3VaVXBJdFF1UGxqZXVuTmdhbFJxSTBLRUJKWHZydEZXekdW?= =?utf-8?B?SGhnTjhJWG12QjlubEo4ZHNvYXNkOEJsSjhVV0o4RGIvczRxR0xoYVdBWkt4?= =?utf-8?B?MnNnRHovSVcrSVQzWXMzcWsrU3Nydm1jZytXdnZ5OFphbTNlY29obW9HeFlW?= =?utf-8?B?RXh2b25IYUQ5VkNPWUM4R1JJS1RCNXVDSzdvaGdNZ0hldU9md0ZHZTdnREtu?= =?utf-8?B?Wi81YTVRY0wrbHdkVmxXanpHVnZ4TUkvTkFLaEVIUUhSMmpZbHRQUUlOSE1i?= =?utf-8?B?OWRQdk1OMWFnMm9BQ3kvVkhBNlY2Q05ld2FEU0xabW52ZFZwZTk0MU9OaC9j?= =?utf-8?B?WWV4OUIzWXhPbjlOOVZaRVhLd2Y5bVV6NXpaMTlNSTlHR05uczRSMzNzOFlu?= =?utf-8?B?QlFKeFpwaEI2aFA5Nzg5TVBDTS9nL3l3ancvK1NuandsS2kxR0pKS3hkdEIr?= =?utf-8?B?Q0J6Q3pyWERTNVN6cXJrcGo0ZmxUM1IxR2Q0NjJEeVJVOVdQY21vUjVkZ2JQ?= =?utf-8?B?cjc5VVhEY3oycHBaQXhvSjMxVEI4bTl5dHRRYVBNS0RtejhCdz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26796b7c-1813-4a12-1cc3-08d9cec1740e X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2022 14:00:52.2602 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB3607 Subject: Re: [FFmpeg-devel] [PATCH] avdevice/alldevices: constify some function parameters X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer: > Signed-off-by: James Almer > --- > libavdevice/alldevices.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavdevice/alldevices.c b/libavdevice/alldevices.c > index fbbe187a51..3db489b83c 100644 > --- a/libavdevice/alldevices.c > +++ b/libavdevice/alldevices.c > @@ -68,7 +68,7 @@ void avdevice_register_all(void) > avpriv_register_devices(outdev_list, indev_list); > } > > -static const void *next_input(const AVInputFormat *prev, AVClassCategory c2) > +static const void *next_input(const AVInputFormat *prev, const AVClassCategory c2) > { > const AVClass *pc; > const AVClassCategory c1 = AV_CLASS_CATEGORY_DEVICE_INPUT; > @@ -94,7 +94,7 @@ static const void *next_input(const AVInputFormat *prev, AVClassCategory c2) > return fmt; > } > > -static const void *next_output(const AVOutputFormat *prev, AVClassCategory c2) > +static const void *next_output(const AVOutputFormat *prev, const AVClassCategory c2) > { > const AVClass *pc; > const AVClassCategory c1 = AV_CLASS_CATEGORY_DEVICE_OUTPUT; > AVClassCategory is an ordinary arithmetic type, not a pointer type; due to call-by-value you can't change the caller's value at all. We typically don't constify such parameters and doing so is highly unusual. That being said, I am not against changing this policy. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".