From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2D486425AB for ; Wed, 5 Jan 2022 06:46:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4721B68A6D6; Wed, 5 Jan 2022 08:46:32 +0200 (EET) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-oln040092068102.outbound.protection.outlook.com [40.92.68.102]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A232E680529 for ; Wed, 5 Jan 2022 08:46:26 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f9CFrTEw2GWYg3oKcZ3FPSbzbIDs5pz0bCdkQJ+1q77UDqQWzKoWN5ltRWKDWHwkOh5DDRQ265veuy/VYSAr/K7bEKwn4L0paDM3Yk61ufARkS/0vkq9v4avQYJRjvF/B+wx+PW3io+5KwQtyvC+TlZWkeHVb33P4oUR8Or1gWCvSZNzd0cp/LCXj1fsNzvV7HnFBpfKsaRw5TFK1qHBlnjyLrk54Y/eBdZ0blCftZfLkFYFJb+WKdwwm8gq0efZQ5b5z6fbH0LUfDHIF9ggSGCftXdCJ2WAj79+R8BrH1r9M81Y/bkGy6Sq0Zq9dTvMh/c3MUyU44o3n/VcGgtbDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DCN0VuRDYVeM0es5Fok6UVEOUq5fLZuaPKorHmtLC80=; b=nIpFcs5UQlUjCtwEZI02cJbYhzhvapKe087UHSw3PJbYqPgEQloFlP5v5Q87SpMWLD/MZ9IoPJ6ff80isBreEty7s9zLpx0aHHkaXIEb046zRxAelxNjDSr5yIzlbQ5Oh7ON/qn1q0au08ilM7nAyWk5M0G93nqLJXcIiurx5SZl5BfwDH62lOheBEYiVvP55fCuY0dUjdcRYIko3olXRA08ojfPdCSfA5N+urgHDDN897T5vL5+DJADQSExV2cqzrT7DV8Qb0agf6BgSHS1nH58DDNhlneSN3M94tqH4S+muE9Ju9z21gcdch80Ty/L0DT3VwLVgrr+j7XyUvswZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DCN0VuRDYVeM0es5Fok6UVEOUq5fLZuaPKorHmtLC80=; b=R7yPyQXKrEhusmKS+z/gLs4RIPlqf3hbdrJKHDOCnid65WZUaDFShuLGt4g9GImZsqff4ONuzBgh0ClCIhsgtbJKV+FslZlaP8oDMSAKK7YO14934jb8rUKTvAmqKThl+K71P64TVpTkT/zcXb5LSK4tpolNenpjRD8mg6TGRkzNr5vsBkt2QdqtVRaaRqe2/ceygudXSmmwzwQxPpmNgTlvz7PvHYV5JON3jF9pt1vMfOmfTn80yUCn7YHhXPf2PjJ5vZVvaaACp24qEyFSl8qELjusOzS8imtty1oqiBOxNiT+bC6yjeiZq5aChnjdIpxNah7OMdYm+yvs115/UA== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM7PR03MB6166.eurprd03.prod.outlook.com (2603:10a6:20b:142::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.7; Wed, 5 Jan 2022 06:46:24 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5%9]) with mapi id 15.20.4867.009; Wed, 5 Jan 2022 06:46:24 +0000 Message-ID: Date: Wed, 5 Jan 2022 07:46:23 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220104052018.9541-1-jdek@itanimul.li> From: Andreas Rheinhardt In-Reply-To: <20220104052018.9541-1-jdek@itanimul.li> X-TMN: [6Uv3PrcwHwiP9Pmjff6KNcjsvNnKC7Qq] X-ClientProxiedBy: AM8P191CA0014.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21a::19) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 46294336-07ac-4004-23d7-08d9d0171748 X-MS-TrafficTypeDiagnostic: AM7PR03MB6166:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tNIAqXorwildKv6TEUolRP0Wg95ya4t+EgZ/vTx3qnRxcD1UCotl7NZmM7EcYgx2LHSIscKrUZIkopQ9dghj0FhfwPBtxxZrgPT1Xc1Y2nYWH6IXMXObd0+SsXZMec4IQaQaQ5LhxhG408wVNU1UXc5thanxcMeav+7ftI4H/BwxGL430mIlqyfqjkHQ95pdYYbM+DVZT99Qs0FKDwU550ijVv2VvjSnUcgZCaVBNrG5aX2R2HwBTzLldAfmWF+bNwvvr/F4ohAAwTzqsXNYhrz8CoX2/I2NKvUpe6rTJ4B7OdQR8dKsomkDIVdXRxLwFhZnj2iWM14BKJOFg4Qy55rN/V98LttsQfUJNNO1Zf1EXoTz7o5ReDtAQ1jl9eni+wDEgjc33LCZp4XvR29id7z0XtIrbZ/BYgQWXg/Qo4QHAikD97glNY+2JubSDETUd+34NtsaL1h5f96H04/OTQGRKyVinbtWwLaiqXNDzGbr9nKL4fG5x3H8zqcaaCENRN0MzM/AbemG37k8ZwTHmB3JBHjCaEl9PP8SPGR387i98R1Wyb27tbvM0lUpMzkwY7Cjf7jDlEWV7NHeL9jlFA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ym5kcjlYU2RiSUdMaFQ4Q2N2QnRQNk02TkhrQkpQZGUxSXBOUFQyZFVOOEhF?= =?utf-8?B?ZVB4cUgwZ05janVHdTNzdCt4Uk5HQ1R2am1vNVNyUWhlTWJ0NWhEY0VjVHBr?= =?utf-8?B?ZTYraHV5K0NLM3RFSzR0NGxXc0xyRTExZDNTTGlURTdWTGk0YmMyNUNYOWtv?= =?utf-8?B?ZXFybDhROWJDZDZjalR0Y2J2TWQ5Nk00ekVWeWpLMUFGWHBUeUhMYWJDL1pH?= =?utf-8?B?VVRYTndFaUlWZm1ad2ova2l3aTFmYUpXdjdQd2IxM0FYL00rOUF0WmtZZ2Uv?= =?utf-8?B?cGs0dVJLMmx4c1h0dDBaTUdGQ3ZaWXVkWHQzMlgzekNEdkcva0UyWkxNKzhx?= =?utf-8?B?NkFJZ2I3ZUdCU2pjQXVNZ2VSUjNRU0ZVenhzaTl4YkJ1NDBEL3RBUms3VzIw?= =?utf-8?B?MTZwT29kZGxiMGJ3L1ZWK0ZUbHlxUVJoWmVDVnBQZ09pTHRiSllVTGdzaVRx?= =?utf-8?B?UXdlK0djbTFpZHZrQktPSEVVMVZoL0NERjU3VFhlQzBjelVtcWNNazNCcFpm?= =?utf-8?B?cFd2QzdUOFA3UitxTm5xWlRvSUFDNHVNdHJYMDErRUZTTThGa1hVa29VZjRi?= =?utf-8?B?TmNPQkc1Wk9mcmJyR2dUM21vVTlVVjErOTQvem9Fc2dmWTNuR3JMa3VNdnFK?= =?utf-8?B?Yi9jcDl0M3lsZ2l4TjFMUEQyd01aS3JtMXVoK2lobytucER4THFYUkFxODYv?= =?utf-8?B?MFExM1dBaVFsRjByOHZGc2V6TVBBNS9tL3J0T3VnZkZOdlBPZ1IvZGgvYUhU?= =?utf-8?B?cE1NWHNhcyt3RkRTaE8rUVNPOFNZYVhycWZxVFd2TFViWFJsaEpZYTRlckZ4?= =?utf-8?B?Y292SVpaRXBiYkRRRnpzME00ZWtUUmxyU2VhOVVuakZvWHBURkJXU244Y2Yr?= =?utf-8?B?MnYyZityUHcrSElOdGZSSjFoQkdTaUhsbU5uMjFHV1VNUXNpNWpNUVkwRk9I?= =?utf-8?B?WUdKaXVIVGdINGV1MWVCcTJiNnJaanB6MXhBS3g2QVJ2OGIxTmVPcVVvMVlK?= =?utf-8?B?ZENiZ3BYTzJwTXdSTHVwcVJpMDNOcTZJVVRoWWNoK1F2SFgzU0p0L0FPV2Uv?= =?utf-8?B?ckhDcjlTa2x3WSsyRk92VlIzQVk1cVI4SElMdHhWZkVuUlJuVnRXUDU0MEZT?= =?utf-8?B?VWNCKzdUand0eDdBaDZJbzhkTkZYQjh1OXQ1N2hlak9jUjdNN2loMWdaVHoy?= =?utf-8?B?cjJDbFZJc1hhK3FXbFQwS3ROWllVRnhFSnRQNklVRUx4WWd0aWNQK2JjYm5i?= =?utf-8?B?RzdLYWs3OUxNMDRsakFyTlhZdENEVktXWkNybWd4YmhLV1Q4dz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46294336-07ac-4004-23d7-08d9d0171748 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2022 06:46:24.5720 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6166 Subject: Re: [FFmpeg-devel] [PATCH v3 1/6] lavc/arm: dont assign hevc_qpel functions for non-multiple of 8 widths X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: J. Dekker: > The assembly is written assuming that the width is a multiple of 8. > > However the real issue is the functions were errorneously assigned to > the 2, 4, 6 & 12 widths. This behaviour never broke the decoder as > samples which trigger the functions for these widths have not been found > in the wild. This relies on the mappings in ff_hevc_pel_weight[]. > > Signed-off-by: J. Dekker > --- > libavcodec/arm/hevcdsp_init_neon.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > This set has already been reviewed by Martin, sending to list for > transparency. > > diff --git a/libavcodec/arm/hevcdsp_init_neon.c b/libavcodec/arm/hevcdsp_init_neon.c > index 201a088dac..112edb5edd 100644 > --- a/libavcodec/arm/hevcdsp_init_neon.c > +++ b/libavcodec/arm/hevcdsp_init_neon.c > @@ -270,7 +270,8 @@ av_cold void ff_hevc_dsp_init_neon(HEVCDSPContext *c, const int bit_depth) > put_hevc_qpel_uw_neon[3][1] = ff_hevc_put_qpel_uw_h1v3_neon_8; > put_hevc_qpel_uw_neon[3][2] = ff_hevc_put_qpel_uw_h2v3_neon_8; > put_hevc_qpel_uw_neon[3][3] = ff_hevc_put_qpel_uw_h3v3_neon_8; > - for (x = 0; x < 10; x++) { > + for (x = 3; x < 10; x++) { > + if (x == 4) continue; > c->put_hevc_qpel[x][1][0] = ff_hevc_put_qpel_neon_wrapper; > c->put_hevc_qpel[x][0][1] = ff_hevc_put_qpel_neon_wrapper; > c->put_hevc_qpel[x][1][1] = ff_hevc_put_qpel_neon_wrapper; > This patchset led to regressions; see e.g. http://fate.ffmpeg.org/report.cgi?time=20220104162724&slot=aarch64-linux-qemu-ubuntu-gcc-4.8 - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".