From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7A3ED40895 for ; Fri, 24 Dec 2021 02:20:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9DE9268B1E2; Fri, 24 Dec 2021 04:20:36 +0200 (EET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2024.outbound.protection.outlook.com [40.92.89.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3EE2568B1D6 for ; Fri, 24 Dec 2021 04:20:30 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LFivUpaS3kDNsguLVPmLBUHHJa3lzdQi3LiN4lBHb7muId+/IMyinMYxTFSECnIIwcqHnvrNYurdLvHdojnfVu8eX3wxBSAHbns9v0TYjzRdtrjC1dT6ZTcvKUZt41nsIU+BoSbMsaVMQB4OQmwsFqpyT3jAVhJJpYvepZuvluTwNMKdyDvXL9zG008e8+99YwnjeEBnHqyGkhzWdaDqlfew6O5d5lxGEm33cz2IWWPHgjpEQvU9bk0KpFn0le2HeMgUQ37MfD9Ve+pfwj2mIT7WCCpHGr61dfSsfp4cdsnCZGjIW5Mh6/pZ/p4rfE4kr5139QJpqZ16xBQDIqVD0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V5OMP8kOvs5N08rMERXVCUJHrUVFXpLFJWHHS99dMeU=; b=MkGzA3hf6mcP8VQ8XNiH4jP1QuX4TnlTcUIeWLSpncwrPQKB63FyeQTPXwkR1sWVut0FNzMlKgJjBiT6BZB54/DEmjzxChovorGz0Mz/OlzYreG5rEgCkTk3Qmxlo/JibA9RhHibYQ5g58KpgOIn+eBJwEUwlYWLYJoBj/UMBpgpQHQ49Opo3PTNlCVQ59cBA5lGactrUXE7behXuhm+YHbibHbg2nON7pjZlkU1KmlgzWnWhUTUI64cxZv8Zn8/qJrRffqNieIhK5ieGlBPeSBIh7vb5YsjERtjRWUyfjMuhgCVJwlOTkoMIr10Mwq7hqIXBTlFlN8vYDDKDCRIYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V5OMP8kOvs5N08rMERXVCUJHrUVFXpLFJWHHS99dMeU=; b=iLRleL96CstlRqIUipMrzJDxbxoKY2cFLWkJPJc3DJaA2Olf/LL09BL2lfubQ8t/QX9JQLjo/jQP+xGteVZdN42xr18DtnK8M6RQG8xMnahJnN5hpsYD2FsL75MI1zsX7f+tYTN9w7tIsQgKQpCtKYQjDX7Uyjgg2kJL9R7vKPnKm14riR4cwWAYKEQm8/ffrKtLIaqzgzm8OQhrLyqWgXnm9INIP6RfdvaLn00cqYfqWQD71oX8QOnVfFQsJKh0Uj7MoO9xeCRkqAydlqe5/5nSf+KofdmhOzADwAYMwlR4U7xIWqs/IOn/HNmGaCUIT8moYulWTkNYZwszewH71Q== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM7PR03MB6545.eurprd03.prod.outlook.com (2603:10a6:20b:1bd::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.18; Fri, 24 Dec 2021 02:20:28 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::f0dc:92f5:6bc2:45ca]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::f0dc:92f5:6bc2:45ca%5]) with mapi id 15.20.4823.019; Fri, 24 Dec 2021 02:20:28 +0000 Message-ID: Date: Fri, 24 Dec 2021 03:20:26 +0100 Content-Language: en-US To: "Xiang, Haihao" , "ffmpeg-devel@ffmpeg.org" References: <420d12e0288d42515f1f8dae75c2a70e561084da.camel@intel.com> From: Andreas Rheinhardt In-Reply-To: <420d12e0288d42515f1f8dae75c2a70e561084da.camel@intel.com> X-TMN: [8vpdhfM3q94AiJLGjmxdELLHXCBtUeT8] X-ClientProxiedBy: FR3P281CA0024.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::15) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <3d47d74e-d8d5-ccd9-634e-8cade8b95030@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7dd7feb4-1e61-45e8-cbbf-08d9c683f3d9 X-MS-TrafficTypeDiagnostic: AM7PR03MB6545:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bJIGIoJiYnipDaG2+nfBFWlAyIsUgxnkSl8Zb4BVWYnVNeecze32Oxa2zXfjQvsfIX3xMNRbFD4OP7BHreR9an7xORm9WYnKAbIVmbsy/JfAcnEmFHTFPCc8hgrKO9CZXXefuE+sX4DFtDRDdpGWVFPkSen9sYE1f30DZrMlkFHSd7RYEUH8b0Q2kMRqfkWH4ShgmyNw5tyE9+Tu8xyGLCMUCq3YXvgrSM+Kzs9OZtsMXLI83VJui5KfapeF4tprTSTUFNQAbBX6+d2ibehTarlcOSLAr8x98CGyrh8ijPTR+eWlWpud1LEJfKD1KYQI9qtjRbPhmB/KBkuyiiifNmkUBbPsuMJv0nSYckssunCxWPwZe/J2BgQUyga38TAyMA4ZdH7Hr98lzWbJLOl3QTGVyxXzerdOJDpbFLdhcY0oAFovN8ZXmpPaD2PVdUac6VqZypVoq2811XR9JyG7kR9j0CFO9wf9/90uR9Dix8FZ0flrAodtVIY+HYg51N06SDlmOO5mhcIvkHdGRoBnhzIQhmceRb/wG/1wOe8KYergBdDvL/qtoRM9Cd4jJz3V5csyHTTXhwi+pnBPfXjKAw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVVKZUxyM2dSOWhqalhJRHFENVYrcUdZdUpleEJYMkFuVkxNQTV2eGNaSUkw?= =?utf-8?B?SzZWWUZNd1V0NU9iMzA2Wm5sU3JQb2o4M3hSQlVMUWNLTFplM1Fmc3ZRcW0x?= =?utf-8?B?bHJ3cmxCTXZ6TEhyK01mSnBQQkRsMVhKd1JKMCs3YS9oR1krYXV6NTZGV2R6?= =?utf-8?B?Smlia1NrYzBSL0ZiUmFFby90NkV5WTFFZkpIRFlNS3c2OVF5dzIrSkkreGU2?= =?utf-8?B?ZlFBcFJIUTlFaHFrbGdsMUhIb2h0dmthVnRjMEU0aHE1U1Z6WGpodktwSGh2?= =?utf-8?B?ZVppZHMvK3RETEg5bWpyRWFJZmk1NXpFUGx1KzdVT2c3VU9VdFF2UVk2Y2Mx?= =?utf-8?B?VVRuMjB0U3hjRlREdzBnakVWOUxXeDdRNStmczVUZXA0SWpqYTBkYTh2b0lj?= =?utf-8?B?QkZxYXFBSDdsa0xMaU9wWVJWdTYxSk5kclZPZzJ0MHB1WnFIbnZlUkU0dUQ5?= =?utf-8?B?QlRyK1dnOGtKcWZEcXBTQWN4VEx1SXhXRllrTVc0SkFIUzlSQjlGaDBQeVRZ?= =?utf-8?B?NzNYYjdhMG8vL3dQZ3gxVHdhZHBxN1htUHdUeGF2dVlJNCtySHJ2RmI1bFJG?= =?utf-8?B?cEV6V3B0MXcrU21KRmJOUHpQM2hRV2hQcUt5elJMU21RNFhOWkRkMENHakhP?= =?utf-8?B?dDNzUjE0V0s2bHpaVlZXaGhHNTh0M1JacmErb0ZRZDNBTW9rL1N4ci9FRGZt?= =?utf-8?B?RWVZNVpCS2twNmYwQ2dEWktpSkt0SjRsdU5JMU9lZVk2TEwwMUsrbkpLcUlG?= =?utf-8?B?azgxbnFMU1IzYzVTT3dlNkxVcFlqcWFiT3RRMC9iTHNrTmF4SFRVeGt0Ti9h?= =?utf-8?B?cnA2VkE3cGxRT2xET0tqOVdpQUE3U1I0b0VGajVlRUJwVThMeWNzMzd3MDU4?= =?utf-8?B?UHpMdTFrTjZibDVVemdGUno4cTd2KytFZEtoYWNvNkxHaWVVU1dEUGhnMjFK?= =?utf-8?B?Zm9sdEpCcEhKTTZIeUllRllsSTRjcVY2WWlzdUx1V2QvTFVuemZ0WlkyTnBu?= =?utf-8?B?U3pBNkpiUkFobzVwQ0RmTVJiTUhndjRpQTFPcmdyVnhUMGxRbXZPVHNqblk3?= =?utf-8?B?TlpnQ3F6NzZSS0xoWnBvblVYSHdFOCtqUW1JaXlSRUZFcnc1Z1IrSjh4Njly?= =?utf-8?B?aEdzK2k5cVJJU2RoU0xpVXlwdk14d3JyNGE2QTQ0ZzRKOVl3SzhOYmhVdE9w?= =?utf-8?B?Z3VMN1pPQ3JYV2g4VVl3blhRK0FITkN6R1UzSmNvY2V5NlZtMHUybW00TFBW?= =?utf-8?B?LyttWEpZQVZRTWxGa0tHY0Zpa3RaWlAzdnhuSzFQbktVNzRodz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7dd7feb4-1e61-45e8-cbbf-08d9c683f3d9 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Dec 2021 02:20:28.7068 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6545 Subject: Re: [FFmpeg-devel] [PATCH 08/11] avcodec/tests/avcodec: Check codec caps for consistency X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Xiang, Haihao: > On Fri, 2021-09-24 at 18:37 +0200, Andreas Rheinhardt wrote: >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/tests/avcodec.c | 38 ++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 38 insertions(+) >> >> diff --git a/libavcodec/tests/avcodec.c b/libavcodec/tests/avcodec.c >> index 5512ae99f7..e26315c368 100644 >> --- a/libavcodec/tests/avcodec.c >> +++ b/libavcodec/tests/avcodec.c >> @@ -19,6 +19,7 @@ >> #include "libavutil/opt.h" >> #include "libavcodec/codec.h" >> #include "libavcodec/codec_desc.h" >> +#include "libavcodec/internal.h" >> >> static const char *get_type_string(enum AVMediaType type) >> { >> @@ -78,11 +79,26 @@ int main(void){ >> if (codec->channel_layouts || codec->sample_fmts || >> codec->supported_samplerates) >> ERR("Non-audio codec %s has audio-only fields set\n"); >> + if (codec->capabilities & (AV_CODEC_CAP_SMALL_LAST_FRAME | >> + AV_CODEC_CAP_CHANNEL_CONF | >> + AV_CODEC_CAP_VARIABLE_FRAME_SIZE)) >> + ERR("Non-audio codec %s has audio-only capabilities set\n"); >> } >> if (codec->type != AVMEDIA_TYPE_VIDEO) { >> if (codec->pix_fmts || codec->supported_framerates) >> ERR("Non-video codec %s has audio-only fields set\n"); >> + if (codec->caps_internal & FF_CODEC_CAP_EXPORTS_CROPPING) >> + ERR("Non-video codec %s exports cropping\n"); >> } >> + if (codec->caps_internal & FF_CODEC_CAP_SLICE_THREAD_HAS_MF && >> + !(codec->capabilities & AV_CODEC_CAP_SLICE_THREADS)) >> + ERR("Codec %s wants mainfunction despite not being " >> + "slice-threading capable"); >> + if (codec->caps_internal & FF_CODEC_CAP_AUTO_THREADS && >> + !(codec->capabilities & (AV_CODEC_CAP_FRAME_THREADS | >> + AV_CODEC_CAP_SLICE_THREADS | >> + AV_CODEC_CAP_OTHER_THREADS))) >> + ERR("Codec %s has private-only threading support\n"); >> >> is_decoder = av_codec_is_decoder(codec); >> is_encoder = av_codec_is_encoder(codec); >> @@ -103,6 +119,19 @@ int main(void){ >> ret = 1; >> } >> } >> + if (codec->caps_internal & (FF_CODEC_CAP_ALLOCATE_PROGRESS | >> + FF_CODEC_CAP_SETS_PKT_DTS | >> + FF_CODEC_CAP_SKIP_FRAME_FILL_PARAM | >> + FF_CODEC_CAP_EXPORTS_CROPPING | >> + FF_CODEC_CAP_SETS_FRAME_PROPS) || >> + codec->capabilities & (AV_CODEC_CAP_AVOID_PROBING | >> + AV_CODEC_CAP_CHANNEL_CONF | >> + AV_CODEC_CAP_DRAW_HORIZ_BAND | >> + AV_CODEC_CAP_SUBFRAMES)) >> + ERR("Encoder %s has decoder-only capabilities set\n"); >> + if (codec->capabilities & AV_CODEC_CAP_FRAME_THREADS && >> + codec->capabilities & AV_CODEC_CAP_ENCODER_FLUSH) >> + ERR("Frame-threaded encoder %s claims to support >> flushing\n"); > > I didn't see such requirement in codec.h and wonder why the two flags can't > coexist, could you please provide a little more explanation ? > The only reason for this is that it is not implemented to flush an encoder that uses frame threads. (Do you have any specific encoder in mind?) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".