From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0D1FB40BF1 for ; Sat, 5 Feb 2022 06:26:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 632B768B34B; Sat, 5 Feb 2022 08:26:27 +0200 (EET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2084.outbound.protection.outlook.com [40.92.91.84]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4CB8268B1F4 for ; Sat, 5 Feb 2022 08:26:21 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cW9w2+f6cXXjz5bfjWqbkLjqE0gb9nBpyh2Wj34JyacqP04doBjTGop7UHRR9U5m8g4IvvFT1QZX3QiBgdsBhtAF+hxJFDIe8YEkH+3Ypv1fYqOdkX2QpB+kwnaazwEwnArFnjxpCntpIi+1SgGLQTMQRF7hjbOadzLE/AelKY1OmrOzIAmk3wqzyzZ6uTMRNxL41+YBgxy6peb5N3WVuDjK0FtDPCE2MDiHHVH1ywzggM46qK0jjLkTX3TJGzNJd0MByhqvILov5zZETdh6b4fDI7mQM8OZkEMSQ/hCs2+ZSNxQ9rt0JLkxpU40bEgHdlBcH2EhY7i1ioct4c42Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JroWun+pYFpu4a4W8tOwG/IAdmgjCj1gtQDDYZ7/E8w=; b=PuedccHbfYSARh5XlrD0JCDBzyQB+/XL9Ty54/SlTPgJPcEXIBCLp2qTUy/bIu+0FzH0iLzdQpjwSbEemZt8H1rBfZm9jiBM5sub9J39eGHcv6lqz6yz4u7JsZHueSmym88M8I+9S7YM36lqV89mcGv1Hg+zBvClbPiVC/QhGHaXvSTYj7cQTd1T+sG4sHxFyj6Xoob8CUcv8Ffe7pACeHhXEJHf66HNKAhx2GApFQFlXGoJx2sSOgWDVt1OeYHGgjmlSMtFp6uCs7TbQv2RDiYnALAv1hDYXuV4Y/gpcSsyu7YldtV9TaU4DYRMj2pd8tbGvdZlbkNx0iePNiwEEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JroWun+pYFpu4a4W8tOwG/IAdmgjCj1gtQDDYZ7/E8w=; b=OfMfFwtA0/Ppgk82acSS7Sn6HoXDsvxiDJl6tc7XVsOyoOaosTMxMOVu8gk92H+6o7b1KSMNFM7MJHK75DVyByPt3ekI4JyR0HDczBpmsmsd8KrtrOLJoFal57gsjMduujZ9Prjley1m4JLfUF7Kl4KRV/griofRmaQxmwIIHVfYpcObW4EqkIcIxn3ICXeNS0byDwgFcTyw74IYnwda/yq17Nks15LwwgM9tMOvRURJfG9v5tJIdWwAbEPW0AsjP1VPtomOkVJ7EPKOIZGZ3nrHj7C15oBqva9Y2EYK7KOsGsuFiAae6f0E3aBpLugRIBVoGTknMsdKFybEyPQd+w== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by VI1PR03MB4031.eurprd03.prod.outlook.com (2603:10a6:803:73::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Sat, 5 Feb 2022 06:26:19 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22%5]) with mapi id 15.20.4951.014; Sat, 5 Feb 2022 06:26:19 +0000 Message-ID: Date: Sat, 5 Feb 2022 07:26:18 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220201212056.29712-1-scott.the.elm@gmail.com> <20220203184450.5491-1-scott.the.elm@gmail.com> <20220203184450.5491-3-scott.the.elm@gmail.com> From: Andreas Rheinhardt In-Reply-To: <20220203184450.5491-3-scott.the.elm@gmail.com> X-TMN: [HVA10+03qtwc8t3m8NdKQvEuwySHNBja] X-ClientProxiedBy: AM6P195CA0090.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::31) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <1f48b52c-bb93-d777-747a-508bab9d9ddd@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f1d7ed51-6fd2-4239-2d59-08d9e8706bf6 X-MS-TrafficTypeDiagnostic: VI1PR03MB4031:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F54u401ar/djXwvdX9ifDTqJ3w0mCcnIdSTYQ5eZGuY5pnxFIwfxQ1WPUU/HXqOJQ0PVfkXRo9rh7zh0u1iD5QTPXTfLHKer+R5uyElgrPpxpsqNvkTSnrS3FcmhHhhqTlsTAa7GiVCYjma04fkY6nwq1ZtltXYMTUbUlnCH0UBGy2gX+OJ8I54615HYNRCru6J/nFW3eCLNtEW6/WxZ39G9eEXq7xQqMbXoT0u5l9EawSCleUlwHICL3Od0wOjfziad6emrf0LCWosPQAXQ+5Tojlh+JPE4jZEfGSkuVBT1Vk3NCVbl4x5PGtVyAdsnUux2IIIdL3qXF5/Fe8VRwQYMm047+/S/wH3SG9eFZuaP57QBzpXkkDX13yzcw0ie2TgFPKtS2fJDP4J6YQkmnK0oWr2+RFAleU754askqMNn50olUL0nIFD84sjOo7zyyZhfAiUf6SxNG5tGro6XIgF1oAUGzVWoRvybWobj5mt9vu58IiaUyKQV4X2a7A8USQigIeffVutzQfQdeGPy5bzelug2zEjj713x/Ypb5KKtmzPlC4H1oZw5A1Mvp5uff9WJptSJ6lUx6Ya9OOwXdw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDZCaDdNRGwxNTJ5YThDNTkzQnFTRUNGd0NZSys2cldQQmRybThMK1hFRmlZ?= =?utf-8?B?MkRrdFlEZWx5UGJDZUkzQkYxVE5nckpSZDdzeVJZdUdSVmMvZnRpRjQ5SmJ3?= =?utf-8?B?cGgvaldPUG9XZG04SGFUTDNWZWVlTldDc0VXckhoNUVGc2xIc2RRU0VvOHEv?= =?utf-8?B?SERXK09aWHF4d1VJV3FWeUtKbWM0U2VOU3NHY1pvOFA1OGwxTHd1SDRkdmNH?= =?utf-8?B?UjNBMitkOVJaTzVmTDEyYWM2TVRhSEJ4N1NGTXl2dmFYaTVlY3lrZk1TUHZU?= =?utf-8?B?Ty90OTQvQTgvR0pBQ0RmbUw2MENXajNFRFhaTmNYaExoKythZzlTVVY1cUp1?= =?utf-8?B?SnZMRTdSdjRvRFk3WVo3SWZwa3NCd00yTytFWTBrWFJTc2NRR2xyOHNZbjAz?= =?utf-8?B?U1RjYlBONmM0QXBSNHIzNzU2bFlaZGpLa1VoSnhFZ3lFcXQvSGZBdjJiODY5?= =?utf-8?B?dWMrWThDVnNwNzNvYWRNMGxEWnpGUCttd1R1b2NpV3R2Z3Q5eW1ZejYxd1BS?= =?utf-8?B?V1Y5d1ZyWWVlb1dNNnRkQk02SGFpQ1d0UjhBWUFQUW83bnI2cDg3MHczc3U3?= =?utf-8?B?aXdPaDRHMDN3SysyUkdYREpGdGFHcWQ1TEVNd3lrYVNVa1NRQSsrbGU4bm5L?= =?utf-8?B?ZnpObE1sTkxtdnBLK1RTZk1DeStRTmZnS2FwalB0d2hLTEhOdkg0dndQWDJn?= =?utf-8?B?NEQ3WlZ2QTUyanc5QVBuVFpPVUFyWFdQSFNsUG81N3RMU3hKcWxPeklJdkg2?= =?utf-8?B?R1NDdmZ2V1IvbVJFQTYzajN2bEhWK1N5UlpVYkllWHd1dGFpMmoyRDI5OHBm?= =?utf-8?B?TzNGZE9xYkNiSGp3dHpBSDhtUXdUTXduUXM0MWkyT0poVGIxS0Vtb20vblJK?= =?utf-8?B?MHcrK2Z1MUZwdXNDb0RnbEpXdHdBWCtKR0x5RGIzWXowTGxJODNaYlZScm1h?= =?utf-8?B?b1RjYXpjTWtTWDIvVlJqVjh1aHNBQVFnb3N2YjJudGh3NW1idkFHa3VDZUxU?= =?utf-8?B?bjFnWFRNYVRBdVM3Z0IxKzRkUmFCVk5kazI5S3dQbGdvOHN2YjZjcmUvaTNV?= =?utf-8?B?Qm16T3M4cXdwRzNYSVp6eDVpT2FKQ1MzMVpWU3BqZmlyYmUwcXBGdTV5ZzVa?= =?utf-8?B?ekxhcCtOV2M1OW5GUVRCdEp4aWNGcWNhWUUvdVhEbk1pZGJsRG5PaTk4YWI1?= =?utf-8?B?VzFLMVRqQndITExTc3dWNStBTzVpWE9LOGtJNEhUREtmamZrYWg1dmtpWFRL?= =?utf-8?B?REJscjNzajFLQ3EwdldmRitqajVFazg4eFJuRHJXenFaTm45Zz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1d7ed51-6fd2-4239-2d59-08d9e8706bf6 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2022 06:26:19.6319 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB4031 Subject: Re: [FFmpeg-devel] [PATCH v2 02/13] avpriv_find_start_code(): readability enhancement part 1 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Scott Theisen: > No functional change. > --- > libavcodec/utils.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index b19befef21..cb4437edc2 100644 > --- a/libavcodec/utils.c > +++ b/libavcodec/utils.c > @@ -967,10 +967,14 @@ const uint8_t *avpriv_find_start_code(const uint8_t *av_restrict p, > } > } > > - p = FFMIN(p, end) - 4; > - *state = AV_RB32(p); > + if (p > end) > + p = end; > + // this will cause the last 4 bytes before end to be read, > + // i.e. no out of bounds memory access occurs > > - return p + 4; > + *state = AV_RB32(p - 4); // read the previous 4 bytes > + > + return p; > } > > AVCPBProperties *av_cpb_properties_alloc(size_t *size) Where exactly is the readability enhancement supposed to be? I only see the opposite: The earlier code spoke for itself; not this simplicity is obscured by lots of comments. Having to parse lots of comments makes the code harder to read. This is also my impression with your other clarification patches. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".