Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH] swscale/x86/swscale: Remove superfluous and invalid '; '
Date: Fri, 21 Jan 2022 22:26:43 +0100
Message-ID: <AM7PR03MB6660E890433B59C9BA66131C8F5B9@AM7PR03MB6660.eurprd03.prod.outlook.com> (raw)

Inside a function an unnecessary ';' is just a null statement;
yet outside of it it is actually illegal (but compilers happen
to accept it without warning except when using -pedantic).
So modify the macros to always expect the user to add a ';'.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libswscale/x86/swscale.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c
index 3cf0c419fd..73869355b8 100644
--- a/libswscale/x86/swscale.c
+++ b/libswscale/x86/swscale.c
@@ -384,7 +384,7 @@ YUV2GBRP_FN_DECL(gbrp14be,   opt); \
 YUV2GBRP_FN_DECL(gbrp16be,   opt); \
 YUV2GBRP_FN_DECL(gbrap16be,  opt); \
 YUV2GBRP_FN_DECL(gbrpf32be,  opt); \
-YUV2GBRP_FN_DECL(gbrapf32be, opt);
+YUV2GBRP_FN_DECL(gbrapf32be, opt)
 
 YUV2GBRP_DECL(sse2);
 YUV2GBRP_DECL(sse4);
@@ -405,35 +405,35 @@ void ff_planar_##fmt##_to_a_##opt(uint8_t *dst,                            \
 
 #define INPUT_PLANAR_RGBXX_A_DECL(fmt, opt) \
 INPUT_PLANAR_RGB_A_FN_DECL(fmt##le,  opt);  \
-INPUT_PLANAR_RGB_A_FN_DECL(fmt##be,  opt);
+INPUT_PLANAR_RGB_A_FN_DECL(fmt##be,  opt)
 
 #define INPUT_PLANAR_RGBXX_Y_DECL(fmt, opt) \
 INPUT_PLANAR_RGB_Y_FN_DECL(fmt##le,  opt);  \
-INPUT_PLANAR_RGB_Y_FN_DECL(fmt##be,  opt);
+INPUT_PLANAR_RGB_Y_FN_DECL(fmt##be,  opt)
 
 #define INPUT_PLANAR_RGBXX_UV_DECL(fmt, opt) \
 INPUT_PLANAR_RGB_UV_FN_DECL(fmt##le,  opt);  \
-INPUT_PLANAR_RGB_UV_FN_DECL(fmt##be,  opt);
+INPUT_PLANAR_RGB_UV_FN_DECL(fmt##be,  opt)
 
 #define INPUT_PLANAR_RGBXX_YUVA_DECL(fmt, opt) \
 INPUT_PLANAR_RGBXX_Y_DECL(fmt,  opt);          \
 INPUT_PLANAR_RGBXX_UV_DECL(fmt, opt);          \
-INPUT_PLANAR_RGBXX_A_DECL(fmt,  opt);
+INPUT_PLANAR_RGBXX_A_DECL(fmt,  opt)
 
 #define INPUT_PLANAR_RGBXX_YUV_DECL(fmt, opt) \
 INPUT_PLANAR_RGBXX_Y_DECL(fmt,  opt);         \
-INPUT_PLANAR_RGBXX_UV_DECL(fmt, opt);
+INPUT_PLANAR_RGBXX_UV_DECL(fmt, opt)
 
 #define INPUT_PLANAR_RGBXX_UVA_DECL(fmt, opt) \
 INPUT_PLANAR_RGBXX_UV_DECL(fmt, opt);         \
-INPUT_PLANAR_RGBXX_A_DECL(fmt,  opt);
+INPUT_PLANAR_RGBXX_A_DECL(fmt,  opt)
 
 #define INPUT_PLANAR_RGB_A_ALL_DECL(opt) \
 INPUT_PLANAR_RGB_A_FN_DECL(rgb,   opt);  \
 INPUT_PLANAR_RGBXX_A_DECL(rgb10,  opt);  \
 INPUT_PLANAR_RGBXX_A_DECL(rgb12,  opt);  \
 INPUT_PLANAR_RGBXX_A_DECL(rgb16,  opt);  \
-INPUT_PLANAR_RGBXX_A_DECL(rgbf32, opt);
+INPUT_PLANAR_RGBXX_A_DECL(rgbf32, opt)
 
 #define INPUT_PLANAR_RGB_Y_ALL_DECL(opt) \
 INPUT_PLANAR_RGB_Y_FN_DECL(rgb,   opt);  \
@@ -442,7 +442,7 @@ INPUT_PLANAR_RGBXX_Y_DECL(rgb10,  opt);  \
 INPUT_PLANAR_RGBXX_Y_DECL(rgb12,  opt);  \
 INPUT_PLANAR_RGBXX_Y_DECL(rgb14,  opt);  \
 INPUT_PLANAR_RGBXX_Y_DECL(rgb16,  opt);  \
-INPUT_PLANAR_RGBXX_Y_DECL(rgbf32, opt);
+INPUT_PLANAR_RGBXX_Y_DECL(rgbf32, opt)
 
 #define INPUT_PLANAR_RGB_UV_ALL_DECL(opt) \
 INPUT_PLANAR_RGB_UV_FN_DECL(rgb,    opt); \
@@ -451,7 +451,7 @@ INPUT_PLANAR_RGBXX_UV_DECL(rgb10,  opt);  \
 INPUT_PLANAR_RGBXX_UV_DECL(rgb12,  opt);  \
 INPUT_PLANAR_RGBXX_UV_DECL(rgb14,  opt);  \
 INPUT_PLANAR_RGBXX_UV_DECL(rgb16,  opt);  \
-INPUT_PLANAR_RGBXX_UV_DECL(rgbf32, opt);
+INPUT_PLANAR_RGBXX_UV_DECL(rgbf32, opt)
 
 INPUT_PLANAR_RGBXX_Y_DECL(rgbf32, sse2);
 INPUT_PLANAR_RGB_UV_ALL_DECL(sse2);
-- 
2.32.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

                 reply	other threads:[~2022-01-21 21:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM7PR03MB6660E890433B59C9BA66131C8F5B9@AM7PR03MB6660.eurprd03.prod.outlook.com \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git