From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 96B1D42107 for ; Tue, 22 Feb 2022 22:49:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8026D68B151; Wed, 23 Feb 2022 00:49:40 +0200 (EET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073071.outbound.protection.outlook.com [40.92.73.71]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D5B8468B095 for ; Wed, 23 Feb 2022 00:49:33 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZGIli/bQz+RmqKO93vQmRKztTkAMPzv5Y9JzhhSx4E49aLEJkVZ70apWF0Uomw94wuDhVXHIroFX0X8BM/rTe3nWjY3uuw9HjR8Nr12lm1dOYjszl80nO5agAgHJzRdzmUWr3zc0BKYRCcBXdR4oHbHc0slBdR6ntiqFDayRYweed3a8j0RR4WfPGKg2JREqClyFCZj6q8PK4mVWQzX9wFneMDFuVPAv/1iJC/CBajUsERmERHXBPg85jYqc/YH5mIS8Ie7EGAZ1CF/8tGgI4dTZgegLd+Du768rU/MjR3Zw0uqWR7T+N0wnbvYclT35jBqGXApij3wtZJR7jxFJbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4sxlYt0G/kK35YL4Ro3LB2zkyphEYNMZsGO4uh2yrig=; b=OnHQe6CAyohEZHYEFj58IuCilnccEZYwRhq6Ta2GlEIVpbWqTYpZWMbwUZs/TBhNuIgfgmN5a55aUn8KYUmzhqUqsY4aWj7ejTJtWQ69+RgZeVXK5SyUEX+aP3PGdVySVXipj8J35dcFbopIqAfvOQ3fJAOZkXXq/qOClky7TcUAL4Az2hpqfAsxU+KRbLhKQhklXOPPsdN4UJG6X0PQjm7J94oliPIG0B2QYl/3G7xETAODMVctPPn8177ufKQoxaENHpdEq615lN6Diu2qiU9/ZnwBnDXyai/50vdUUqDGuHwNgX+T4UOdsA78OPb/Utzg8/VB18332rvwh4O1Xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4sxlYt0G/kK35YL4Ro3LB2zkyphEYNMZsGO4uh2yrig=; b=CtuqSTI9ixQMiIn1Q69Ywr4aE8786qbxtL/atN1GoYK1+eBiSoc/QDwo5THlQoacYGRiTUqo+kTs2gB4ZqrKzur7FPAZTD/KEXZSUF4CUK+yRJhRCjBDf6FGgUkWH+gO/Ffrjm4r4nFvhRPKDhh55XVPU9/vJVWmA89Q0+5WgS/ArcEAYNXvflYyzmG8iNLCllbV8X9N5wAytDCz/7THRMwjC1ZK7LhgIcFWXy1h6e93nrt+UPAd66BqufMTJo15lOzo/6pm/khST/4KMDz5r4eejRFuz3GCddb5FaFuwAVORbj44WVUIEv5QCserEhq+/rdGZKJ4Tk9fs9T1Ku4Xg== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by DBBPR03MB5398.eurprd03.prod.outlook.com (2603:10a6:10:d7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.27; Tue, 22 Feb 2022 22:49:32 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::b8d3:effd:9a3c:4090]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::b8d3:effd:9a3c:4090%6]) with mapi id 15.20.5017.022; Tue, 22 Feb 2022 22:49:32 +0000 Message-ID: Date: Tue, 22 Feb 2022 23:49:31 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [LxYqZgAXkdXUZOm4nPxHj+rxlndo7Inm] X-ClientProxiedBy: AS9PR0301CA0049.eurprd03.prod.outlook.com (2603:10a6:20b:469::24) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <002ae18b-a143-2ada-43e8-7a07d391a0b0@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e957a53d-e9cc-498c-e705-08d9f655973a X-MS-TrafficTypeDiagnostic: DBBPR03MB5398:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U0u8+V2pj66Ak5L46pdsMZseAjUoF2cIIHbT7MoBjT6ma31sII4AN+X/uKfq/ZQO69wanw6mMMEx1L9jBlBFT+lfn/6NQPWX+iz8g+D9Cew4qsmzd94XQ7d7ji9D9nme3WxB8q3I3liQAkH78tWSjzH2ecN6A11YxT1nrnjMT3KUHudFBvJl953D53spR1j+GyE7FBMjaSfNDzOfMPxahC7j3UJjnMFPtprNX9bHlVsImDqDFUpVyEcGqhYrJom8VN/6umvEN8gqOWtL15pxzjnVTw+XHbxxdXPaRk368Gxz0WC+cnoaRzVkyrSMGigbvGXrpsd0HNEJdMMnzoRtBNCHmcce9+6OpTQxtnLnloRvOo8TikE1+xRKY5pIjTiQUnv3wNXeC/u1hmlw+FECw4BaraqL4vF/yY1+WyVUOD+4d3/wueOtJmd+XOoR0z1d/vQN9oRMKPQkv2aAjqMslkYipyhveoWylqOn05o3A7Yla8nFDeoRSF5P+HAVH9UjyGYATDvqyklt5vQQoHK+FgU7zReZuHw1hqtgG+VLhX52sZoVpejelk80kydyjQVeKUhUc9rteHVbijZvThdc/g== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rm1uckpvVjVZVUp6SGJyWkF0Y2xZbVN4SmtXTThYL0wxM1V1SzR5Nm9qNEVk?= =?utf-8?B?MGNLamNTaUhHeUFPQ3ZLV21MbDdrN2tXNHlYYUNtd3dEM1g1eG1SZkZHWXRo?= =?utf-8?B?eTVFQzAvKzJtQVhSSnEwUkxPUnVCdGJ6c21rU3JXZFBxUytycTAvOVV1RkpX?= =?utf-8?B?YTlmYzd2eXo0VVRoenNCL3MyL2FVM2JKOGxDbjI4OHRwNWZra1hqTFpnTVBC?= =?utf-8?B?eHlBREJaTlVxeHhDRGxxSERaS1Zqcm5jcWhQYVZXdDkydnZESnRiQUVzZTFO?= =?utf-8?B?azkzeVZiT09kR3hPYkZ0NCtnMWg5SHh2TkIzU3duUTZpUXV5eWNLdHI0SGl5?= =?utf-8?B?ajk1eHNLQ0o3Qjk3UFQvKzNuVjVDVklGUkI2WUc0VlBaTzJ3bjliaXRUcHNU?= =?utf-8?B?VExxZFVVbldFYVg2MGdac3NBVUJHUldMTjVWT29Vd00zUDRKY0Q0MkNoM29R?= =?utf-8?B?UzVqenRjOWJ1Y050aTc2UzZENGx1aFNYQTBhbnR3dTJiSDdwOXkrMkI1Zmlq?= =?utf-8?B?bGdYb1Q0ZHBjSkdkOUVUZzFhTTdxbzdvYTU1Mms0bUFYNm5SN3cxNEltQ3VP?= =?utf-8?B?cS9XamVxRlg3OWZCNS9PaXJrd0RnOWM2Uld4ZVBwNzhvTGh6QWNicHdPR1J0?= =?utf-8?B?QmlPNXE2WGxMK0R3blVYdGVSTXc4L0JoSFR3NHdDWXBIeGRXSnBwdHZYR0c4?= =?utf-8?B?emsyZUJDeTlqcTVIb2swTUIzMFIwcmNWSFF0cWx1Yy9Zb1VkN1picFlhM1ZI?= =?utf-8?B?dVNPYVR4dkVSZlJmWk9xdFllMXQ2cWVwd3lNZm1BUkJMNnZ2TVRSaDV3YnVO?= =?utf-8?B?Zm82SU1DMHYyZ0tnVXFSNHllaXdDKzFGRDA5a2pkU0tIVDNFMDhWaU54L0dJ?= =?utf-8?B?UXkrVU1kTEtyNnFkVkVEMUpBSEk3K2RhdkZGbUJQYmlCTWFYZWJPbkp6bDRC?= =?utf-8?B?NGNJQWh3bVBTUUNPMTZzM1pDNTd6bDFyU0Fmb2xwQnpZcDZybmV0b0x1V1lU?= =?utf-8?B?a3BPbkpPRFJCNThvRUFaaDRFVUtmSkRzcEMyNVdSMElraTExSUxPLzQ1a0Y4?= =?utf-8?B?MmNSMm9YZUxOM1RLWml3cFdXdTBzd3g0VHB1a0h1ZitjdTZIQjhMeXFrSzl0?= =?utf-8?B?U3VKWWY2M05aMkFEMFJTdDd1NkdHNVBUcXc4T2ErUitiR21YOHRzQWozUGpv?= =?utf-8?B?c0djVU4xQXhwWXlLZ2FwZzgyMTZrN25CV29ZdzhGOHBkOHRsVlVYZE5Xc3hE?= =?utf-8?B?YXhmSmxXQjl6KzkzSHN6a21vMmFqVW9IY3Ftb2lteFVra1FiQT09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e957a53d-e9cc-498c-e705-08d9f655973a X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 22:49:32.2438 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB5398 Subject: Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffprobe: Flush decoder after draining X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > This is a prerequisite to continue using the decoder at all > to decode the next interval (if any). > This fixes a regression introduced in commit > 2a88ebd096f3c748a2d99ed1b60b22879b3c567c and reported in ticket #8657. > > Signed-off-by: Andreas Rheinhardt > --- > I wonder whether it would not be simpler to let users reuse a decoder > after draining simply by sending new packets (without flushing). > > fftools/ffprobe.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c > index 8a8e3de540..4205ddedda 100644 > --- a/fftools/ffprobe.c > +++ b/fftools/ffprobe.c > @@ -2730,8 +2730,11 @@ static int read_interval_packets(WriterContext *w, InputFile *ifile, > //Flush remaining frames that are cached in the decoder > for (i = 0; i < fmt_ctx->nb_streams; i++) { > pkt->stream_index = i; > - if (do_read_frames) > + if (do_read_frames) { > while (process_frame(w, ifile, frame, pkt, &(int){1}) > 0); > + if (ifile->streams[i].dec_ctx) > + avcodec_flush_buffers(ifile->streams[i].dec_ctx); > + } > } > > end: Will apply tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".