From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BDED240E19 for ; Fri, 11 Mar 2022 11:05:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A2E5668B0D3; Fri, 11 Mar 2022 13:05:22 +0200 (EET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-oln040092074079.outbound.protection.outlook.com [40.92.74.79]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AEA7968AD75 for ; Fri, 11 Mar 2022 13:05:16 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OMeJUqRUPG5WFkvdiISkdVs5vN53mHtREodEo12zTUEhvq/EHYTdi3zDgquE/yM63GK79PNa28SKarwky6SqZf3l7GyaYQq+a6+zbZHhtsrD8H3bXv1G76bG1RjB5KJR/+gdt2qFbbeanOcdTpfa2E+bnJS/BxFnz87wQeaH86OhggeuuTL/7x4u9ycNsZjCipW8D9smJb2+lrNn4aUrcgv4Iqc8MwYR0+rWm6Szn8i3PZj+aAOm8XE7hBBdjceQNxaD0Ywr+dI19E683JN3wHAy83JTDJT5I0oZH3q50ZBrJu3rLBkJoKwvSuSJ0u+3kyZ2tVv8EjBydTK7VJijTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=plCQq1MBCwphFRoEQfLe2o3kJEn2q4KB6enUzQXnF2M=; b=ApIhObSkdmJZ3RJFUkcy91fZlRxRLDzv89OFEarriVmRjLQTU4ueenIbCkHs8gqeCfAEjncVW160ulGVEkV4JGJjcVuJYrFTaAxvLPOxs3wghRLVU6oRUEjlK7g7ILNjMsGYjSJ1A1zf/Vuk8cx3kTNfS+479Lz+WhS+q2thvJ7iV6IQDcSD+EGHRgJdKTL7k/YmnnStxVM9cQDL+Am8sRoWHRowcI8okL4tmG0DfMEWJjNttGSDbGLywCjDaEU6hU/ybkTd0uQJGGrLOg6obniMzc/OpGXXvyZRMYwKU3uwq3kfgOQNuuGYbRL80arz0T/7ps9A9B5KRfRsKESAow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=plCQq1MBCwphFRoEQfLe2o3kJEn2q4KB6enUzQXnF2M=; b=A3ozvP+rcwOsYKbDBTiOKTTRaWDwYK3WQZ5nnc856KItU5kxZaSnMd4CJhgCr4sRCuWzcOdUKnQo6QQcJLm+GPBluhKZObmOgexunVbnVKuTs7vesjaFLwA4sENEbdtJG9ZY/7SzmnLlXG2+C1uo6vqc/bIG43BdQTHU7sH1W254mFAEYyqRGtYHPsX4eHN9KpOZYz0Udu/S9HnBq2E4dwYdfVH3+EfeH4G++cohpkwb2ZNMwy7o2YXOVGAoy4iY7sHUo0244qKHm8xI1E5ENvlX3QXWJe80XD0noRPJ3gBbPXbK6aaVguGECph0EYdDKvpOCjMiMkvyPxMWxOweGQ== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM9PR03MB7664.eurprd03.prod.outlook.com (2603:10a6:20b:419::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22; Fri, 11 Mar 2022 11:05:15 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::bc6c:af66:7adb:7a3d]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::bc6c:af66:7adb:7a3d%7]) with mapi id 15.20.5061.022; Fri, 11 Mar 2022 11:05:15 +0000 Message-ID: Date: Fri, 11 Mar 2022 12:05:13 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220311101413.92878-1-ffmpeg@haasn.xyz> <20220311101741.104545-1-ffmpeg@haasn.xyz> <20220311112137.GB109703@haasn.xyz> From: Andreas Rheinhardt In-Reply-To: <20220311112137.GB109703@haasn.xyz> X-TMN: [8JqiAWr29UO7jaJx3y2KVoTJRkpBQmou] X-ClientProxiedBy: AM6P194CA0080.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::21) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 218428eb-e70c-47ce-190d-08da034f04c2 X-MS-TrafficTypeDiagnostic: AM9PR03MB7664:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vdAHl/EzFWv3FXWtQ2adFV3IK2h1aTzG2++QyJPaNSbNtvPADjXJhd/a/W97ESvsoRWlcH0deXHElCEQnh98q/WYFPqMfiJ4pZnGL4SlKxNnDSz0MiOun58M/GrxPNSax9XDpItdk2IaQ5d9WnzNOD1gWKQdD3QJQuVkENqxnbMLBQGiymDxTiEKIUSyO30Tsx45rYAE/0tJ5Bk1zeBhv655yiSTCzMyXo97F7TBv+VZUUJYoQxSvtKez6Ge3aaqBZfVBKxHL1Q+nhAFVdWp6KapoJ9s0sMxY9+jlkNpx6olifSrBJlB/AdnpPV7mRYdZFXXodn0QJ/KyS6Jj8jSEUPnJU3Q4ZeAksM9PX821uZ2wAdiBn4H1+RWBDboG4cNPIN6heYdRzd+stqEo90+bhEJD/qCYLH/2zfuXgz8Omrt4tlImpDL12A7IaFIBiGOQz5yGTWDA74aehcwnD668VOYC0SaI/4Pp3Iyug5jv70D2d0cUZRiQ4aOJKLm2nFqrGe77PZYbcrwWnbafdkF95+8B+tSNLyZyDOO/RyYdWRQrYRT/X79BvMslRzjLKF+R5mHXbGvOUmNYqrasClqBw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WnFBSDd0R0lDMTI1d0lTcFJGSzE5Y1JwQ01aemowSzlJSGc0RWxWbUhBNUQr?= =?utf-8?B?N2podklmd1UyL1dmeVhXejJHVU5teWs2R2lNbzVjY2hYeElhazNRbTFvajgz?= =?utf-8?B?QWc0NEQ4V2NPRk0rVnZKUlZQUXQwS0I5eCt5NWZHQWlnd1lsOU94Q203Qm1X?= =?utf-8?B?Rm9lRm13SE5hK3lRZ2NTSmZNdU1qZlMzWnhISGNDTFhJdHBSc2RVNmtPWHp1?= =?utf-8?B?cC9wRTVGQk9HRitZdXQveVpnWXNna3hCc2VsOWpDeWJiSklDcWN3T1kxdXZn?= =?utf-8?B?MzdMQWEwSU5aaHRHNk8veDc2RkVIbXo4UGVyMjgrV1Z2UnVQV2FEWUV3eCsx?= =?utf-8?B?bEZqNDFiVU5XNTJWU1RYSVh4dnY0ejdUSDFwR1llZFN1b24rQ2Qva0srQ3ly?= =?utf-8?B?YXhLMDlsczFYcHRFTDB4WHFIS3M3cEROTmtUWm12WnpTNzZObHZ6d3p4NlpL?= =?utf-8?B?SGROTHVKK0pwT01jdGdGWDgydmEyZm1DMk1OcHNsejRkbGtNSUZvRElqNGM5?= =?utf-8?B?djN0bi93QTA2MDdoZllXckRpQjZyVEZKNVhmek1KUm4zVUpSRWIxc0pDNW1V?= =?utf-8?B?RWJYb2xJMER0TVVrTjFPSTNDYndtdWFYU3YzdVYrQjRBTFVpcDJ4a1pMVVVP?= =?utf-8?B?SERDdDR4U282ampPMDc5cjRsQ2RrYmZ3MEpLRHZSempHU0Z5RkhuY0IweUVM?= =?utf-8?B?S29wRnU3N2NGa2tiVjg3RUFEcTM4T0JaYXFkWm1OdlNQeTJuazU2M0FKa1Fs?= =?utf-8?B?TG40OEI2VFh0V2tEWGtqdW5nV1A3M3ZiSDRvNXpQN0pxNzZsY2d4UlY1L0Ra?= =?utf-8?B?aTBBd2U5azc5TlN0ekh5SU9MWXhOUm4xaCtEOTVHV1NFK0lST1NPcDBPQXgr?= =?utf-8?B?NWQwQWQraktNejROZ0lKTVVVdVBmUTV6MVdKZ2pSS01lcmM1bXNXQ2xBdWpp?= =?utf-8?B?NHRjazllU0Rwb01YTVVTVm5YenhYTjZtT3hHWTNHQ3RtUEl5WU00YlhySFJj?= =?utf-8?B?M3gyQVJGL2tLRWdUM0tEb2EyVk5NcU5hbG0zanU4MTZROThHclp2NDRMVjlW?= =?utf-8?B?QVoxVmdVVmVFakFQMEdZNGg0RXcxRExjcDVqdkxIM2lXOVRjWDA1S0pBR0s0?= =?utf-8?B?RXM2ZTdWZUhtT3U0MnBnOVhWeU9tZGJ4anpUUktSam4wYWZBMTZGc2dLM1or?= =?utf-8?B?QjlidVNEaVVzV1RwWW9jK1dBeDZITWVWZlRkaDEvRFRYS2hCd0hTUjVMbTJn?= =?utf-8?B?aWxvUGhzUC8rTWFaS1ZBY2NTWFgvZ3JPUEN4SHE5Y0d2M2JCejZhYlgwYXBN?= =?utf-8?B?YlhsTncxMFR0bG1KQS9zZGJKVlNUWjlucG41Ulp3QXd1NklPMUZMbjZsZDV5?= =?utf-8?B?MEMzNFFFVk9UaDJzbGRNN3p5R0RmOWJ3Qmt4M0Z3TVVzMURXVXJtZEVmSFhZ?= =?utf-8?B?UjFSOGJZblBwenpndTV1cnUwdUxOSzRNc3M2VlBUTzdwcG9ON3FqQ285TnNL?= =?utf-8?B?VDE3TUtZVzB6NEVPeFJWY1RaalhxV2poOFRXRDFqL092QWdYZzNDWXNHSnlH?= =?utf-8?Q?Mx2T7qrAPmfRxjKChckjqwyHRt4cx1qxyxJdfWHOFSgGln?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 218428eb-e70c-47ce-190d-08da034f04c2 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2022 11:05:14.9424 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7664 Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/pngenc: support writing iCCP chunks X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Niklas Haas: > On Fri, 11 Mar 2022 11:17:42 +0100 Niklas Haas wrote: >> Oops. `-c copy` doesn't actually test the PNG writing code. Need to use >> `-c png` instead. Fixed in v2. > > Hmm, actually, even this doesn't work. I can comment out the iCCP > writing code and the iCCP chunk still gets written, somehow. Even though > the file hash is different from the `-c copy` case! > > Any idea how to force a re-encode? What makes you believe that an iCCP chunk gets written? Is it the size of the framecrc output? The reason for this is that this is the output of the decoded png frame and not the hash of the demuxed packet or the output file. The latter is included in the +7e412f6a9e2c7fcb674336e5c104518d *tests/data/fate/png-icc.image2. Comparing +49398 tests/data/fate/png-icc.image2 and the relevant line from V1 shows that there is indeed more output. You could use -c copy on the encoded file; and you can also use ffprobe to directly inspect the side data. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".