Re: [FFmpeg-devel] [PATCH 1/2] avdevice/avfoundation: fix memleak

From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avdevice/avfoundation: fix memleak
Date: Tue, 8 Feb 2022 13:50:32 +0100
Message-ID: <AM7PR03MB6660D3030BFE368F7896CE8C8F2D9@AM7PR03MB6660.eurprd03.prod.outlook.com> (raw)
In-Reply-To: <722ff81b-e695-4dfb-019b-1d9c3a58ce69@mail.de>

Thilo Borgmann:
> Am 04.02.22 um 17:19 schrieb Zhao Zhili:
>> ---
>>   libavdevice/avfoundation.m | 10 ++++++----
>>   1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m
>> index 0cd6e646d5..2078c4879c 100644
>> --- a/libavdevice/avfoundation.m
>> +++ b/libavdevice/avfoundation.m
>> @@ -106,6 +106,7 @@ typedef struct
>>       int             audio_device_index;
>>       int             audio_stream_index;
>>   +    char            *url;
>>       char            *video_filename;
>>       char            *audio_filename;
>>   @@ -299,6 +300,7 @@ static void destroy_context(AVFContext* ctx)
>>       ctx->avf_delegate    = NULL;
>>       ctx->avf_audio_delegate = NULL;
>>   +    av_freep(&ctx->url);
>>       av_freep(&ctx->audio_buffer);
> 
> Why carry it in the context instead of adding the missing av_freep() in
> parse_device_name() ?
> 

Because video_filename and audio_filename point into it.

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".