From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9CC6D40E93 for ; Fri, 31 Dec 2021 22:19:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2B51068B082; Sat, 1 Jan 2022 00:19:36 +0200 (EET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2047.outbound.protection.outlook.com [40.92.90.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1CCD968AFF0 for ; Sat, 1 Jan 2022 00:19:29 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N3c2tazz+0XyCaMUyOW+nggALsQWiu9YEAZyy67Yt8xQIF5WSvvUlpAuFk5Vf6mGRe0uUta/zmPDpIPVtJ8qa9vJOqJfQTImQv4/+/Rn6t1xavg0iVdsLcLp4eaJ1vBvIAFBZMQvXJbBsWAzm9vD9as5ZyEWIV23LGpC5+GePolIFUGVmJ80kF7pjHqWIrOwKZiVj0DdtRGz6vwT5LryQuurajoOQDk2b7Ai1WGJXTI0Ov/m83xQaFTycA4LlFJ6LcBo3DFEIIgPS3HlKSwhzRXobvas1K8eBxhWNxKH/rn4PPvRTdGu15lgfTmM8SXmX7054lCkZLazUKD9JwTsRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YzA1aejM0TeQhD6AL/4Ouk7v+1jdv/la8/VOtNBZu2Q=; b=ieKeMyaRGgi8xmIpSIz6C2za1qzjnIccQMIhWOuJwIfsqoK0eE1gg7UzIlxZsSoXqjWTItK3EGCp+Xj1q7XaLaQ3PEk5dHSlt8enWXBIODaCam6i7zgdPaLEHtIhS4/rSsn11zLVNrtO74DbvbjOuVwOyHMwEg5VXVQ0izYEN7+g8OpczReELrhqjhGK6M+TnhWX7xEH1LGAviZkF7X6Z7Ady9uW2NIY0RZ6EHOKzWw+QeD4YLmrhIrYAAe6nBwyipWO39v7boaGLfDUAtDW+qADheWFn7LFvs+ujDGtncyuLu4+jDnXONDbF3Hxi0JeD8nMA1Ruo1CJ/wpP36wedg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YzA1aejM0TeQhD6AL/4Ouk7v+1jdv/la8/VOtNBZu2Q=; b=ltdKfLRLf4wVF8xM/DL+AOT68XevbccKRXuOE8h5k5uadQCu8lE1B047nQJbPplZCtztfb3wjoafFZoNswjrxeELFrhc3qPV9eWlsKsx6MVXV0Dbs8k7FV5NOLEK/aWw27cYmwtUTiBVUt8uBSwebNdaF2ElpxO1YpmwE4Xiqc/VVwhvD26rszrsJzD9p3hbNgf2nDWA+94ddt6Ya0bf6VP5KgCDGxO6yfW+3JHJDm/zTaoibvi/Dq+z6WSdfF3JNaU3OHG4O70a5XwQl7Zb1xPfyjha81QsODwjzHfaLWtA8nrIugxsXo6seboCMgC5bwZxknZ4Fk+h1uUPsD8YLQ== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM6PR03MB5608.eurprd03.prod.outlook.com (2603:10a6:20b:f6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.15; Fri, 31 Dec 2021 22:19:25 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5%6]) with mapi id 15.20.4844.015; Fri, 31 Dec 2021 22:19:25 +0000 Message-ID: Date: Fri, 31 Dec 2021 23:19:18 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20211231195019.16191-1-jpstewart@personalprojects.net> From: Andreas Rheinhardt In-Reply-To: <20211231195019.16191-1-jpstewart@personalprojects.net> X-TMN: [xNfDDej6aaqRG1rntJaWLOAf2hF3KuQw] X-ClientProxiedBy: AM5PR0602CA0015.eurprd06.prod.outlook.com (2603:10a6:203:a3::25) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <72de939d-04ff-ef1a-cf9f-c0521f9934a2@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a7c16a1c-33b7-498e-283c-08d9ccab9a5c X-MS-TrafficTypeDiagnostic: AM6PR03MB5608:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zEUd3744BOlqvgcIT2Ex6wEy+6xEsxq8XNoWu4tXJthNXszJdlX44mFj/2tbOh3oACCLbv2q4BOdQ6ZAi9I9VwOzr68lwNJWLOr3aFtW0W5kYdPNvcAYduk1ACIG1XHEl7Il2zzYcq/J5ktHLaF9B2kGTmrqu5iHKPSZ6CnEWwfx9owju2mMlUfPFN0hb1su7nozljtbKM4LcPfZgysZogAqcJ6Y1Z9wLkjbdTonbDLw73u3grKLUxxIfZYvY3T55tuc8z5BXfELvKsy6V/LOpqgpqU15KHpZrMLVC+7V/Ra2RaSWkY5brXqBp+Ys2e6XC9JSLGBA95lT08Zywra0EMtx2ntLZNr2QXE2J7w2Pc1YD9BD7ABGUK+s4Bo4mOsq8DWeKG0++IXgn0zuIF0mT52CGH/3bbyW83Us0oTQp6oar0ssDjx0FXtXFO6y5cgVyf+bZeWa3mhqqtj3id8e83K40rkXJFzju9zCV8BItKsk4XZkRkpfW1jFQlieQAjXJhJdWl70/4h96+4UTzydlPWM8E0AMg0zzGX/AZWhdfQGsGDq3U6SHU+CZmoSKVbIer8+aN4Ipu3DoQ+i6z/o1ky23opgy2tiONlhdO84Db1N5G1Jg1oMtFnNTgo7l2h X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YlExQXZtR0I5c3R5cDZFUzZkUUlhNjh6UlY4V0U5TEV2WWU2d3lacGFYUUpI?= =?utf-8?B?eEoxVG13dkFBT0I1QnZ1WmhFWmZtVzdpTEcyeE8zNTBPYjVYdVRWYWJUTFhm?= =?utf-8?B?N1p3RzI5Ni9GaTk3UVF4ME9ibVZhNDNFY0FFNUx1SEFLK1RGVjhZM01GRW8v?= =?utf-8?B?dEg5djM5VEpqWTJ5TSs1Q21FR0M5Yy9TekJzSHlaTnd3RndWQWxCd1JKWGNn?= =?utf-8?B?SkpHUW1vMTBnZ3FKd3NodEp5ZTRtOHlxNi9tRndXK3dvWlQyM2ZIbmZEVm52?= =?utf-8?B?OEpsTzFIRWlDVHVRMXNkK1U3ZVg0NXNzQmhsTFgrQUZwaC9XY28wWmV1cHpY?= =?utf-8?B?Tk1DRVU2d2pHeThNQ3ZydGV5cWRESXJBY0dmWWF4ajRPZFdWeGd0UlM3SHA3?= =?utf-8?B?UXQvSldLR2FZRFlXYTZ6ZXhLVE1VMldoNlBlTGc5ZjRjdzRnaHdDQWFvaG1l?= =?utf-8?B?SWlITnJ2UmJnMDN4MzV0ZitTWm5SWVZ3V0dVVlFReVBaQnZOT3p2eU9jQ0R6?= =?utf-8?B?MitqT0FhSklHZ2ZWRFAxM2VrdVMxeHhjdTdmZEF4Qzd3RFVlNWRmMVhZTXZU?= =?utf-8?B?dU9WUEdGdmZUVldaV2VyTjZDYnVGUlZiTU5IWlVrcFhPYnVFbzdsTHhISEtG?= =?utf-8?B?MExaQ1pJTVlHb1VFY3FJM0NDWTUwTGdnK2g2UmN3S2hPYllJQ0FYNEhGMFVU?= =?utf-8?B?blh0Ulh4NDBXMHM5QWtRWEI3QXAyVGMwWkhsNmdWMStYelltaDNzNjhRYWl2?= =?utf-8?B?ZFYweUFVWlpsS2hIczFqVk9KaXZEcThDazB5azBHcFF2YllCbUcxNHZKWHZu?= =?utf-8?B?MkQ3RTYyTHVXRDY0ZGoyU21QZnBsd3RJUC9KOStOSi9TU1VsNXdkQTdOdHEy?= =?utf-8?B?byt1c1lTYnZDOEloaGRKa3k3ZEt3dHFXM3FUOUtCYmsvT0FvOHhPYTZYbG5R?= =?utf-8?B?NGloVExMMllpeWxyK0ZZelo3bG0yYXNMUGtCalhnei95RE5LOUlMd3A5Y1Ro?= =?utf-8?B?Y3kxSThpaVNWK2dUU3RqR3pKZGM5a2p2MlV1TlpzT2tmS0t5NXJtdjU1ekUy?= =?utf-8?B?ZzJYeEIyMVBja1c4Y1RKOGo3R3pUZ2ZZdkJDUHZUcmNJK1F1ZVZUM29NcnI4?= =?utf-8?B?VGp4UzNxazBjKzBwaGxBOHBRc1hVYWhNS2RVOHE5ZW5SMlNWQzYvU3ViWk15?= =?utf-8?B?MEIzUUVqU01oa3c3ZERodTBsVmtwaUdpRWZmN1ZkalB1MGlRcWhEWWlkbFJD?= =?utf-8?B?MGZRMGthTU16Ym9XaWNxazBGcEk1ZktNWW9EL3plYW9YT3Radz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7c16a1c-33b7-498e-283c-08d9ccab9a5c X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Dec 2021 22:19:25.4447 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB5608 Subject: Re: [FFmpeg-devel] [PATCH 0/2] avformat/mvdec: make audio stream conditional X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: John-Paul Stewart: > Recent discussion on the list led me to realize that libavformat was > unconditionally creating an audio stream for all SGI movie format > (version 2) files, even when no audio is present in the file. > > A sample of a movie file with no audio can be found at > http://www.personalprojects.net/ffmpeg/silent.movie > > Unpatched ffmpeg will report an audio stream even though no audio is > present. After the following patch no audio stream is reported. > > SGI movie files with audio are slightly affected by the fact that the > audio stream is now allocated after the video stream, changing the order > they are listed in the output of ffprobe or ffmpeg. I don't think this > materially affects anything. All existing FATE tests pass. > If I am not mistaken, it actually changes it a bit more: The audio data (if present) is stored before the video data in the file and mv_read_packet returns the data in the order of the stream numbers. Now that you have reversed the order in which the streams are created, there will be seeks; in particular, the file needs to be seekable. This can be fixed by inverting the order in which packets are read in mv_read_packet and by also creating the video streams for the non-version-two files before the audio streams. > Incidentally, the silent.movie sample above is at 25fps and can also be > used by anyone who wants to double-check the earlier patch 3c9ffbd009 > that reads and sets the framerate. The sample file is only about 88 KB. > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".