From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4002340325 for ; Fri, 21 Jan 2022 12:14:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 26D6E68B2D3; Fri, 21 Jan 2022 14:14:16 +0200 (EET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-oln040092072015.outbound.protection.outlook.com [40.92.72.15]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CD23168B1AF for ; Fri, 21 Jan 2022 14:14:09 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U/E18AlnCw27tSNd02gSR2ewT6ky6E3lUdhrU1D67L9CGQa3rPLq3k1YDNLBnySMD5xc0XrLRhfEmv4oXrmsGG5lzkKYbYtynHSnSg0DdLVHl/IAThbCnOhS8jcpM5H3XCaLWgF5XJZy/MAX3y5m5YHSbwm/oigVZfCJB372Kv90Ic/8C3Ek5osD7oGTV5K2/4hxCRM0NPHsSN3RAn+dgW6ppOPcsB9sD4NBwq6IFmL7nylRuTOrY6JcmcmF0VAOn8W/LMtO5z00ruUY2OuupHTPThNezgb+m6c9gXrkGqBYbn2sMj2TVL85/TJotdm6hDq7mr4bytqGs/a+Dw8A7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pTUZOjiJF/+k4eSCD0W6dqNWVewBGuvUXASuu025uNc=; b=OFTSWn90ksbO1s82pG3WJE9K1LsKDlaurbAu5aDV5D7NR1W8tWffyU7cQWaPhUc3gkKDfpclxCAVoIwSfamZCE5s9DSHrLBc7279ddjKFusaBkgkev64YQHLnjkNVOXa+6hLRd9e7bId2XR01Q6cGjEqqMEVmwFaxHsk2j2jVf43eGoKLp1xIxHuUvt61/S7HeVfwqnb8bsad5YJNaJY44s9F50dozldXA2EkZHMoyTMqocF00SpVdIcNNQUXIwgmgMckmLu9pYqBsiJoSrdQzggl29Ss26UtWvzCFr0r8OPljGOX37S7NeccaD2cG71bMDp8Gk8oxZvxWKSAjYEwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pTUZOjiJF/+k4eSCD0W6dqNWVewBGuvUXASuu025uNc=; b=nV6EOIBUsMn+vcUFYOxqpUPSzNclyBH3dmxCAXIopMZP8UZ0jnmpFb4scaUDLb5dpe8dCa5JDUML9st77BIGRp9sapo7EzIU3PjVr0u0N6oiPVcCz5JvrAU/elz+aDA9bTo6ebIQx0UAybAp9dAaeLG0OpEPWE8331Q/TCFg83+MLlmcNMNEZrYuntRpKN89ft14wk9TEtOhkVErcMa2LkFEUCTrBbMBQVNwzJfG7L4pRsTBNaLhOrunETaDK/3/7xi5Rbfeg+BtVSsMG51wTx41rxgLG97j2pfO0FNZ/kae1TjGrJIwUUDC2x9NAdtVRDcnCSvnx4uZ8+mXM9axpg== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM9PR03MB7250.eurprd03.prod.outlook.com (2603:10a6:20b:263::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.7; Fri, 21 Jan 2022 12:14:09 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5%9]) with mapi id 15.20.4909.008; Fri, 21 Jan 2022 12:14:09 +0000 Message-ID: Date: Fri, 21 Jan 2022 13:14:07 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [8jcU3XpyrC6Wro5FMToDcZ0GLsBpqvqK] X-ClientProxiedBy: AM0PR10CA0110.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:e6::27) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <5a942555-257b-2351-472d-621aab52096b@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c35c575a-a9e1-439b-6b57-08d9dcd786cb X-MS-TrafficTypeDiagnostic: AM9PR03MB7250:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yxFaXxF+j54/zQQc81wral+KTFLG2YabFo2j3YDLlJNvJ9pA5O3Sw8gyUesv7FptaHwjdzZz3VhR0Vue/Sguwcg0BnWJpOFQ4Cj9Sla/CG6tzpu3MODvyFwIhUEwLa6Lkpdk9w6cf+6AGTA30AMU1uTzSRULWt1MBvx8NToVrr44E19Nd1QwxZLrTmRbJU9Tco2HmL8bPAKFCEbKVTv/cHbykZm3Qp3Wrc81vNOaW6q+c64V3Ho+vmBjzWc1QIKjYgNVw8KZOHbat6T8IYryXKupXQ3QTfH6Y6V8au/KUitqwg7Eedaj43V9yY8cXYVBZnIkpROhO8xMCIwvVpfaBKoiuKaCO/8T77jTkR6at5PPJ8vvNkBT40khWfkok8K7cTsMKRRWZP8JwfAjhHETxAFwOxiPyoCYkzOXbdtiwDiuKjC5plp/ptkVayWwISIL6klEKS4rPj9Cp7/JwxdQGoy9YRUHNSRHrTZIheIm+ZlInJgKgoT+8EBFuGlswHzttHaxu/K/7a898Iql9Jc61meCczJaCfJ34krcKLpxk7CEauiVxbYV6FOpJNXHuqEp77fUlzWrFPCSxm89Sqsc1Q== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTYxbVgwU1lOUzI3cElxZWRtNGFPV3RvLy95Si81Y1dSKysrZzhmVm5yWEk4?= =?utf-8?B?TlFCclVSeFZNTGhJaXJFQlNwNkU0UTJmTGFScHZYdTNXSitrL3lqS2Q1MUlR?= =?utf-8?B?ZkxIWHFHMGIwb1lvSFVqeDh1RGNVb3Q4REcxN0U4MEJFME00eGJaUERhb2Yy?= =?utf-8?B?bzY1SStmd1FHUUhCOFY3UHdqZVR0SUxaY0VFVWxvRWduWW5Qbk1nREFVb2VJ?= =?utf-8?B?YXNYNlY4clowSGRXNmJNT2hzUzRCRUpzbnBFejZpNFRXQ3pJWGJ5QjVPRGhM?= =?utf-8?B?S0daTGMwOXAwZmxOaU9RaCtHZWtBdXNOK1hWTDFoRlhXc28wdFh6clJZLzhv?= =?utf-8?B?ZS81a0tqekhVcVhqZ2ZnRVkzdDhTL3pJQ0pHek50QkR6Q2g5WHlXWC91UVlI?= =?utf-8?B?RnMvU3p3dVRGSW1KbkFBTGp1eEZNeXQvcHI1NENDUHE0dnJtZ2NjKytkR0FZ?= =?utf-8?B?eVZrWjcvaHl6clJ4YzJRNkw1Yzk3MkhORmd0bHlWdlhRSnF3RzJYMTY0UFI4?= =?utf-8?B?b1l1bjFWdXFoM1lsMUlvWjI3TEdpWXdudWVZN0VoQTM3aVJha1BHRjNJeW14?= =?utf-8?B?UEhaWEE3SisyUmVlZ21iNzlCcXphOUt2enZPS3RtSUlZWm51d1o4WlVFSTVB?= =?utf-8?B?a0M0UnNhcS95NXVQcDRCY05lU1QzQkMwZHl2V25rcndSTEJKTmkzTDBYTEFu?= =?utf-8?B?S05pbEh3RHRYNGJpWCtPL09NM2pjZlNEekZOYjMzc0FBWWZiNE0xcVYvS2Fl?= =?utf-8?B?Z1UzN0V2d2UxdzN5aGFxZkpGR0JZR3YzZ29XVUFkdmg3djdlM3pvajRMdElu?= =?utf-8?B?WGcvZU9XM0g3bGUrTkJxM2h2UkwxKzZWR3ZoZjJYdVBENDA1TDBaeDlmVlc5?= =?utf-8?B?SXBFc1VycHFqRFpHaG1ucTZiM3FzMjBUNk1Ed2c3WElNR1Z0MTNiSG1tUnBC?= =?utf-8?B?dzhRV1psL29GV2prMXl6QkM2QVlDWitIbDVhWmxBREhXUjZtaytrUVF1RmxW?= =?utf-8?B?VXVVUWY1YlFRMnY0bFJGRUQ5V1AzRXFUc0lHZTBncTVld1FwVE1VVGwvOWp1?= =?utf-8?B?cWNYL0hMQmhSdU1GZkdOS1BuSnFMbGJySTZrK2s3amNiOTN1ME0rQUUvRTBl?= =?utf-8?B?S0FVd0l1cHcySGlsRktMS2RNOWxhV3FOT1BBMzJWL1QzTThaMEI4MnR2RTIr?= =?utf-8?B?UjdzUHdsSDdEUUNMcmV0Qkc4cnB5U2hlc0o0R1NlZHNmOGFxbjNsVFE1NlJK?= =?utf-8?B?UTRkc3d5WG1tQ3FnRDdiTUowVXJXTDBDQUpBei9la2J5dzJ4dz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c35c575a-a9e1-439b-6b57-08d9dcd786cb X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2022 12:14:09.0161 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7250 Subject: Re: [FFmpeg-devel] [PATCH v2 1/6] avformat/mux: Remove assert based on faulty assumptions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > This assert is based upon the wrong assumption that > the noninterleaved codepath is never used; if it is used, > max_interleave_delta is irrelevant. It furthermore > ignores audio_preload. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/mux.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavformat/mux.c b/libavformat/mux.c > index c387f8ec6e..e34fd88f05 100644 > --- a/libavformat/mux.c > +++ b/libavformat/mux.c > @@ -697,7 +697,6 @@ static int write_packet(AVFormatContext *s, AVPacket *pkt) > ); > } > } else { > - av_assert2(pkt->dts == AV_NOPTS_VALUE || pkt->dts >= 0 || s->max_interleave_delta > 0); > if (pkt->dts != AV_NOPTS_VALUE && pkt->dts < 0) { > av_log(s, AV_LOG_WARNING, > "Packets poorly interleaved, failed to avoid negative " > Will apply this patchset tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".