Re: [FFmpeg-devel] [PATCH v2 1/6] avformat/mux: Remove assert based on faulty assumptions

[Andreas Rheinhardt <andreas.rheinhardt@outlook.com>]

Andreas Rheinhardt:
> This assert is based upon the wrong assumption that
> the noninterleaved codepath is never used; if it is used,
> max_interleave_delta is irrelevant. It furthermore
> ignores audio_preload.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavformat/mux.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/libavformat/mux.c b/libavformat/mux.c
> index c387f8ec6e..e34fd88f05 100644
> --- a/libavformat/mux.c
> +++ b/libavformat/mux.c
> @@ -697,7 +697,6 @@ static int write_packet(AVFormatContext *s, AVPacket *pkt)
>                  );
>              }
>          } else {
> -            av_assert2(pkt->dts == AV_NOPTS_VALUE || pkt->dts >= 0 || s->max_interleave_delta > 0);
>              if (pkt->dts != AV_NOPTS_VALUE && pkt->dts < 0) {
>                  av_log(s, AV_LOG_WARNING,
>                      "Packets poorly interleaved, failed to avoid negative "
> 

Will apply this patchset tomorrow unless there are objections.

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".