From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1941B4068B for ; Wed, 22 Dec 2021 13:07:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6CB3B68B058; Wed, 22 Dec 2021 15:07:18 +0200 (EET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-oln040092072067.outbound.protection.outlook.com [40.92.72.67]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 27A4F68ADF7 for ; Wed, 22 Dec 2021 15:07:12 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n6KLtKybTjzurHPlY5IAzYpeNQ1HUAlLUPteo82u5lVBiyorZAoRKt8Uv3RqIR0D037WxClfMFLxb5f5vgg9u1MeYVvOhAv/Fy5GIGrxb/7GSZ0dfwLU+AK92krf2ELxbFvHLcypX8Ju02AhNGUXeaxRLH4bsRgGu8AuGckJp+7zUiim+9wXK+iSEmVDUIVaI50/YsN0m41O39HUPItL/TSTO1co2GfDWFQyMgdJc6iKOlh94cwb6EG/oEtRDb8G9xn0G6W7m7/ApSHP6GVOtGTSd5wa7Tqkm67GjTqcCxqnCffMOyaHgyFl+vwZ5bKMXX2YUu43qpKYtEOn0Hyiaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W3KI8cw8zn7QlFQMweqj6nUKxqEbZJsND26QyWxK0Tc=; b=k4ZJ2TSecTp8ZUOFv0kEo/FMJcY921UJR5KF9CYR0bBz2YLhGab/niwODKBIaPqO9I+0qRr4RiUB3nBFaRwJUbmx16gs4jccAI+GdUSZLs7XNWff/V3E1BsnAUQxv9DffTlLx9BYijFiALGkEWJTCDsBcIjdqQ+m2XAa8fHv37G9BWfsNYwqj12Q/MSWRdQIhZ6nDmhmiUy0c99xzTNiPxvI3duWw2IBZHf6phC3PEjfotWY6kOC/odQzsfGN5b8n3CeSXeaz+Z+DGvhccAZe0Z3JQPaoJNEvx9JrOBaQFb3+PiSTHkihl7lq2fmglPmpKmwFxS+ztDDwF5XS1RCZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W3KI8cw8zn7QlFQMweqj6nUKxqEbZJsND26QyWxK0Tc=; b=Eba6Pu3BHqmCWw6ygoP1GNhuppP6beQLapC23EOtOLIXdnsra2obHxljCD2Vhabe4nnEKjXEA2aVYIFpD0KOujecukrvsFOdbsSrvwcKKVWNJRntkyw5esAievCC4q/l1SxDCJQhs0DAh0nynFAWLb5SowHidi/Bw6XCg6EdF/WfVcc7PUEfasW83VlivTsZuFGk76HAvOxvS+Fa8MNPn6jR4pkkM1bOx6ffkdeUE0CK045ER2siZ3ekGa0AB4LROE/WgrrAbIpsXCfwS0Bm93/le2ujR/ACPI3z3PivNIqzynW4JdWN6HZvJvOo0R71sGCJmdiNqVNJvInR8kt+Bg== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AS8PR03MB7256.eurprd03.prod.outlook.com (2603:10a6:20b:2e1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.20; Wed, 22 Dec 2021 13:07:10 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::f0dc:92f5:6bc2:45ca]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::f0dc:92f5:6bc2:45ca%6]) with mapi id 15.20.4801.022; Wed, 22 Dec 2021 13:07:10 +0000 Message-ID: Date: Wed, 22 Dec 2021 14:07:08 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [4pKUK9Sl3y7M32SDHf46IXZQGUzfO45f] X-ClientProxiedBy: AM6P194CA0061.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::38) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <8ea56e60-e83b-a871-4e2a-0f8f734c3218@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 60008d43-305f-4eb3-0bd4-08d9c54bf6ce X-MS-TrafficTypeDiagnostic: AS8PR03MB7256:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FiwlLomz8narJHo0SxGY0VYIalGpmbGQuY4QPDqHI9BY6j9IWi7kun6t/AQEpK5j/3nPUy6kLy0lyv7JSSBMMgkH9JN5xtJTk0x5MLV5QDcFwfjSYfUkQF3yxW4zQMI3HUpGGGD/O7SMx3KHyRMEPOTpMem9ayjhU88u4XfmOa4+ZQjqYcXboA0oCEaF+AbAP+65u+mN0SWfdze7NCPPabVpHH3c0G0ru8ReA0ybzzS/CHewbtDb5TnyrA+ZaBnOTTmxNCOO9MVUZvemytPlrU1AJa9rZ8vwq4nnhXGALWb6JIzCs1VH+DJAAmngOV/pNvUD5vdeGI0QF1ECDd14+CvctF+BUrX2LBMrYsAwnenlqZGy+p8zg0SbVuoXFKfVd31M/wFGcy6FqKi5oVsIDzhk7Cjvo2yUv2CuGi2SaHszUu2yLx1Vg5BT144ALYYFloCNCHMH+8yGH7/i+nNbeYXuaG3m0J2PK8z0eA3V50h7AHA6gu6+onLtDISjwBKuaxibhxiLX3m+Z2IRrdOzjvvsT0vs1Vg37q4HQ5tGIwFEksWEScC46okJlFExqWk6O4c46c1W2f+9eihTYUq0Og== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3ZLMGxqUm5zL3FiSGJWaEZUZ2JaWFBPQUF1WWcxK2h4OTRvaEJxcE9ITGxu?= =?utf-8?B?NkRPZkEvS2ZnUngyeFZhQ0dyUDNyMkw5bnpLc200bTJodEdDUVUzVytnQnNM?= =?utf-8?B?SXg5UXVoMk9SQ09MOHdNVUt2UW13TDFKZE9xQ2xuU24yOUhNb0NSN0p3V0NB?= =?utf-8?B?SjlGSzBHQWRLdUV3QlBkd2JGOEs4OFdoMjM1UHBCeTFCQmlPTFJXZ3lTWGZw?= =?utf-8?B?ditCK0V5dWtMNVNuTU9tdlNzbHkvMi9UVXU4QW9qcWh3VlJ6cjY0QTFtZlFQ?= =?utf-8?B?NmprbWNvWkFXdVh1RlduNVNseDlZYlMwRXQ0c0t5SURwaGR6TStFcGkza09L?= =?utf-8?B?N01lRUZ0UFB5ZVNPMmVWWWlzODFoWHlXSCtwaWZ4dnR6aFJmYnIxMDNFT1Vu?= =?utf-8?B?QzZsbHJwSlF6WGpqenZkazRpakJtTzZpRUpiVEtXbGdrU2ZzYmRVK3FKaGdD?= =?utf-8?B?RlNZSTRqcmwwT3lYSUZiR3NHQ0tIZDRkdTlSRkJwSjUyMnQ2VHN5ZXA2MXcx?= =?utf-8?B?VWl1UVVMT2sxYUJkRExZUFVuRk5xUE5tZjF4UkNZSGVzWTAzMm9DV0N1ZlVL?= =?utf-8?B?NkRUOWczZGlLZ3I3VnF3M29LNVVyNUpMSnpGRURCNVJ0UUwvL2dFVjRMMnRW?= =?utf-8?B?WUpNdEgvbzhxeWx6M2RSZlZReGhtMnNJVCtheENPaGxWV2xkUmxZVjkvZ2xj?= =?utf-8?B?bkdDWDdTQ1FTTXpBdUJ6ZnhteTBHb0lrNUY1T3VzVkNFUnpEc3RpS0pQWElX?= =?utf-8?B?dFhSTWNUS0lsdFZKQXY3Q2VTSTA0Ni9DVWg0aW1YRWpDdElTSCtBSXFNbEhK?= =?utf-8?B?dWt0TlZVSDgzNk5xU1U0UEwzaEdmL1FMbmVOUlpYZ2N4UTU3MVB1aW5jeTdL?= =?utf-8?B?ZmdvMGFlUVNzL2JrUldiN3lHeDRULzhMWEw2NFZSb0k4cnJXaGE1UG5CY3Ja?= =?utf-8?B?eGQ0WmI3bER3am1QMFVRcWNPbFlZUVhqUVIrcXo5YkhhL2pjUHB4VzJpZUpY?= =?utf-8?B?Z25mdHdMRU4rY3hyYjY1M3FiTDZGZlMzclZCcGRNdGNsTXRINitnY3U4WU5a?= =?utf-8?B?VlFBQWVjd0ZiWkp2SzNxOHRCeUpVMnlyekdoVktiVDFoWFhnblpvUkRxQkVJ?= =?utf-8?B?MUtkRG9IaVlVOGx1SThMUWJ6QTMrbFM3MDh1ai9DUURWdG1DWFgrK1pzckFl?= =?utf-8?B?MUNOd0Z1VmRzeWtBdWxzZWpsclA5M1R2Yi9sN3hWOFlpVDFzUEZpQmQ5ais4?= =?utf-8?B?U1hXRFJ1RUhkMlVkYnlWTG05Y2owdjdmTHZveDllSGZiT09Bdz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60008d43-305f-4eb3-0bd4-08d9c54bf6ce X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2021 13:07:10.6834 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7256 Subject: Re: [FFmpeg-devel] [PATCH 1/4] avcodec/mjpegdec: Fix exif rotation->displaymatrix conversion X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > The cases in which there was flipping together with a rotation > that is not a multiple of the identity were wrong. > > Signed-off-by: Andreas Rheinhardt > --- > This whole patchset relies on the mismatch in av_display_rotation_set() > being solved by keeping the current behaviour and updating the > documentation. > > libavcodec/mjpegdec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c > index 8b154ce0ab..0dbbc14bae 100644 > --- a/libavcodec/mjpegdec.c > +++ b/libavcodec/mjpegdec.c > @@ -2896,14 +2896,14 @@ the_end: > break; > case 5: > av_display_rotation_set(matrix, 90.0); > - av_display_matrix_flip(matrix, 0, 1); > + av_display_matrix_flip(matrix, 1, 0); > break; > case 6: > av_display_rotation_set(matrix, 90.0); > break; > case 7: > av_display_rotation_set(matrix, -90.0); > - av_display_matrix_flip(matrix, 0, 1); > + av_display_matrix_flip(matrix, 1, 0); > break; > case 8: > av_display_rotation_set(matrix, -90.0); > Will apply this patchset tonight unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".