Re: [FFmpeg-devel] [PATCH 1/4] fftools/cmdutils: Fix undefined 1 << 31

Re: [FFmpeg-devel] [PATCH 1/4] fftools/cmdutils: Fix undefined 1 << 31

[Andreas Rheinhardt]

Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  fftools/cmdutils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
> index 594eeef379..f80c361eba 100644
> --- a/fftools/cmdutils.c
> +++ b/fftools/cmdutils.c
> @@ -1823,7 +1823,7 @@ int show_sample_fmts(void *optctx, const char *opt, const char *arg)
>  int show_dispositions(void *optctx, const char *opt, const char *arg)
>  {
>      for (int i = 0; i < 32; i++) {
> -        const char *str = av_disposition_to_string(1 << i);
> +        const char *str = av_disposition_to_string(1U << i);
>          if (str)
>              printf("%s\n", str);
>      }
> 

I know I have promised to make the disposition field (and the
av_disposition_to_string() function) use 64bits for the disposition; yet
I have forgotten this and now it is too late to change it. Sorry for
this. (Fortunately we will probably not run out of bits during this
major version period.) So I will just apply and backport this patch
as-is tonight unless someone disagrees with this.

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".