From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2F92940B0D for ; Fri, 4 Feb 2022 01:30:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 94A0F68B217; Fri, 4 Feb 2022 03:30:48 +0200 (EET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073069.outbound.protection.outlook.com [40.92.73.69]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6F31E68ADDC for ; Fri, 4 Feb 2022 03:30:41 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eS0rA7Yc5c+qd5icf9azztcX99nwSVXdxkMUbVHykeo5Gp997NvRKKqKJ3+g9Bw3vNL4XzXDjSkP/COe40mjdlazDtB6K78Tm/nIYjOpOXsejPJwAcw5qhv5CeBO2Kz1JxmwxHolKTxWdoXMrAlRGaFJu/lA+VGzpxrJvXawgmg6MaU/0wNW5i3vPfFnKWcRR/LPXpKzvfa7LUh4gAdCCiXqVYOq0TvfWU7ATHqrrmHfm0tpF5WPj3LYj0/irg8j0Jgn1JT45KoAjsUcvCFMMRiPWwVGZBUyzcAzVHPV1C36+TVKKhcKsUG7sC4DO7frZaO34Dndi+XGraXnFm8Gww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7m7JFvknwCbWwa0XOVQfEfxxKabnLA0brT+kaORvcLk=; b=XLMAQ7y4SOCkGbhwDcbRKCKzHBLCa702qbwvOiv1YkyhBelAdeinL9N2uzy67QWCojH+hRp92C9kLULwHz+1aQyTK0b3wmVvrAKJv+lZjKY1/04r6Z0FdzrtFPkuYgShGi+Bj09DEOZ/TvAGd7XdwEvKzvDhXdfqMbZ/4vizoBeUFgRdosmEmiVmHa/RO5qVOlBq2GiCnHnzxFvEpHKOnK+ZkUZsF+jGSlkRqsWwIo1CcRvawerkj6ea+0HD9M7BEcRATnzHzeriexl3JL8Soxl5xl2yspVX8Ny91Ih1cMpwvtHPm+CIMJts50piZIXKTRb0m8IolrbhBqFSKB3kxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7m7JFvknwCbWwa0XOVQfEfxxKabnLA0brT+kaORvcLk=; b=i5dYf3NRA5Q42cX0TM78mlBt3h9E5J+ma1n1UcUv8gQYxOWBuBTh02bmzKH6pvv44jy3K+OoWcz3492zmUH0V8MbfuNNLxz4QGKB7/q7TjRR8zf1WodT9KGUFJrwknIVeFJfW/4Jfyp6a5S0kpm3Q7mosdn6xHCkwmLQCFhe8Q1lqckF5aLikgIoHarf2GlFYnYIhvXNnI2dlaQ6ja5b9msSUphFcre74MBq9jha03Rv7fpjnfXkicRpsNUdS3U6UvxoqyBtJ2YNWSfsxGKWSwxgSYhRXCwG1Sk3rUZ4Ophl3oEhw8UazYOPcb6PDMGx6pUVH9jPDU/JUGKgc+NDlA== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by DB7PR03MB3964.eurprd03.prod.outlook.com (2603:10a6:5:39::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 4 Feb 2022 01:30:39 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22%5]) with mapi id 15.20.4951.014; Fri, 4 Feb 2022 01:30:39 +0000 Message-ID: Date: Fri, 4 Feb 2022 02:30:37 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [n9A9uBufJiTfVoWu5WnAuRY4RG+YAm5/] X-ClientProxiedBy: AM5PR1001CA0007.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::20) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <86593d2e-00d7-6d8e-5429-647e15c132f6@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 16ecc418-778d-4f0f-20ab-08d9e77df390 X-MS-TrafficTypeDiagnostic: DB7PR03MB3964:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v5hsAQoKQV3bCQP8tF5eadpmAfjovSWHJl3jSfQMcXYUYJLG6Sk/In6mlnJiW6GRFcg+Fzzl9zl6E9A1pWg1tGm9IWsDfoy6bn2UzvkVY53nU27FSJLMCCjS5SzwygH8Nkh0gkrcnyL+rYJ9/EqnCs0MIaJXuv49+MTfTwhhrgFvLNLyhn9ZRpIALMYE5imYoZAvOKmnX/2ns6Qc0zILD88eMkOIfzAp3J/oYaL7gaiWLAnpaNR7uhtk4EleWP1w3qcvJg0HcVXIMTM9jnn1WtE3dE/CqwrcWqSl6upkGc9NXdpYDXWM+lUETjZbX1juHxaVV7qJshJZmaAVa8lVC76CeT9NjxDhcNNu4BuZTV6gehVuR50E3a1d5SXeyaYIzgM30DW1x1m3hnL+TJFUSYwbjIdbGZb1evaHb0cc92s6C30H6hZPeXRw/eMFuhX7IMQ/VB7bCu6Bumnfp814IdHbadJdJDnjpuw0XkdrpYgzcpSyoGSTiUBrkBGyUxr3FTCE8v9JvzV3lL8kycS+U6yN6HmhMMTH0HoHXDJ8CsjhuYsA27DvXkh9q7DUvzmpJJE+dWtrOtzHZmKL6Ec7gA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0JkSFB3OVZTaCs4Sm83d3BqRXlvL3ZwaUVWYjdqVU9Od2ZnVnpYdGhtcDUz?= =?utf-8?B?Z1RQMGNpTDVRSGRVRElINjZ6RmZoY0czcEhpSFkrNldoV0lpRmo0b3pJeGx0?= =?utf-8?B?a09xS1pQTmZnVllCV0pwVnZ0cUc2TXhqV09FdDNzcHpWQjN0cFNRZlliN2ZD?= =?utf-8?B?Zk9idklzRENicG55SlgwaVpsMlpDRlhSN0FJYkZkMWJ0SmpEZGc0ODg0aTRK?= =?utf-8?B?Mlp1cWJ3Y01XRDVnUWNMYklxMXJ4dTRuaVliLy9WYTFaOThHdW5adWJGckdK?= =?utf-8?B?VWVUQ1gvaXBlODRyV0lXOWVPNGY3U2l5aEcrT0ZNM1pwdVJURXZnd2t4eW9l?= =?utf-8?B?Z2pCZ1VMcGlITTVmNkhLYk9iaXpTWnEwUklXUnBtVGsrNUpHT0lTbWxPd2Qw?= =?utf-8?B?bXVsb1FVQ0IzQk5ybzQ1STgzZTlRcUhZVFZKRmNIOTg3akMzT1dSVkFsNDhQ?= =?utf-8?B?OStLL2dzZHAxZkVCZ3pLK3htMnM3elFVdE9adk1JUEE0Qy9PbnlRYXhPRGFl?= =?utf-8?B?Wld2MkR6SmNXOGYvMDV2SXh1aXlGQTJkc25wZXRXandtYUsrWDNyelJtVkR0?= =?utf-8?B?d29jNmg0R1dpV3M3TFlPMno0YXU4TndFdnQ2aXlKUWsrTUFja0pCZFk5ME1u?= =?utf-8?B?dzV3c1V3Wm5xdzU0MDcrNDAxSy9ZVGtaSUhIbEg1bVBxUHJIaVpJMzFteTI4?= =?utf-8?B?MnFEbkx2TG4wWkhnOEZuODlNQStOZzg5TnM4SW9WZURhK3M3Zk5oejBxZHQr?= =?utf-8?B?WmZqbnpFK2NRZmJza05teEFFUmhrUDluN1RZSEsyRUdJODFRUTJuK2JoMTRB?= =?utf-8?B?cEZYSFRZNDRTWmFFZmZGQ3BHZXI0WlF1NWszbWNQdVpGL1NDSHJmQVNXSTV2?= =?utf-8?B?YTh2dG1VbmRWUm5VM3BOL3BnMkdWN0JseTc3NDdkN093QVIxczBuTkpHWkVN?= =?utf-8?B?ZVl2NkJzWlNoWW04NVI0TFJiaTR0MEgwaXR6ZGZybWRCZVR6bTR0TlVjb3pw?= =?utf-8?B?eFIwYTJhRWRvSUVOeFYxNkVWMXFiMHBDK2N4ZEdtSEVMcmdIblVzMVZEMXlF?= =?utf-8?B?ZkFRUU9rSUNkakwreExFRlFlelNsNEhBcjlKQmgxbFk4WlpRMFp3WWJkNm43?= =?utf-8?B?WVlPLzVTZjRMWHJDVXl3U3k0emR0T3RNVVNWL2REMnUzR20wdk5Wc0o4d1F3?= =?utf-8?B?bFdKdG83TVRnRmY2WXNNQS9MNUFreXdtVkdIeHVDS0pDcDIzYzJhQVZkSTNo?= =?utf-8?B?SFRjMHh1NFNabDZyU1BCeUg4SjltL2IyUnBzK0JvS3Q0WWhNZz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16ecc418-778d-4f0f-20ab-08d9e77df390 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 01:30:39.5372 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB3964 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/{ass, webvttdec}: fix handling of backslashes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Oneric: > On Thu, Feb 03, 2022 at 20:51:16 +0000, Soft Works wrote: >> I think when you inject that word-joiner as a workaround for ass >> parsing, you'll also need to make sure that it gets removed >> when encoding to other formats. > > There's no way of knowing whether the word-joiner comes from > a conversion performed by ffmpeg in the past or already existed > in the original source. > However, the wordjoiner does not alter the visually appearance and > is unlikely to change line-breaking properties; that's why I chose > a word-joiner. Therefore I don't think removing (only) the inserted > word-joiners is possible, but also not necessary. > > Also, was the wrong \\ recollapsed into a single \ somehwere? If yes, > then this code can be dropped as well (but I don't know where it is). > > My biggest concern with this is the unconditional assumption of UTF-8 in > ff_ass_bprint_text_event? Is there a way to improve on this or does ffmpeg > convert all text to UTF-8 before it's passed to this function? All text-based subtitles are supposed to be UTF-8 when they reach the decoder; if it isn't, the user has to set the appropriate -sub_charenc and -sub_charenc_mode. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".