From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 608E440C4C for ; Sat, 5 Feb 2022 21:58:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 43DCE68B03D; Sat, 5 Feb 2022 23:58:40 +0200 (EET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2042.outbound.protection.outlook.com [40.92.90.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6EE9C68AF12 for ; Sat, 5 Feb 2022 23:58:33 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gkxRqjiO14kmHUcj3eXQyMRjuM7lhIuvELFVTGNv3XMvdZpw4Tk/XJVDAk8Fgnv4VggDGDrQ1nCaTBZOxHaoBrrrnRY8ZpxWtdQ7jCcvtvdSLJpZ2aUj2NjiHwu/L95iWqoXrkM+QoAoFPHtKkvreXWrZ23ZSZ4UsfqK9kOdE47pahvby+UTJj9+0SfOm9/H3JGH0V5zVoVCb7D19WADQ4kLZwqIy3E5O1CIabheMcw7lSBXL4BoGvXygthrel70ZkysYchaXbSU75AM78Q8Yi1t77vfYrhs/WMqADtdok1yGIzTSiQlG65MHDfNm9VACQoS6rE2d9c15h5ubKne+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iLPAo863miYXVMfpl8tp3rDsjpFVLP/kZj4O4RxT9lo=; b=SV9yLDVqaFTv8lX/dPZCRsapPF+T7I1DDovl4QMx1SOXlYqg0JMPl2FVQyYwNRE81ivXlcSMnwlJKh23EIE387vDE9S5vri43oMun7Rp91u3On8aky72A5btH7Kc3o9oM0jR+IWHLJuLXeYL43M2ECQNOlh3QLdVOW86s0RhisWzf7exhx9Sq62krCa3pogl1nod+0J23ohsRFYy6WSCZax1JLRNBgkCHRDqMPTR71fKhVzMi2zm8l2SmMkhrZ22GK8QbuICcZcGxaaNOebopiRCf0yWkJbePgNVGA4RFsTiFvzkFMIy/n/Usb3+m6pauFpLs9th1R7BaQMr9hiFNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iLPAo863miYXVMfpl8tp3rDsjpFVLP/kZj4O4RxT9lo=; b=SHZjZm/TAe2yqUn/r3dtcqDGGnEop7tMgyodeGhjR1atVAVMVJWCR7haaoZrs2samnP46LGFhCyAGDDTNa9Kvr90G51hcrnN25h4mkxX/p9tb91GtQ8i93h8svuJ5Xxf8vWjTiOFza32LfevrbU3cvo1gZ3V5mc8eJuNQr3KZDljo8Uw+axJypeT54OQTh/NY/gWOf0hGOI1BYk4tn6UoUbjHBih0YrjZa4Kh9ac61DTu2IPio0Fgmec2AhOh/fQsnytFd9/e6VLs2UeMRZc4r93MbAyyoiKOj5rTR3khUZMXI++CSV7Y/oImaxHhlP/siCj2iJmyGWcekbh6wl4ag== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM0PR03MB5076.eurprd03.prod.outlook.com (2603:10a6:208:101::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Sat, 5 Feb 2022 21:58:30 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22%6]) with mapi id 15.20.4951.018; Sat, 5 Feb 2022 21:58:30 +0000 Message-ID: Date: Sat, 5 Feb 2022 22:58:28 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220205195304.14816-1-michael@niedermayer.cc> From: Andreas Rheinhardt In-Reply-To: X-TMN: [uHY9NPE/4lB1eBBcgROI1HrDsGH3Arwl] X-ClientProxiedBy: AS9PR06CA0045.eurprd06.prod.outlook.com (2603:10a6:20b:463::30) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <6c834649-edb2-cd30-e5b9-bdd261f62069@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f14110f5-49b2-40cd-adcb-08d9e8f2a578 X-MS-TrafficTypeDiagnostic: AM0PR03MB5076:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jomL7bjy+hewnmVfh7Bu8emLDQ9ZmDOrN96jQeAKTBMohAW3Agg3CRTXSZeTJUzcgkBDb61rw+gTfejIWmd9um82TyL1NxxCiAVh0mCsC9IEXTvQTWEeauD0HltsA5jpcJ+ICzOhAplFuwMlXcP7lTxS9z1ez9zFXbjfC1DZ1MoTDtEt174HWHA6iVkOoCiR5Jefhu0jPtW1ca4fyQc79+kBqC7Mu+DJYXH7w2x8pLqUjbS8rKmE+jvjYpCQa1IIB6tBX2bwhv43Y42H7jP4qe7taFZVoOsoxVcHxVHYebtkkJWbXuQ0p9F3IkAl7F5KB+MYU7if6irL56Pu1el7UitaDvhWhNryQj9TuTO2bHJxsJW4L68HuLKIO7aB/flyyXI0WXX09UDL6YGXkIRvuwpXtiXQl6NbMnhueBMwWE6n69eRiav/CFs83XF9/Arq3c4tFrldW+Gnb3/E1RAHoZkGt/rIcV3uWcLnuV3f9jqGXVwIArCq0gKyxKTyvEICH8Il+5Cc8zaPPS51mIhHJHw8DgnpAU9c/lO3lhUi/v4mee78mlepeUXrzHiPwiL2y8aFnd18h6OswjIJBPN8ehBrhCMjuiCnzFApK8YVyFlajjQ5NcXFjj7E2ydOOpWT X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWlYTDQ5WVh1Z3NhYmFsWkl3a09DMlZ1WDJ5eVNxTTFGMVpnVnRSdVh1YzhD?= =?utf-8?B?WVdZbGp4RmZ4U1pQcm1pTTRhc1c4Tktaa3AzczNQcU8rYklZaFZXdGQzQU9Z?= =?utf-8?B?ZU1CN0NXY3g3ZEJHYWNGNlVzWjFscExIbmxob1RnTThodzNkblFIU0hHWjRL?= =?utf-8?B?WkFBdzhJRTRLYm5MUFgvZERsSFEyWlhtUTdlckxwZGdJaDR2aUNhSjgwbmJ6?= =?utf-8?B?MG9WS3UrWUVXdUluUCtxVytaTWN6ZXlhdkVIOUVXTldOOFVWaWlUdUdKSS80?= =?utf-8?B?elhGbFBoeDRuNUtwRE5Ed3RuU0thaFZmVWd5U05oSVhjMUpIK0dXeitlUjZt?= =?utf-8?B?R2duQTUzTGhrdUNIU082OXNCcElFQyt6a3dKL0lOd2lmd204eFQyVkJtbFRz?= =?utf-8?B?Wmh2UHROWVFySGduajR6ZEJUOTROOXJVSnhBZjdjaEhtWGlGeWwySDJFVFJZ?= =?utf-8?B?Z1ZUN3BXNDl1REZVYUt5Slg5S213bTUwZXZabTFBeXg1d21KOENpY1lrWitv?= =?utf-8?B?MW9qS2xqUWltanBjUTdlN1RBbGRsb1VXWStmaStyZEtBeG5kMkJvdGhKKzdi?= =?utf-8?B?NHlLK3I3bFJJQXhtZTZ4dm9hTU1OeGFsOVlHeHdScThmaXMvSkc3c2ZzNGxa?= =?utf-8?B?NkdsQkUzSXFrMHUySkx4djBxWXAxMGFJSUUzT0Q4VVlvUXAzdk5wc1RVeUlM?= =?utf-8?B?RGJNZitRU2t5MUdIN2RVcVNBcUpHak9qWG9pc1NwNDhLUWdmSUFGNmRjTHly?= =?utf-8?B?aGVZcUsxZ3NnUS9oeWlCb096cmJJU3huMDc1eGpRWExSTGhzeTVVc1JKR0Nh?= =?utf-8?B?c1plSW5PYmRCemtrbk40R0xDUURJMlJjUlZ3UTEvNXNsbTF2ZmpkVEdpWEto?= =?utf-8?B?dGUxQXpZQmNBZ0g4MDlJNjE5bFcwUDZ4K2VNcGFmMk5rMFQ4c2JIQjVyZGph?= =?utf-8?B?Y3ZUOEIybXNaZGNhUGJBYVl3UmZJZE9XU1VKamkzRHRBK3Z0bG1JYloxYVRD?= =?utf-8?B?Rk9vTE5EZnBKcUFoNiswdThhbXVVZEZXTk01UDJ1Mzdmb3pMSytoOC8zRFA1?= =?utf-8?B?YWxrWFMrVzF1OUt1RzAvOG9IcE5tdGRZMnNJQjVLMGUwWVJmRTYvMTdQMDhU?= =?utf-8?B?bFI1cVdMQUVRVXkrSW55TEtudXBsVEMxdUZBcC9NUGV2Ulg3cDd0NFBDV2ps?= =?utf-8?B?Q2pZamZyZmhSd2Nyc3JnSk45U09QZnBCcG5IMzhqbDdVRWFRQkJZSnZralpH?= =?utf-8?B?YWw5cko1V2ptN0NsdEkzZ1hySGptRTdDaWdOUXRuWGZKbWZQZz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f14110f5-49b2-40cd-adcb-08d9e8f2a578 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2022 21:58:30.6920 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB5076 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/matroskadec: Check desc_bytes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Michael Niedermayer: >> Fixes: Division by 0 >> Fixes: 44035/clusterfuzz-testcase-minimized-ffmpeg_dem_WEBM_DASH_MANIFEST_fuzzer-4826721386364928 >> >> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >> Signed-off-by: Michael Niedermayer >> --- >> libavformat/matroskadec.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c >> index 5a9acfb247..f433391a16 100644 >> --- a/libavformat/matroskadec.c >> +++ b/libavformat/matroskadec.c >> @@ -4216,6 +4216,8 @@ static int64_t webm_dash_manifest_compute_bandwidth(AVFormatContext *s, int64_t >> do { >> int64_t desc_bytes = desc_end.end_offset - desc_beg.start_offset; >> int64_t desc_ns = desc_end.end_time_ns - desc_beg.start_time_ns; >> + if (desc_bytes <= 0) >> + return -1; >> double desc_sec = desc_ns / nano_seconds_per_second; >> double calc_bits_per_second = (desc_bytes * 8) / desc_sec; >> > > This should give a declaration-after-statement error. > s/error/warning/ - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".