From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 970C640F8F for ; Fri, 11 Feb 2022 12:55:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D3F9A68B1FD; Fri, 11 Feb 2022 14:55:53 +0200 (EET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-oln040092075109.outbound.protection.outlook.com [40.92.75.109]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6CA2D68AFF5 for ; Fri, 11 Feb 2022 14:55:47 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iPnkmVnjsT7477p1tN9E+AhGA0wTsFq+tzXd3pN23Kku1ubAEMZr+0+0Vg2D7jqDLTsycTh3vyJcuzQ998tp/PkfcfvJronvbTMQwkyUguK9ylLbfEfaUOdtO4lEB0X44eh3uhGB0QDvmU0KTFd547mk9+YXzYZRWHFpC5rNHDJGB6Q7nzqTtpb7TjBZeyt43fPRy4towr2ocdwJrBFn6TxJg8p4is1Y6XoKZ09qXSOUFEPNIYjHkpnVkTHCLGZH7zyB8XBTSb6/xhAum3V33ivzCjlvJL24EhwCuNfnEqq8Q2beidxOb6z5Zv2TGufAQYgpBfS/n8Wn/3xgypb47A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dd1UBkDePL8Xp/LlgT7iA+fBDI+CpZuJUX+FFJ0J6Mg=; b=GZFA7YHKBXcxn2vu10CZGAlAu9MIAVotAKnJKgAhZWB1GnNR3rWyHBDI5j5P7Co7BGnZZ2y5eRuyFdcw/RJ7wX1TGbcVzXFNqqyj5YON6fMCjKbIlJZBJ9FS4K1XMzdHhHopxWov0TSj0c1xoBZm0q8VhoxErZ/a++SZxHhflwKlKt6v7GGHn+QwODeEXjTqksWF35J24FTy5oXLYH3Vdp57rhkM+0O/W2HP2Q/8oU00BzAVhW6PenCcQaijguUh9mlQOT9VDEjmrgWztMCS8CQ4s7lK1QMdF9d/+Ew4Jx06ArWvaR8ys2UY675P/i2fqOmMa8YcudF+XTx+Mul4rA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dd1UBkDePL8Xp/LlgT7iA+fBDI+CpZuJUX+FFJ0J6Mg=; b=ltl6ywjk9hNP9NW4Tx+7z2xp9CFoalgHyihLf/wkJ+z7GYXFh0Ws4x0YyNGuNO4ue9TYV67Lx6w3iKxTDS9D5iw3tSGCmAiNDNjb9hRyyTATsWd+uSNV5ae4KWSptCGzfc4Y2fLq+C8rssqy4M4bni30irKyW2IBYdk+F6teJVkSNAFAATYJaMx1XkJu4FIBX+TWa/ueirIQ5DnR3/0vBPH03mCrcITcg6EPZqH4geOWT5oXO5ExixmX6Hqyl1WTWKKIouja4rjvPdP0hGdZ72RpIZToITCxJtIQDV7WAIPhMd7lh7lE4setjsg2A+zWN2dS0HpWA+W/VBzAFAnE0g== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by PA4PR03MB6800.eurprd03.prod.outlook.com (2603:10a6:102:eb::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Fri, 11 Feb 2022 12:55:45 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22%5]) with mapi id 15.20.4975.011; Fri, 11 Feb 2022 12:55:45 +0000 Message-ID: Date: Fri, 11 Feb 2022 13:55:44 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220211125155.11643-1-lq@chinaffmpeg.org> From: Andreas Rheinhardt In-Reply-To: <20220211125155.11643-1-lq@chinaffmpeg.org> X-TMN: [+HeR9IQcz/m5ObhxGTrZxaIqsnZbsodp] X-ClientProxiedBy: AS8PR04CA0064.eurprd04.prod.outlook.com (2603:10a6:20b:313::9) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c32cf975-51cb-4960-1a64-08d9ed5dd1aa X-MS-TrafficTypeDiagnostic: PA4PR03MB6800:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: laxf1xVLTLyfwcYIkhQwMgKsqz6Pj4yDjeEdmnJpuPIlX+zdfdMMUAg7p4ltmYUf8LR+rhOOABtIUDI+J+NokuNLZSOzIXFlozb6W9o8HPKNnSCRWhGDmuvbmmJJnnpWPx7eZbmjQn6aDzlGr2BuH8RCscKb4I1fLY3XGxGvzFFIgZEna32N7CBpjUaVBo7iupBbUt7ITSEb7kCpBY5ftdJkpePZ+iLGstD0ObHZ4RIGvDv2Mg7Os1wozoO7Hb/cxYWasj4FUOknpHD/UjfrB/Q1gIA1R7KjQFLvb0yTn2FOguOr9zyFpAnoIQlFwAzlVpL6Gw7U1O3+E/ep8qPbxQDvG7RiVpq5qCJCW6JNKEv1oiqdk1MCj5nSxRHIOH4BAyjzvM3eUAaT6oiVXu8tebruFEQET31oJBBX5CDSiA2tdYo9TuNbdx0jCFEHXGH6Ho6+qEdMWor/AbOxpx8HD3bNKTqmz1ePjJmYbUIHW/h/4iih7zvc6aThRcJJVhhUe8Pa2KVJ08Zjxtu3h3kqM+6yOReBbRPb7pg0+WdKMXdxANHiwGEFysyTplNZ97YSK68LyBApOahRs5VPa/+EZQB2+Rmi+5Z7d9G8+FaQNy+ZWSqrFSh8oAr2XZ86H2/z X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OU9OSUNyKzY4bjdVMEhHRmoxQklxYk14RGthNVZuWDdPYzNUTHp5NGxGalhw?= =?utf-8?B?SXR0V1JhRzJlNTJTRmFQVEJ2U1pyU0M5NGttais4OWhNelhmZTcvVVl4YzJY?= =?utf-8?B?Tlh4bW5Jemd4eGZCVVQyZFRoNkFmeWEwelRsNk9obWM2dkRQdUtDU0JWb2VO?= =?utf-8?B?MjcwUklHOFdhNWVFOUlQaTIzTTF4eGVmVU0ybG5OWURYVUtqRFNreWZ4YStv?= =?utf-8?B?blhGT2NRaElFa0VxUERUVk50WE5aMzJZYVVjaFR0SFhqMVovaFp1eVU5dVJF?= =?utf-8?B?azduZEdSa1h4NFVPT25pQnVkK2hlSmdrMEF4WEFtbmJZZ1B0TGUrSTRZZ1ho?= =?utf-8?B?dWF6TG50MXB6aDJpR2xzT0ErcUdyN0REK1FpM3R4Z24xSWI1MjJFbFIwVGdZ?= =?utf-8?B?SXdKRDlBWEpyUTBBcDIwdGFZK1BFZC9manE0N1VqdHBKM0VrR2lrUC8zNzdv?= =?utf-8?B?MkNFYkFaL3hheVFkN1I3eHJHTlUrblVWaURuUzNCM2JsSS9iaE1scjhydUd2?= =?utf-8?B?MS9ucGlXdzRLK0dXM3hWWTI4ZVBxcTV1UHJJMDhNTGZNVlVMSHg2aWVnWm5l?= =?utf-8?B?YzdLQ0hxSENBQzJLZ2c1dEN6UzlUK0RCdEFUSVlzZ3ZzcXZKVVk0dmw0V21B?= =?utf-8?B?Rjlkc21tY0x4bDRGb0drVzR3NlZLQU9zNnRlQWg0S3ltbFNPMnRxa0NCNzFK?= =?utf-8?B?OGpaMnZSUTBZVDFVZlRIbEdqL0MxeFNNbHZrVzRmWllTU1hiMnQwcFFsajVO?= =?utf-8?B?Rk9lRWVKWjIzOFNyeUMwTEMvNTkrc3dBaTJxSS9aOWlNeU1ES3NSUlAza2pi?= =?utf-8?B?SlI3NTZaZlFiWWw3VUpLYWVYZDZIMldGZ0paaUFRWXZsUE5BMUNQcjQyK29n?= =?utf-8?B?UXNqeFByVytseHRiVTdvNFZhblg0SGJtalZFV0gyY25GSE1LWkRpc2Q1R0hi?= =?utf-8?B?MU9wcTNQMkErVW05eitYTEEwWExtVUlydFM1OXp3Z1JRSC9FQlR1QzQyc1BC?= =?utf-8?B?WHJ4M3l2OGx3NEs2L09XelY1S2pWRUNyVVFITDdSWnNneDF2Y2c3Z0hRTWd1?= =?utf-8?B?UjZyRkx4T1haOWxQbjRudUVuN3VhenZ0MTNvR3pTV3NqdWl4UUJmT3o0MVVS?= =?utf-8?B?ZGpxY3ZtSURINEVDT3gxY3FMZmVpeXpKQityK1JnYzNOUzJXYzV4UkNSL29C?= =?utf-8?B?Y3Fsd29pdWZKdzhIUGJaY2RPNHJ2Q1RZS2ZuQmZSODZ5eERkZXZZSk1SNFVJ?= =?utf-8?B?R2FndmFEMzZUU2xWYklhalBNckJGTzczNEp1U3pTZFNVMnNGQT09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c32cf975-51cb-4960-1a64-08d9ed5dd1aa X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 12:55:45.7462 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB6800 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/vp6: Check alpha_context for allocation failures X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Steven Liu: > Fixes: null pointer dereference > > Reported-by: TOTE Robot > Signed-off-by: Steven Liu > --- > libavcodec/vp6.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/vp6.c b/libavcodec/vp6.c > index d024370793..7ddabbff80 100644 > --- a/libavcodec/vp6.c > +++ b/libavcodec/vp6.c > @@ -653,6 +653,8 @@ static av_cold int vp6_decode_init(AVCodecContext *avctx) > > if (s->has_alpha) { > s->alpha_context = av_mallocz(sizeof(VP56Context)); > + if (!s->alpha_context) > + return AVERROR(ENOMEM); > ff_vp56_init_context(avctx, s->alpha_context, > s->flip == -1, s->has_alpha); > ff_vp6dsp_init(&s->alpha_context->vp56dsp); Already fixed by https://ffmpeg.org/pipermail/ffmpeg-devel/2022-February/292714.html (pushed as c4d63dbc9417ddf77f6e33f6144b23da7e97cb3b). Furthermore, your patch would leak in case of allocation failure. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".