From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 56065402B5 for ; Fri, 21 Jan 2022 01:31:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D076868B233; Fri, 21 Jan 2022 03:31:31 +0200 (EET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-oln040092069070.outbound.protection.outlook.com [40.92.69.70]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6336868B1F7 for ; Fri, 21 Jan 2022 03:31:25 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UtOwQPT+fjBPYS/IMWr2mnHy0JhhdOzoowne7/MGEUub9cvvK5ouZMJYSwI0rn/DfM738EMTvWsVrNe0KWQVzPFaELQOmNUcqbMt1S4LPQQHar8Lvp04Cpzfb4reI04Oy9aJycXeT6wF+83C2GByDklHX/I6pzSWsKfL2PhktWSXgxG7nDWT/RJZpTSQ9GikS7OnNW0xIIwxT81NQ31hwU3JbWQTgcmS+uAB7UwBJZrLA6uQE/S1eGrcrtkvEZ5cINK2n08+SNGccwEwZY0fuBEWR/o1Gi2eQ7ris/lWa3mS41wBd1eIQgReqzju9bPrvXkL5USglJTIZUq/AejofQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AuuABHnrwzuMcma/J4hy1diuESuliJM657clMid9YgM=; b=gJCYfVv9zhjUr4D7JdVlttn19KB+xhW30fg0hf+ig5f8mkAuWy+JU5vWCyDi1fvpR6PEhxL55psKDNNLd3yJjuUnvKUk9A3sHqXa2+KQUOsAnz4Dzm21zMjBHIF2SklxXBXGVef7dmUab2qK7PdK/PTQQSBTGMUdgGstAEG0USwIpHGKpelUBZueU+C7oqTewaqQA5rwNmjNLDJ28zn/4mj9Do4ycoEIDgNSnTFUy+4go7B13hTqfY9rUG0FzZq6oUOnyc8Mmteo5D32xDTkaj7JIQMW7uJITiVeMcHmAlt3NIxh8J7KKhcvDQJ6kxY0a0jqR7qdIiqfg86b8FvYgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AuuABHnrwzuMcma/J4hy1diuESuliJM657clMid9YgM=; b=HnHWR/nuo97UK2SFRXj7n6EXl3NsZlEuM/ho8QNEwc5Q9kQVVjExxxrZkTtpvAyUB9hqpeJmoBcWkguaohIul5OrAf8/Kkji+GZ8LDWf8b9i6azTgMl2bhwRm8/dW3REnyTlEk1v3xrJf1V3GO2yKk7UqYHuO3D6BK13oX0r/en60qDR/uFcF1L0B4ZjPg3NoNQ6hBgWGv/MPBAoNDs+QTxpdOhYY4E8FUxhV5nUT/dTa2oWE1TlUdfJh5awrgA0JWonOR7LoJEBEgBDxcVPQwMJawMtwtRiJ+P43t4cz3kG4dugRp/XnRm0mqCuA43zlgUPYA6bbLqe7vhzG9x03g== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM6PR03MB5139.eurprd03.prod.outlook.com (2603:10a6:20b:d2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.10; Fri, 21 Jan 2022 01:31:23 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5%9]) with mapi id 15.20.4909.008; Fri, 21 Jan 2022 01:31:23 +0000 Message-ID: Date: Fri, 21 Jan 2022 02:31:22 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [kr1sSi9yLm5TFWU/tdA2qlaUI//p9LUl] X-ClientProxiedBy: AS9PR06CA0312.eurprd06.prod.outlook.com (2603:10a6:20b:45b::21) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 89b81a52-85d4-4b44-77d9-08d9dc7dbc18 X-MS-TrafficTypeDiagnostic: AM6PR03MB5139:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5RvS4UBv24/8atxMvQeeXnE5BVX/tvoIXLhW1IUjYjE++OzqQjpWNjazOAX71gxj/wyjEmV+FPDHS0F7D+Z7LNi1I7K3FpxQ0fVpCaQX3hadsei5UmYZSmvo1S6ewCogkrcUt3J4pkCmePZC9kJPcXNqdAQzfEBhpgWK3vDhaT8Mvy7lA2/VKQVKQEKKhj+CA7NMIM3BzXrGfCvd2nOnQ9HuIwfH282wG5ThUbazHDCU/g2er5JLjuxJVIkRbbM+bN9XIO68azxgGU48p5tO3yVu3M5xoQ2ySjwgczNZGTKtGJuIkOQvZ4Nys0hL7vPsA/A21ofzha+aK9E+CWQWUmpMCjnLCii22JWN7PVeTJDZBGfvYA1QZP5hh/BjFFuz9ovm+xUShCdnkEPjVj9XcM+GxbLI/vA8MvSkShGb/B8crHckzEUAHUAoL8oyMdxl/BE8o16T7TFg1KUJfIAWPdUsZuFebywXlLrPaSzvcjddf1oMzE/f0EvoLtgFTRAyt9VpTeKeiXF4oqt37lhdFkTMHVxFa/HBed5Mwj0fLYUKFEcOUwMNaYnrQnKVynN10/utUWze1nt7yyiQkNoRRk4MAqqDQNc1WO6Ur6Q4CaEUaO1vAZZWu82/bV/Vj3xhQk/V2bydvQ2GVqMWwc2w30uy/DN47Vnv8HmjR1uA+MA= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWRYUDl4RkNKRjdyMlB6enVZVUVTSnB6TnNrQTdKa2JQUkV4eGliaFJGclpx?= =?utf-8?B?WWFrZVJ4bnVOcXZRTDg0T2lXeE5uNlFSVy9kU3JmSk1UWVdzRlZDeVY4WW1o?= =?utf-8?B?VDBRVlRtNlpyMENXeUFzYnRyOGN2YVB4QWQ2MCtNdnBtMFQzOVNQcG9zQTN0?= =?utf-8?B?cGpQNUNHVUFtWkJ6QlpRZS93RG9vQVlheWNmTUtyR3Z4Tm5wSWgrOExXTlBU?= =?utf-8?B?S0xlTEc1NG5MU0g4QUpjQlhtMGh3M054VmJiVFJPV0xoODBuTi9XMEtWRksw?= =?utf-8?B?emdSSVlJcFN1L2tuRGJWcG5HTzFQUUtKcjY2enN6REpRK3NVcllqVXIzaFgw?= =?utf-8?B?VzJUSXQwWW5QeStjaG5Ca2FPczV4cUNUbk50aE5MdjBpY1pBc21JajJ2MVBH?= =?utf-8?B?MVJ4OUtmQm9WVlM2WU0xd2V3cHpWK1hSUWU3MFI3a1JjUU9EWmJoa1pRMHdF?= =?utf-8?B?NEptbmVSeU5RbS96cm16NUtXN08wVjd0U0xjZG01NTJzbTlzdUx6ZWlQRGZr?= =?utf-8?B?WW0wYzBaeUZ3cWNMaTJJRWRNeUpzRDRHNk1BeWFaUXlWR1ZGNEQ3VEpSczRO?= =?utf-8?B?OWlEZnc1eXg3ZFV6TXJwUytiZnJqVjdwcmtndlFVL3pSZVIyeE5tQXZveVI2?= =?utf-8?B?QVdZaWlNd3NrVmUybSt5ZjU5RUZsNk02czBQUTJQWVRpTG9yS1hIaHF1bHd3?= =?utf-8?B?M1hYendYbTJDYW1IRGg3TDBBdXNVNXBkRWhkSFdVRWlrNlkyaGNwdG1xc2hS?= =?utf-8?B?aEVpM1JUZUczS3hWeTByLzF2YnIrWUJaUWJ0ejBUa1VGbzVHTXVKVjFJSDhT?= =?utf-8?B?SlZiZzNXMm9wZks4cUZXZDZQcFFPcjBySGZnTXJkUDNxNzlLLzlRM1daNXha?= =?utf-8?B?dmZKT2RQdlk1ZFNjdFBITzJMZm9NNGxicXMzbjNIemcxelZYSjlSekk1c2pG?= =?utf-8?B?bUVsUUZaT1BjZjkrL0wvaGtRQzdUNHFrWTMyMWFHRlNqeTFmOXBSU3M3RkVP?= =?utf-8?B?dGVXZjdFcVJMZTMrYmV5aWRmcmsvTXh5NndIMURuSUYrWWM3WkNBYTJ0Yy9F?= =?utf-8?B?aDFxU1FXcUtnanJKRDEzTE8zMkxydlRMdGFqdnU5QktReTlPNjlEUllVQ3Vr?= =?utf-8?B?c3RvRVFhZzVaNHFaZjZmREt1MU5QbEllOTBJWWljRGVvWnhYdFg2elJ4SC9K?= =?utf-8?B?V0tNbFoxaDg0UTI5ZlpHY0I5alB6VVQ1Ujd0b1FiaGYwSncxU0wwWm05M2Vo?= =?utf-8?B?WU9ocGdsalpHYytYei9wVUFVbEM4dVZ4ZnFJdE14RGpYSUJYUT09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89b81a52-85d4-4b44-77d9-08d9dc7dbc18 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2022 01:31:23.7346 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB5139 Subject: Re: [FFmpeg-devel] Patchwork FATE Errors X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Soft Works: > > >> -----Original Message----- >> From: ffmpeg-devel On Behalf Of Andreas >> Rheinhardt >> Sent: Thursday, January 20, 2022 11:38 PM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] Patchwork FATE Errors >> >> Soft Works: >>> >>> >>>> -----Original Message----- >>>> From: ffmpeg-devel On Behalf Of Andreas >>>> Rheinhardt >>>> Sent: Thursday, January 20, 2022 10:22 PM >>>> To: ffmpeg-devel@ffmpeg.org >>>> Subject: Re: [FFmpeg-devel] Patchwork FATE Errors >>>> >>>> Soft Works: >>>>> >>>>> andriy/make_fate_ppc >>>>> >>>>> => Does it possibly need 'make fate-rsync'? >>>>> >>>> >>>> No. The test does not rely on need samples; >>> >>> It was just a very quick guess, because yesterday I rebased and >>> saw the test matroska-dovi-write-config7 failing which was fixed >>> after fate-rsync - that's why I though it might be the same reason >>> (with make -jX, it's probably not deterministic, which test will >>> fail first). >>> >>> >>>> and the other test that uses >>>> this sample works fine. Some time ago, someone else wrote FATE tests for >>>> AVDOVIDecoderConfigurationRecord in Matroska >>>> (https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220101165153.440729- >> 6- >>>> tcChlisop0@gmail.com/). >>>> These were faulty and one of them relied on a sample that has apparently >>>> never been uploaded (but this test is actually redundant with the other >>>> test), so I investigated and saw that the test (presumably >>>> unintentially) reencoded audio, so I switched it to a pure copy test and >>>> applied it, believing that codec-copy tests could not possibly for some >>>> arches. That was a mistake and I am deeply sorry for this mess. >>> >>> Nevermind - things happen.. >>> >>> >>> BTW, I was thinking about submitting a patch for libavutil/tests/md5.c >>> >>> something like: >>> >>> #ifdef __GNUC__ >>> #pragma GCC diagnostic ignored "-Wdiscarded-qualifiers" >>> #endif >>> >>> #ifdef __clang__ >>> #pragma clang diagnostic ignored "-Wdiscarded-qualifiers" >>> #endif >>> >>> Would that make sense? >>> Those warnings are appearing in every single fate error output on >> patchwork, >>> possibly covering up more relevant things. >>> >> >> Instead of pragmas one should limit the volatile to those compilers >> which miscompile the code without them. >> (IMO one does not need to find the exact set of compilers that >> miscompile this; all that matters is that recent versions don't give >> warnings and old versions don't miscompile. If some compilers of medium >> age still show this warning afterwards without needing the volatile, so >> be it.) > > You mean like this? > > #if defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4 > volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849 > #else > uint8_t in[1000]; > #endif > I would not use an else branch, but only put the volatile and the comment in the #if branch. > > It was fixed in 3.5.1, so "medium age" would be 3.5.1 to 4.0.0 > Fine by me if tested. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".