From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 10FAD40BAB for ; Sat, 5 Feb 2022 02:24:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B089168B2E9; Sat, 5 Feb 2022 04:24:16 +0200 (EET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-oln040092074039.outbound.protection.outlook.com [40.92.74.39]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8880868B2C8 for ; Sat, 5 Feb 2022 04:24:09 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NOuo0O1T6r8ZSvG1gSHgMyyNfFWwdjZRiq1JXAeKABk7S5Z31fBcl824qm7WuysbSeLZDohrd7B60PVxCK6Ef2o5GCrNsDgfhg3GllYkoIec8cRH24GG/TW4gXaCf95Y1++pW48jr7I9tC70p1ZxIehNfVdu3Xu9ch1YtZbFU3W6VpLY71akrD2aQi9ZMKjJNhWsxwrn35gyVNvsc2MGEEu91A60Hu83H9chGzRNEWj8nnmpxvEJstDbihf8BHJDKQtUHfb8f63avsiJ9dBpgLKj8j5JfqqsBUQUt/4tHHcry68p2IRAksiUddmQYK3b49X+blXZ2MhImwOSU/UurQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V/Tz8nFdb9OCCK27h2S73Fme2ptTIvLfxHNTnDlYswk=; b=Z9i/vSNDwZG4kjRN0rVK4hG8lIwRKldisFyB0ZQJ+a0rjccdihW4Cd6QHv81T1ZgUom0igzWofLcDdfm1k16M6QAgdZipU01lVdKB+VcJ1ExxMFCDZuQ84Pfs0t+ochzWyu4Q71AwXH5JkShdbib4Ctibq//ld7jnTstI+MKtBWvj5zuZE5uxhi74hbozlzElm5EhbNoH+lTdYp+fPXYjeN/hTYBDx1/Tfv9CIOqk4DaVi6yxrQkcbQh3K51sq9yAoXEIn305J1e3fSNIZGpvx6OwfUgx0hZKF9GbOkD8hzr/vKoDpbskZf4IPhzX31wGwknEKCbNdZaB4pu5gudVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V/Tz8nFdb9OCCK27h2S73Fme2ptTIvLfxHNTnDlYswk=; b=TiSxd4Q7DeqAh4XXD1DZzZAg9Njtiqf58TvCqd+RM5+huRs1oA/0OWy/60zvrLMwflY6Hnp7nuNKDXBVFeyRw4FN/PzB5ht8MUKp/q8gEaSpabUIQxriDUyQVCZeGJh6NpVOzLaPBn/serFV82wALJbOiU5lNi56YcqmdJMDBpNq4PY6iWYv00hxbj+h1+nnTYNuDJy0A2gK1Fqmtg7JbQ5wyZz02KaoJ4fw/jldCjYn+iWojCDjcTSZziMG7uyobMz87iGrIdQ+z9SsNCSKklT2K6uZ/iuQExtpJMHZsREa1QNltnMgz0vyGyIsCA6YY8PoHOvpCPAtgsnBTitBrQ== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by HE1PR0302MB2811.eurprd03.prod.outlook.com (2603:10a6:3:ec::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Sat, 5 Feb 2022 02:24:07 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22%5]) with mapi id 15.20.4951.014; Sat, 5 Feb 2022 02:24:06 +0000 Message-ID: Date: Sat, 5 Feb 2022 03:24:05 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220201212056.29712-1-scott.the.elm@gmail.com> <20220203184450.5491-1-scott.the.elm@gmail.com> <20220203184450.5491-13-scott.the.elm@gmail.com> From: Andreas Rheinhardt In-Reply-To: <20220203184450.5491-13-scott.the.elm@gmail.com> X-TMN: [dw10L+RWJQG7HxTrfuFRZ1BcCn+k/n+r] X-ClientProxiedBy: AM5PR0701CA0060.eurprd07.prod.outlook.com (2603:10a6:203:2::22) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <7c47492d-5c5e-f1a2-7378-25f1e287debb@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4a54130f-337f-4fe6-e575-08d9e84e95b7 X-MS-TrafficTypeDiagnostic: HE1PR0302MB2811:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z+0a9vLbTy3Hfmgr2p8aqtDGFS/dCuSQINUTbu9MfCLyMHNihA+aDD+ABH6n/vL9btVlf29U52V6Kd6ww6ENVVg78aVMiZOBfsrSVi/Tif9dQdoYQSDMe56xqGKPRpJlCqihYhf7cXG5Dl7vrqCw/cGyrIBnPWiWZJb2LFHcs1z590xbdVDItBxA6dpTybdolcQL62plYYTz/UIqp6pooj1iHqTsnu/kA4Aur6dsp0/oiWw7ziOgCdNbwnmuxcdIdtbMhxEgqHSuE2jEx+nnrkxTqzoE3mYg34tseor0COUnyqOJyPdaH0Anfz/4czBSsYAqiC+BWa/eLyqo5LK+2KGB/gIUUMsWKKWAlWKO1RZbKrKQ41+GdraUWSqotwF2L54A0IGifvvh2zIE+10tO1KkrDwJ8x3dWYdQUuQJtvoSntwoVrz6HKAUGa4T26n8MJY+kwdCI4CHOmj7nHBpl6OEDt0mZS0cEFsBw+d2oF40oG21x3BQDcOSYUOk64knQ+4H3JhOQZ7EvMSIBXM1DGo5ln05h0fl/n+iHMdL1t/1uKll6fK05saaMz4X3HzVodyA29Orhs4guRbQO2/ARA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHBrY3JFVjgzTzAwQWFwYTRoUldVcVVhcmZsSEZWT0FBbU9YWWpKYWZ2Szlx?= =?utf-8?B?QnJTemdYaUJLVHVaRVUwckppVzNHY0lZbHFGbWxKaDdnbEFZNGxKWEk4d1ds?= =?utf-8?B?eXlBMVVnN3pYUUJZUVJBYjgrcnBSMTQ5VFZTQWhIN1czMmg2R0xuQnRCbk5V?= =?utf-8?B?ZTlvZEc2WURNNHUvdmtmNnMraHQydWRkRzVNVjdhTmpmSnlmUHlOMFo5WlJt?= =?utf-8?B?U3hMYkRJTnJDQ0tJSyt2a1RRcjNkMXdoWEVoSDZXSWVWb2pjRDRzWXVESDcy?= =?utf-8?B?Z0Z5cTd4S3RIQThJODloMVdmbDgyM0kzSWlIaTNiWEYwZjRVRDFINFNOTnVu?= =?utf-8?B?OTVaN2VOQVl0L3ErRmxNQzIvVmhUWFpXUTM0cmJxM3NGSnRYWFlmZFdweFYx?= =?utf-8?B?TmxCM2pXTWRBamVua2xnL1ZHbEdCNVpUeEQzbTQvUUxSYmdrOFhWcy9lNTRj?= =?utf-8?B?SGFzMnN0NkFNNFhtWG1yKzEvNGZKYXlKM1hDVTJ6aU1KdkJ5L2pLSVR3NjVR?= =?utf-8?B?S2dEL2I4WjdNY1lPZ3h2VjRMVWZNTGcrcUNCbkhra2ZYZkVJYkZtTnBsSWxB?= =?utf-8?B?YTFHRjhKRUxXWFd2Y1lHbU1iZ3U2eE9EMXVpUGZteWpESUczQ1o0Y0UwaWVx?= =?utf-8?B?WmIrdXVaaldBSWNuUE1qdDRTRGJFbWpLL01EZWtiUk41bTdnOVAwUjRHS0lF?= =?utf-8?B?Y0dOcGFVZFRvT3pDTkVlMzRlRzFOUkEzWTlzTkdYNjNMcDBZQS8wNytlcTBP?= =?utf-8?B?Q1hmVjU3UWg4WGtPd2p2QmpYRnRKdzNaU20vaHZXRk5mVUNQSDN3YkJjMGxw?= =?utf-8?B?bjhLc1Fjdk8wTFJPVlNXMkRSNS9IZGRwNUdHVXAzZ0hvZFJTVVMyY3UwYm1n?= =?utf-8?B?VWZYMng2QUdxeXQ4ZFBQMDRxVXhmbFluUnRFdllVclJlQ0duNStBMmxjTmJC?= =?utf-8?B?dFNPR1M0TDBpK01ZYXFyWWxZSDZFdy9TNGFJMTlZanh5ak13dUdvd3o0RnVV?= =?utf-8?B?cXFsZVJzc3BHRWttM0tqUWExQkJ0RW04dnhyNTJKVGlvNXdPeWVTa0FDT014?= =?utf-8?B?YkR0L2Nxdm5JZGNaNWQzVnRVTVlVZGtkNkFmbEs5NWRuV3dycVBPMFc1eSth?= =?utf-8?B?QzF5WUV5eGJWaW01RTZFdHdKaWd0N2xCRFJ1MHpKMDE5ajhXaUVOcStlS0RJ?= =?utf-8?B?bUQvMzlKNzlDNUVYK1NoMlJSRithVS9aMGcyK1NCUXBwMTJtankwQXRqOVVN?= =?utf-8?B?bnR1a1ZPNk15dGJZWGtqSUJ2S0lyWkxXRHFRSWNUZHZ5RmVhZz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a54130f-337f-4fe6-e575-08d9e84e95b7 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2022 02:24:06.7991 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0302MB2811 Subject: Re: [FFmpeg-devel] [PATCH v2 12/13] cbs_mpeg2.c: improve readability of start code search (part 2) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Scott Theisen: > If the last four bytes form a valid start code, the loop would run another time. > Since (start == buf_end), start_code is invalidated so the loop terminates. > > However, calling avpriv_find_start_code() with p == end, it will immediately > return due to the zero size buffer. Thus the history is not needed. > --- > libavcodec/cbs_mpeg2.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/cbs_mpeg2.c b/libavcodec/cbs_mpeg2.c > index f2efedde5d..bf95fb7546 100644 > --- a/libavcodec/cbs_mpeg2.c > +++ b/libavcodec/cbs_mpeg2.c > @@ -168,8 +168,9 @@ static int cbs_mpeg2_split_fragment(CodedBitstreamContext *ctx, > // the next unit will be treated as the last unit. > start_code = 0; > } > - > - end = avpriv_find_start_code(start, buf_end, &start_code, 0); > + else { > + end = avpriv_find_start_code(start, buf_end, &start_code, 1); > + } > start--; > // decrement so start points to the byte containing the start_code_identifier > // (may be the last byte of fragment->data); end points to the byte end is now uninitialized in case of a unit consisting solely of a Sequence End. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".