Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp3: Don't output bogus warning

[Andreas Rheinhardt <andreas.rheinhardt@outlook.com>]

Andreas Rheinhardt:
> It is perfectly fine to have from one to seven bits left
> at the end of parsing.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/vp3.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c
> index 5b9ba60f49..791e531862 100644
> --- a/libavcodec/vp3.c
> +++ b/libavcodec/vp3.c
> @@ -3149,10 +3149,10 @@ static av_cold int theora_decode_init(AVCodecContext *avctx)
>                     "Unknown Theora config packet: %d\n", ptype & ~0x80);
>              break;
>          }
> -        if (ptype != 0x81 && 8 * header_len[i] != get_bits_count(&gb))
> +        if (ptype != 0x81 && get_bits_left(&gb) >= 8U)
>              av_log(avctx, AV_LOG_WARNING,
>                     "%d bits left in packet %X\n",
> -                   8 * header_len[i] - get_bits_count(&gb), ptype);
> +                   get_bits_left(&gb), ptype);
>          if (s->theora < 0x030200)
>              break;
>      }
> 

Will apply this patchset tomorrow unless there are objections.

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".