From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C235F42859 for ; Sat, 8 Jan 2022 13:08:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BD8FE68AA64; Sat, 8 Jan 2022 15:08:16 +0200 (EET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-oln040092074095.outbound.protection.outlook.com [40.92.74.95]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8E02F680576 for ; Sat, 8 Jan 2022 15:08:10 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DftA98ciZEl1U78lt2RnkOCefIT7bwXenlS6xctoeYti6wOeXypKnDswiN2L6b7erJfop0+GACipFfyQotfp0UHIk4dhXFd0/pyEs5CTOqdlWjK1NExHGznsRsbDO12PxIR2LXiY+LEh21BaB9yFIp+vbYMBHV8wslb7RVpRrKjnFdZjdf+FdBj1hVsvSCXjyWqNx9P9VxSl4MuWVTEYZNKFdy6aV15GzvyqRoVXjKfA9mN8yultgz3MKTQPkLEbkdAMVkLSZ8Vovfb4T6xatrxV5y/gGJRmCZsnYtNNEDnc8GeRfMBDVdzG1MAwikkDP7sjyeWNWT3I+CE1SiWm6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9rqfUNZxjVGuP2THit174eYKCKqLLqDkVfbAAFv7ApQ=; b=bchU2NIWfUK+p1SuKQPoddLffK8edKDWoYsO/iCHVIEu4EJvvXBRTyEmtMehK/VrBurElyo18/rLW9MaXW3ttZDVafLmCWtLyMJrznAtleASkCibbA8HmivNZM95uLoZ/zlLu6QjmdOjXPtXMgxVoxjupIcW9gOJjgXSDVbaTQRXPN3elEI4DKgXSHAI2QNXk4vhWgcYtGkqEfmkXxK7kaw7uAIejxa3UKKNYUHwGmjcVud3qGhPe2Af/njsHmhFor6V2gBFQCIdkNc4TqGipXYhEQQJpOM1ybGy83ZN+2jYqKtmaOm2yXxXCfUD8suslhKLpBa+9R6z+ZSVLK3xvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9rqfUNZxjVGuP2THit174eYKCKqLLqDkVfbAAFv7ApQ=; b=X4ucxQkL43SSgDQy8/GFsP2JWmO20VQ7j6djiWMom3hmmBsaSVp/NjA034jNA8Epod7+4+uBTkJP1PK7TqWD6joRRj7Xi5G2ullPML7XOTzp59XvmK8JtX8FTF/WP40fmaSfQ63yG3/H55deoFNydmEUP1kewQOOA70K+LrQ6Fvufb4JCnC0hJ6CPr9dZ6EjfmATpxWpqpiuwRqkpoY0SMfcDs5m5gYT5PKKg4Bnzqr9hJYVHsuJ6107UWia7KvVvPJo2csirhEgm4DPluQxu0rIFSH/THebrLeuvxVPG5j7QE92Cwb3sJGOoqdV/cWBV+zHG/eDVsgavueP+xhcgQ== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM6PR03MB4536.eurprd03.prod.outlook.com (2603:10a6:20b:1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.9; Sat, 8 Jan 2022 13:08:08 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5%9]) with mapi id 15.20.4867.011; Sat, 8 Jan 2022 13:08:08 +0000 Message-ID: Date: Sat, 8 Jan 2022 14:08:07 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [h5GxVRxdnq0UUYQdmUJYmEQ1efbyVztS] X-ClientProxiedBy: AM0PR06CA0144.eurprd06.prod.outlook.com (2603:10a6:208:ab::49) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <6b7cda08-9cd5-2e70-d8c6-3fe14b579aa6@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8033dba7-a4ed-4ef3-a71e-08d9d2a7eaa1 X-MS-TrafficTypeDiagnostic: AM6PR03MB4536:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IH0mQ8HbUQoIvrChwURTEA1N63aqwzcf5FmRrzSaT4dPSkEEUX4LSbRm67AgB2f0ciT+C3PCem7F6rqy/QTh8H/+jqS1dmpKVsLFATiQQ2aJXIu2orq5gUH0OGuFP7IITGS5pHLs+S5GmhAl3yVc4pqh6TzFiasltbSq2ofBf4IRosV2zsohZAWkrvOmwmrSDAyy9dYuNOBP2SQyrML+08nu2uBe67DSxgbGxWNin0L5i7DsCFAgTaYTH7byvkYKWcyOUyxL2L5ZAyh4O4/R2whMC+BissPB7Jt1mW0kMjzafCVsjxtAohB2uSE7AUdXHSAuAfpGEYffPlMK7UVT7UT90hMPYS9su0Q20AVqem5/sTJ9HXciFXn4bqIQUDFNGRSGd30D+yWK/9B+bO0qfCKL0+IBpS1uzgNW4iMSU+8tZnOdxQubvYfbJyGruAHZLOaZxEUM8qdT7PEgv9jLdiUCPb/KO+kIx69B410UMpdUAl21kSJmvDCTbf3PCgjYH1E2I3yAVoxHNlBHSPaD5gtntvkS2CctBmPtyzoazBEXbpKDJn84i1ZFOYrNl/Btbcunf2lumscQ0otYHK0+3w== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eEFuRmJFMGtOTC90VVg5SG5SU3VObkd5ZzF1RzBEVFFKZERTd29XUFhWSFJp?= =?utf-8?B?WHd6WUEvYzExRitIOTYrbUsySGhiaFNsMVBCUkJNaDVaQmI3VDd0cEozNkNh?= =?utf-8?B?MzBvQkNNdDUxSW9tWkttSzRvdkZCQzlYVkpSVHQ0TDkxamNXcjJzdUlLS0V2?= =?utf-8?B?S1BIK2pUM1FnK1BWMzh6ekNJQzk3ekZiSnBkeTJFR2pyaGw0N3R3aVl0WFRm?= =?utf-8?B?Ym1pSm5MZ05yMGVVd0FEbkkzMWZianhDU2xJU29VVGhtN1FmUUZwZ01iMEg4?= =?utf-8?B?TURaUEhKTUdFRzRjUEdqSmtpQzNma1Q0OGZFMEU0NlJ1Q1RUM2pjUHNpNHJi?= =?utf-8?B?Zy9RZzhpQWFzejFNRnQvTk90bTJDRkM2S2N0QUx0VTBRMlN6L1JTYkdXL0tt?= =?utf-8?B?MU5uNGF2ZS9RZHh6b004S08yMFNFL3BUQU1FM0Vpa0xJQXF1ZTkwenVUUEdq?= =?utf-8?B?SjB3UkZtSmtoZXVlR2N4T3Vkb3BOOHdXQTY1TlVwSG5pUnpVOVVUdmtYTTZx?= =?utf-8?B?d3RMTUpNQW1LYWxIaS8vVDBXYnFoSEJtamhOVmt3d3ZJZ2xkWVM2L3pSS0s2?= =?utf-8?B?T2xENmNQMlh5N3JMendESWwwd05pL0JyeWZLVEVJUFZFZ0dxOWRUMG9nRlBj?= =?utf-8?B?a1g4Y0lwck82MXlvbVlRYUE4WjN2akVxT1dwTkdCd2hyQ3d0RzMwVjdoQnJs?= =?utf-8?B?Vk5Eb0p1R0xzVkIwMFBoMStsKzZ2ZDFPSzlTM1FCejhYWjZFWm1OYWpJVmZC?= =?utf-8?B?WXN6dHpYNGdMYjQ1OGF0UGFWWnp1RGM0YWFsN29JN2l5eVdvOHlVeExIbVRw?= =?utf-8?B?aDN5ZlhUcVBLYW8vZXA0cStjd3JUTnBXYkZ3ZDYxdG9RSFZIa0xKZTVjUWFZ?= =?utf-8?B?MHV1cS9wYTZJbHByTm5IRjVGV3dvY3FkUTFsWmZpblIydEMwZ25tQ3Z6SHdK?= =?utf-8?B?dmxKcDFqOHN3RTA3ZnI1elJIOS9WQzlBUUs5NndKSFlxZ0hRZ1Y2R0pscXl4?= =?utf-8?B?VFVrS2V2V3VVOEhYY1kvdnhXTldWclpFc2x1dHJGajFQY2NwTWI4alpWUXhD?= =?utf-8?B?MXI3WGFNUlVDTXlJS2FyaVhDYnIveHl1Smw1bkZNQ1V6Zm96eTZMNmpKSmpl?= =?utf-8?B?aFNlaEpUUzNSSVlid2RDNTVFQTZNVzd4TjBHaG9TeE1DU2psem1qb2NFVHVm?= =?utf-8?B?cnl1Y3FTVkJDdGl3dTRWbTlNajJaRTM0cU1FNGNIRmZWSVJFK3hZaGdJeERC?= =?utf-8?B?a2xOTHR5TFlwWVE2TlhneGs5R3orWDhITkJIM2p3dVEyWkVEUT09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8033dba7-a4ed-4ef3-a71e-08d9d2a7eaa1 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2022 13:08:08.8876 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB4536 Subject: Re: [FFmpeg-devel] [PATCH 01/10] avcodec/mpeg12dec: Don't set write-only variable X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > MpegEncContext.picture_number is write-only for MPEG-1/2 decoding. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpeg12dec.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c > index 35dfc74fe7..6ad9fb245c 100644 > --- a/libavcodec/mpeg12dec.c > +++ b/libavcodec/mpeg12dec.c > @@ -1066,7 +1066,6 @@ static av_cold int mpeg_decode_init(AVCodecContext *avctx) > > s2->chroma_format = 1; > s->mpeg_enc_ctx_allocated = 0; > - s->mpeg_enc_ctx.picture_number = 0; > s->repeat_field = 0; > avctx->color_range = AVCOL_RANGE_MPEG; > return 0; > @@ -1092,9 +1091,6 @@ static int mpeg_decode_update_thread_context(AVCodecContext *avctx, > if (!ctx->mpeg_enc_ctx_allocated) > memcpy(s + 1, s1 + 1, sizeof(Mpeg1Context) - sizeof(MpegEncContext)); > > - if (!(s->pict_type == AV_PICTURE_TYPE_B || s->low_delay)) > - s->picture_number++; > - > return 0; > } > #endif > @@ -2072,10 +2068,7 @@ static int slice_end(AVCodecContext *avctx, AVFrame *pict) > ff_print_debug_info(s, s->current_picture_ptr, pict); > ff_mpv_export_qp_table(s, pict, s->current_picture_ptr, FF_QSCALE_TYPE_MPEG2); > } else { > - if (avctx->active_thread_type & FF_THREAD_FRAME) > - s->picture_number++; > /* latency of 1 frame for I- and P-frames */ > - /* XXX: use another variable than picture_number */ > if (s->last_picture_ptr) { > int ret = av_frame_ref(pict, s->last_picture_ptr->f); > if (ret < 0) > Will apply this patchset tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".