From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8A79240F6C for ; Fri, 11 Feb 2022 09:24:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 51ACF68B272; Fri, 11 Feb 2022 11:24:57 +0200 (EET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-oln040092064076.outbound.protection.outlook.com [40.92.64.76]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0332B68B24F for ; Fri, 11 Feb 2022 11:24:51 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HPpV/+xaBlMLlgRQpSn2XL97TaknwU6iIbBLmvSphAPN1ipeh5WsDH5K+Mo50lCf4ROIDQitcsCg9s3iN+PhW7TIrs5zjcPwzINeVUEhcAZ+kzxEZGQ+d6FXmANfXiJ96heOTF4EJfksuYYfdHk/1Dg/yoKQbwYaY5LDX8XclqTuQWdj6vCkmtq1JzpaMCF9sGEd496zViwdAorj3mDICmLO8tCYUhrJhSK3G2st8KQE+w/HYOAz9AC6J9l//ew6Ee9S3BKZ7NtDEtSiWpZII7CZrue1Xe0i+B2tt1rA9jESmsGC0N4wYZ4dslm2ASBsAXcELREBoICw7p/hzJhCfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o55io8XMmcMKlwz1FYxBMKe+1h6jd0rvPfdAgx2IuWw=; b=N2XRNPRNbdbdD1RgpF+jrF/TCCUyOxFc3wCPwZJzbgdYyq6z9BzDyztcIFZPpmRwh/rOrbxYQRZ3JRgb8I/i1bx1g+HJDTB8uEOpEtaDRq+tRsT5FzowYcx6XDZUH/DQXtvx4F9MN5oLPcsOFKVEHfdu0J1WYblEJmMVK0ukx57B3s9D7iERJ+i/qkQbyRn1ciCD9eicap6BwPaicQmet2Qr6gAxxsQ57YE+zXorl62HhH0TpErIzus1jfgsRrDH0NvK1R4hNj2+rbURfNdJNO72LRIK92/zgWUWr5KmATiE2UB6ve8a3JgeMXGrFvgBYUVKKbrgZMtGkDPLzQNLpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o55io8XMmcMKlwz1FYxBMKe+1h6jd0rvPfdAgx2IuWw=; b=fkJsqd5/nh2BXPN1WeFdck41Q4ZxR+0rRLORSGc+RINs38gU6w2B4lCW5VmPGWwA1NLq95fpYita4FcWxVl23bvrTXRYVLSE7DekRNvKP36YhF6rmBuLiftRCGN3x+yXCzJEIrEPfq+aNmaZvgxlCOYlwQjRDVDUE7ljmpKjSRT1MnA3/S40kzXo+1QZysGrSEUIgcvBPMFiLr9DL4XfoAUVblNB6zxK10N+9lvfJMXaAImRKp6q3ygKBcNukMlpV+EOm67azMTz3O+R0wWxCrjGo9SMGbZtY4L2+yfcf3yp5udqhz9BpkkUfqW+BaqN5EoXRXxQescxBSpAkuDjFQ== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by DB7PR03MB4889.eurprd03.prod.outlook.com (2603:10a6:10:78::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.12; Fri, 11 Feb 2022 09:24:49 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22%5]) with mapi id 15.20.4975.011; Fri, 11 Feb 2022 09:24:49 +0000 Message-ID: Date: Fri, 11 Feb 2022 10:24:48 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [8pIWdUQiQIoBqUGQu4elSOFoohxfU+5R] X-ClientProxiedBy: AM5PR04CA0020.eurprd04.prod.outlook.com (2603:10a6:206:1::33) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 20c51052-0b6e-472b-2ba1-08d9ed4059d2 X-MS-TrafficTypeDiagnostic: DB7PR03MB4889:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5cIE2ZB8HTk13HoVR97otcQRJqwkfdNNmbRFW/2PgDx1EZdG3OPg95eswGfAi3yCxL47ybNAxArhcgdJm6lMKmKvZVRJwhSqxRTBHz8JG3cYA92S5lJtONah3YRdhlgLperrgV512vXcueMKkRSUODAHdnbEeLbFQts7f35AQvwaKp+45Q7zYFXANgAXJiXoNkPepHFaVsbthKXD6PRaJYMwXBik+CaGyGipEpQxpB3Gew+fBftvQqNstAXaY/YwN0RedG0LWkvcRwsI4s8p9ykf6NR3uMo7eou9xSMuWWZCDW9Lw9KNWUKwpszdp+uI+gBXmN4clZTRR6kiFtSgXaTJmzxGK5FBA9k6H8OH88B9qcG7pLlILoZT8SkbqOjyN+T/HwUH+dZLPncrmnsd4l3sPB87mOozp87j5phkGBVQpfhQ0QSl9ryjR2DtY2TZRqetwkf2SYo5xrI9Ty9BMIBzOCXF6iU1EEQxP9fYucMwXHNW0GKjWhQG0PZB/x4v203qqIVH4OFZxTRIQqpVq6U8kGISxLWJprETX3nx6T7dtZIo4FrUxwjVN/4cXZ/451gV9HR7gPQAiME/HXTzxw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkhtZkxPU29OY1lJRFB6d29TVEVxb0xORm12amI1SkVLTmNwdC81RHExckxD?= =?utf-8?B?a05RZTdpOGt2ZnpJZjZTNHozRW5pSXRqNTJaeW5FeEgyd1NaemdqdE45TEVO?= =?utf-8?B?a29oaEI1YVRhK0R1SXdidjN5eXBBTVRjaWh3ZnpnN09qZlBYYnJBMUpzUUxl?= =?utf-8?B?L1c4d3d1UWpoSGljd0ZJWW5EVVQybFZhRjNvdlJ0NXBGaWN5RGdRNDJoUEFV?= =?utf-8?B?TnNOMVhoTTd6SWlZNys2QzRDZDhKMWRodUY2QStOazFQbjV0d0pRTzlDeUZX?= =?utf-8?B?Sk85d0dUOFVZL1lhYnpXMEN6aUlRckg1ekM3YUJJQWhlMlNHRURERVNDYndJ?= =?utf-8?B?WklWaVc3SkUzalZKYlQ2bUF1Wi9FT2RuZVRNNU1Qa2RUT1JHcDhCY1Z1SDZR?= =?utf-8?B?OUJJRVF6dm9aajVJQmZXWGp2ZFFSaGJjUGwvdThyWkN0ZlowbTJZalR0VjBj?= =?utf-8?B?Y2xTTlVWanVoczFyQWlrQ2dxVldaNGlHTG5BajRneHF2QWJ1S2tTOVluS1NK?= =?utf-8?B?VHAxQ3NocEVRVGdKQUt5WDl0NmswZG9seHZBcUs2eWFoV2M2d0pUTDQ1R0RL?= =?utf-8?B?QUsrZGRPLzB1THRKTU5QSW50ZitXM25nSmNNbS92bUF4M3kxZ3MxNGFCaEpx?= =?utf-8?B?cy83SGs2SHgrRUVZQzR1bzZ6K2R4YjlVY1RZZitzNU1rcjZXczBHc0FmWTdj?= =?utf-8?B?RHNRaGYxenF2YWptSVBzVG44OGhMbSs1SmU0Tks0WlA0cFpFcGczeTZFd0du?= =?utf-8?B?TU1uMklrMkRaNkRIZVRxdkozOUVISFRlMVdDZGl3aWVhcEl3dS9jWXE4Wno0?= =?utf-8?B?R0UzWXJTR3BNSElFay9HUGFEYUdYMUlma08zdEtSYjR3b3NLdzJiQzBZdjZN?= =?utf-8?B?aWkvekFCRzJSaDBjYnJiMnFrVXhHTUV5Wk1MeTJidkRBOTJuUVhVS0t6TUpy?= =?utf-8?B?Sk42a3I2UjhtNGNzR21pT2d0YmorUUpwSzRxQTQwY0hRRzdqY3FLQVI0R3BX?= =?utf-8?B?cExVVGJXNmZOT2FtYksrMjh0blhITmpoSng5b2tNYW4vM0tlb01sTFFKUWNO?= =?utf-8?B?RFFVazR0WDJxcnh4c3A4Zm9oUGpnOVRRcUJMbTVidEs0ZzcwWWRHcFFXdmFy?= =?utf-8?B?WHRRMXVFR2JPUWpYUzQ0U3RIU1EzQ3YxY1doS25xWnpXZVlweG51SjJmTWRM?= =?utf-8?B?QnpPc2ttSi9qN2xaeURWYlRwWnhidjUzNzJkYjNtUGhubWVrZEs4aURKTGpQ?= =?utf-8?B?MTJucGJqREM0aS9VWmVPQTVEQjgzbUUvQzNHS1gwYTNPNXJtQT09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20c51052-0b6e-472b-2ba1-08d9ed4059d2 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 09:24:49.1990 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4889 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vc2enc_dwt: Avoid NULL - 0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > It is sane, but UB. It could happen in case of allocation errors > in vc2_encode_init(). > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vc2enc_dwt.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/vc2enc_dwt.c b/libavcodec/vc2enc_dwt.c > index a8d3f1c669..441af040ec 100644 > --- a/libavcodec/vc2enc_dwt.c > +++ b/libavcodec/vc2enc_dwt.c > @@ -276,6 +276,8 @@ av_cold int ff_vc2enc_init_transforms(VC2TransformContext *s, int p_stride, > > av_cold void ff_vc2enc_free_transforms(VC2TransformContext *s) > { > - av_free(s->buffer - s->padding); > - s->buffer = NULL; > + if (s->buffer) { > + av_free(s->buffer - s->padding); > + s->buffer = NULL; > + } > } Will apply these patches later tonight unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".