Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH v2 00/31] New FIFO API
Date: Mon, 24 Jan 2022 15:44:35 +0100
Message-ID: <AM7PR03MB666072F4E7572C4D4DB462358F5E9@AM7PR03MB6660.eurprd03.prod.outlook.com> (raw)

This is a modified version of Anton's earlier patchset [1].
The main changes are that the new FIFO API is a clean break with
the old API (the new API uses a new structure (called AVFifo)
instead of sharing AVFifoBuffer with the old API) and that it
is now documented that one may attempt to read/write more
from/to the FIFO than is currently possible and that such
an attempt leads to an error being returned. This allows to
replace loops of the form

while (av_fifo_size(fifo)) {
    TYPE element;
    av_fifo_generic_read(fifo, &element, sizeof(element), NULL);
    // do something with element, typically: free it
}

by

TYPE element;
while (av_fifo_read(fifo, &element, 1) >= 0)
    // do something with element

- Andreas

[1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-January/291156.html

Andreas Rheinhardt (2):
  avutil/fifo: Use av_fifo_generic_peek_at() for av_fifo_generic_peek()
  avcodec/qsvenc: Reindent after the previous commit

Anton Khirnov (29):
  lavu/fifo: disallow overly large fifo sizes
  lavu/fifo: Add new AVFifo API based upon the notion of element size
  lavu/fifo: add a flag for automatically growing the FIFO as needed
  lavu/tests/fifo: switch to the new API
  lavc/avcodec: switch to new FIFO API
  lavc/amfenc: switch to new FIFO API
  lavc/cuviddec: do not reallocate the fifo unnecessarily
  lavc/cuviddec: convert to the new FIFO API
  lavc/libvorbisenc: switch to new FIFO API
  lavc/libvpxenc: switch to the new FIFO API
  lavc/libvpxenc: remove unneeded context variable
  lavc/nvenc: switch to the new FIFO API
  lavc/qsvdec: switch to the new FIFO API
  lavc/qsvenc: switch to new FIFO API
  lavf/dvenc: return an error on audio/video desync
  lavf/dvenc: switch to new FIFO API
  lavf/mpegenc: switch to new FIFO API
  lavf/swfenc: switch to new FIFO API
  lavf/udp: switch to new FIFO API
  lavf/async: switch to new FIFO API
  lavd/jack: switch to the new FIFO API
  lavu/audio_fifo: drop an unnecessary include
  lavu/audio_fifo: switch to new FIFO API
  lavu/threadmessage: switch to new FIFO API
  lavfi/qsvvpp: switch to new FIFO API
  lavfi/vf_deshake_opencl: switch to new FIFO API
  ffplay: switch to new FIFO API
  ffmpeg: switch to new FIFO API
  avutil/fifo: Deprecate old FIFO API

 doc/APIchanges                  |  17 ++
 fftools/ffmpeg.c                |  69 +++-----
 fftools/ffmpeg.h                |   6 +-
 fftools/ffmpeg_filter.c         |  14 +-
 fftools/ffmpeg_opt.c            |   4 +-
 fftools/ffplay.c                |  22 +--
 libavcodec/amfenc.c             |  43 ++---
 libavcodec/amfenc.h             |   2 +-
 libavcodec/avcodec.c            |  17 +-
 libavcodec/cuviddec.c           |  28 ++-
 libavcodec/decode.c             |  24 +--
 libavcodec/internal.h           |   2 +-
 libavcodec/libvorbisenc.c       |  20 +--
 libavcodec/libvpxenc.c          |  42 ++---
 libavcodec/nvenc.c              |  49 +++---
 libavcodec/nvenc.h              |   8 +-
 libavcodec/qsvdec.c             |  88 ++++------
 libavcodec/qsvenc.c             | 134 +++++++-------
 libavcodec/qsvenc.h             |   2 +-
 libavdevice/jack.c              |  30 ++--
 libavfilter/qsvvpp.c            |  46 ++---
 libavfilter/qsvvpp.h            |   2 +-
 libavfilter/vf_deshake_opencl.c |  92 ++++------
 libavformat/async.c             |  68 ++++----
 libavformat/dvenc.c             |  28 +--
 libavformat/mpegenc.c           |  40 +++--
 libavformat/swfenc.c            |  22 ++-
 libavformat/udp.c               |  34 ++--
 libavutil/audio_fifo.c          |  44 ++---
 libavutil/audio_fifo.h          |   1 -
 libavutil/fifo.c                | 298 +++++++++++++++++++++++++++++---
 libavutil/fifo.h                | 237 ++++++++++++++++++++++++-
 libavutil/tests/fifo.c          |  47 +++--
 libavutil/threadmessage.c       |  38 ++--
 libavutil/version.h             |   3 +-
 35 files changed, 986 insertions(+), 635 deletions(-)

-- 
2.32.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

             reply	other threads:[~2022-01-24 14:45 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-24 14:44 Andreas Rheinhardt [this message]
2022-01-24 14:45 ` [FFmpeg-devel] [PATCH v2 01/31] avutil/fifo: Use av_fifo_generic_peek_at() for av_fifo_generic_peek() Andreas Rheinhardt
2022-01-24 14:45 ` [FFmpeg-devel] [PATCH v2 02/31] lavu/fifo: disallow overly large fifo sizes Andreas Rheinhardt
2022-01-24 14:45 ` [FFmpeg-devel] [PATCH v2 03/31] lavu/fifo: Add new AVFifo API based upon the notion of element size Andreas Rheinhardt
2022-02-05  7:55   ` Andreas Rheinhardt
2022-01-24 14:45 ` [FFmpeg-devel] [PATCH v2 04/31] lavu/fifo: add a flag for automatically growing the FIFO as needed Andreas Rheinhardt
2022-01-24 14:45 ` [FFmpeg-devel] [PATCH v2 05/31] lavu/tests/fifo: switch to the new API Andreas Rheinhardt
2022-01-24 14:45 ` [FFmpeg-devel] [PATCH v2 06/31] lavc/avcodec: switch to new FIFO API Andreas Rheinhardt
2022-01-24 14:45 ` [FFmpeg-devel] [PATCH v2 07/31] lavc/amfenc: " Andreas Rheinhardt
2022-01-24 14:45 ` [FFmpeg-devel] [PATCH v2 08/31] lavc/cuviddec: do not reallocate the fifo unnecessarily Andreas Rheinhardt
2022-01-24 14:45 ` [FFmpeg-devel] [PATCH v2 09/31] lavc/cuviddec: convert to the new FIFO API Andreas Rheinhardt
2022-01-24 14:45 ` [FFmpeg-devel] [PATCH v2 10/31] lavc/libvorbisenc: switch to " Andreas Rheinhardt
2022-01-24 14:45 ` [FFmpeg-devel] [PATCH v2 11/31] lavc/libvpxenc: switch to the " Andreas Rheinhardt
2022-01-24 14:45 ` [FFmpeg-devel] [PATCH v2 12/31] lavc/libvpxenc: remove unneeded context variable Andreas Rheinhardt
2022-01-24 14:45 ` [FFmpeg-devel] [PATCH v2 13/31] lavc/nvenc: switch to the new FIFO API Andreas Rheinhardt
2022-01-24 14:45 ` [FFmpeg-devel] [PATCH v2 14/31] lavc/qsvdec: " Andreas Rheinhardt
2022-01-24 14:46 ` [FFmpeg-devel] [PATCH v2 15/31] lavc/qsvenc: switch to " Andreas Rheinhardt
2022-01-24 14:46 ` [FFmpeg-devel] [PATCH v2 16/31] avcodec/qsvenc: Reindent after the previous commit Andreas Rheinhardt
2022-01-24 14:46 ` [FFmpeg-devel] [PATCH v2 17/31] lavf/dvenc: return an error on audio/video desync Andreas Rheinhardt
2022-01-24 14:46 ` [FFmpeg-devel] [PATCH v2 18/31] lavf/dvenc: switch to new FIFO API Andreas Rheinhardt
2022-01-24 14:46 ` [FFmpeg-devel] [PATCH v2 19/31] lavf/mpegenc: " Andreas Rheinhardt
2022-01-24 14:46 ` [FFmpeg-devel] [PATCH v2 20/31] lavf/swfenc: " Andreas Rheinhardt
2022-01-24 14:46 ` [FFmpeg-devel] [PATCH v2 21/31] lavf/udp: " Andreas Rheinhardt
2022-01-24 14:46 ` [FFmpeg-devel] [PATCH v2 22/31] lavf/async: " Andreas Rheinhardt
2022-01-24 14:46 ` [FFmpeg-devel] [PATCH v2 23/31] lavd/jack: switch to the " Andreas Rheinhardt
2022-01-24 14:46 ` [FFmpeg-devel] [PATCH v2 24/31] lavu/audio_fifo: drop an unnecessary include Andreas Rheinhardt
2022-01-24 14:46 ` [FFmpeg-devel] [PATCH v2 25/31] lavu/audio_fifo: switch to new FIFO API Andreas Rheinhardt
2022-01-24 14:46 ` [FFmpeg-devel] [PATCH v2 26/31] lavu/threadmessage: " Andreas Rheinhardt
2022-01-24 14:46 ` [FFmpeg-devel] [PATCH v2 27/31] lavfi/qsvvpp: " Andreas Rheinhardt
2022-01-24 14:46 ` [FFmpeg-devel] [PATCH v2 28/31] lavfi/vf_deshake_opencl: " Andreas Rheinhardt
2022-01-24 14:46 ` [FFmpeg-devel] [PATCH v2 29/31] ffplay: " Andreas Rheinhardt
2022-01-24 14:46 ` [FFmpeg-devel] [PATCH v2 30/31] ffmpeg: " Andreas Rheinhardt
2022-01-24 14:46 ` [FFmpeg-devel] [PATCH v2 31/31] avutil/fifo: Deprecate old " Andreas Rheinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM7PR03MB666072F4E7572C4D4DB462358F5E9@AM7PR03MB6660.eurprd03.prod.outlook.com \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git