From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A267342584 for ; Wed, 5 Jan 2022 03:54:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 18D3468A2D7; Wed, 5 Jan 2022 05:54:01 +0200 (EET) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-oln040092068071.outbound.protection.outlook.com [40.92.68.71]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F2F1F68A2B2 for ; Wed, 5 Jan 2022 05:53:54 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a5o10QV3cawYHPCrQcrNvITBcDEGCS+D3Ff3MEX/UgULmLo+wGtND2JfUwvCdiM7QCPl1j1RZx/HfA0zZBBgP35/JGfyjrt11pRb5LSVLAKHBCVm3yh7TfVt7/jQQC8n6hNIPXQlS98SUrNeJDCg1vNw5/Q4v3JasXXuWORtCXLhh+EAdVzZdzqqCImxc9U8pYyLuem0sJJ4YtMJlB4HRiK3bbGVQp+AelOi9eFN4m4G/2s+bwhOKfux6G1i6+aBFYM3wCMc2cjm+MaDmN8skBUiOG6LP/IAMDTP3RTK6okW3inQlKHSzCSH0d3/Q4S91572jMNtBjHGYL1xcaR52w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PZ/Xp/P29UyVSnzeZZADlAbZ6Jy5l3NnAgWrX7ma0gA=; b=fwfZa04A65inHwhRhF4rSPRmuLDRxo2Lec3yb2iSQNq57JOTsB+vOwiMJOzPPeguBMayrzkODBlQpLX3y9TmAd1A5T4oEyrK5Ea2+JPJcc5+bG7cwXXJkC2SlxECHnhxJ9d6hKHuL45cHtKz7XzTYruTGyX4sP22FAhY/kqLHZe9AA+oKVC6Pdmebl+l2Akqpp1iCVeccxY11e689Zvbpmmuhc1dGv+acAJQkmjYXAdrfDZXA3gI2iExmbvq5Astampsn1QTkPLdffCV0jMNPfEYHAGpJ5I/qlgBG1unrbizDOP4CUa5P1NZqJP63VsyeGMTfGMTrm2s5o5qbfh39g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PZ/Xp/P29UyVSnzeZZADlAbZ6Jy5l3NnAgWrX7ma0gA=; b=rv3lI1Jxvo9mTKO42m/zGXtfJLAzQLA9CGQTMQaXVmwpddoWJUx+m+GFNXO9v41Mat2iAzSMy5nRPRf/WxEVpCOMfgP55oxpoWYcyj5MCw4XbrD/Ybrg3mxTX+fYVnlBNgtsTuDlsWDflZHIhEZei2EdZk8LExN6AnN2vw4i5zhNJlF++6yMY2GzFlTfp4Azmp1HWiKf1nDzwFhOs8RUoeSe+yoVI4KA0o2PmPLYHoOc8lv03k7BxQdRMnHQN2SmwM6YTZ5CWWnoevO35oQrRm6h9mx7whCuMC9FzpCiRKtE8ScAkHyT1gPp1bX+IRj2NBkkSB0IdudVyOq7/TcF5Q== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AS8PR03MB6984.eurprd03.prod.outlook.com (2603:10a6:20b:29e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.14; Wed, 5 Jan 2022 03:53:52 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5%9]) with mapi id 15.20.4867.007; Wed, 5 Jan 2022 03:53:52 +0000 Message-ID: Date: Wed, 5 Jan 2022 04:53:50 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220105032107.1170629-1-zane@zanevaniperen.com> From: Andreas Rheinhardt In-Reply-To: <20220105032107.1170629-1-zane@zanevaniperen.com> X-TMN: [w2RrQh2LEkGT1hfjMSQs8ML9iC3e1CET] X-ClientProxiedBy: AM0PR03CA0030.eurprd03.prod.outlook.com (2603:10a6:208:14::43) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <8dc8a7b5-72b9-da57-8d51-a32e76e18450@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d57342cd-19e5-4f21-ec9c-08d9cffefd05 X-MS-TrafficTypeDiagnostic: AS8PR03MB6984:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2sODk2m69yWqZmdjSR/FZIvx6WzeHIsifdFYvZXRj8teB7UPQvxQBzFjupagCumJ/CUscQcasxdTfEBRJOlPeYvVZ/Cy5P9Y8baqChr81qEBG305nir1vS+MPiMm/KDXYGXncaEdCk8y+9EXJp+tNe7Kj8isJ7/x3ng74oMKNfXXXzngYPVAnwe52W4Z3OqS/1rsxgbrhZxuMAmOdX1BlOTCFVEqhjihPtBGiXpLmI84YhA2CU7DGBTB7Bxcd4QEu030fa6bvTtIetbiCe9F7FnqTqhq0bdg8MslAveme2ZfMj7iMVC6uVfxKzN/tPhSQAangbuvFg8hvkroiEKO10eN9r5wsnJycFAADDeAU+ucSG9V1eyzSsbzP+84SWjVZWT2NULMBnCNnSxh/7CyBCSrCFG2bTdPel6kOGAVubGGXsfpWFylCNJjRJvYr0Gnjl3MAg+9GYZNduTqZZrzAWODq2dl1yZMcEIqVNB7LBF86/qKs7HssUNMQ0Alt3UPPlWPemxuR3KCsdOu16JPpoxkLKnpVJUcf0VJZfJXNyt+LC29+hD3of3fh+ZHko5Y4KBCSZ8OA60HBHvXvwAokQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MEtjc3ZwSEJPQzBKL3JKREkxWTRTZWxtejdoaHdSZ2VBTnFycCtMdUVWZkZ3?= =?utf-8?B?NFhaK0k0eGVvRlBhd3pDZ1JsdGNiMitGYzExMnFhN29nME5BNFFhVjZFY21t?= =?utf-8?B?VmFuNUhrSjg1RjFoK0pJbm5NZE5EektQRnc0VUVMclM4SWEwVDJsMWVDWnFD?= =?utf-8?B?VUpNeDc0Ykk0U1ZwQkYxMVN4dEMwZlQ3b1YrT0hBenl1b0JKWmRLU1BRZUdr?= =?utf-8?B?OVRnRFFhRTZsU1VGUUhRUjBnQmFqZTcrTFFkdERHdUxvWCtybTFWL0RoS0I2?= =?utf-8?B?bGpnM0pIenZXZHZhYmUxbUFlUkFsZGRwdWRSSEF3TElGem5hQTIrLy9VcVU1?= =?utf-8?B?ck9vYkFUOWMzOVRTMW5qRHR6WFkzQmNKeE54Y3JQbXFRSEMyUmNKU3FnQXM4?= =?utf-8?B?VHREYXBYVGlFSS9CUnlKalYwSmpVaDBBMVAwbmR0SXgxWlo5cDVHbGhEeTQv?= =?utf-8?B?Nlg1VUZXUkJvVmpLRFJLUnp2VWp4QzZlS0NzQ1FrWGQySlh4T3hiRDZOWlB0?= =?utf-8?B?UGVYSW00WXZJeGJmZWlxN1FIdFBtNTRiQ0Zia0RGL0kyVURmZWdBb3BReGhj?= =?utf-8?B?cnpGYjR2R2Y4eGY5T0xrYnk1M0pEQmJaV1hubUR5V2pyOU5OZ25uZksvUUp1?= =?utf-8?B?N0dvUnN1YmdZYTI0U09jcm4yVkx3Y3dIUWFOWlUxS1NFSVFPN0lhVEFGM2Vv?= =?utf-8?B?bWF2U3lJWjQ3dHFHald3RTVpd0libWdhOTJlRFlnZGYvUHNhV3NHVGRiVVVx?= =?utf-8?B?b3pMUStBY3BocjYrZHhkVDc0TmYrQkoyNHdFUUJmQnllajJrQ0ZISE9wc1lG?= =?utf-8?B?UUtsUk9XdGkzek9NdTJlZ0pIUWxDdDZPV1BST2hzWFpIZG42cDFsSkloS2FL?= =?utf-8?B?QnY3ZkYzYXMyMnh2M3paOUFlV1dGbzMvNDloZ0dEWGY3ZEJLMEJaSXc1MlVu?= =?utf-8?B?Rm5QR1hOYUloQjZTWFNKY0RjWWNLMllUZTZ2TE41dmdtNUVLSFRuQUNhS0FY?= =?utf-8?B?OEgrdkdySTE2ZFRnN09IakQwN0RZT0N5N003OUxPZmRhWGoybFNBakZWdFRm?= =?utf-8?B?M0xOU280ZFBIbUF2cnFJWnZoQy9JZFFmZ1lLVFMyWjlESDljMElGdTluZldU?= =?utf-8?B?K21ZTkkrbU5mL1hPcEhxQngwZEd2YVQ2TnFqTGpZd1ZwbzlLVnh5MHlYeEYy?= =?utf-8?B?SytyVmtyN0UzL1pQbWJOK2xzQi9nTEJKZUxVQk05MWxLaUZLaTFQTllRNnlG?= =?utf-8?B?YkhEajAvZ1VUMVJxRHgwbmV2Ymx2am5aZnJ4VFJHS2hML1JTZz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d57342cd-19e5-4f21-ec9c-08d9cffefd05 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2022 03:53:52.6127 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB6984 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/Makefile: fix mp2float and mp3 dependencies X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Zane van Iperen: > Signed-off-by: Zane van Iperen > --- > libavcodec/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/Makefile b/libavcodec/Makefile > index 7dc4ccb85f..8cd2d6f849 100644 > --- a/libavcodec/Makefile > +++ b/libavcodec/Makefile > @@ -481,8 +481,8 @@ OBJS-$(CONFIG_MP2_ENCODER) += mpegaudioenc_float.o mpegaudio.o \ > OBJS-$(CONFIG_MP2FIXED_ENCODER) += mpegaudioenc_fixed.o mpegaudio.o \ > mpegaudiodata.o mpegaudiodsp_data.o \ > mpegaudiotabs.o > -OBJS-$(CONFIG_MP2FLOAT_DECODER) += mpegaudiodec_float.o > -OBJS-$(CONFIG_MP3_DECODER) += mpegaudiodec_fixed.o > +OBJS-$(CONFIG_MP2FLOAT_DECODER) += mpegaudiodec_float.o mpegaudiodata.o > +OBJS-$(CONFIG_MP3_DECODER) += mpegaudiodec_fixed.o mpegaudiodata.o > OBJS-$(CONFIG_MP3_MF_ENCODER) += mfenc.o mf_utils.o > OBJS-$(CONFIG_MP3ADU_DECODER) += mpegaudiodec_fixed.o > OBJS-$(CONFIG_MP3ADUFLOAT_DECODER) += mpegaudiodec_float.o > 1. This is a regression since 33e6d57f01dd4742a2e25ac5fa072b487d9d02ce. Before that all mpegaudio-decoders had a mpegaudiodata dependency via mpegaudioheader, yet now the latter only needs (and therefore provides) mpegaudiotabs. I should have checked for such indirect dependencies (which should actually not exist, but they unfortunately do), but haven't. 2. This does not fix everything; e.g. it won't fix the issue in which only the mp2 (fixed) decoder is active. Instead mpegaudio should have a mpegaudiodata.o dependency (mpegaudio is the common group for all the decoders that use mpegaudiodec_template). I'll send a patch that does this (and backport it) unless you want to. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".