From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B28C141A2F for ; Wed, 15 Dec 2021 15:58:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 08E9C68B0D1; Wed, 15 Dec 2021 17:58:34 +0200 (EET) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-oln040092071030.outbound.protection.outlook.com [40.92.71.30]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6706F68B079 for ; Wed, 15 Dec 2021 17:58:27 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FgPvLg3bodKosvASGnCm4OvjUhTV424JI3gNdOeRnyKmDQAGcmn/CJhHf7ocE6Dkpf5zZl9CTfhNPIndbcAq3E8bEmNTcxE3LlAIYrSFN5FgUjvEEw2CjiJiMHQmdKQXBHv7xQaGDVTf1TChBWjGHoI1IEWBasAjkLfhzlavMAoQWS77q0XK+Ir2BU/RJmdPFA2ytuvQyDQjjqXn9Em/71FxNrxu31fgr9zQf2n2LhaHZxyU9Si5oweu7DdS0tyz7BfcYx8XUjaZ+bPDDzSpo2gwi6byRMncpygdQc4HI+lNT30/MhKH6XL0MOJ0ZZmHpgqmgC7zLaLMSQhOJEEJPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jsQUMOdgywIvGp5UN+bEbZKZAfu6AvwyMxdcYeaCbiM=; b=dnvGTFcN1g+uylvZFuqUrieSy6Ui0F/KvTt7sFJ4eq1Of4IXaWTOH1Ntx3k6uTJq+lwJZzO9R3zujKc1XzvSdkgliAWrqmp+8aQUwKAWfVtZ+2dnwrmR/DYvb2pWS+V2TcHqUx1JlYrjRCxIgzUJ2LTuhdwBly13enqdZWJl4kFomdpCIK7RVi60ws1XkPUVFXY3CvnvMdUYokyv4AO8TADByLBZT3/+3v8HE+1MdTfOe2w6RAskezvmhl1MEyYoxh2Hkip+wC3ZB+GznSNfDlNzmWQaGo5sqPVcXP7awOosuJfmuI86mCOG8MgQW3BfDAhQdgWGr1kC1vxT/tFfqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jsQUMOdgywIvGp5UN+bEbZKZAfu6AvwyMxdcYeaCbiM=; b=lXAKhY6xY1UIlEN8Oa16mJkxpmKS8Z/CsLbYlnVn9j2MuDHkh6PuSjOHdgway9pKA2jlr9GDM3kKJVnBaDot4zrTj/TncTjsuzkVJBXCqMg66o2gWd329TxNTqYyXD1XJehGnjm4NMs8ZYioJeopWive0lZjqtBr5rANvSbkWNlqRjWpv6fv/vdpv/J6btIMqecOdzGe03Nb+vaMecSSIBGpsDfJhk2lFEgeXxPBUp20Flgxx2f4lq6C6RssxEPtg4Bv56txhKtzxxPtlOSzi9wh633BwpPfg7+ct+6dJUFfTbUtitxrT5Odox3k32un+fxE7Nhd6rJMBOaUujXnUg== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM6PR03MB4616.eurprd03.prod.outlook.com (2603:10a6:20b:e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Wed, 15 Dec 2021 15:58:25 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::f0dc:92f5:6bc2:45ca]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::f0dc:92f5:6bc2:45ca%6]) with mapi id 15.20.4778.018; Wed, 15 Dec 2021 15:58:25 +0000 Message-ID: Date: Wed, 15 Dec 2021 16:58:24 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [IVho1kV1NfIJMC8h7TYcN2AYWoSTO2Ki] X-ClientProxiedBy: AM5PR0701CA0061.eurprd07.prod.outlook.com (2603:10a6:203:2::23) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <9dbd679b-bd5a-1600-ee92-aa11c7c856a0@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5f4a129b-c7ec-4887-3b9d-08d9bfe3ba6b X-MS-TrafficTypeDiagnostic: AM6PR03MB4616:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TMXToCLj6JjjWKqEvkITkUhDOhjA8JCpQF5k8exgsBnbe0FGeO60krHETwp/1c4Q/UQmLAaBMJc+lVkJog9nZxCISYFF89O/HG/7RuTNy6K4MusjRQkQWVWvhbr2RgVe+2qwC7KWNXLt386kt5y8dEKRO3lbEakN/RAcB1/0N1/RoQHj3dhZK3eoAUfbxwVqsXvPrerRs2fvftVj/8jZt7FqKynBNnOwFQNW6aQZ58jtHsnYdbcVinCPQFhI5fDY3XFSLn3LgdsJ7hNj65W5IFwoYPmkxsfN3mgvYMkx3E3c6kHw8UjJQes9E+K5KWQ/EQt7yvtI29cYDRodf3IG3YhYJmeVjoFAX/I82radPYqbzunp9wDJYlS9vz8O4rCvsfaPuwWoxSz7jV3uBJAT/ez3soLP61GcVcRERudgqWet03dbXuVp6oIfddUqxn1gD85w+I4/Ok2oYbHo7kDrn3uUYiV1C3im1jpXclDmQG/iEmdTHkyXjQR6xBYZi1LFwSH7v545ehaOB5An94P1rwf4WmMBru49r7WLmJ4BTV9HbumJnoONYhOSIB2Cqum/bJZ8ahlfSvxalQDnehJTYQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGlHdUh1OVY3MmtWTkNHSGlPa202U2xyQm1mS01pQ0t0emtZZ3RRVmFycENo?= =?utf-8?B?b2xqcGJ0QWZYQUJSMWxNZ0NqRHFRZWhEd1QydVc4ZHJoeEN6eUNzNzlobldk?= =?utf-8?B?K3RJb0twd3FoaWVxWFpEdFliRXdQWmNlaGRxN0NkRnRIampuNmpFRjBpYVVw?= =?utf-8?B?dWFvMVhsRlZ5WG5QZytYN29wUjRheVllMTJtSHc3WTBrNnE3V2N4c3lWYWhM?= =?utf-8?B?SStYNTYzRzZnM20zTC9ZUlFhV1p6czB2OGFBRXpSM0lPVnpWN0hBUmgzZEVZ?= =?utf-8?B?ZHZSRDBwTCtEMUZ6RzFrRVVOV1lJYTFac1pKZnFRdGJlclZBSVhmRWdqdEQ2?= =?utf-8?B?SktmYzBReDJicmsxcDVucXZjcis4TjhNT3c1NWlXQlNIU3VQZWNSUTRJNnhO?= =?utf-8?B?RHRXcHRqTlNVY016MlpleFNVZlBKbk9PVGxnRTg3SDJqUTdtQmxEK3p3aWhq?= =?utf-8?B?UnJmMnRTemFSZlQxRGNGdjJ2M1AvaWtpc0g3dTNZYW1qa3lWMjNYMDZWQW5t?= =?utf-8?B?ZVUzRFIyY2dyY3ZzUUF4QVdya3ptRmNpQ0czeG9Gb3l3OHZvclQzVFRlTGVX?= =?utf-8?B?alY0MVlwSVdGWk9HNXJZZ3o2c00zN1NsWjlUbVd2U2pWbDdqK2daM09ydXJI?= =?utf-8?B?NGg0RWxXclNhdXdOSy9CT3BVV2x1UVg2S000UDJ4MmNtN1FiN21YMlVuVExk?= =?utf-8?B?T3BQbllubHNVVzlQTUFTQkRYdSt3Vjlmenozc05sVmlrQnBGMUNybTRsOGpX?= =?utf-8?B?RUpxcTFyRW9Gb1Fjc3BFbmJSd2VIWGVLUUxpZktHZ3JDQnNlYm82azFCSTU3?= =?utf-8?B?ZFVvUzNhNUt1MDFCNTcwcjA2K1N2RTdhZXdLaXBsL3k3eHZMV0ordWg3ZlM0?= =?utf-8?B?WXJhOEpBaHVnSkswYWZXQzF1emRETHRZNEIxaUJ3WGZ0cUxBRlkyWk1HSDNP?= =?utf-8?B?M0o5TFBjdnJ6Z2NFOFcvWXZEVU1XZ0RWUlNnTDVYajVXYTZ6UDdoU0FlK3ZJ?= =?utf-8?B?WmJpZi9QM2Z4WUVnTjhXSk1UdkNxTnhlK3FQVFl2MWU3b01WeEtJT3ZZcTNh?= =?utf-8?B?VnZaVnVPM1dacklwUW5OZUFlTTFpelBwSjZMNWNGSllDSXAzNHh5bXBZMmJt?= =?utf-8?B?SGdOTXY1Y21CR21oajJmaXJ2MlFhRXA2YWhWSStpSjdKMkhyR1Y4V0NRMFV6?= =?utf-8?B?NU9uaTN3MmQ2bXg1TzNsY2Y3Um9IR2NDbzhEaHpRZU1vdVZlcU1OZTAvcVV0?= =?utf-8?B?VCt3QXo5OThYNDA3N2dVU0ZhejFqMktJT0s5V2dIK3EzQ2NyQT09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f4a129b-c7ec-4887-3b9d-08d9bfe3ba6b X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2021 15:58:25.7737 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB4616 Subject: Re: [FFmpeg-devel] [PATCH 1/3] avcodec/speedhq: Replace always-true check by assert X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Should fix Coverity tickets #1473572 and #1473504. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/speedhq.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/speedhq.c b/libavcodec/speedhq.c > index 91ba80ebd3..743dacc6ce 100644 > --- a/libavcodec/speedhq.c > +++ b/libavcodec/speedhq.c > @@ -295,7 +295,8 @@ static int decode_speedhq_border(const SHQContext *s, GetBitContext *gb, AVFrame > if (s->subsampling == SHQ_SUBSAMPLING_420) { > dest_cb = frame->data[1] + frame->linesize[1] * (y/2 + field_number) + x / 2; > dest_cr = frame->data[2] + frame->linesize[2] * (y/2 + field_number) + x / 2; > - } else if (s->subsampling == SHQ_SUBSAMPLING_422) { > + } else { > + av_assert2(s->subsampling == SHQ_SUBSAMPLING_422); > dest_cb = frame->data[1] + frame->linesize[1] * (y + field_number) + x / 2; > dest_cr = frame->data[2] + frame->linesize[2] * (y + field_number) + x / 2; > } > Will apply this patchset later tonight unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".