From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3C4F84109E for ; Sun, 13 Feb 2022 17:32:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 237D168B237; Sun, 13 Feb 2022 19:32:38 +0200 (EET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-oln040092066083.outbound.protection.outlook.com [40.92.66.83]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CB4FF68B205 for ; Sun, 13 Feb 2022 19:32:31 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hOCDxxMUT4C5P9RkBkJoVQKi0H6FUHtTaRYi4eSJJpPSWjfv6+OSWaQ7Yobfucp/qwa7RJRT564ud+zkyhtM+bWEip9CkxBBiqEvAFnXShGV907rvfdY4pka4DbN0QdeYGKq+kbNK+uCvWXtJgA4BEhcWss0/WIrmvDGVnl4FbWuv397iPdOk2JMnTuqB0i49cleXUOtydX4utysbOeUE103KskoNdK3XRskv5M9m99WpRdffhd0PAFd0uv3HSUK0M8/86/0q3evCZykTCtPHAulmTHmGpTQr6FJjmS5tovWGW6DdZFq8tm8kh21wRS5cTlE9kUy2pXaFuPhVqLH/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KqQglvYW4ctMst21OQ5hwUNnoLxazz8/ouV6oBM7VKc=; b=ZLhvC7EvS6mY5XpFFX4rcg+SXwoHkv1AuzXp7hdZ1EOyoBkbvF0QHHshI85ZrCLIEwg6+r9iWwhfEOGismV/LrSIgE5jeuk+nN1zGtHMHa8cMF4hLEICHmmoE249mya9+RAslD1H5wA2RpSrQjsIJGRJ9Km5w27j43APPTaS7JSvPG1poMPtKHijHzblCeJqPCs+pzD0QV7qyUud3ssj0oMe0TUR82wHLUKe2jJi4LlAdw12OVmCkg096nUVRg+jY3Ults+ys5+QNZKb4fgceF1QqDRZAJ5Z27YqJaivOQgo2vYo0wV34s4iKANSyA+htMQrGkIZGksz0jowrJmUBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KqQglvYW4ctMst21OQ5hwUNnoLxazz8/ouV6oBM7VKc=; b=unReKfpe+VeO2inX9/bEWTYxGj5s2PPvhzYkLtnKCfdIDWfQoHUbB89Z9y34GNCbCqAk27b8GF2cEXVjavV0TAqB3c3D2ltmYTFANPD1m++QLGz9UkncxM1BqVeslRPEJZmrumDXoz0zdAAp4wfoUGnQy8DhCkloRF2th7Z/4vGZgoBuO2FsRhEiz90iVBTbc3hNjlgQSL+ey2hm27VvbekCcpt1sOMMAkcdV/klN+iDuw+YwJUMu2GbFi2kbgEwMTC50cy2OGYEacEC3PoINjXZBenJUqM/OT1c8wLuNvLYCMF0x483cKFfoBaR4IMTs6AtJl3+gt+Y/4eswYOTMw== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by DB9PR03MB7785.eurprd03.prod.outlook.com (2603:10a6:10:2ce::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Sun, 13 Feb 2022 17:32:30 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22%5]) with mapi id 15.20.4975.015; Sun, 13 Feb 2022 17:32:30 +0000 Message-ID: Date: Sun, 13 Feb 2022 18:32:29 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220209152858.2339-1-jamrial@gmail.com> <5ae2e409-77bd-cd38-d10b-d65f2c4e8a84@gmail.com> <7e822563-4ecc-ed9e-3518-56cf8b497f4f@gmail.com> <54f088c2-0ed9-6a62-001c-40c24e9c88b6@gmail.com> From: Andreas Rheinhardt In-Reply-To: <54f088c2-0ed9-6a62-001c-40c24e9c88b6@gmail.com> X-TMN: [asYHFtQDtXEEbfQR5LxMG806z3Md/hfv] X-ClientProxiedBy: AM5PR1001CA0032.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::45) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c765ea52-7823-40ab-0641-08d9ef16cf7c X-MS-TrafficTypeDiagnostic: DB9PR03MB7785:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x9lXfsRzWK9kZFSlpdBgTcsTHNu5HraDqCb7s8pWgip9+f0kBwc4lGdtfZ0+pXfQxAdc7Zn6NjiDmPyoFaV8PndwYaHsaNZTFhwGyL16jKOWRGXmuGLMwWd99XeS6d88xN8CEpnm9pjAq7QnZBJaqgkXrzzwFXRAC6mejwbmszeWnNVx8iul7XVCyCH7Crkirv19LxkETENVJCN+CYaFoHRrAWGR+SO67UsspL6TYNjJ8nx7lbxPffs+VltiJAVl2bLjK9sVZ0rUnoIyO/Ng6Vc0mLMXndA/VUn1RDUAaxJeaSc92rSC+SqJesySASZt3TiZOHsSyeHS/EwDP8GAnMLeuKFKjB9cgm7iS7g+2KzkwZlwNYluI8s0qNlnFkETsexMbmOIuHKZRhSMtZkSVAmr4cGq6tISAs3H771ZYtOnaL8YsUmNu8Umtx3dkatLiZXir1cOqzRZWnZQ9Ms0tdSjso76Nk271EpygtZghiOymnFIbvsfErUrN/cHzyW+iMAkS01Pf42jOf1o0H+/wML0DIZXp+I1CjjUL/VSCOFXE2KbxyV8b9jbdGjncNC3TQcCPYjSocwqwHv94MWNrg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MzNlMEUzZkt0bEFoSHF6TFdLajdRd3hTNDNaUDRLbldJOC9PQjNxbWtrdzA4?= =?utf-8?B?WEx1K2R6a2hhRUd5aEdyZVJHUkFsN0lpUUZEaVRJd2ZvUURMdFRFK0R0UklP?= =?utf-8?B?STF0QUZXRWlYcjZkM0VmYjc0VzR0WTBFdjczZ1U2VkxOQ3BueGc0SlNzTE1X?= =?utf-8?B?ejNJa1d4aWJXQlpMYlhRZDI0bjJrWFVyaWpnNjI1WHZSMEFyWndZQlFNYWM1?= =?utf-8?B?ZkNtMWtmcWw4YXhjWFhMWWdndWhXMjlNeTJqbjBNbGk3ZXo4eUR3QTJuTWx3?= =?utf-8?B?cXpwVStaT1VlUE1WVGJhSndpbm4xN0ZWT3dYY1V3d041aEVoSER4UEQ3NFA1?= =?utf-8?B?aVZvVmJubUhpUEZWRDlWcGJlb2I5Y3BYYWdqellwWGlZVG4rTGltM2JPRnV2?= =?utf-8?B?R0J5T2FuV1UyWUNKb1lxaTJ0UDRxelNCYmJ1aVdXZjNkbmJnT2lYbllwZnBO?= =?utf-8?B?TXpLa2tuMkQydFcrOFpqbmVZTy9wYlJNcXhHY0xVVUhXTGZPOUdwbEk5MWZp?= =?utf-8?B?ZTlwcHdwTjNFTllKbnlsT085MHBBWHJZMVpaV2pQWjNpSE40U2ZmTGJ0eVdL?= =?utf-8?B?TTNGemgyYmk3QjJNYUk5UTh4QzQwZWNrNFcycWlERHRtT09Tdk00aC95ZGpD?= =?utf-8?B?bndsdWpyYWlpQ2xhN3BsUGw5TmtWSmVpeEh4dDJhUDJMdjRMendLSFAxdVlx?= =?utf-8?B?SUZ1TkV2RzlKRG9TM0wzSmZuYjlXSVVldm1qWjI1RlMxK241Z1JRWWFBSldu?= =?utf-8?B?ckFvMjgxQ2kxdmRRa2FCN0k5Z0QyZVFCeGg1aW9FbUdWcDZaOVJnRDU2YmJI?= =?utf-8?B?UFBrNkxLLzNaek92dFdkU3gyd2JTcWI3RjNKRzhJVnZIb0lnZWlrb1RtT0VE?= =?utf-8?B?SXZoaVRXaFRWSGZoZmRzUERjZWNHbDM2dFI3SEN0Y3VmMHJJZ243K2FISUU1?= =?utf-8?B?eWNPWlBiTEFjcmQvTkQ1djBVekVWQnZSOTEwZXIvV09PdW12bXhwTWY1VGxn?= =?utf-8?B?OVg1cUZEMER2V3BjSWZ1aElZbG1GTlNQckVQVmdZNjQ0cktYUWxhTmF3K2dT?= =?utf-8?B?akxDRUg5YVFuQ0xsUWVJVXhZcTJiV0dXQVYxbU9iY3NueFdNQ2JFTVhUTUtB?= =?utf-8?B?bUZGVEJyaE1ZZ2xWYVVtemRCaytKUEpKc01aUXpueVd3SURHcXo2TEZYclFz?= =?utf-8?B?TU04WVJMa2hWMlVieFVCWjdPb1FpOUtUZjliVE51UlR2VzRZVkVXazlRT1Vq?= =?utf-8?B?RndkYnFBdUZVNXQycC9KdmpHc1QrM0F2aEtaWEFwanhoT3BDQT09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c765ea52-7823-40ab-0641-08d9ef16cf7c X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2022 17:32:30.0841 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB7785 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/setts_bsf: set the output packet duration to 0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer: > > > On 2/13/2022 2:22 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 2/13/2022 2:14 PM, Paul B Mahol wrote: >>>> Too soon. >>>> >>>> Wait more, >>> >>> Ok. >>> >>>> does this breaks something? >>> >>> There are no fate tests, and 0 is used when the duration is unknown, so >>> it shouldn't break anything. >>> >> >> It breaks the simple use-case where this filter is used to just shift >> the timestamps. > > How so? It's a documented value that means unknown. What breaks because > of it? Wouldn't it be revealing a bug if so? > Effectively forgetting a known value can have bad consequences. Think of subtitles. > And in non simple use cases that completely replace or rescale the > timestamps, the old duration value is no longer valid, and something > definitely worse to have than 0. > I am not saying that this filter is currently always outputting valid durations. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".