Re: [FFmpeg-devel] [PATCH] avcodec/setts_bsf: set the output packet duration to 0

[Andreas Rheinhardt <andreas.rheinhardt@outlook.com>]

James Almer:
> 
> 
> On 2/13/2022 2:22 PM, Andreas Rheinhardt wrote:
>> James Almer:
>>> On 2/13/2022 2:14 PM, Paul B Mahol wrote:
>>>> Too soon.
>>>>
>>>> Wait more,
>>>
>>> Ok.
>>>
>>>> does this breaks something?
>>>
>>> There are no fate tests, and 0 is used when the duration is unknown, so
>>> it shouldn't break anything.
>>>
>>
>> It breaks the simple use-case where this filter is used to just shift
>> the timestamps.
> 
> How so? It's a documented value that means unknown. What breaks because
> of it? Wouldn't it be revealing a bug if so?
> 

Effectively forgetting a known value can have bad consequences. Think of
subtitles.

> And in non simple use cases that completely replace or rescale the
> timestamps, the old duration value is no longer valid, and something
> definitely worse to have than 0.
> 

I am not saying that this filter is currently always outputting valid
durations.

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".