From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2BEC340E1B for ; Fri, 31 Dec 2021 11:47:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A3D2768A8F5; Fri, 31 Dec 2021 13:47:40 +0200 (EET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2101.outbound.protection.outlook.com [40.92.91.101]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 039D7680073 for ; Fri, 31 Dec 2021 13:47:35 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FYA2/zI5rywrpAsPLKXKba40yx3+SGcUCh4w0+sYjAzH7wa3f0Zxt/jbTISyMNRWFUkxtxZtcmeO65w5KIHy0HaAp2uvItGMLKuWGDsqAW9NewFy/rNc/DK4HMx1kUmcLfxQDzAty5xJcOFa73jsMfqNbUR8L46e8d0k3kxECKnbCPylzIbGrTqdV8VjyquPsVrlOe1Fwfje7oe379Wgby9QqRBFs2nnwCty9lFAk0eQGNf6IrnKrGW0rfUsJalxlVsegWVywKgUO+2rUW4jBKbClkIRC6Hp88/H2ZWmdpwXllPGXxfOzzGB58W0KoXQtsXqT1zrMUlrwDrfRZ6/ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QNIdAKYVPzJiYU7zLCLZjukucYQ3/yo+76mSgLczjis=; b=HJeYTkZYKXkdFNTxGSMEqhIjvYKJQIxzg5lkZbuRCHv05f3VZllyncTKo6i3yUqhE/sAYGXxn2QpbMliqI0naMQQy27FGcx628Gn6dyNHbXE23u3lOlSwZaQKitZqFASofxohYon58iQhc3l54fwatK+c415GQ7dbL3UTtRvl1dH+LFZxb9WF4BgV0IXqGAtQxPu2XABHnUOigR7Ao9JpxIBBNIdQwq4DhTJI0C8tXplvBaDPk5DUhXI7PI1eyPmTJmVMw3N388qvLzV7qHB+8vliT4efBMs7uwkGLb76njhjPd7rYSbsNBL8TnfNYKhhzm7RqL31P6Rm6G7iXv+yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QNIdAKYVPzJiYU7zLCLZjukucYQ3/yo+76mSgLczjis=; b=Pf94gsUCziCA59J1j4si8xXEQdK3G7xk1naOKS3DrSaSmeHlJG7OqK9RPeS5l6WGyuBgRlrlv4sMAMyUdsKqNknCuNbGDHPvAvP5/6WmveFELKg+D0xgJYddmygvlYf9UGQ9GfvQzWEIYH4dB5FbcWeRWTtyLsf1HGIOHDAp0yjTWAKpjIJ2jDuqJ+msmlleqnhTDHbU3VKDD9skhSlIRLDB5a9HeVAiOOCykvo0cMGER+0iqJOdIHdO9f4jMT+cgEHDRFRbf5LiV1rmHtV+FAKq+WOjw/ja3PjYaCxwInrt+YDslDjR/CT8y6LgdUNKuC5txr5KgjoLLpKKlr9tGw== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM6PR03MB5251.eurprd03.prod.outlook.com (2603:10a6:20b:c1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.14; Fri, 31 Dec 2021 11:47:33 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5%6]) with mapi id 15.20.4844.014; Fri, 31 Dec 2021 11:47:33 +0000 Message-ID: Date: Fri, 31 Dec 2021 12:47:32 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20211231105307.30946-1-anton@khirnov.net> <20211231105307.30946-6-anton@khirnov.net> From: Andreas Rheinhardt In-Reply-To: <20211231105307.30946-6-anton@khirnov.net> X-TMN: [BEZB1P0Oqb5JyU66ONrikjOWpyhmZj7h] X-ClientProxiedBy: AM3PR07CA0057.eurprd07.prod.outlook.com (2603:10a6:207:4::15) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <5a4ca102-f761-662e-7d24-46974216b36f@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 81d5f308-fb3b-4af9-eb80-08d9cc535545 X-MS-TrafficTypeDiagnostic: AM6PR03MB5251:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aplCB+qUSKwK53ZHrvGfc53JGpR7Vgv3mtdwpWIn5B/UPUefGxDl6qQ2mZn6F28izh2xuMOq+kq24bj/LZu49TjMrzpbIrVWG3xskkawe8w8JpM9kPjMUUy/HFDg48zNEg6pbs5pXZuroRzav+dVKAN8wjNuTSIAku9kMrdfL2wQb1fBWCz36l1/4eQse6IJDVmWGudkHGjDF16851iI59ToInonEOoSNoVQ/QwEM+Ug9h18OWRVTowuMGnDQqA5UTM9DXnm7fVoylGOmzP6HSM7OXqPQc47uhLLfJdOvEcReElT86BqDDp+Rk+gGlp+2XU1p8q5rJDOOa0gHpOyikV2yPr+Z5K84EJO6Xv/EH2NgM0NiciNp1nq4oXDczWb1ljZa/g8Q7aE7DVxo56F3ymM10TCkm9xauICbU2OpHKNemP576S3jSiQlQ9R7osIn0LQZ8s3dVfxDD3UkV52dw7gSPnwyVIU/LVfxA3vakYZ4wmcTgJAMJ1nI2Y/PM8Ssrdz328mqjHxHoh5ETqfBsRxSzhIg5TTv5yzbQyu6bgXePFmuSSWdlQkjJxMo7pktXSvrbGWPTdMdoSypK/8Mw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlBYaTlJemZNb1ZPWlN4Z0VNT0ZCUmhQeU8yTkxTcXp6Y1gwOVJHZkIybFJT?= =?utf-8?B?RnRRMGJEU0I1bmREQkl6alBMUlpvcmtiMVdUWDVDRDBFTGNEYi82bzhidVJS?= =?utf-8?B?Z2lyZlU1YnF2eGhjUTRPWXF2NkJmaHQ4OUpBOFN5eWw3UTMwT2JCNStTMHAz?= =?utf-8?B?MXF1b2NZclJHbjBZcDFpc2RaNGdZR21FdWtrZWtlYTIzVHV0UjVEa3ZZK2M2?= =?utf-8?B?SlIrMmFuSVJyWFA1cFJtc3EzeERHWm1HNWZaWFJtVjlhNFRXNURZOGIweVYr?= =?utf-8?B?cVgwb3BKdjVyM2ZrVGt6VWZvdzczSUpmZU4yL29EWFlyT0NtMTR0QjNhSVp6?= =?utf-8?B?SCtRd2ozdnZtVHNzcFdIcjRhbStkbUpwbS95U2ZoMmxqQ3paSkpnRVlEdTF6?= =?utf-8?B?RS9xZ043Rzd0YlJmT2w2aTBkdUFSMzRyRHlDeHRBcU91L01DaE5PWEJIL3lk?= =?utf-8?B?OUdUQWVSZytlMlY2WmRWRzZtSGxnb1prZ3Fkc1BHa0w3UkMraysxMmdhVkw5?= =?utf-8?B?eGV2Q3haUDQ5RVhYR3kzdGhoN0lBNk9hVXhkczhqcGM5dDVBVjd4aGowNDdZ?= =?utf-8?B?SmFxTmRRV2FOSkVhaG1yd3l4T1ZKRTRNWmhERnZNWEVsVngzVGJ0S0pGem9C?= =?utf-8?B?c21lY3BHWjROQW83cGNGWkU5Rmo1N0ZVTWN6cnpkT0hmNTJ0R3I2WXFMQ2JV?= =?utf-8?B?VUVxQ01qa0dWRGNCMGdPTEdnZDJqR2dVek5MeEtsWjhueFNvMXBzMzh6elBV?= =?utf-8?B?RzVFaTlHTndsL3RaeStHS1hEeWhoeFlHbDNaY3Rkd3ZjWWE1WW5NR25CeEg1?= =?utf-8?B?L1gxUlVnZjAwTTVKNTVlaEs0dDVHQWt5SDBIQStXbkdaZlZQT3liWEtkL2tN?= =?utf-8?B?ZkJCSU1TMCt3WEthUmtVMWoyQ2dSMzVYUWtWckFKdno2My9YSTZUekY5cW9X?= =?utf-8?B?aHA0MUpnaUd5QXc4TktQZnlrWnU2Zmp1Z1FhNHNBcFZ5V0lHaWlaaktrc1o4?= =?utf-8?B?UTl3aHpCd1grZEU5QXlvcWY3bTVyM0t5V0hzWklhL3NMYWtmSVBtOWxSRC9l?= =?utf-8?B?YUM0RExjcXU1TGZCMEdiT2FIWmltdUY2aEtYbCs5YzFEOU5zK3FUemk2NUw5?= =?utf-8?B?U1JmcU1FV3preGVCaWlONkltUVRuSnBkc0lEN2hvOFFhdVhlSm14cERJd1VD?= =?utf-8?B?SVBJY0g4Ukh4UHhOUHZmMU9mSmt6Y2NXZ3ZCdmxNS3lSVWFDQmdYUFpTazR1?= =?utf-8?B?bFFGd0xVUkdMSzdqRWpsKysrUlFXOEZDMXQxcWdHTS9vU1AwZz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81d5f308-fb3b-4af9-eb80-08d9cc535545 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Dec 2021 11:47:33.6508 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB5251 Subject: Re: [FFmpeg-devel] [PATCH 6/7] lavu/fifo: drop useless comments X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > This object was never intended to be thread-safe, so these carry no > useful information. > --- > libavutil/fifo.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/libavutil/fifo.c b/libavutil/fifo.c > index 171c1aa9cd..f38e8ff089 100644 > --- a/libavutil/fifo.c > +++ b/libavutil/fifo.c > @@ -144,7 +144,6 @@ int av_fifo_generic_write(AVFifoBuffer *f, void *src, int size, > memcpy(wptr, src, len); > src = (uint8_t *)src + len; > } > -// Write memory barrier needed for SMP here in theory > wptr += len; > if (wptr >= f->end) > wptr = f->buffer; > @@ -197,7 +196,6 @@ int av_fifo_generic_peek_at(AVFifoBuffer *f, void *dest, int offset, int buf_siz > int av_fifo_generic_peek(AVFifoBuffer *f, void *dest, int buf_size, > void (*func)(void *, void *, int)) > { > -// Read memory barrier needed for SMP here in theory > uint8_t *rptr = f->rptr; > > do { > @@ -208,7 +206,6 @@ int av_fifo_generic_peek(AVFifoBuffer *f, void *dest, int buf_size, > memcpy(dest, rptr, len); > dest = (uint8_t *)dest + len; > } > -// memory barrier needed for SMP here in theory > rptr += len; > if (rptr >= f->end) > rptr -= f->end - f->buffer; > @@ -221,7 +218,6 @@ int av_fifo_generic_peek(AVFifoBuffer *f, void *dest, int buf_size, > int av_fifo_generic_read(AVFifoBuffer *f, void *dest, int buf_size, > void (*func)(void *, void *, int)) > { > -// Read memory barrier needed for SMP here in theory > do { > int len = FFMIN(f->end - f->rptr, buf_size); > if (func) > @@ -230,7 +226,6 @@ int av_fifo_generic_read(AVFifoBuffer *f, void *dest, int buf_size, > memcpy(dest, f->rptr, len); > dest = (uint8_t *)dest + len; > } > -// memory barrier needed for SMP here in theory > av_fifo_drain(f, len); > buf_size -= len; > } while (buf_size > 0); > LGTM. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".