Re: [FFmpeg-devel] [PATCH 6/7] lavu/fifo: drop useless comments

[Andreas Rheinhardt <andreas.rheinhardt@outlook.com>]

Anton Khirnov:
> This object was never intended to be thread-safe, so these carry no
> useful information.
> ---
>  libavutil/fifo.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/libavutil/fifo.c b/libavutil/fifo.c
> index 171c1aa9cd..f38e8ff089 100644
> --- a/libavutil/fifo.c
> +++ b/libavutil/fifo.c
> @@ -144,7 +144,6 @@ int av_fifo_generic_write(AVFifoBuffer *f, void *src, int size,
>              memcpy(wptr, src, len);
>              src = (uint8_t *)src + len;
>          }
> -// Write memory barrier needed for SMP here in theory
>          wptr += len;
>          if (wptr >= f->end)
>              wptr = f->buffer;
> @@ -197,7 +196,6 @@ int av_fifo_generic_peek_at(AVFifoBuffer *f, void *dest, int offset, int buf_siz
>  int av_fifo_generic_peek(AVFifoBuffer *f, void *dest, int buf_size,
>                           void (*func)(void *, void *, int))
>  {
> -// Read memory barrier needed for SMP here in theory
>      uint8_t *rptr = f->rptr;
>  
>      do {
> @@ -208,7 +206,6 @@ int av_fifo_generic_peek(AVFifoBuffer *f, void *dest, int buf_size,
>              memcpy(dest, rptr, len);
>              dest = (uint8_t *)dest + len;
>          }
> -// memory barrier needed for SMP here in theory
>          rptr += len;
>          if (rptr >= f->end)
>              rptr -= f->end - f->buffer;
> @@ -221,7 +218,6 @@ int av_fifo_generic_peek(AVFifoBuffer *f, void *dest, int buf_size,
>  int av_fifo_generic_read(AVFifoBuffer *f, void *dest, int buf_size,
>                           void (*func)(void *, void *, int))
>  {
> -// Read memory barrier needed for SMP here in theory
>      do {
>          int len = FFMIN(f->end - f->rptr, buf_size);
>          if (func)
> @@ -230,7 +226,6 @@ int av_fifo_generic_read(AVFifoBuffer *f, void *dest, int buf_size,
>              memcpy(dest, f->rptr, len);
>              dest = (uint8_t *)dest + len;
>          }
> -// memory barrier needed for SMP here in theory
>          av_fifo_drain(f, len);
>          buf_size -= len;
>      } while (buf_size > 0);
> 

LGTM.

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".