From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 64BAF4085D for ; Mon, 31 Jan 2022 23:40:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D7F1A68B04C; Tue, 1 Feb 2022 01:40:41 +0200 (EET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2016.outbound.protection.outlook.com [40.92.89.16]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0E12868A6E0 for ; Tue, 1 Feb 2022 01:40:34 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d4Co+kR0CK12AEtmDoxQeyA/cWjRMtUP1K1NYQ7d2TPGVLMaX4TOKQx8c1X6lDGHOCL4e+/2e4eiyi3vpjk0FW5/NOLv2tKokgTh+0jH0Mj8UOltJUCnOVx6dKZVXT1FXo8yY/S2SqPOHKm2Hv5wyCahqK9NxfdDFPJK1Pg2dQ3nchAZWg42XyzkFo5oV3T6MvpUEDve+kLH+8iUu9M+/RL1hgZcH9vVIWwX7ntov02rmkmVupwH9g7Z4HBOarLvrwsmSusrDseeMcIJq3+cn4Q8UIkToTw0VdqFRGfAHS87DSH9EESLvZnHJNEZ5d1rg83DeONmOoEjnd7d9041uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U6cKT5at6f+dQS6pFtfq7aUMvLEyxOpx3DD0nIA5u74=; b=W4osmwRkF+s+SKTez6aNh17gc8yxqVsHP9dQDIITvT15QwT0RdjW/t3ZcRcc06oyCtT0D0Wdt1S+Lke103yQTRHIeJ2z6HOc1p/0c31uJG2L0YSAcio/cAO7/eFyhq1ohEfNaOVcHeYXeCz+LtE/UFtTx30BDoR1UsBCq6zUjfBRaFPVPxZlPsaIpeYpC73hwekuCaew1ww/4YqSCdiyt3lRwZmtIfUDg7P3fAzBgDe6mntqC4/H29zzghw1pYTcs5nc0E74OhWEKoHjAQ716ZKWZbXc7OakE6TmUwhhDGjAZ6+Z5n8MaQGAhLi0xX6Ni2ULZqPrS400ABXwASZfBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U6cKT5at6f+dQS6pFtfq7aUMvLEyxOpx3DD0nIA5u74=; b=Y5VbaREYXpq8K9syXlAde2UFOXI+Rb6WoT7CEzlku9gaS8la5LvpgsxvGtCU/9XW7tthYm6KqdxU1UT1wweJpTFD2zcS3hBkMfTH+ByNH9Fuex2omerWNY4Qwf7u85ct/JHv8B83my2D2TfIQsYsD/YvfN9rbms0GYBPspWvPJ4OLZtpeiQsMXMFaMYpy/yhP2Ix6PXjVU05FGYkXIpPLIlLRgY9/EE6tFtfU/3NGjw26zw3Bj7KGmlpcHd7KvheDuxpvMPOoGKBPMB+9gdc7Ikd0lCO26HZlkRVBh6fcUjvGmVwVNH/2hT2qPUmPZSnUSo7+7nPZcQCeb8wcaFcbA== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by PR3PR03MB6556.eurprd03.prod.outlook.com (2603:10a6:102:70::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.21; Mon, 31 Jan 2022 23:40:32 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22%6]) with mapi id 15.20.4930.022; Mon, 31 Jan 2022 23:40:26 +0000 Message-ID: Date: Tue, 1 Feb 2022 00:40:25 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <350ccc44-07dc-25c6-49a1-4281139d93ac@mail.de> <8b8ae2a5-f77f-5a34-8890-fa68de09e475@mail.de> <5ead1511-a763-782e-7eff-e2256828978c@mail.de> <70afd793-820b-83df-6bc8-58e1787cd9c8@mail.de> <26ca972d-ab44-910c-cc47-5f92da53bc9f@mail.de> <079cf800-f26f-34dc-13a5-2a75c7ab7ea3@mail.de> <1ba42e6c-458a-92dd-9cc4-830bbd452e16@mail.de> From: Andreas Rheinhardt In-Reply-To: <1ba42e6c-458a-92dd-9cc4-830bbd452e16@mail.de> X-TMN: [sMXuwa6OLD9VquHCkxe937Wreb5yk7wW] X-ClientProxiedBy: AM6P195CA0011.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::24) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <083f6ddc-8c10-ba63-20f9-d27b51a54a70@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7397fc6c-6c1a-4740-e962-08d9e5130e6d X-MS-TrafficTypeDiagnostic: PR3PR03MB6556:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vG1VX0oGehrDB63BTKSmLeqP+HX+5IhTigjvy1eLedRUsJat4JxO7tJ7LdWheJg5glFydIHTLEnn2zCdbqSfQxAJxMh4ST0pGQPjwfE+WSnFu+jg57POJnVNefZ9axFxzXuctLDfs0xjhtNopkg2a7XshNrx/Fvth+F3clXXxhWYWmRmoM15E4CsPP+a1ZQyN315dV+6Ago7eMNJZcbLoue/KYn289E92AmcFRoES+l8aEMWDlugGvlMFVNm1PDnmDwsa4jp6DC4g10kzUwbwR5Iv/0MoloJlgB1MIL676r8JE43WKAJrNpnHyk4sDxrm77jUWn5+uLthWTB4AsDYcjcge2Z80o4gdMJzPJzgoZv/L2qDwl8fzlQxPa3ANldvwtSWiCpIzmJYq/GczYrCqOLdd9iajJyP9oM7Wv6XHn6LJYteyL7LOMrIXIbeBS1Q6zJoZbso8qMArs+SwyKxqJFC/ud2JFpMEOZm3yIYRMCl+TJpmDxJYFA0wXFoQQ2StZNQgmwtzD3xDaFcs9xvmK6KZeI79t8UAvh07qXqcguJoH+9pT31pcMbUf4aSlM X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXJxSEtDdjZKSTdSMGcyNEZSd1ZHVklmTWxTaXk2ZkpYZlNENUhTZTZyTFdo?= =?utf-8?B?QUoyVDl4akRxNDh0TU5wRjNIcDdZQUJJYzIrVlJSalJMVVplbU9rNEFLaDJ1?= =?utf-8?B?Z0xXSGNURDFCK000c3NxNlVETW80NS8xYm5pL1lQTnNnYlNLdUQ5RVJ0YkxL?= =?utf-8?B?K1dWQ0lHVHQ2TnZ2ZHZvR0JCUC92TklCV3NZVXFLbHA3TFhEbWZCQ1lPM0Y2?= =?utf-8?B?bEZWYWxqNTZBWEhTdDBQRTgzVVRIWG8vcmZJcU9OZ2dkQ3RtSjRJc1JhZnV0?= =?utf-8?B?WTJiS09KTVA3S1EweENMbTVZSUh3WDlBSjBseTIvRlZNVXJWcm9IWDQvaWpI?= =?utf-8?B?NE1iejgzanRqZnNocGZxSndlcE53c0Y3cEY1ZkNjTXpScVdFeFVscStXcDQ1?= =?utf-8?B?UEo0RXRSLzZtYkZkMERHb2x1RW9zd0t0TEdLaStvejlQOTd0UVlibzdoZStK?= =?utf-8?B?ZDN5bW0xMmlETVloZU5IYjNYd2ZhWkhUbXhEajVUbUxzZ0t2ZGlLblp5QUtT?= =?utf-8?B?alNiTHk1aWl3OGovVWhXcTNUNnlLTTl0Q0lMelNWb2V1Y2JHMGtIMkhNVk5V?= =?utf-8?B?WlZkaGtKa25DUmh0YzZaeDd0WXU3dEhUU3EvcC9CSmxrcHhxOWdwMXJ6TU9n?= =?utf-8?B?TStPdmFaZlVXVU5BTEtLNVJTMWQyL3l5ZjVnaVphUEY3STJHblA2VmlBdzZz?= =?utf-8?B?TFAxbFJFZ2pXRnltemg2d3hGK2VCaWtUQllSekNNRHB0NGtQV3BpWnkvVzIr?= =?utf-8?B?dGVtRzJSS2IvTDdHdTl5SUhXWmQvcWFqQ253MEx1d0JzTHFzUStoK2tPR2hw?= =?utf-8?B?NWlQYVhRNnUvZkt3U0dNYmFubGVzR0pzb1F6d2k3ZUVwbis0enlMcnBRcVZJ?= =?utf-8?B?ZDNuSzZUcGoyUVdVWDhmMk1XUE45NEtWdjFOZHlYaEw5SnhUMVR1R1dsckFl?= =?utf-8?B?UkNmQnoybk42LzY0bTZnbm5XdHBoZnVRMnpkbHEyemNZWTNlZUhIM3RkNWV1?= =?utf-8?B?ejA5ZGFIZTFoanpZMkV6V0dvZmZWei9Eak1aL25vM1ZRTjMvNnJVT2FrelNC?= =?utf-8?B?TkFubFcvT0RXVjltSElSUzk2Wkx1RmNCZU4vY2NGRHJLK0puV1AwaGlRK0Fs?= =?utf-8?B?Q2llcGxUb1RmeVk5UjZudjk1YVVTcGpXaVNNcmhUb1NlM0lyRUR5bGthcTYr?= =?utf-8?B?Mndray9LT3FzVjJ2MElGd2FnV25tbGpydlJPYzZnblhZTDF4amxxUXJucWFj?= =?utf-8?B?YzhlUStFMXBkN1BhWkE1aUpFS1NaR2ZmY3dvdWhjSjE5ejVtUT09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7397fc6c-6c1a-4740-e962-08d9e5130e6d X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2022 23:40:25.9796 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR03MB6556 Subject: Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Thilo Borgmann: > Am 31.01.22 um 14:08 schrieb Nicolas George: >> Thilo Borgman (12022-01-31): >>>> v10 attached. >>> >>> Also going to apply soon if there are no more comments. >> >> I think you neglected to attach the file. > > omg stupid me. Here it is... > > -Thilo > Seems like I misunderstood your code and ignored the outer while. Your code can leak if there are multiple 'N', because (as I said) > > + > + if (fmt_new && fmt_new != argv[0] && fmt_new != fmt_default) > + av_freep(&fmt_new); > + does not free fmt if it is already allocated. It is possible to fix this by adding an char *fmt_allocated = NULL; at outer scope and a fmt_new in the block that is executed if a 'N' is executed. (You have to free fmt_allocated immediately after av_asprintf().) But maybe it would be best to use an AVBPrint to write the new string instead of allocating a new string for every %N encountered. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".