From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 60938410A1 for ; Mon, 3 Jan 2022 05:21:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5CBA068B1CC; Mon, 3 Jan 2022 07:21:35 +0200 (EET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2089.outbound.protection.outlook.com [40.92.91.89]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3F60F68AEF7 for ; Mon, 3 Jan 2022 07:21:29 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gihZ0Gr/Xo9vRIWqD7l00BHE5eUtJdPodAR4naNxZoqudnVkDaoImNWOgf1D+i2rvEHRG5yXwtuO1CB6yoSf0MloptqNVrzmLLNeItKsA1iPohaUb+pSbvFql1PXwwtE6WgHp08UMRIHqwUyHetfSOKLOZcc+SzYlTwWih08k7jMqtquo3hgKYrlfyrdqDW1UJgwE8bLdvnIA66kLhu7nmxkWTs9wVuyHeGiD7i4UFQ6d0HWnw4pUkgH7EnxEUJT4xtkJlyp8aNf1K+TbrpWsoMtq0lofwygX+BvREwHo23invf6oylcTyPZjHvCzRAspuhkzAp929XXCxWl64pJcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kiaAdO+UqY7+I/l3PVxFQRKu36jmQUZaBBL25O8Pj0E=; b=fkwGHw8H5W0dpaKKR+kp4MtKrpkoszJFvV/NX7DSdjhG/9M1iPOljFEwJ6euK6WHISqESKrQcqO0KffBTffOdSZeUeKey6X+yrMH+eD7KTpF88mdlnrLlR1I80me2DY1BATHyGffvnNlNA30ldZCnzeOGVdSn6IojUOh8Xv3zPE5Xhu6BMpXeAXniiRY0fffHA+Gm5X6IRmMw7ELElQ6epdDuKLJ9dpJXrv9fNgiedrDFJoZmtz9E4oUpbp3PFeL9iZC/Bf70keAfUDZmnuRKtbb3uByORE81saa9Qf4nlDNbAiJzVEkoX09QcoCZR8xpTw4tZAtZuz424m3uJZhpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kiaAdO+UqY7+I/l3PVxFQRKu36jmQUZaBBL25O8Pj0E=; b=aAA3KJ++XGwhtSBSIzYsMJgGZBWkqPuJsBuGc4Br9Ti4AE//SWf0oYZKpPdEuR/8x6t0y8zjTzVW74f2EMmj9eb8uahdL4QK1bPGqFgP5EwniA8s0gK4mveA7PEQDSO69TV3JLitHoUc9dPbCB0v1nwFDM/X5wGv9DYl8QDQ/60qhnMtuu0MrEzf2PmYTTwNyAOBLGFr7avnLSZhY1fk+oIWAb7HpAvGEEsHFyBlyoioZVyeTynvfkvqCvFPM7UXtypLIohv4JjpVIvK9Y2tusufZTduBHMN5x2Qaulb/W38AhaXMJU+BZlH5ED+KqpOi9v/8atFR+KIj+cuXZ89lA== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM6PR03MB4776.eurprd03.prod.outlook.com (2603:10a6:20b:9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.15; Mon, 3 Jan 2022 05:21:26 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5%6]) with mapi id 15.20.4844.016; Mon, 3 Jan 2022 05:21:26 +0000 Message-ID: Date: Mon, 3 Jan 2022 06:21:25 +0100 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US In-Reply-To: X-TMN: [zEgxpdRZbx7BHB/bcknZ8pF3OclAc1ta] X-ClientProxiedBy: AM9P250CA0020.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:21c::25) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <1eb53fc7-035f-1e18-7631-0ee6fa8e0df1@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3d3a0dcd-fc2a-4e37-0cac-08d9ce78e3f0 X-MS-TrafficTypeDiagnostic: AM6PR03MB4776:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DVJfu7SA8S6rsQOJyFeeIik44laSa6lmbc/8rYuc0q1G0nFHx7QeiwTVjIIF6WeX1Tny9aLCFe7YDVZZjkcjWWFYZ6+PhPXIBx3YKPKjmbbBPv0AynhH56oxOc42adYBRkxd6a257+RfZcKQAS5jsfglPjuyGnK3zrBpKvdmMvgs7zvFnBEvmRm62gmnwbtXvC3kfgRfznUf+HuX43K9yHIhmPqDv7rarV4REUpUDtWrTTsyB4oz1qN6GUlLgdOQXb9U8Nua0MyYvKZRGGTF2nyAjaqkO7kzuftHnHyCzNXgwlRg5kiIZM3vpHzRatNqzzdPFIY5y2FNxqgHOuupL8ENfEht0U6JjhkqSCNsrbDmsOHp/XjflUNESr/1WtAiu8zOQZtvuWsd501XZhMRs2D1Scs3LDkC9q5jnC6j8c9zMgEruuvSSniAdYQ42xFYLnARI9GKpkqrDWCd/fz6nPTbyjq6Vj4c4tyNR3lOpIQZfFRRcct1evWf1GezsefKgy6Z1LZ7oxbxq9bnJh1/MFy8r3G3be8edyGkMvH+RVL95ixirb0s8tonrhaP4AjbObU+dlTXjpFzOFubQTftzQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0tnaEpDc2hjY1Q0VmJmZ3lydmZsZ2NYcG1vbnc0U3pJc0c5L0RibVlnSU1x?= =?utf-8?B?aGNhcW54SzF4dVd2WHhsZVowT1F2OXV3bW5FdlRHNkgzNmRQakpnSDZ3cUx0?= =?utf-8?B?WGcxRFVQRnFXZ29XSGFGNGIwdStVUHBWMnRPM2dNQ2IwVXh1RWs5aExBNSt5?= =?utf-8?B?Y0hpdzIveS9uTXlub0NML3dPZHNPeWRoNUhuVE5lTjBIdEtqaCtHTUZsS25T?= =?utf-8?B?UjdIb3hXOTdaeHhJQlJZU05lUWFoMVlSeWxaNUFIc1FCUWFhR1N6OXIrb0My?= =?utf-8?B?WDVkNUxIZDBlZm8rTmY5Vk01RUNLbjNiUktiMm5RdlJGUWZ2WEFDNC8zT2lo?= =?utf-8?B?b2E5V3Z0MGJGOUVWQlNCYmJrY0xKNlJYeTg1Ry9lc1dOem1kcFBOMnd1cVBM?= =?utf-8?B?QWtUOTBnakc2Tm1OZUZNSDhKZm92MG1vcUo3Zm1jdFZRSE9BYkZ1OVN4T3hw?= =?utf-8?B?Y1JpZEYvbjg4QlJNQmprWTYrTXF4TXNkQnVMY2JtNmRzcXZoVE5VOGEyZDJh?= =?utf-8?B?TFViRHErZ0VZZWN4eVpFZkxlclR1L0VZT1ZVVEkxRk9Ga0tqSVVOMWF3Vk5v?= =?utf-8?B?YWFBODJVcytYcG1jZ0hhR2VMNVM1aDRiQnJBanBUb2ZvbCt5bFNhbzI1a3h1?= =?utf-8?B?Nm9qekZhQlN5anBUK25MQXJDOWpHVjFqaUNhd3F5UWVyUXFQZkJDVVVYZm45?= =?utf-8?B?RjQzY2ZqZ3VuMkg2ZGIvdWRGeWR0TnJ0VWJ0RGFvUTlKMUo3RVUvM2EvTVFh?= =?utf-8?B?VlBYNGNSellLMzQ3TDk5Vk4wTUo5WGZYK1IwTll3Qk1wR3hWVmhkMjg2TzVy?= =?utf-8?B?NHlNNXovSUhydU95Zm5oY09tcVFGMDkycC9iZENjYVNMcXJ5VHNrRlBKQXQz?= =?utf-8?B?aEdwQ1RwRnhNcTNFMUtQcGNLMW9SeXdCUVFpK0UrRFhyclBCaWRzMC9wUGpw?= =?utf-8?B?R0JCVkd0VVozS05MQWd4NTNVT29XNGp2Vy96UVRzR1ZPUXVJM3RtdDJ3cTk2?= =?utf-8?B?Sy9tTFltMm1waWEyM0JqQ2FTYXNqWmFIUUs5R2JUZ2dzcUNmVmhWNFBQdnR4?= =?utf-8?B?R0ZNOFNEelpyRGVwYURmRUtVRDNCQmFFc3drS3p0ZU1CdVlYZHJRdHNvRDN3?= =?utf-8?B?aHFvbWZKUU1BZjhubzUvTFpxRUhRcFZ1Sm83Ny9XeUxYVmZPV1NjUndPVHFZ?= =?utf-8?B?TEhlTnhZVE5UMEhnelN4U3NsM04xUkFScU1hTXdvU1hON2EzdUZqRW1VcEtT?= =?utf-8?B?bVI5dXdiOER1NXA2dGE1VUdYV0t6dmJuL2xxWFJlTHRzMHJmdz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d3a0dcd-fc2a-4e37-0cac-08d9ce78e3f0 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2022 05:21:26.6911 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB4776 Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Kyle Swanson: > Hi, > > On Sat, Dec 25, 2021 at 1:24 AM Paul B Mahol wrote: >> >> On Fri, Dec 24, 2021 at 9:52 PM Kyle Swanson wrote: >> >>> Hi, >>> >>> Never followed through on this vf_libvmaf patch from last June, and >>> I've had several people asking about its status lately. Rebased patch >>> attached. It's been a while, so I guess let's start the review again. >>> Would be nice if we could get this in before 5.0. >>> >>> >> Please read old reviews and follow them. >> There is no exceptions. > > Thank you, I've taken all of Mortiz's comments. Updated patch attached. > > Thanks, > Kyle > > > static const AVOption libvmaf_options[] = { > - {"model_path", "Set the model to be used for computing vmaf.", OFFSET(model_path), AV_OPT_TYPE_STRING, {.str="/usr/local/share/model/vmaf_v0.6.1.pkl"}, 0, 1, FLAGS}, > - {"log_path", "Set the file path to be used to store logs.", OFFSET(log_path), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 1, FLAGS}, > - {"log_fmt", "Set the format of the log (csv, json or xml).", OFFSET(log_fmt), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 1, FLAGS}, > - {"enable_transform", "Enables transform for computing vmaf.", OFFSET(enable_transform), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS}, > - {"phone_model", "Invokes the phone model that will generate higher VMAF scores.", OFFSET(phone_model), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS}, > - {"psnr", "Enables computing psnr along with vmaf.", OFFSET(psnr), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS}, > - {"ssim", "Enables computing ssim along with vmaf.", OFFSET(ssim), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS}, > - {"ms_ssim", "Enables computing ms-ssim along with vmaf.", OFFSET(ms_ssim), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS}, > - {"pool", "Set the pool method to be used for computing vmaf.", OFFSET(pool), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 1, FLAGS}, > + {"model", "Set the model to be used for computing vmaf.", OFFSET(model_cfg), AV_OPT_TYPE_STRING, {.str="version=vmaf_v0.6.1"}, 0, 1, FLAGS}, > + {"feature", "Set the feature to be used for computing vmaf.", OFFSET(feature_cfg), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 1, FLAGS}, > + {"log_path", "Set the file path to be used to write log.", OFFSET(log_path), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 1, FLAGS}, > + {"log_fmt", "Set the format of the log (csv, json, xml, or sub).", OFFSET(log_fmt), AV_OPT_TYPE_STRING, {.str="xml"}, 0, 1, FLAGS}, > {"n_threads", "Set number of threads to be used when computing vmaf.", OFFSET(n_threads), AV_OPT_TYPE_INT, {.i64=0}, 0, UINT_MAX, FLAGS}, > {"n_subsample", "Set interval for frame subsampling used when computing vmaf.", OFFSET(n_subsample), AV_OPT_TYPE_INT, {.i64=1}, 1, UINT_MAX, FLAGS}, > - {"enable_conf_interval", "Enables confidence interval.", OFFSET(enable_conf_interval), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS}, > { NULL } > }; You are removing lots of options; removing options is only permissible during a major break and even then the options need to have been deprecated before that. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".