From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 90C4340B92 for ; Sat, 5 Feb 2022 01:49:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9896968B245; Sat, 5 Feb 2022 03:49:06 +0200 (EET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073038.outbound.protection.outlook.com [40.92.73.38]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4BF2B68B188 for ; Sat, 5 Feb 2022 03:49:00 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MR1oshBKFXzmFyxGQblz/aESq7d2jQo52iivVPH76D98hdYfCc2CdHhMGhpJEo8HEeF9uUKUZTlagTme1hM6ecw6i4miAifwoNzGyVLoWZ+EKgL8rhM72PUjKd/y+T5gYIzTA/TOkPNDI8h47CQdz17zCkUpjWpbJZMgMmkuKVqSKC8NlIhTJJZCC+U2hkp0exyePxOA6r+BX/y4CUjOWYikjjgS0pNpxvZPk4NHg6dS64w5likjXhq6ce22ucByjDYfNdyMCGtOpWnKOxC7SWy0SFy4YxAPq3ywmjE6xHdw2fsrKOeWRnK+q1GB0PbfRl42dCjB6dImvgRFTuUFeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nEHJwXGuzDz81AUglqdOeb/Alx7DCiwuYuY90w0B1+M=; b=atgpNcNkWaOz3qkLYkl3evS+LOxPYgL1gqqCeOg/NlYYIgj3Y1lGeV+c65DDwfmfW7hlGBPSIGfq28DRKc4THFZ7O6smDhDEon4I4FO03IzxJzn0iluxplVCzbMOHpAHJ2zng1yjvZ0CJeQzEeH3sJzTvU6HA3tytEcRXb1JvbeMAHbScYN7YLJt84gmi0cQXaVSd29NizEbw5SuUykfSDCEQn9a4Ix7b4nkNl7IjWPIsnJl3k8bOefoPEcMJInLG+BJfalUkrOZklGuqp9F4qyIGpa80SEsrnnryuxvDjFahuwOnr8vVHwOFwc4F6upmw3oQg/he2ghhDs4FS8GGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nEHJwXGuzDz81AUglqdOeb/Alx7DCiwuYuY90w0B1+M=; b=ANMrD3uB//raIxeUbBN9KEWiPBXYIt8kFtNzojSa+NodZM4WGZHqTOoxMK/KfrilQa+xn9KwOIbSYJE+vb9WsMRLGk53Kg7wnfBzxUCuJCP/QUg5uZ+SZ9g9/zNmRzVauBfTaTNj46jg5dJRobn+ayTftxm10quhGozbT602auMdG2Whub1TCCY0MMAodRmk+3ltCqkeN6Xe+8Aoud2rssuF3iOxVW7QMMq+YotfXEjiwHNj//OWiqgN8WSNd1AttjS7+Dc8WYkKhwUZ99jTHjJvQBAnp7fSTGMdqljOl5nouQzRqKwnt6AMyUtMwuzRnTQGsFdVJ46Mz8Pk207QDQ== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by DB6PR0302MB2725.eurprd03.prod.outlook.com (2603:10a6:4:af::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Sat, 5 Feb 2022 01:48:58 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22%5]) with mapi id 15.20.4951.014; Sat, 5 Feb 2022 01:48:57 +0000 Message-ID: Date: Sat, 5 Feb 2022 02:48:56 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220201212056.29712-1-scott.the.elm@gmail.com> <20220203184450.5491-1-scott.the.elm@gmail.com> <20220203184450.5491-11-scott.the.elm@gmail.com> From: Andreas Rheinhardt In-Reply-To: <20220203184450.5491-11-scott.the.elm@gmail.com> X-TMN: [O4UqYVToBWiGsTcz5Tgx1wMYQGI2jqh9] X-ClientProxiedBy: AS9PR06CA0249.eurprd06.prod.outlook.com (2603:10a6:20b:45f::22) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b4779016-25e3-4782-2f0f-08d9e849ac90 X-MS-TrafficTypeDiagnostic: DB6PR0302MB2725:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o9EY56pQt1nyTfyJszBCCaMY+ZE0zP7lEUpkP2Uv7mDBlRMVnC0FVH77hc1KFNSor/gJrHEFWY/EIG28aOf+ATppF9SC/FGkg18f0+JG4vCJjvsMNjdFu7LCpLtkekGJBTD6sD5tcHFZLf2nxS814exLcNQIbYeMU33jVXuGWyRxfXZrA8oZVXK2bsVnEStCVfPFxgIXyqyg65IdlK6br5aYw1zIJ4gSyF3Ew7BdkILK5eKRKOzxVUkLrcX4k7RLJWqfkN7PZRqWtDxXp43CCUKLcCNrwDgPpBiavmhBnDC+H5GiuzkTXWxN5eiHwMkGNPRt0TzRj870XIFDlNYbywO+pZ0nuv2Gx9pbzn89/ACuXpWBjwirC2AyN54dAoUuB3TaA+qLyZMr6rB39zVHZ7/9zBxo25ogKVMCZSk+Svrf0e7XYci2p/tTPSSV9trl8zrNGFyFYANuhSkXwne6xhWXJjl6rNKiggoG4VqQE+YsHhwUBL3En9SfmRUbiBnK+K44qrdAhl46OdnBL2fW17v90i8wnaKFI69/pg8TERP72+oDSdTpgqeYeUxPyjsSJ3RtbNOZJGczs/IFLdAi9A== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWlKMnR2UmorTkl0T2ZDdUFTRGI1WGQ2WkJZSnpFNDdNNWZFWU5rQ25TbW55?= =?utf-8?B?eUNYNmdaVGRYSzBFMllJQnk0SjFIakRIanpNVzZNNDFhRlJxbzQzcVhzRjF3?= =?utf-8?B?UjZlMUtXaktBeHoyZ0RpVmp0dGxuSUp3bnlEZzB0cUs2OWpFeWJGVmxJTmlw?= =?utf-8?B?U2JmVmFLSWdnY05pNUZhbjBYM0NSYWhwczBFS1NyNXp0dWMzd1dndWNmcFF3?= =?utf-8?B?QXBkb3lVaGJzTVhBZG44U3ZUL2N6OUp3WktvY3dZQTMycDNacDY1M3Yvbms4?= =?utf-8?B?YytZdFdLbWhmb2d2cHVCVWluU3hqajF6OEk4V1M3NDN1ZmUzdmw4M3JINkJ4?= =?utf-8?B?WUNFQ05VSWVxTmQzTEFCSVBqRjgrcXpCNGgvWkpiUi9XTm5qNU5ZUjFRREdV?= =?utf-8?B?RStUZHVjeWdKU1pPNVF1UU1uY3ozTll1dllSaW5kUUMyUWtFOUpDaysyQlcx?= =?utf-8?B?OXZoWEFVSWVRcklLWjRYNmtlTjV0c2ZkTVlnYTUvUTk2Sm0wNXFYeFlQZEg4?= =?utf-8?B?bU5USjV3V3lQQ3p0ZFpPaEZsaFVDMHhoWEZaK2pUdGU0SmFEc3VPMFhveDVV?= =?utf-8?B?a2pYM1NEOTVDeVVEdkJ0QlZ1MUxiekFzWjNoc3MzK1VBL3VaSXg1anpxS2Ex?= =?utf-8?B?ZnowODJmcnJZMGV6VTBEMUhlVzFKMXhCckpZTWorQjg2Nkt2eTVkT2MvcUhp?= =?utf-8?B?cXR4SDdiQTFnck94QU5IUXdPV1NkV3NzKzlvcWw5ckMydjlKZi9KTnF3ZHFL?= =?utf-8?B?RWxPWTRJMG5jM3NDblN4S0Rlb3pNR3djdmRmTjJ3RTRyUzNHTDBSSzFQQ0Nm?= =?utf-8?B?NHpYNkpnb2hpaFFlUTZ4Y0Qza2cxRFc1ZSszSHI0MnlzTXVEQnlrMTJDdjla?= =?utf-8?B?azUyeW8xYXN0bUZSZHFVeTlYOTZJbUZ6MVFHM0J1NnVTLzNpRFlMSXlvUUZD?= =?utf-8?B?bjE0eHhOZ21XengrMFJBL1VadDhCeGdWRHhmdkFoTXNneG1jc3FodWRhTG4z?= =?utf-8?B?TlBPWTk5amllSjgyZWpWWm1ETXFuMTRwSVVkRVNCd2xoWG1DOEJlQWxmTEpy?= =?utf-8?B?ZkR3OTk4Y2JlWVhxUUxBdUVVL3IxZ2Z2bER4d2Y2cUpTN2FlcnlpZ3FHcHhS?= =?utf-8?B?NFZscE9IV3dWQyt0MDdkWWcrWU5QSUZJRWFBNzhYMFcxZGZENnU1WTl3VTA3?= =?utf-8?B?VFpobkJ5dFNCTHdiZjA1SUREdzJlVkFGQWE3MXFYaERUcW1uTzVwZlZ5L254?= =?utf-8?B?NmRXaVpaWVVFallIemlITmlqZTdTbzJUY3dVTXhMUjJDWUQrdz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4779016-25e3-4782-2f0f-08d9e849ac90 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2022 01:48:57.7834 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0302MB2725 Subject: Re: [FFmpeg-devel] [PATCH v2 10/13] cbs_mpeg2.c: use a while loop with a loop condition instead of an infinite loop X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Scott Theisen: > This enhances the clarity of the code. > --- > libavcodec/cbs_mpeg2.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/cbs_mpeg2.c b/libavcodec/cbs_mpeg2.c > index d41477620e..afe78eef9a 100644 > --- a/libavcodec/cbs_mpeg2.c > +++ b/libavcodec/cbs_mpeg2.c > @@ -148,7 +148,7 @@ static int cbs_mpeg2_split_fragment(CodedBitstreamContext *ctx, > CodedBitstreamUnitType unit_type; > uint32_t start_code = -1; > size_t unit_size; > - int err, i, final = 0; > + int err, i = 0, final = 0; > > start = avpriv_find_start_code(frag->data, frag->data + frag->data_size, > &start_code, 1); > @@ -157,7 +157,7 @@ static int cbs_mpeg2_split_fragment(CodedBitstreamContext *ctx, > return AVERROR_INVALIDDATA; > } > > - for (i = 0;; i++) { > + while (!final) { > unit_type = start_code & 0xff; > > if (start == frag->data + frag->data_size) { > @@ -190,10 +190,8 @@ static int cbs_mpeg2_split_fragment(CodedBitstreamContext *ctx, > if (err < 0) > return err; > > - if (final) > - break; > - > start = end; > + i++; > } > > return 0; I disagree that this enhances clarity: When using a counter, a for loop is the most natural. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".