From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9730A40851 for ; Mon, 31 Jan 2022 23:10:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C7AED68B10F; Tue, 1 Feb 2022 01:10:47 +0200 (EET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-oln040092075034.outbound.protection.outlook.com [40.92.75.34]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0542768094F for ; Tue, 1 Feb 2022 01:10:40 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gv8Hyq3oE5I9x6HjjS2dBRyLJ6xDQb/RO8IUQllbGY29vbh9horZ8fo8wKLGToXteJ+rYfrzOWEQpaIQbETE0p2MKkhj7c3A/T2NwGTEEYOip5Fbq4Nv0L3HQpMMV6/F1Nc5Skb6hxgb/ba7TVzS38xSBZWZDQwOSjlaQYtnbDn+73RLwSFRxsxTBGSawKGR13OyL7/IjU9BNj6FRICFqjw9/B+uxbdmGoBmKEASf/SKmBxhaNb4awrRZtakMLM4F5y9tsCiWWXmBBLnoedgZyPzGwe1iGTh92TIbgI+bcC0k1FeVis/F+SdYAQeX6KFOeUGZS2zdi0UNrqpzFgH8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qRhOlUeJSCW1kHsa+2cR8qqv/UCvUZmFjmDxZEblzGo=; b=TdbMg5Ky3h4lPNM4cOFhFnusCnRP0PvEqdUC3Cx69OVbmjOm3WPgbYfargdp138W5xdaD+cDAQDjhIWf+ZDMex9/QcPi387CVXH2Q8ovSKpBoYsLwPTI4P5E6n+DXE912WapHijCznpUb+YHzAwQNMWoHJX0rOaUtyLdfePBgZzx1fYLHSmecx7ZNGKrkW8a54xW7qeUTz83r6zsfFL5ObKDN4teielqvgkak8mSEECvawnW5qoWDe7r1kgFJJLlac5i7VuUWWqzbDZMwdvViVxoGaYQ5MrvzMpzPZQV2SVp2v7xsoU8VT2NgBO5q7xduRNk4aTJ/WBbflBHceVXXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qRhOlUeJSCW1kHsa+2cR8qqv/UCvUZmFjmDxZEblzGo=; b=iqEzu/im4Pd7sSsywwBuFs4WuSrUbwPPldQ2Abys5lsTp13xaV36kq9WhHfH18IKuEkt8BXIvSkg3oD+BW+VVbRRIRSHQ+Cun2rNL/aKnbwoiB2xyi7HcWRRDD0xvx0MFDaXDHTjumoYn9Wwa6koshlNQS1H6p4LeYuU2ASSVnQqqg8twDvlsRMRlfg/D68bd4LcE5up3l0+2x2m9UyYnJAnkzjbpHk2d4BUDqYYIokkjyFYdUf+2Z5PdsLE0q6kI8kCxHaQa8qJIXRtJPaspl3xxxXfVRfVXS1f/s2q6mSAPYoCbrRMFEanh+N03/WAr6tTfuE2v7PwZqqG8197Hw== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by PA4PR03MB6957.eurprd03.prod.outlook.com (2603:10a6:102:ef::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.21; Mon, 31 Jan 2022 23:10:39 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22%6]) with mapi id 15.20.4930.022; Mon, 31 Jan 2022 23:10:39 +0000 Message-ID: Date: Tue, 1 Feb 2022 00:10:37 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <350ccc44-07dc-25c6-49a1-4281139d93ac@mail.de> <8b8ae2a5-f77f-5a34-8890-fa68de09e475@mail.de> <5ead1511-a763-782e-7eff-e2256828978c@mail.de> <70afd793-820b-83df-6bc8-58e1787cd9c8@mail.de> <26ca972d-ab44-910c-cc47-5f92da53bc9f@mail.de> <079cf800-f26f-34dc-13a5-2a75c7ab7ea3@mail.de> <1ba42e6c-458a-92dd-9cc4-830bbd452e16@mail.de> From: Andreas Rheinhardt In-Reply-To: <1ba42e6c-458a-92dd-9cc4-830bbd452e16@mail.de> X-TMN: [8JQ964r02zSTWOOAYU7u9gZc6t6xhUmd] X-ClientProxiedBy: AM6P191CA0082.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::23) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <386d1744-2f72-4f6c-838d-07cfa855bd2b@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 10102afc-070f-4e3f-4589-08d9e50ee571 X-MS-TrafficTypeDiagnostic: PA4PR03MB6957:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fASmvPPMuK7vfUFuKzsh7a/KMR287yBCDAMBv1aXkU+AK821qWW6tBV4FfFXwXPBIx1hqVaU1ITZGrWMXfq3xc96Y9UeGEZXhz+jiaRn9eTDcgrxWFopKo/YQKSj+A+9Yl/+DOkIh0f9JhJkvTOnuf0twWyYMbAozmrN780AVetJPOXXwXsOtkvCot3KvSPRBVILK4393SJhjzg/IwcdfpiHAzNfSE5SmQvlf1gu4da9qMBuQ1zh6OLsmeWkPK44aBdLhngwVI1sae1+lUV4bgNbuGy71aQZhL/nVRAepY2lFl0QzPWR7T8T8p2bvfUNSTNs3gwkSBNSKp7JApnt0OtMD78dxhttK5TMTkbPiy/pDISrzVRpI++spI2YiK/NBmU0N8h5ZZGkn3Bnbtm+0XqDvbd1KH55Qf6T+Lb0fndryBQAPn8YFAzEe1bZwCBqYYdcMzOXrHDlzWL6lgO5nqK9QjEZwEnz+7zHnrTBzvrJ4rT+U+3A2MJgQ3jyhyNaJCncukYm29aUxPog2VGeXKyfY1+UZeM/hbmnirCJcCB1QXFbRWFJ/lBGCBVdu495 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZXZFSVQzSGo5MWFZMFV2RjAvUm52LzBsaDFGNUtwNnVRZ3VRdXBhbWZnc2FU?= =?utf-8?B?OVVqbVZOOTZnV0Q1QzI4WUF3VmxnRTRxcE5hV0xoeS9EY0oyU2lVNnFCSEUr?= =?utf-8?B?TUZxQzRIaGdSY3JKL0R1NGVJSjFnK01hK3JvK2M1alBxWFd3Z1JUMUdFZ1RJ?= =?utf-8?B?enpEK295YlZyRks4NmRQWXBnaHV4YllKNGx6bTE2OVZWa1IxWTJsZHVVU0dZ?= =?utf-8?B?dGdUS29WeFE0N0xTQTdUOUtocW5sclNVZ1AraS9LSnRXcHdrellSeFJWNVlj?= =?utf-8?B?dVlKYWVxTmZSbm5IdUZtbWJHa3ZEOXU4am9WWmw0NithV3drSXlQNzdZNFpN?= =?utf-8?B?dDRhUm5maEI3VVpzUlVBRVY3NmJ1VFMrc05SUVRqL2lCaUNKdGxXNWdVLzVx?= =?utf-8?B?eHZ4TGp5R2pRVTN3Y2tZM0RsSTBIUzNqOEU1ZDZIUjE5WVE4UzdJM1ducXVI?= =?utf-8?B?N2k2VnJSSXpYWFVRRzViQS9tSEJoekphdFg5aWl5Z1ZnMGtHeDhJYTZWQWFR?= =?utf-8?B?TjJKbmhmT2F5c2RyK1hOUXRlRVhnVVNhemd6NklpRkNycXptMXQ4U25EMUw4?= =?utf-8?B?QVBpaUl5cW14d1ZJaS90a1FtTDNNUXNPbG5FZzNuR3ZtMkZQaE9JNU9OS2ZZ?= =?utf-8?B?YjdTMGhFTHUxY0htTDBlcEVCK1Z6WlgrZHRoSExKcFdGODYrcHFFeUcvU0tE?= =?utf-8?B?T2U3NDNaQVc3NXlldHJrWVhPdThqYVdESXBFbVNMWkJidjI3alkyMkZTRHlX?= =?utf-8?B?L3poS0JHOEwwNmVzRnZCaGVxNS9kajdpdnduN2p5VURseXFadzR0bTFLRzhQ?= =?utf-8?B?QjhEMTdDMWdrTVRVZlBXRDJRUUpvTVBBWnpYTHloOVdKU2prQTRFMGliM25J?= =?utf-8?B?ZnBFZDBKcGJ3SDBBV1NmbHJBbmNweTlBQXFkK0hOVmNjYThQTmh1RmU3V2hZ?= =?utf-8?B?c1Q2ZVVqR1NubmNKQWFNcEZuT0lpU0U3WEQ4WGdOakxzZVFIbXN0MUJOZndM?= =?utf-8?B?RnV3VlNyalFUZTNPOHhkcWh2N2xFR1EvRzFoenkyR0JYWVk4aWVya3FLOWwr?= =?utf-8?B?U2RBeWJMc0FvTFBzcVJJSWU3QmVoR3dWRTNJZ0lWRGRBZzk4T0piV3VkTEI1?= =?utf-8?B?bHh6S2YzekpUK3BJQVBjVmxFMUtpVVdxMWJoeVh3dEg5SXpQQnF4dzkvcGVm?= =?utf-8?B?TnhsYzJuMHFlYkZGbzQ3KzVsSVdMZDN6ZkVTaGtIUWhZQ2Z1bWFXK3RVdWVD?= =?utf-8?B?eFhSc3dKYmdnRWFpYkM3cm5XZVpacXI0Y01YdU9ZVGlkSHdWZz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10102afc-070f-4e3f-4589-08d9e50ee571 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2022 23:10:39.1969 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB6957 Subject: Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Thilo Borgmann: > Am 31.01.22 um 14:08 schrieb Nicolas George: >> Thilo Borgman (12022-01-31): >>>> v10 attached. >>> >>> Also going to apply soon if there are no more comments. >> >> I think you neglected to attach the file. > > omg stupid me. Here it is... > > -Thilo > > > + > + if (fmt_new && fmt_new != argv[0] && fmt_new != fmt_default) > + av_freep(&fmt_new); > + fmt_new is always NULL at this point, so the above is unnecessary. > > + if (fmt && fmt != argv[0] && fmt != fmt_default) > + av_freep(&fmt); > + Don't free a const char*. Instead add char *fmt_new = NULL; directly besides the definition of fmt and free fmt_new after av_bprint_strftime(). This fmt_new should obviously be used instead of the current fmt_new with the more limited scope. You can then also remove fmt_default. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".