From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AF55141158 for ; Mon, 14 Feb 2022 19:53:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5B0CD68B1E9; Mon, 14 Feb 2022 21:53:02 +0200 (EET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2024.outbound.protection.outlook.com [40.92.89.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6E8EB68AF00 for ; Mon, 14 Feb 2022 21:52:56 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YzToPe4zIZH4AveZqfhz8hzU+/8AUQlhqIEUUYrbUy/YbG6e/FO2bJWscqLRqHwVkBnOqORS6hrbuOnqC/Q6rY/5MCVsj1LcJ487WTxmPQZNbH0POHCB6G3DGXk0TCK+qlB9rwHnOAzMpu5MsZR/2nb3Vwo1q4yd6wrouEafqX3mpvku9hFpHg90hnAKULVan+iehf3rtsmCDJffeOsyvp2IzRclrO1QxSozCO6ScP5pDRCx5IE11PnkwCIXDmn5IKEHf3lNVSBgWtwIJ8dvOG7Dk/oqYrj8oCDPXx9InLqq8CLT7Ezb5TWZIk6cRlVx4yl1GgMc4sqx+DOHxTzpJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fGJrBoXmP+yiW3KnWytKFHKHzaIRbrOJGHcf7d7yXSs=; b=g46NP+PrB1gZy5iveGHekZNIU5qgtc6KXHyukPNF4ISLl3AO8pMhIRs7piVQ3TzbfnY4eSk5Nz7qzl4fepmQ0Pk8WxfhnoTpnibqx9vsz9cpRTP3OqOwHjtQGEKE2Oon4PLIchsTpjAOF/D8GMmyjPSInD+sr32gtTxrgi9fE2kPkWvoXSdBGAm8DKmtqg8Pei6Kmb5w9bS0PPEbpMszG+VWeDXsqpeHYTMtF2DRMXzdyjLE0FcGxPpaS01IQdD4Cv1Z3v6Z3NExGeCIpBLNw5wCK4dm+phyYPfNVhEZpvo/gxpcZGX+F1LbvHG7k5frTHD+llLz6i4Q6Sz731KxvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fGJrBoXmP+yiW3KnWytKFHKHzaIRbrOJGHcf7d7yXSs=; b=kdAJz5xLXyUi3ICXjzRfwDAVyuIo8oIgnQMfSWkg1qa2Q4AdhXIrYwnP4APSA4ZvBnsv20E31JkhtK54SeD0awqtHSeCnlV23HgRK9t3P1Nk0ZYuXsQVyGk9OHvyQVcYn+blxs0k8AhcKcJPj+aFgVOlNa7EOkTnObR824R0a19SGnBH9cSd5A12oUwX1rY0v+KeUEWnIkaPsUAaKjskjVaPQpaIWopc06ieWP9+sLOZBzGX2uGiUmoLtCgGX06pKviE0IIw7EcOtn5jndrHQkdZWzPStgBkcK2DcthsVApgZEI9GUr6OnMGCI4lymvhpxgZawB9nwWRuvj0YHCdfg== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by VI1PR0301MB2189.eurprd03.prod.outlook.com (2603:10a6:800:24::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.18; Mon, 14 Feb 2022 19:52:54 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22%5]) with mapi id 15.20.4975.019; Mon, 14 Feb 2022 19:52:54 +0000 Message-ID: Date: Mon, 14 Feb 2022 20:52:52 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220214193934.22315-1-michael@niedermayer.cc> <20220214193934.22315-2-michael@niedermayer.cc> From: Andreas Rheinhardt In-Reply-To: <20220214193934.22315-2-michael@niedermayer.cc> X-TMN: [L+6o5arLGnVlpxI7dKhxZVlJM9UIu+PY] X-ClientProxiedBy: AM6PR10CA0066.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::43) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <57f88ed9-ae93-b595-979c-4cbc318af337@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8cbb385f-a067-4e13-ef24-08d9eff396a9 X-MS-TrafficTypeDiagnostic: VI1PR0301MB2189:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zGJh7oj3HOajyi+hOa1belyvBtOU7tKR2gthOvoyybSRBl/pZmBLVUuL9xzz/YHWyKXTQ+7H1yFxE3WMl0rHn/whRHv/dHPT8M3x3QM4wKE8sJnF5OMgPdz96p8yfqQ3e5mtO5lb1GzYA3OxqFp3nKBf5opBKUFItapliQwjNeV1vwbWGTBxtvI7biU7/gS7GXt4zCnRI/uh8vOyp8+WvCaX1Ix6FPEE608c75XvLrGVlCGkL6pw3LNUGAAa1XywBoihpaK6mdwFdriXSaD4zHrXqWFUyU2oFuN04Jm2sMA71Mtix6G79dfWG7OQczOh12xgmzK3zEhFoUZfbEvoRsfqoWtI4VcxPGAj5ySih37QYhKODHoHKDJomt3QFOvI7KqsxxnPkgK07r4IXaDS8H+2w0nyP8PYjkMJ2PBR36nIEK4fakCoxaPZVPMl4wCbwD5SMmvGiUPPUt3BiOOrg07YLduvvKTjSwpqwT/MRNKZTt9M6n3olJDSS/u0myzU2lQ17RybsrDZ/KcnIr2BPVOwIg+2qCF3PYJnDcNK4oiaIeAlzmmc5f8V6tfjMtJoziFGmiezJvtbeU1bwNjNXA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZXZLWGozcUJrOGdLYXpuekNhU0lCQ1ZlYWVmU3c2Y1ovR215M3ljTktPYTl6?= =?utf-8?B?clNtaE5keWdhWmdPNE12SmVPTFVkSi96NVlhdkg5QlZ6eU5OdWRwdW5uMXJL?= =?utf-8?B?cTN3MzRJeWxONUxwWDU0ZGkrMis2bmdxSXE3NDh3ZG4vSU5FM3Q0NHQrdzhI?= =?utf-8?B?QXBuN2R6NWM5NGhiUHZSYWN4b3VqZm05d2Rmb0hSYlF0MWphSnYvcnlMYjc2?= =?utf-8?B?S1FpMERVczV2VDZvN084RXVXeGxJc21RQWNXQ1ZXOHFMNUREZ05vTEZ3TFFN?= =?utf-8?B?NkZmd2FPNkpaaktHSERnUFJKclZMdnA4SS9uMnE2OXAvUGNIRHVrTjN0K3Nk?= =?utf-8?B?cTFpMi9pcDkvY2FxSU1CVmdpYTJSOWY1ZmJWL3ZEeGtOc05jcWtCRG1WYVhX?= =?utf-8?B?OEdyNjBrMkJaWHgyNzJvbnVYNWhzRDVoM0ZZWjNJYXF1MXQrWlU5NmxIWHNH?= =?utf-8?B?UEtyankvL0lTellqR1lqcWhnZU50OHFQSnB4NTBhRmwvTHlPalAvZ2JMdkhu?= =?utf-8?B?RDk1bFRSZmJlcHcycWlkMEdkMy9vZms4c0s4MU5sdGFPMjByZmRERFFXRUh3?= =?utf-8?B?Z2lKRVp2MmdPcDV2VHRxdHJsODZKUDZ6TDduUFQwTnV3UmV3S216NDREaTlz?= =?utf-8?B?V3ZXK21HVjFBYnNLcXYweDBUTVgrNHhubmNLQWQ4dHlySmM3aDVPR3g5TmRr?= =?utf-8?B?Q2I3WlZBTlVmc2Zla2ZMRmRYVlRhdDhRZlBQdUp5OE14UHFvMlZxalN4TUdT?= =?utf-8?B?SkJ0S1puQklZbGdXc2dXbVVCd25qeFNHVit4R2ROYXlINDJUQXQvbkpBazNp?= =?utf-8?B?UEw3SzNnNVpVUWo5Yy9kaElRdGJuM243SjlWcG14TFFCM3J4UEZWNUN3cGNW?= =?utf-8?B?R3k1NHJpT2Q2bTJPcDlVUVpOL2toQ3Z0dFl4NUIwc2g4dG1IUUFscVJzaVNG?= =?utf-8?B?bTJVOVpSajFxSXo0dnJyVnlZYWljdXpGdFp5WHZUcEE5TUMxekI5NDY4Vyt0?= =?utf-8?B?WnNGeUcrMWxocUdTMVBsZ1dUVyt4T2ZTWFF4TUgyUzdoT2RQcUs1eDZ0YVkv?= =?utf-8?B?elg1TEw4TE8yMWdJbHFUSlJ2a3AvbHdOb0RmaHhnZXN2Rkd2bE42QVZTUlBs?= =?utf-8?B?cHRPTDhwUjk0S09ZTUVxWkJOWlZuemFFaFhoTVVNV2Nna0p5TjkxWEhLeU9T?= =?utf-8?B?YW9DY2ZLYTczL3hGRlRXVVJNaUozK0FHUHFXWEZheUZMcEc0c0l0UXAxcVlx?= =?utf-8?B?QzM3TFBhK3ErN21tOHQwdW8yRVlpL1FNdURacHpvZzRwaTRNQT09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8cbb385f-a067-4e13-ef24-08d9eff396a9 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 19:52:54.2819 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0301MB2189 Subject: Re: [FFmpeg-devel] [PATCH 2/4] avcodec/movtextdec: add () to CMP() macro to avoid unexpected behavior X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > Signed-off-by: Michael Niedermayer > --- > libavcodec/movtextdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c > index 825632ca9b..dc30fdc698 100644 > --- a/libavcodec/movtextdec.c > +++ b/libavcodec/movtextdec.c > @@ -263,7 +263,7 @@ static int decode_hclr(const uint8_t *tsmb, MovTextContext *m, uint64_t size) > > static int styles_equivalent(const StyleBox *a, const StyleBox *b) > { > -#define CMP(field) a->field == b->field > +#define CMP(field) ((a)->field == (b)->field) > return CMP(bold) && CMP(italic) && CMP(underline) && CMP(color) && > CMP(alpha) && CMP(fontsize) && CMP(font_id); > #undef CMP LGTM. (Did you find the issues in patches 2-4 by code inspection or by a static analyzer?) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".