From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/4] avcodec/movtextdec: add () to CMP() macro to avoid unexpected behavior
Date: Mon, 14 Feb 2022 20:52:52 +0100
Message-ID: <AM7PR03MB6660474D1796F84B3747D3FB8F339@AM7PR03MB6660.eurprd03.prod.outlook.com> (raw)
In-Reply-To: <20220214193934.22315-2-michael@niedermayer.cc>
Michael Niedermayer:
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavcodec/movtextdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c
> index 825632ca9b..dc30fdc698 100644
> --- a/libavcodec/movtextdec.c
> +++ b/libavcodec/movtextdec.c
> @@ -263,7 +263,7 @@ static int decode_hclr(const uint8_t *tsmb, MovTextContext *m, uint64_t size)
>
> static int styles_equivalent(const StyleBox *a, const StyleBox *b)
> {
> -#define CMP(field) a->field == b->field
> +#define CMP(field) ((a)->field == (b)->field)
> return CMP(bold) && CMP(italic) && CMP(underline) && CMP(color) &&
> CMP(alpha) && CMP(fontsize) && CMP(font_id);
> #undef CMP
LGTM.
(Did you find the issues in patches 2-4 by code inspection or by a
static analyzer?)
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-02-14 19:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 19:39 [FFmpeg-devel] [PATCH 1/4] avformat/matroskadec: Check duration Michael Niedermayer
2022-02-14 19:39 ` [FFmpeg-devel] [PATCH 2/4] avcodec/movtextdec: add () to CMP() macro to avoid unexpected behavior Michael Niedermayer
2022-02-14 19:52 ` Andreas Rheinhardt [this message]
2022-02-15 13:37 ` Michael Niedermayer
2022-02-25 21:21 ` Michael Niedermayer
2022-02-14 19:39 ` [FFmpeg-devel] [PATCH 3/4] avformat/argo_asf: Fix order of operations in error check in argo_asf_write_trailer() Michael Niedermayer
2022-02-25 21:22 ` Michael Niedermayer
2022-02-14 19:39 ` [FFmpeg-devel] [PATCH 4/4] avformat/argo_cvg:: Fix order of operations in error check in argo_cvg_write_trailer() Michael Niedermayer
2022-02-25 21:22 ` Michael Niedermayer
2022-02-14 19:56 ` [FFmpeg-devel] [PATCH 1/4] avformat/matroskadec: Check duration Andreas Rheinhardt
2022-02-25 21:19 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM7PR03MB6660474D1796F84B3747D3FB8F339@AM7PR03MB6660.eurprd03.prod.outlook.com \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git