From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0BA67422FF for ; Fri, 17 Dec 2021 11:43:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9CB2468AE4A; Fri, 17 Dec 2021 13:43:26 +0200 (EET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2062.outbound.protection.outlook.com [40.92.90.62]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4DC4868AA67 for ; Fri, 17 Dec 2021 13:43:20 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kv831E/6UZAD5jyBecp1mXiswPR3MaVqIFOwtz29gtPalPHDfVMHzNjQ1W0TN1iyRmkOOjzTgDdvtbNy+JvI0iZy2QluubEl58JFeD4697pn8j11YIHIeLcIjXBhlot/ssTnOjPOKaOj9i+3v0nQd1CYjm4IV0Q46TwHhskXsxXW992k9vPo3dG97TxTKD1mgfvRMz+AzWcFe1DnuQ4LNME5w8Of6Gl71pBz+FLJ9Ywf18OAC85piaNsfX9td/vPB4jXzJ50my/TfOMfsehi4Z0xlrucr8E/UKe4heFdaacxGmjo2mGSk0ASU8ENZ018kSQAYT/Uo3yXUhtZuYYR/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b32VKzzW9gB3uwG0hv1LXIST0CaclzEMjLMmkvknfjI=; b=i1gVXTfnH3Ig5HyKBHpLJaB4GaGwRNG1TGW41vzaVeXHrf/AfMTOwJkMYSH4m9+Cg3aszw7MBajT6LeoLNlnXozSMZV8JI3ZVfwRAUKCW5HCZBocTVx5moIHQ51TfhPgOU6sp5UpUa1q6ptR5BRRedQAjciyitpe+AregtC73//TxY44FRNkuuy/HyilN7hYOc7DJQlRnP78HS5Euf3TiShmmbQWWITx90NjQ9TRl869o6RgN2SvX4mDLynkZQU1fi7+GvpVOCxJlGzLk4Wq3CuXdA1MNBzLUb0MmX1Kpe0ZFdSxNG6nzRom7YxcyhGPgqt33OL7THBNx0f4JigYqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b32VKzzW9gB3uwG0hv1LXIST0CaclzEMjLMmkvknfjI=; b=jZ8X5TVQCZipF0Mz/33DxshtyM9oYkwqMftQ8blQ5cFk7QA8IoZPBfkKXBBWqZNQp3P2agnaLnPqdQ8FetplJ8y/SwfikHiCTl6HfRFZD09rjVgWVK2aimZkJneyFXNqF8F4ra1fPnZ/l7EzysIMDxOAfhjR4LvdqxfxA6xmhF6ubWuIFrgSnXIDSIAeNQjzzYCP3WBIPYj55rCm6boH/0NFORWIMu3I9RfhvfvZwhFtCm5LnVedmiKXvzI/nxBQdHv30Ax2avOi826unOWE1SXnkrmAzuix+OCLZkKB0Ko3CPKMtXA5OqVS/S5b7CM5ljLOZ6lNRNs6JvSx7IZFLA== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM6PR03MB5443.eurprd03.prod.outlook.com (2603:10a6:20b:c7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Fri, 17 Dec 2021 11:43:19 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::f0dc:92f5:6bc2:45ca]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::f0dc:92f5:6bc2:45ca%6]) with mapi id 15.20.4801.015; Fri, 17 Dec 2021 11:43:19 +0000 Message-ID: Date: Fri, 17 Dec 2021 12:43:17 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20211213152042.5900-1-anton@khirnov.net> <20211213152042.5900-5-anton@khirnov.net> <163973359101.13029.8183236648046984224@lain.red.khirnov.net> From: Andreas Rheinhardt In-Reply-To: <163973359101.13029.8183236648046984224@lain.red.khirnov.net> X-TMN: [49X2cR93K/S6BSx8fLPRQ0iTaiOd7WGo] X-ClientProxiedBy: AS9PR04CA0078.eurprd04.prod.outlook.com (2603:10a6:20b:48b::25) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fd39e6f3-7594-4d8d-15ea-08d9c1526bb6 X-MS-TrafficTypeDiagnostic: AM6PR03MB5443:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GD0oQ4JGNn2DV0evLAIMWFAnnAiVDnIjzx8cXMxP1c9wc2eHClbrxtEbNJ0srF8XWE26SmNxn6JMLT71qpLWCpMDo73/asx1vu+hO2C5E61ktEOZi84u5qGnUY9f/kbPEoWdLm862x1tEMziEYW2Z1Cuq/8Pzu0baJP5ur6VnbCPAMFfz4iOPFqUqgPPF6eHzVn9yjMTgaDMKseVmtmS4zOSrHATEYRzbyaXoksRqfYNDlTQS7niT3+m7LDDagUOTP08P+Bkb2KUx0WAK9uCbXbrAWVn3k0+LZ8EO8pfOTr5vjbAv4J+vvEcwHEbqSb5YgRaOMYdKsDY4jgwtuTb9+cxOYLS9RSUy8Ddetp47Vt8DC7NqJjGyJQ59VpFYnSFYyReklN92xBc3sTRZQMxIBIOSGvPwkXmT11KxB6W0IKS6tCb9AV6OcioZV5Bc12MrWhsnDtcyK7UZe3IIKCRhosrnjW1WrEEU+GHBHnm+DorFBbQHSAWLTtzbG2X5n1OUjMnQjoj2G8O5lgu8pD2PkzDXyuyi6409s8UQZ6Jm4cmGVJjMkmbtDYPTITQR+S+zr3tzQ2W8C7QFgcIztOS+w== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0pnTUYzSHAxczdXb1gwcnlWSE42ZEZvdnNwV0ZoR0VCdXpqN0x4eUVUVC9p?= =?utf-8?B?TjBYMHE5TDM4czRDdjkxUGp6UDFQVFM3MXFvOEx6Nm81aHpyUlZOb05OOTE0?= =?utf-8?B?M0IwTGZMc0MzVjRUZkhReXVub3ZzNnlNNjZsNU52dXhPb3pBK1d4dHhPeGcz?= =?utf-8?B?NGJMVkY0cDc2WXVldUx0dTBBVWVSWWdxaW9ZcTRrWG41RHh0VmY1RWp5cVhs?= =?utf-8?B?NnFHWUI2aCtEMkdiSVA3MFpRK052QXJ2azlvajA3eWVtUkNqTld4VWhUUzRM?= =?utf-8?B?WHh0TDVrTFNFNW42UmxnSm0xdGtENHJBNFdmRnNIQ1RDY1VsUTBOcGxRUC9s?= =?utf-8?B?RHlkbFFEWFBQSVhwbjBONHdYK1owczl4eGc1dmYwWDdTKzJVUkJCckRoTlZv?= =?utf-8?B?bm9hbjNDR3pMUEUzMDhyZis1eHh5Q0tPM3lyNFVaRVNtdnBTcVZrbDBXVWR2?= =?utf-8?B?QnRHOGRvU2lHbk1iL3JNbzNZL3JwRytVTFRUY0F3Q2ZvTHdRb1RYNmtoL1Za?= =?utf-8?B?VDdIN1g5RTFVM3ZrNkp5ZTFUWkt5R294Z0dTOGVEOTJaUW52N251b09ROUZ4?= =?utf-8?B?VnJwTU95aXZZOE9PYjB4Ri96ZXRHWG01SHBXT2drOVB0UVZqSUpKeVdvUDRh?= =?utf-8?B?K3dLSlVDV1J1WFl5dU5PV2VCYkJSMVltUlJqWGcxOWd4cWw3VnNaQWRHdFp3?= =?utf-8?B?MlhmK09UNVlDeW5YcVB1L1JzQW9JZnJyblMvR0dqWldIU3llNEc5UjVnSUJu?= =?utf-8?B?ejVHZnN4ZFZIa3V6U2dCRVptR2syUTNYbnQwNFRoSldieXM1MVhpdnJWQ1JB?= =?utf-8?B?MTFQc3ZqOHMvZktPVUwwWDJIY2VYUDJEZWJ1czNlMlZQay9STmFLZjJEMlNw?= =?utf-8?B?OEZBVkxHRFEyNU5nNmZRSVFpa1orMGxIM004Qjk5UjJobmdPckFzR3VrTFE5?= =?utf-8?B?ZnczckR5NVA4N2RVQU5UbGZXTC9OcnM5RnBkNElvQ0pGVGlSWEgyNEZIckc3?= =?utf-8?B?VTJ5Yk9WeVc4eGFwcHFSQTZta1NwMG5zTzBta1Nkdnp6dXdCdFdocDlkVUF3?= =?utf-8?B?K0RodnVZK0xWb2hoaWc4RS85ZzcxNFd2a2x1TUNENXo5MkFicXl3UkJQRENQ?= =?utf-8?B?MmxBRjc2NFV3ckFJcE9BYXdrQmh6amoxOTVIVmVTUkRhaXJraHdyUGY2UWpy?= =?utf-8?B?ZzRwaEErSDhCTTJLb0dvTG5CMThLejZGNEhoM3FwNS9XbXo1L2lpOTNIaGhI?= =?utf-8?B?bjdLU1dJcFJCYldKdko4Q0xMTFQyM0RqU1RtT2tyU2hSNWF1Zz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd39e6f3-7594-4d8d-15ea-08d9c1526bb6 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 11:43:19.1647 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB5443 Subject: Re: [FFmpeg-devel] [PATCH 05/24] ffmpeg: move some muxing-related code into a separate file X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Quoting Andreas Rheinhardt (2021-12-17 02:55:43) >> Anton Khirnov: >>> This is a first step towards making muxers more independent from the >>> rest of the code. >>> --- >>> fftools/Makefile | 11 +- >>> fftools/ffmpeg.c | 273 ++-------------------------------------- >>> fftools/ffmpeg.h | 10 ++ >>> fftools/ffmpeg_mux.c | 293 +++++++++++++++++++++++++++++++++++++++++++ >>> 4 files changed, 320 insertions(+), 267 deletions(-) >>> create mode 100644 fftools/ffmpeg_mux.c >>> >>> diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c >>> new file mode 100644 >>> index 0000000000..e7c6ddd8f8 >>> --- /dev/null >>> +++ b/fftools/ffmpeg_mux.c >>> @@ -0,0 +1,293 @@ >>> +/* >>> + * This file is part of FFmpeg. >>> + * >>> + * FFmpeg is free software; you can redistribute it and/or >>> + * modify it under the terms of the GNU Lesser General Public >>> + * License as published by the Free Software Foundation; either >>> + * version 2.1 of the License, or (at your option) any later version. >>> + * >>> + * FFmpeg is distributed in the hope that it will be useful, >>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >>> + * Lesser General Public License for more details. >>> + * >>> + * You should have received a copy of the GNU Lesser General Public >>> + * License along with FFmpeg; if not, write to the Free Software >>> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA >>> + */ >>> + >>> +#include >>> +#include >>> + >>> +#include "libavformat/avformat.h" >>> +#include "libavformat/avio.h" >>> + >>> +#include "libavcodec/packet.h" >>> + >>> +#include "libavutil/fifo.h" >>> +#include "libavutil/intreadwrite.h" >>> +#include "libavutil/log.h" >>> +#include "libavutil/mem.h" >>> +#include "libavutil/timestamp.h" >>> + >>> +#include "ffmpeg.h" >>> + >> >> These library headers are ordered reversely to our usual order. Is >> this intended? > > I am not aware of there being a usual order. So no, it's not. > The usual order is the inverse of linking order (i.e. lavu-lavc-lavf). >> (It has the advantage that e.g. missing lavu headers >> in the lavf headers could be uncovered.) > > Won't make checkheaders also find that? > Some of our headers behave differently when included internally (when DHAVE_AV_CONFIG_H is defined) than when included externally; the fftools belong to the latter category, I believe checkheaders belongs to the former. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".