From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 346F440882 for ; Thu, 23 Dec 2021 21:46:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F346B68B1CD; Thu, 23 Dec 2021 23:45:57 +0200 (EET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-oln040092072070.outbound.protection.outlook.com [40.92.72.70]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0B29E68B0E7 for ; Thu, 23 Dec 2021 23:45:50 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=euI5Hssfv9/WDYpPPxE5vqOXjB/qqkO2od8F5vmsBvB89zi8Lrfe41RugW76ISg7fK7nBoIyiePIgTt6KZJnYRIusySPgAiweAqj9L205milfq/W8yYihMumoK1Fd2I3jKJGJaL7tqeQa1CDJBFmt9qnnClz2SgCKHgYbLYricZIWMMy9JlLkKTrqPOzGAcVparOF3BRFOJ7CrzVqHpgKIphcODU/W2UoRlP1ideAShc40S9OIsDN1Sv8S2QsU5bUiO0UcIL037XDdxmRq/RHEhVePHAMAy1/FypWWuXELkTPrFO6R5/twP3h1Ni+hjUPE4GQHfjayJhGy685Wvwkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=47/k3nnmUkdlbRt/qazwUqVs83nfgMl4iME7T36b2vI=; b=JEX8PjSZgkhRVse/7dijX+AqjP4KZrqnzSWSd28a62Uxva9IHsq3T8OBZ4Ql3FJ6vqa10kr69DrZ7wxCqdQgd1d1uNWpycphKkAKplRVIEV6RDx4MUdCtwAHLmd+Rp+wtD/SScJc0XNZEtnX9TwqDfZS/mhMQYMQrQN54ewOcUu5dVsXQIHD3ymBSnQa7F62ieF+IFs8fXRjwt4/JE6T4e60VxVXezWC5eO60AanRDyEd8ukDhVRjEoqJCviJy7edYkPR4R/WHRCxsZpIrgOE7mD+hwI/xpn0tpBNoZA1sBfs5TySMeQl/opGgj7dzm2u3zZsOr5hnsC3P2KTmMW0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=47/k3nnmUkdlbRt/qazwUqVs83nfgMl4iME7T36b2vI=; b=ozGQGNlu3LAri9xnbupld0RDtxvboG3pcwryy7PAyZNAUbAjtxdADJvLW7lvxMSlC4puZ3gjUsEiTRzBYw6K+5xNWMb3eg7hDUlnDJkfw42nxz5e7XYHb88ySoa/TKesbfuFnzyChYf230OSQ+wwHpv7aYV8pJelh8ctpDbP5zHdM4V71U2Yt2zwTivnpt00XsxM7hqRIkB66A9jBEMQ/CSe7rX3aX3pr468JrvZEHBdp3YF/JhwOfYJwpHMqGJ32rzrRXIqL5LICDj50GsFXW0er8sDHJubinHp43m6x0SzU1RmUdG1bf7nwJyNyvAkRhO00IkHXTJRIkt3+st9lw== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM7PR03MB6327.eurprd03.prod.outlook.com (2603:10a6:20b:137::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Thu, 23 Dec 2021 21:45:48 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::f0dc:92f5:6bc2:45ca]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::f0dc:92f5:6bc2:45ca%5]) with mapi id 15.20.4823.019; Thu, 23 Dec 2021 21:45:48 +0000 Message-ID: Date: Thu, 23 Dec 2021 22:45:47 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20211223211527.20408-1-michael@niedermayer.cc> <20211223211527.20408-2-michael@niedermayer.cc> From: Andreas Rheinhardt In-Reply-To: <20211223211527.20408-2-michael@niedermayer.cc> X-TMN: [o2qijtJoR684606qHtf1e9cInhSefk6K] X-ClientProxiedBy: AM0PR10CA0027.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:17c::37) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <4a4c9e4d-87ec-1efe-e5c5-19fc97e57b64@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3be04543-df05-4db8-6da8-08d9c65d9514 X-MS-TrafficTypeDiagnostic: AM7PR03MB6327:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C37Zu2WvOUJNPKKND6gDtkXg0EUbGBTmyGe1Z0ueJ0BYO6p27LfCiwMGddDhjLOu4w75IBd3HtHjUTMkXXemuD1qcLoLBcO/wtMFmfhTwmV8YodU0Zzk5NfBNcl3SCC+EjwMH03+42YQiRFtOaXv3alaWM+bkdyk2ZSGhTNdWw9WBX+aF96N9U1SNd879Ldf1VWFeH0EKdkJOfY8uvijYLu2M1U4FJTc2nAncyBbXlDWW+sTQxuj/vKsCEo9gACGduxSJyuJPJIyBFWEup+RtgeIX5ugCiKSzxDHT8gvzZ9OH10mFQnQQm2MQHjZPPVnexui7lhqxrZ/NEQPyBEfgDFd+DXy5Haz1K4HQ2rI9bm5GYVrkrb7XzSV3EeJbg0awnEBN1F3/VwAPdIdBm48i/O7bjWnP/93Jf4oFnXxONjEnFYsiAJeeKtW6GZsO/lEgzWjHN8DttPJeP2wmWrU/FN2eAxSkDLhTZzAYgqDIwkP1CJ+vzI4YRD3sgHH6i3eXddkkFmOFGjHwV+/yTb37OHb5+sl9s1PEFJnvTvDnr2IhSsU4qizvfRINHWSCuzvHs/NAgJocJdTQXZaWf0l/IcM7oxYFLsyEsavMUCARb+B/SFdJ19BmGOiU5ijKPri X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmFqZkREbldZOGZTRHY5R29hNTkyYTR4cGE5eHorUmtGV2Ywdm9UTTlZank2?= =?utf-8?B?MWZyQ2Q3U3B0YmdyOWxZRXlld0Fja2RqcUk2aVVqUUdETlBZOFBGZ2FaUitI?= =?utf-8?B?cWxWVngrQ3V4RS95d0EvNXRNMGZkNGRzZVNlc0JsNTdrbHlsL0xiNnY1bm04?= =?utf-8?B?bFFBQXA2THdJVzF1c2xHSzg5VVlkZG5zNUJpQnBCN0pKUHd5UVRzVjFaalB0?= =?utf-8?B?amxGS1NaYzVLVWlVNk5XV1NvUEJVa09iSDZBUEo1eGpNTmQ2SkovMk5Gamo3?= =?utf-8?B?eEF6cXg3Y1hsZlJKUTBHZHFhQmp1U0Q2TS8zeXYzWlRuOExNYUQweXUxS0Fa?= =?utf-8?B?VVhlRVhtZEpqVkMwSDlDUi9oYU13T2FUcGE0eHFxZDM2TXI5eG5ubkpWN3hi?= =?utf-8?B?Ky9qeGpLMDd1NlZHZlYyT1c3L3ZkYTRKZStYN1JobEdMYTdJSDRZbkE2MzFl?= =?utf-8?B?ZlJWYWhZRWtiZGR1K01TZW1YaitNUWpFTlg2NFJCTDR5MnN3VmpRVGFhTXdC?= =?utf-8?B?ODVQZWFqcm1NQkRkKzVVQ2lBQmdBVVk4TGxuNmQwYXlucktzcSs0RGt5NkI4?= =?utf-8?B?eHdPdUF3cjB5ek9ETWl3NjNxOWRSTUJyalFZMlovSEtaVkVrMmllbnM0WE02?= =?utf-8?B?WFg5VjdoZ1RhTS91dzNMTlVTaENNSDJoM0Flb2QyYTA2V0xITTFDSUx2SW5o?= =?utf-8?B?cFM5T00wdENNbm11MkVGeENZNDZVYWp3ay92MEx4citsN3NKbjdrcGMvaWFw?= =?utf-8?B?VG9tNk50QkNGOUpQNVQxVng1Uk5kUEh0Z1orZ2htVUtPS0JBRnlEdVM1RDJa?= =?utf-8?B?UnRqekZ4a25RbWlkVGNDb0ZGc3ErRkpQOHEwZlg0Ky9ONk9sWS9iVEVZb0tH?= =?utf-8?B?bXZLSW15ZS94Wkw1SzZSSXR0T1NMNE1VZno2eTBIejgvdldVNVBVbVl4Q2RD?= =?utf-8?B?ZVpiQ1hQZUxMWjRoR3lYdWczVXgrMWtuTEVMdGNSbXN2dElDWmc2Z1F4NFV3?= =?utf-8?B?WW9mOW9vK3BDbjNTNDhkeitXQm0wcEx2Q1hqZWt1NmJnNGlxR0haTTJzZDVm?= =?utf-8?B?OGoxVFJrazRYYVlmZlZWRUQzU1RyekpESkx0TEtnZUZXQ0lNL3NscHZ2ZjB0?= =?utf-8?B?SS9DZVRLeVdRZ3hTQzZDN2hnT0RuM0NQRkVxK3dEWGpuNytWQVVYdnFTMHIx?= =?utf-8?B?dEhoNExxaXRKS2ZKb3lORmt3R2xYejRicExOZzM3SlFDeWRtYWwvd2pSNHJn?= =?utf-8?B?KzJna0pWVHhYTzhQL3JsSE1HRExuOFA2dlZRMFFxVkx2ZWptUT09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3be04543-df05-4db8-6da8-08d9c65d9514 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2021 21:45:48.7850 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6327 Subject: Re: [FFmpeg-devel] [PATCH 2/5] avcodec/cdgraphics: avoid signed overflow in alpha X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > Fixes: left shift of 255 by 24 places cannot be represented in type 'int' > Fixes: 42766/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CDGRAPHICS_fuzzer-5142826105569280 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/cdgraphics.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/cdgraphics.c b/libavcodec/cdgraphics.c > index 06f83920943..f54ce5a05c0 100644 > --- a/libavcodec/cdgraphics.c > +++ b/libavcodec/cdgraphics.c > @@ -122,7 +122,7 @@ static void cdg_load_palette(CDGraphicsContext *cc, uint8_t *data, int low) > r = ((color >> 8) & 0x000F) * 17; > g = ((color >> 4) & 0x000F) * 17; > b = ((color ) & 0x000F) * 17; > - palette[i + array_offset] = cc->alpha[i + array_offset] << 24 | r << 16 | g << 8 | b; > + palette[i + array_offset] = (unsigned)cc->alpha[i + array_offset] << 24 | r << 16 | g << 8 | b; > } > cc->frame->palette_has_changed = 1; > } > LGTM. Although I'd prefer uint32_t here, as this is exactly what is needed and it fits the type of palette. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".