From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> To: ffmpeg-devel@ffmpeg.org Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> Subject: [FFmpeg-devel] [PATCH 09/17] avcodec/alsdec, mlz: Check allocation Date: Sat, 12 Feb 2022 07:41:23 +0100 Message-ID: <AM7PR03MB66603A956042571EE3724B5D8F319@AM7PR03MB6660.eurprd03.prod.outlook.com> (raw) In-Reply-To: <AM7PR03MB6660B64CF51092B53B6AF74B8F319@AM7PR03MB6660.eurprd03.prod.outlook.com> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- libavcodec/alsdec.c | 4 +++- libavcodec/mlz.c | 7 ++++++- libavcodec/mlz.h | 2 +- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c index c09401d257..029c37e99c 100644 --- a/libavcodec/alsdec.c +++ b/libavcodec/alsdec.c @@ -2111,7 +2111,9 @@ static av_cold int decode_init(AVCodecContext *avctx) return AVERROR(ENOMEM); } - ff_mlz_init_dict(avctx, ctx->mlz); + ret = ff_mlz_init_dict(avctx, ctx->mlz); + if (ret < 0) + return ret; ff_mlz_flush_dict(ctx->mlz); for (c = 0; c < avctx->channels; ++c) { diff --git a/libavcodec/mlz.c b/libavcodec/mlz.c index dbeb7dcad9..9087ffd8f0 100644 --- a/libavcodec/mlz.c +++ b/libavcodec/mlz.c @@ -20,8 +20,11 @@ #include "mlz.h" -av_cold void ff_mlz_init_dict(void* context, MLZ *mlz) { +av_cold int ff_mlz_init_dict(void *context, MLZ *mlz) +{ mlz->dict = av_mallocz(TABLE_SIZE * sizeof(*mlz->dict)); + if (!mlz->dict) + return AVERROR(ENOMEM); mlz->flush_code = FLUSH_CODE; mlz->current_dic_index_max = DIC_INDEX_INIT; @@ -30,6 +33,8 @@ av_cold void ff_mlz_init_dict(void* context, MLZ *mlz) { mlz->next_code = FIRST_CODE; mlz->freeze_flag = 0; mlz->context = context; + + return 0; } av_cold void ff_mlz_flush_dict(MLZ *mlz) { diff --git a/libavcodec/mlz.h b/libavcodec/mlz.h index c3df52c9b4..24993126ca 100644 --- a/libavcodec/mlz.h +++ b/libavcodec/mlz.h @@ -57,7 +57,7 @@ typedef struct MLZ { /** Initialize the dictionary */ -void ff_mlz_init_dict(void* context, MLZ *mlz); +int ff_mlz_init_dict(void *context, MLZ *mlz); /** Flush the dictionary */ -- 2.32.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-02-12 6:42 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-12 6:24 [FFmpeg-devel] [PATCH 01/17] avcodec/svq3: Mark decoder as init-threadsafe Andreas Rheinhardt 2022-02-12 6:41 ` [FFmpeg-devel] [PATCH 02/17] avcodec/amrnbdec: " Andreas Rheinhardt 2022-02-12 7:49 ` Paul B Mahol 2022-02-12 6:41 ` [FFmpeg-devel] [PATCH 03/17] avcodec/amrwbdec: " Andreas Rheinhardt 2022-02-12 7:49 ` Paul B Mahol 2022-02-12 6:41 ` [FFmpeg-devel] [PATCH 04/17] avcodec/rv30: " Andreas Rheinhardt 2022-02-12 6:41 ` [FFmpeg-devel] [PATCH 05/17] avcodec/rv40: Make decoder init-threadsafe Andreas Rheinhardt 2022-02-12 6:41 ` [FFmpeg-devel] [PATCH 06/17] avcodec/apedec: Mark decoder as init-threadsafe Andreas Rheinhardt 2022-02-12 6:41 ` [FFmpeg-devel] [PATCH 07/17] avcodec/alsdec: Return directly upon error Andreas Rheinhardt 2022-02-12 6:41 ` [FFmpeg-devel] [PATCH 08/17] avcodec/alsdec: Improve code locality Andreas Rheinhardt 2022-02-12 6:41 ` Andreas Rheinhardt [this message] 2022-02-12 6:41 ` [FFmpeg-devel] [PATCH 10/17] avcodec/alsdec: Mark decoder as init-threadsafe Andreas Rheinhardt 2022-02-12 6:41 ` [FFmpeg-devel] [PATCH 11/17] avcodec/ituh263dec: Make initializing VLCs thread-safe Andreas Rheinhardt 2022-02-12 6:41 ` [FFmpeg-devel] [PATCH 12/17] avcodec/ituh263dec: Reindent after the last commit Andreas Rheinhardt 2022-02-12 6:41 ` [FFmpeg-devel] [PATCH 13/17] avcodec/exr: Mark decoder as init-threadsafe Andreas Rheinhardt 2022-02-12 7:48 ` Paul B Mahol 2022-02-12 6:41 ` [FFmpeg-devel] [PATCH 14/17] avcodec/vorbisdec: " Andreas Rheinhardt 2022-02-12 6:41 ` [FFmpeg-devel] [PATCH 15/17] avcodec/avcodec: Decrease the amount of time while holding the lock Andreas Rheinhardt 2022-02-12 6:41 ` [FFmpeg-devel] [PATCH 16/17] avcodec/msmpeg4dec: Make initializing VLCs thread-safe Andreas Rheinhardt 2022-02-12 6:41 ` [FFmpeg-devel] [PATCH 17/17] avcodec/msmpeg4dec: Reindent after the previous commit Andreas Rheinhardt 2022-02-17 7:46 ` [FFmpeg-devel] [PATCH 01/17] avcodec/svq3: Mark decoder as init-threadsafe Andreas Rheinhardt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AM7PR03MB66603A956042571EE3724B5D8F319@AM7PR03MB6660.eurprd03.prod.outlook.com \ --to=andreas.rheinhardt@outlook.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git