From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CB4A340E31 for ; Fri, 31 Dec 2021 13:28:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 893A268B007; Fri, 31 Dec 2021 15:28:31 +0200 (EET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-oln040092065100.outbound.protection.outlook.com [40.92.65.100]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C38E868AE3F for ; Fri, 31 Dec 2021 15:28:25 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F55WtYiTTdKQtQ95F3b2nmllhp8BZpuyqBLT64dzI6MRauRqXvr040Qyrzxw0P5eZM3oDrAZfUe88zQSklCSQy+YK3FFS6atIct7+FP6UgkfF9M2+s+myPJW+Y8teSZzlqEN0PUrmlMK4hke4Rg2aAHbZjA9imXqFyV1Rlx+HFetGMIpPL2SSvX4fa1Pfb3V1piLvWXqDZLjCxn8LoN+qpm8HmNuRFZ2WXSk/FttSOlNfzKKveF5mqxfAyVdNJcROhSMOGEcQg4n7z/JbseJ6WLNkuJCIRV4dGPRKRwBELpfg1HxTAN7cegbwOaRR923aRtt4dhI1edQ4V3U/dcDUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nxa/svw3L1Kf6ZfvXZDBzHdyXmb/L6xDbIZZ4nomzro=; b=CtV4Y7QmRSraVR68c8rXZdK893Qt5OA8JRlsuG7BlPQ6X25ns6Dv7cexCC7fd8vwCzwi4LQf2FmjDmXYec0TviuESAn03YxE1NNtmfWmCGSTtw7T+BtB7NIvOzvhnsQJePAbTERXk2LHaA3at98Tbf4p2pc120YtWN90WLXKYJD4PSdnL+ozlrBFRg0YZWXL1T4ILok7ZBTCOTzYttYPZXeMWuU6zvh6rYmb2bIn5jnvhnJ6WL0woagKw1dKMSTFKKXXJjh/4R+M1SG5qx1PHf2pJ+tokI/P+ulUijZBBv4tw2FoYcBqGEyKXawW+Gw1jHEdFE0MQ2L/+kBpGAc+OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nxa/svw3L1Kf6ZfvXZDBzHdyXmb/L6xDbIZZ4nomzro=; b=nEAKluJSII9sjp2u4ZV80fBgawB2/1Y9JqEHJ6y2/9QcNwF/zt9KKObYnl649yaU3vBJADKmjEq6v8gzdwJUmdqBYmznnoUchCPO/coKPeogltuq4AAzkv8ylVLg7dpvfvMZeGALc6ZthoAhSEjj5NhQuB4HKbr51qlULXQIk1BXXvxIoSqZAUyNodRcg6E9cv/elc1NCBS6sENNqwCafXl0HloPXcieeXWjm2EdIapm28f2GqN32/fgRFhsOawla7cBCZf83ow45KtDbJFC/PqcT0tfUOWC2Z2CQf38UGE1uoqw31YVKyqz3RfrAVlTpM2kUtz/v5yfgf5YSlsY/w== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM6PR03MB3606.eurprd03.prod.outlook.com (2603:10a6:209:2e::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Fri, 31 Dec 2021 13:28:24 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5%6]) with mapi id 15.20.4844.014; Fri, 31 Dec 2021 13:28:24 +0000 Message-ID: Date: Fri, 31 Dec 2021 14:28:23 +0100 Content-Language: en-US To: FFmpeg development discussions and patches References: <164085916638.2375.6835847434776821902@lain.red.khirnov.net> From: Andreas Rheinhardt In-Reply-To: <164085916638.2375.6835847434776821902@lain.red.khirnov.net> X-TMN: [V9IALOD9ufLqVORcq3IE1lyA4tgHGRi8] X-ClientProxiedBy: AM6P193CA0107.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::48) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <5485c39a-3755-a5d4-d4b9-b6128361d451@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0b662451-ce6d-4e4e-d462-08d9cc616b86 X-MS-TrafficTypeDiagnostic: AM6PR03MB3606:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y8wd3ymWbkbU6bplxsdNt4t/S7cm4yJ+GJ+UhC8yy2/elY0PHp889EgdGDMtNPV/Rd+3wSnx4pjluHFOs5KQ5Xmo56fki1qQJ2XVelk9zp2fjsBdTntdm0Q/jDQb2IK7nV2A/9QcVVhKavS50YxV+TiYa7c24itil0gO3pb8Wxh+7xE7zxITL06O06sT51aL8ThI+eVDi/FGIZ0vqk4iukRLbcoob16lhRju6jUY5dLZj18tThcjTHlpe2Y2fye4U8usX1LYt7a46b70TsZhoZbfnxgsQlAjb10wCjM3oa1QtiwqD0yQ4y8Oo1FoSBx7Vwd2b5/jMR7oUAk7C8HPvHk7Gw47l3T8HAyHqubE420AsXmfnIkASwQgkHKvOcxLQaBO7fpLfbqPibze0/teRbhf0rx2E/EmOxl40XpKxpKGskpfbZVXDr0+UDI511hqUylxtEyNV9A7vlhFnWjKwyE1mC8B30NLcbomD8fQe5V7Dnzu+ibv7Z0v7SheFmx3xpTAj1lGT0DMsfkU1WrtGkdHvpFYxlXMNkFPKy0ZjO4rlBNS/SkRz5RfF/d7tG7yug3yhEbDIHKcHH6y51cQ2WfTsi9lfCXKtBYrC2yrSRATZO1pM3ivZwhQk297j4rt X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SlRKUFFISzlsa0FBbE1aMkRDdlQycWs1THdPWTZkQzI0QWhoL3hmVFdzVzB3?= =?utf-8?B?a1FIS3NDV1AwdXBGd1ZKbUdLT0RFZkc2Vk1WdUJWTU90cEtGNWJXbGxMejNE?= =?utf-8?B?cXVIMjFabUpRc1FIL0NHTCt1S0JJZHNuUzVYT2d3dXJscWlYTUhKL2cyaUpa?= =?utf-8?B?UmZrSWRzSlozUStmV1RROEJSN0ptMERMSnAyWjVYQUxyN2ZIVUZUU1dSeXUz?= =?utf-8?B?ZWIvOFFaU0R0dFVCT09yWHprTkd2bEcyWlZ1ZktGVlFmMU5IbWQ1c3YzQ2gr?= =?utf-8?B?RXdRNWkyU0lzRjNuTTBDTHN5bkVua0pkUXk1U2UxQ0JjazVtNU03Sk5tVDJF?= =?utf-8?B?d1paK2lvcXdQbEt2M3h6c1BTSDFveWpLODdzNFBzR2NuTCt1eklWRTUxQkMw?= =?utf-8?B?RmlPMXpjUU9WUStpNk5wMmluSE5saHBWbjhnNlBEVlU2blZWZU95QUJCVzdM?= =?utf-8?B?dHVPeGhvSFJpd2FPWENjM3JyMktQNmxmeVd5M3UvOXRxdnpFei8yZ1B4VWxZ?= =?utf-8?B?Tk5JV3hLdzBKVmVIWVZLT2tKSW9ReSthR1VQV3o5TXh4dW4wSmM3QnQwckVj?= =?utf-8?B?enRkbnFaVEtaMG5YNGtMZUJTSUVEdHFhVitWOWowVkRRZlhiS0dJbFIreCtE?= =?utf-8?B?bHRxbXExNHFsZDFNU3VVR0tjTytZZEdpN2ltckpLbDFpU2E4ekhxTTIyYjV2?= =?utf-8?B?bzE0QmcrT0ZPbU01dDM1OUFVL1E5TE5adVNIZlZjK2xYa1p1Zk5MSGVlbkIv?= =?utf-8?B?VEdzZ2hEWDNmRXlyUXVyUVpLQ2RHU3dYbkVGOXJwcHNHSklJUStxam5UdUl0?= =?utf-8?B?SlhaU0dlNFJGck5VbWVzc1dPS0d5eXhxNXdIOU5rRkhOaC84Ny9wdDZxUWtZ?= =?utf-8?B?YVlOMmlNNkFETDhyRzVzeGhIdGZ6aU8wUXM0UHgzYVgrZklFZExUbFNTSkpU?= =?utf-8?B?R0gwU3pJbTRXZUdZS2ExRjk4K0R3Z0k5ZldEU052dEZGUm94NkRjSTcwelRM?= =?utf-8?B?eTBoaHZXNWhLemdoa2p3ckxpL0xPcUdJOUE1TUF4OTMwS1pRRUUreENsUitU?= =?utf-8?B?KzJ0NTBuZEpybGlwQWVUMnJJZ0Ztc2w2ZmxMWTNySEo0WTk0OEpIWkVlSlZD?= =?utf-8?B?eWFteHZCQVAzNnhOOTJDdG1HK21zZERnandOSUFVdjhaRnZ0RzgyNExYdjBX?= =?utf-8?B?ajJzdGZiY0ZBYWZURFFBY2tHejBmK3BoaUxGdklKSWpIUmNGOExNMCs4K2pz?= =?utf-8?B?bTRnNXo4YWRPd05BYW5INitzcEhDTHRMc1JmWUtkdVhiZzUyQT09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b662451-ce6d-4e4e-d462-08d9cc616b86 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Dec 2021 13:28:23.9559 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB3606 Subject: Re: [FFmpeg-devel] [PATCH 04/11] avcodec/ac3tab: Unavpriv ac3_channel_layout_tab X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Quoting Andreas Rheinhardt (2021-12-15 13:35:34) >> It is small (16 B) and therefore the overhead of exporting it more >> than outweighs the size savings from not having duplicated symbols: >> When the symbol is no longer avpriv, one saves twice the size of >> the string containing the symbols name (2x30 byte), two entries >> in .dynsym (24 bytes each on x64), one entry in the importing libraries >> .got and .rela.dyn (8 + 24 bytes on x64) and two entries for the >> symbol version (2 bytes each) and one hash value in the exporting >> library (4 bytes). >> (The exact numbers are of course different for other platforms >> (e.g. when using dlls), but given that the strings saved alone >> more than outweigh the array size it can be presumed that this >> is beneficial for all platforms.) >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/Makefile | 12 +++++--- >> libavcodec/ac3_channel_layout_tab.c | 22 +++++++++++++++ >> libavcodec/ac3_channel_layout_tab.h | 41 ++++++++++++++++++++++++++++ >> libavcodec/ac3_parser.c | 2 +- >> libavcodec/ac3dec.c | 4 +-- >> libavcodec/ac3enc.h | 1 + >> libavcodec/ac3tab.c | 14 ---------- >> libavcodec/ac3tab.h | 4 +-- >> libavcodec/eac3_data.c | 2 ++ >> libavformat/Makefile | 2 ++ >> libavformat/ac3_channel_layout_tab.c | 22 +++++++++++++++ >> libavformat/hls_sample_encryption.c | 4 ++- >> libavformat/mov.c | 4 +-- >> 13 files changed, 107 insertions(+), 27 deletions(-) >> create mode 100644 libavcodec/ac3_channel_layout_tab.c >> create mode 100644 libavcodec/ac3_channel_layout_tab.h >> create mode 100644 libavformat/ac3_channel_layout_tab.c >> >> diff --git a/libavcodec/ac3enc.h b/libavcodec/ac3enc.h >> index ec9ead8a4e..39a41fe0b0 100644 >> --- a/libavcodec/ac3enc.h >> +++ b/libavcodec/ac3enc.h >> @@ -35,6 +35,7 @@ >> #include "ac3dsp.h" >> #include "avcodec.h" >> #include "fft.h" >> +#include "internal.h" > > ? Before this commit, ac3tab.h included internal.h for av_export_avcodec and ac3enc.h indirectly includes ac3tab.h via ac3.h. Yet ac3enc.h provides ff_ac3_enc_defaults of type AVCodecDefaults. This type is defined in internal.h, so ac3enc.h should properly include internal.h. > >> diff --git a/libavcodec/eac3_data.c b/libavcodec/eac3_data.c >> index b159e1682f..2ef0e2053c 100644 >> --- a/libavcodec/eac3_data.c >> +++ b/libavcodec/eac3_data.c >> @@ -24,6 +24,8 @@ >> * Tables taken directly from the E-AC-3 spec. >> */ >> >> +#include > > ?? This file has a NULL which it got implicitly via internal.h included by ac3tab.h (yes, really). This has been changed, so this header needs to be added. > >> diff --git a/libavformat/hls_sample_encryption.c b/libavformat/hls_sample_encryption.c >> index 38795c7fb0..3dbaff717e 100644 >> --- a/libavformat/hls_sample_encryption.c >> +++ b/libavformat/hls_sample_encryption.c >> @@ -26,6 +26,8 @@ >> * https://developer.apple.com/library/ios/documentation/AudioVideo/Conceptual/HLS_Sample_Encryption >> */ >> >> +#include "libavutil/channel_layout.h" This header (which uses e.g. AV_CH_LOW_FREQUENCY and av_get_channel_layout_nb_channels()) is currently implicitly included via libavcodec/internal.h included by ac3tab.h. > > ??? > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".