Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH v2 66/69] avcodec/mpegvideo: Remove strict_std_compliance from MPVContext
Date: Tue,  1 Feb 2022 14:07:03 +0100
Message-ID: <AM7PR03MB66602F802832653452C07DA98F269@AM7PR03MB6660.eurprd03.prod.outlook.com> (raw)
In-Reply-To: <AM7PR03MB666068F62BC40F2C6EAC1C658F269@AM7PR03MB6660.eurprd03.prod.outlook.com>

It just duplicates AVCodecContext.strict_std_compliance.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/mpeg12enc.c     | 2 +-
 libavcodec/mpeg4videoenc.c | 4 ++--
 libavcodec/mpegvideo.h     | 1 -
 libavcodec/mpegvideo_enc.c | 3 +--
 4 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c
index 4b885669bc..a9d87f6854 100644
--- a/libavcodec/mpeg12enc.c
+++ b/libavcodec/mpeg12enc.c
@@ -223,7 +223,7 @@ static av_cold int encode_init(AVCodecContext *avctx)
         return ret;
 
     if (find_frame_rate_index(mpeg12) < 0) {
-        if (s->strict_std_compliance > FF_COMPLIANCE_EXPERIMENTAL) {
+        if (avctx->strict_std_compliance > FF_COMPLIANCE_EXPERIMENTAL) {
             av_log(avctx, AV_LOG_ERROR, "MPEG-1/2 does not support %d/%d fps\n",
                    avctx->time_base.den, avctx->time_base.num);
             return AVERROR(EINVAL);
diff --git a/libavcodec/mpeg4videoenc.c b/libavcodec/mpeg4videoenc.c
index 9bc6fb9388..2f78763344 100644
--- a/libavcodec/mpeg4videoenc.c
+++ b/libavcodec/mpeg4videoenc.c
@@ -1068,9 +1068,9 @@ int ff_mpeg4_encode_picture_header(MPVMainEncContext *m, int picture_number)
 
     if (s->pict_type == AV_PICTURE_TYPE_I) {
         if (!(s->avctx->flags & AV_CODEC_FLAG_GLOBAL_HEADER)) {
-            if (s->strict_std_compliance < FF_COMPLIANCE_VERY_STRICT)  // HACK, the reference sw is buggy
+            if (s->avctx->strict_std_compliance < FF_COMPLIANCE_VERY_STRICT)  // HACK, the reference sw is buggy
                 mpeg4_encode_visual_object_header(m);
-            if (s->strict_std_compliance < FF_COMPLIANCE_VERY_STRICT || picture_number == 0)  // HACK, the reference sw is buggy
+            if (s->avctx->strict_std_compliance < FF_COMPLIANCE_VERY_STRICT || picture_number == 0)  // HACK, the reference sw is buggy
                 mpeg4_encode_vol_header(m, 0, 0);
         }
         if (!(s->workaround_bugs & FF_BUG_MS))
diff --git a/libavcodec/mpegvideo.h b/libavcodec/mpegvideo.h
index 56c1d8118c..a65c23f1d1 100644
--- a/libavcodec/mpegvideo.h
+++ b/libavcodec/mpegvideo.h
@@ -97,7 +97,6 @@ typedef struct MPVContext {
     int encoding;     ///< true if we are encoding (vs decoding)
     int luma_elim_threshold;
     int chroma_elim_threshold;
-    int strict_std_compliance; ///< strictly follow the std (MPEG-4, ...)
     int workaround_bugs;       ///< workaround bugs in encoders which cannot be detected automatically
     int codec_tag;             ///< internal codec_tag upper case converted from avctx codec_tag
     /* the following fields are managed internally by the encoder */
diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c
index 3e9f8b4e42..d3e52126d7 100644
--- a/libavcodec/mpegvideo_enc.c
+++ b/libavcodec/mpegvideo_enc.c
@@ -370,7 +370,6 @@ av_cold int ff_mpv_encode_init(AVCodecContext *avctx)
         return AVERROR(EINVAL);
     }
 
-    s->strict_std_compliance = avctx->strict_std_compliance;
     s->quarter_sample     = (avctx->flags & AV_CODEC_FLAG_QPEL) != 0;
     s->rtp_mode           = !!s->rtp_payload_size;
     s->intra_dc_precision = avctx->intra_dc_precision;
@@ -585,7 +584,7 @@ av_cold int ff_mpv_encode_init(AVCodecContext *avctx)
 
     if (avctx->flags & AV_CODEC_FLAG_LOW_DELAY) {
         if (s->codec_id != AV_CODEC_ID_MPEG2VIDEO &&
-            s->strict_std_compliance >= FF_COMPLIANCE_NORMAL) {
+            avctx->strict_std_compliance >= FF_COMPLIANCE_NORMAL) {
             av_log(avctx, AV_LOG_ERROR,
                    "low delay forcing is only available for mpeg2, "
                    "set strict_std_compliance to 'unofficial' or lower in order to allow it\n");
-- 
2.32.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2022-02-01 13:23 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01 12:47 [FFmpeg-devel] [PATCH v2 01/69] avcodec/avcodec: Avoid MpegEncContext in AVHWAccel.decode_mb Andreas Rheinhardt
2022-02-01 13:05 ` [FFmpeg-devel] [PATCH v2 02/69] avcodec/mpegvideo_enc: Allow slices only for slice-thread-able codecs Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 03/69] avcodec/mjpegenc, speedhqenc: Remove nonsense assert Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 04/69] avcodec/mjpegenc: Fix files with slices > 1, but threads == 1 Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 05/69] avcodec/mpegvideo: Enable private contexts Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 06/69] avcodec/h261: Separate decode and encode contexts Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 07/69] avcodec/h261: Move encoder-only stuff to a new header Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 08/69] avcodec/h261enc: Pass PutBitContext directly in h261_encode_motion() Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 09/69] avcodec/idctdsp: Constify the permutation parameter of ff_init_scantable Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 10/69] avcodec/wmv2: Move initializing abt_scantables to the decoder Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 11/69] avcodec/wmv2: Split Wmv2Context into decoder and encoder context Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 12/69] avcodec/wmv2.h: Move encoder- and decoder-only parts to new headers Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 13/69] avcodec/msmpeg4.h: Move encoder-only stuff to a new header Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 14/69] avcodec/msmpeg4.h: Move decoder-only parts " Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 15/69] avcodec/msmpegenc: Add MSMPEG4EncContext and move ac_stats to it Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 16/69] avcodec/h263.h: Move encoder-only stuff to a new header h263enc.h Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 17/69] avcodec/mpeg4video.h: Move decoder-only parts to a new header Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 18/69] avcodec/mpeg4video.h: Move encoder-only parts in a new file Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 19/69] avcodec/flv.h: Split header into encoder-only and decoder-only headers Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 20/69] avcodec/mpeg12.h: Move decoder-only stuff to a new header Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 21/69] avcodec/mpeg12.h: Move encoder-only stuff into " Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 22/69] avcodec/rv10.h: Split header into decoder- and encoder-only parts Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 23/69] avcodec/mpegvideo: Move encoder-only stuff to a new header Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 24/69] avcodec/mpegvideo: Move decoder-only " Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 25/69] avcodec/speedhqenc: Add SpeedHQEncContext and move slice_start to it Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 26/69] avcodec/mpegvideo: Use typedefs for MPV(Main)?(Dec|Enc)?Context Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 27/69] avcodec/mpegvideo_enc: Don't find encoder by ID Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 28/69] avcodec/mpegvideoenc: Add proper MPVMainEncContext Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 29/69] avcodec/mpegvideoenc: Move tmp bframes to MPVMainEncContext Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 30/69] avcodec/mpegvideoenc: Move ratecontrol " Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 31/69] avcodec/mpegvideo: Move me_pre and me_penalty_compensation to enc-ctx Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 32/69] avcodec/mpegvideo: Move gop_size to MPVMainEncContext Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 33/69] avcodec/mpegvideo_enc: Don't set picture_in_gop_number for slice threads Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 34/69] avcodec/mpegvideo: Move picture_in_gop_number to MPVMainEncContext Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 35/69] avcodec/mpegvideo: Move pts and dts fields " Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 36/69] avcodec/mpegvideo: Move input_picture list " Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 37/69] avcodec/mpegvideo: Remove write-only [fb]_code Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 38/69] avcodec/mpegvideo: Move last-pic information to MPVMainEncContext Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 39/69] avcodec/mpegvideo: Move header_bits " Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 40/69] avcodec/mpegvideo_enc: Remove unused function parameters Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 41/69] avcodec/mpegvideo_enc: Remove unused parameter from encode_mb_hq() Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 42/69] avcodec/mpegvideo: Move vbv_delay to Mpeg1Context Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 43/69] avcodec/mpegvideo: Move brd_scale to MPVMainEncContext Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 44/69] avcodec/mpegvideo: Move ratecontrol parameters " Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 45/69] avcodec/mpegvideo: Allocate encoder-only tables in mpegvideo_enc.c Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 46/69] avcodec/mpegvideo: Move encoder-only base-arrays to MPVMainEncContext Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 47/69] avcodec/mpegvideo_enc: Initialize non-JPEG q-matrices only once Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 48/69] avcodec/mpegvideo_enc: Avoid allocations for q_int(er|ra)_matrix tables Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 49/69] avcodec/mpegvideo: Move scenechange_threshold to MPVMainEncContext Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 50/69] avcodec/mpegvideo: Move dummy dst for depr. opts " Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 51/69] avcodec/mpegvideo: Move frame_skip_(exp|cmp) " Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 52/69] avcodec/mpegvideo: Move input_picture_number " Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 53/69] avcodec/mpegvideo: Move fixed_qscale " Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 54/69] avcodec/motion_est: Constify mv-table parameters where possible Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 55/69] avcodec/mpegvideo: Constify src of ff_update_duplicate_context() Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 56/69] avcodec/mpegpicture: Constify src parameter of ff_update_picture_tables Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 57/69] avcodec/mpegvideo: Add proper MPVMainContext Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 58/69] avcodec/mpegvideo: Move slice-context ptr array to MPVMainContext Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 59/69] avcodec/mpegvideo: Add ptr to main MPVMainContext to slice contexts Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 60/69] avcodec/mpegvideo: Move slice_context_count to MPVMainContext Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 61/69] avcodec/mpegvideo: Move reordered_input_picture to MPVMainEncContext Andreas Rheinhardt
2022-02-01 13:06 ` [FFmpeg-devel] [PATCH v2 62/69] avcodec/mpegvideo: Move max_b_frames " Andreas Rheinhardt
2022-02-01 13:07 ` [FFmpeg-devel] [PATCH v2 63/69] avcodec/mpegvideo: Move context_initialized flag to MPVMainContext Andreas Rheinhardt
2022-02-01 13:07 ` [FFmpeg-devel] [PATCH v2 64/69] avcodec/mpegvideo: Move coded_picture_number " Andreas Rheinhardt
2022-02-01 13:07 ` [FFmpeg-devel] [PATCH v2 65/69] avcodec/mpegvideo: Move arrays owned by main thread " Andreas Rheinhardt
2022-02-01 13:07 ` Andreas Rheinhardt [this message]
2022-02-01 13:07 ` [FFmpeg-devel] [PATCH v2 67/69] avcodec/mpegvideo_dec: Remove commented-out cruft Andreas Rheinhardt
2022-02-01 13:07 ` [FFmpeg-devel] [PATCH v2 68/69] avcodec/mpegvideo_dec: Remove potentially UB always-true checks Andreas Rheinhardt
2022-02-01 13:07 ` [FFmpeg-devel] [PATCH v2 69/69] avcodec/mpegvideo: Move picture array to MPVMainContext Andreas Rheinhardt
2022-02-02  6:01 ` [FFmpeg-devel] [PATCH 70/72] avcodec/mpegpicture: Don't check for DELAYED_PIC_REF Andreas Rheinhardt
2022-02-02  6:01 ` [FFmpeg-devel] [PATCH 71/72] avcodec/mpegutils.h: Move DELAYED_PIC_REF macro to h264dec.h Andreas Rheinhardt
2022-02-02  6:01 ` [FFmpeg-devel] [PATCH 72/72] avcodec/mpegvideo: Make new_picture an ordinary AVFrame Andreas Rheinhardt
2022-02-03  1:06 ` [FFmpeg-devel] [PATCH 73/80] avcodec/h263dec.h: Add H263DecContext Andreas Rheinhardt
2022-02-03  1:06 ` [FFmpeg-devel] [PATCH 74/80] avcodec/mpegvideo: Move decode_mb to H263DecContext Andreas Rheinhardt
2022-02-03  1:06 ` [FFmpeg-devel] [PATCH 75/80] avcodec/mpegvideo: Move h263_long_vectors " Andreas Rheinhardt
2022-02-03  1:06 ` [FFmpeg-devel] [PATCH 76/80] avcodec/mpegvideo: Move ehc_mode " Andreas Rheinhardt
2022-02-03  1:06 ` [FFmpeg-devel] [PATCH 77/80] avcodec/mpegvideo: Move pb_frame " Andreas Rheinhardt
2022-02-03  1:06 ` [FFmpeg-devel] [PATCH 78/80] avcodec/mpegvideo: Move packed-b-frames stuff " Andreas Rheinhardt
2022-02-03  1:06 ` [FFmpeg-devel] [PATCH 79/80] avcodec/mpegvideo: Move custom_pcf " Andreas Rheinhardt
2022-02-03  1:06 ` [FFmpeg-devel] [PATCH 80/80] avcodec/mpegvideo_enc: Remove redundant unref+ref Andreas Rheinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM7PR03MB66602F802832653452C07DA98F269@AM7PR03MB6660.eurprd03.prod.outlook.com \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git