From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2 14/18] lavc/svq3: stop including h264dec.h
Date: Wed, 26 Jan 2022 15:04:05 +0100
Message-ID: <AM7PR03MB66602E4D644E5C98295834E78F209@AM7PR03MB6660.eurprd03.prod.outlook.com> (raw)
In-Reply-To: <164319511653.23111.9954904797759475887@lain.red.khirnov.net>
Anton Khirnov:
> Quoting Andreas Rheinhardt (2022-01-24 21:09:27)
>> From: Anton Khirnov <anton@khirnov.net>
>>
>> The only thing that is actually used directly from there is the
>> PART_NOT_AVAILABLE constant, which can be trivially copied to svq3
>> decoder itself.
>>
>> Otherwise it only depends on other indirectly included headers.
>> ---
>> libavcodec/svq3.c | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c
>> index a3f434ff8d..f06404da9d 100644
>> --- a/libavcodec/svq3.c
>> +++ b/libavcodec/svq3.c
>> @@ -49,13 +49,16 @@
>> #include "internal.h"
>> #include "avcodec.h"
>> #include "mpegutils.h"
>> -#include "h264dec.h"
>> #include "h264data.h"
>> +#include "h264dsp.h"
>> +#include "h264pred.h"
>> +#include "h264_parse.h"
>> #include "golomb.h"
>> #include "hpeldsp.h"
>> #include "mathops.h"
>> #include "rectangle.h"
>> #include "tpeldsp.h"
>> +#include "videodsp.h"
>>
>> #if CONFIG_ZLIB
>> #include <zlib.h>
>> @@ -63,6 +66,8 @@
>>
>> #include "svq1.h"
>>
>> +#define PART_NOT_AVAILABLE -2
>
> Didn't you want to move it to h264pred? I'm fine with that.
>
Yes, I wanted to so, but I didn't want to do it behind your back. Will
do now.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-01-26 14:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 20:00 [FFmpeg-devel] [PATCH v2 01/18] avcodec/h264dec: Move find_start_code() to its only user Andreas Rheinhardt
2022-01-24 20:09 ` [FFmpeg-devel] [PATCH v2 02/18] avcodec/h264dec: Move pack8to16 " Andreas Rheinhardt
[not found] ` <20220124200931.593079-1-andreas.rheinhardt@outlook.com>
2022-01-24 20:09 ` [FFmpeg-devel] [PATCH v2 03/18] lavc/h264: replace MAX_MMCO_COUNT with H264_MAX_MMCO_COUNT Andreas Rheinhardt
2022-01-24 20:09 ` [FFmpeg-devel] [PATCH v2 04/18] lavc/h264dec.h: Move MMCOOpcode to h264_parse.h Andreas Rheinhardt
2022-01-24 20:09 ` [FFmpeg-devel] [PATCH v2 05/18] lavc/h264: replace MAX_DELAYED_PIC_COUNT with FF_ARRAY_ELEMS where appropriate Andreas Rheinhardt
2022-01-24 20:09 ` [FFmpeg-devel] [PATCH v2 06/18] lavc/h264: replace MAX_DELAYED_PIC_COUNT by H264_MAX_DPB_FRAMES Andreas Rheinhardt
2022-01-24 20:09 ` [FFmpeg-devel] [PATCH v2 07/18] lavc/h264_parser: add missing headers Andreas Rheinhardt
2022-01-24 20:09 ` [FFmpeg-devel] [PATCH v2 08/18] lavc/h264: move some shared code from h264dec to h264_parse Andreas Rheinhardt
2022-01-24 20:09 ` [FFmpeg-devel] [PATCH v2 09/18] lavc/h264data.h: stop including h264dec.h Andreas Rheinhardt
2022-01-24 20:09 ` [FFmpeg-devel] [PATCH v2 10/18] lavc/h264_parse: " Andreas Rheinhardt
2022-01-24 20:09 ` [FFmpeg-devel] [PATCH v2 11/18] lavc/h264: move MB_TYPE defs from h264dec.h to h264_parse Andreas Rheinhardt
2022-01-24 20:09 ` [FFmpeg-devel] [PATCH v2 12/18] lavc/vdpau: stop unnecessarily including h264dec Andreas Rheinhardt
2022-01-24 20:09 ` [FFmpeg-devel] [PATCH v2 13/18] lavc/x86/h264_qpel: " Andreas Rheinhardt
2022-01-24 20:09 ` [FFmpeg-devel] [PATCH v2 14/18] lavc/svq3: stop including h264dec.h Andreas Rheinhardt
2022-01-24 20:09 ` [FFmpeg-devel] [PATCH v2 15/18] avcodec/h264*: Remove unnecessary h264_mvpred.h inclusions Andreas Rheinhardt
2022-01-24 20:09 ` [FFmpeg-devel] [PATCH v2 16/18] avcodec/h264dec: Remove unnecessary headers Andreas Rheinhardt
2022-01-24 20:09 ` [FFmpeg-devel] [PATCH v2 17/18] avcodec/h264_*: Remove unnecessary internal.h inclusions Andreas Rheinhardt
2022-01-24 20:09 ` [FFmpeg-devel] [PATCH v2 18/18] avcodec/h264_parse: Move ff_h264_get_profile() to h264_ps.h Andreas Rheinhardt
2022-01-26 11:02 ` [FFmpeg-devel] [PATCH v2 04/18] lavc/h264dec.h: Move MMCOOpcode to h264_parse.h Anton Khirnov
2022-01-26 11:05 ` [FFmpeg-devel] [PATCH v2 14/18] lavc/svq3: stop including h264dec.h Anton Khirnov
2022-01-26 14:04 ` Andreas Rheinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM7PR03MB66602E4D644E5C98295834E78F209@AM7PR03MB6660.eurprd03.prod.outlook.com \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git